missing libkonq_export build broken
as of b29f85d plasma-desktop builds in minimal build environments appear to be broken... In file included from ../../../containments/folder/plugin/foldermodel.cpp:43:0: ../../../containments/folder/plugin/internallibkonq/konq_popupmenu.h:35:28: fatal error: libkonq_export.h: No such file or directory #include libkonq_export.h full log: https://launchpadlibrarian.net/188969385/buildlog_ubuntu-utopic-amd64.plasma-desktop_4%3A5.1.0.1%2Bgit20141103.0649-0ubuntu0_FAILEDTOBUILD.txt.gz HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120936: [KInfoCenter] Set the correct version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/#review69703 --- Modules/infosummary/CMakeLists.txt https://git.reviewboard.kde.org/r/120936/#comment48823 kinfocenter has config-foo.h.cmake files. Thus I'd suggest to define it there and not use command line switch for it. - Martin Gräßlin On Nov. 1, 2014, 7:48 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/ --- (Updated Nov. 1, 2014, 7:48 p.m.) Review request for Plasma. Repository: kinfocenter Description --- bonus - dropped dep on plasma-framework Diffs - CMakeLists.txt 6c1dd1d Modules/infosummary/CMakeLists.txt 5ae1faf Modules/infosummary/infosum.cpp e58beb0 Diff: https://git.reviewboard.kde.org/r/120936/diff/ Testing --- yes Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120913: [kcms/lnf] Make a list variable const
On Nov. 1, 2014, 5:58 p.m., Mark Gaiser wrote: Just out of curiosity. Do you have any benchmark numbers? I bet it's faster, but by how much in terms of percentage? no I don't have a benchmark. But the worst performance bug we ever had in KWin was accessing a Qt container class using the non-const variant instead of the const-variant. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/#review69649 --- On Oct. 31, 2014, 12:13 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/ --- (Updated Oct. 31, 2014, 12:13 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- The dataPath variable is used in an extended for-loop as of C++11. As the variable was not const the for loop uses the more expensive iterators which allow modification of the list. By making the list const it can use the better const iterator. See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/ Diffs - kcms/lookandfeel/kcm.cpp a46774200c0c378485a474ff538294c7617ef6d2 Diff: https://git.reviewboard.kde.org/r/120913/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120946: Add thumbnailAvailable property to WindowThumbnail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120946/#review69705 --- Ship it! Ship It! - Martin Gräßlin On Nov. 2, 2014, 8:04 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120946/ --- (Updated Nov. 2, 2014, 8:04 p.m.) Review request for Plasma, Martin Gräßlin and Eike Hein. Bugs: 332003 http://bugs.kde.org/show_bug.cgi?id=332003 Repository: plasma-framework Description --- This adds a thumbnailAvailable property which tells us whether it's actually displaying a window thumbnail or just the fallback window icon. Diffs - src/declarativeimports/core/windowthumbnail.h a313cd9 src/declarativeimports/core/windowthumbnail.cpp 84d8bc8 Diff: https://git.reviewboard.kde.org/r/120946/diff/ Testing --- Tested with taskmanager both with compositing on and off and minimized window (thumbnail gone and property false), restored window (thumbnail there again and property true). Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120913: [kcms/lnf] Make a list variable const
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/ --- (Updated Nov. 3, 2014, 8:45 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- The dataPath variable is used in an extended for-loop as of C++11. As the variable was not const the for loop uses the more expensive iterators which allow modification of the list. By making the list const it can use the better const iterator. See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/ Diffs - kcms/lookandfeel/kcm.cpp a46774200c0c378485a474ff538294c7617ef6d2 Diff: https://git.reviewboard.kde.org/r/120913/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #778
See http://build.kde.org/job/plasma-desktop_master_qt5/778/changes Changes: [mgraesslin] [kcms/lnf] Make a list variable const -- [...truncated 1126 lines...] [ 31%] Built target trashplugin [ 31%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/SolidActions.cpp.o [ 31%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/kcm_solid_actions_automoc.cpp.o [ 31%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/favoritesmodel.cpp.o Generating moc_FontinstIface.cpp Generating moc_ActionLabel.cpp Generating moc_DuplicatesDialog.cpp Generating moc_FcQuery.cpp Generating moc_FontFilter.cpp Generating moc_FontList.cpp Generating moc_GroupList.cpp Generating moc_JobRunner.cpp Generating moc_KCmFontInst.cpp Generating moc_PreviewList.cpp Generating moc_CharTip.cpp Generating moc_FontPreview.cpp Generating moc_PreviewSelectAction.cpp [ 31%] Built target kcm_fontinst_automoc [ 31%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/funnelmodel.cpp.o [ 32%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/imagepicker.cpp.o [ 33%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/krunnermodel.cpp.o [ 33%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/leavemodel.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/applicationmodel.h:25:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/kickoffplugin.cpp:21: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ [ 33%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/models.cpp.o [ 33%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/kickerplugin.cpp.o [ 33%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/recentapplications.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.h:23:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:21: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ [ 33%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/recentlyusedmodel.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:98:54: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KService::Ptr Kickoff::serviceForUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:138:49: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] bool KRunnerItemHandler::openUrl(const KUrl url) ^ Linking CXX shared module kcm_solid_actions.so http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual Qt::ItemFlags Kickoff::KRunnerModel::flags(const QModelIndex) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:258:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual QMimeData* Kickoff::KRunnerModel::mimeData(const QModelIndexList) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:272:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls; ^
Review Request 120954: drop libkonq_export for internal libkonq copy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- Review request for Plasma. Repository: plasma-desktop Description --- as suggested by David Faure to fix the build fail introduced in b29f85d since the internal libkonq does not have an export header Diffs - containments/folder/plugin/internallibkonq/konq_copytomenu.h a830c5d8b6d19ae05636919acbb8b1c47e0bd524 containments/folder/plugin/internallibkonq/konq_dndpopupmenuplugin.h f92cce9d8dee65bdbad4fe7ef26768e081f97ef4 containments/folder/plugin/internallibkonq/konq_operations.h 1b36516d8c1993a65e90949187985722e95f6b3c containments/folder/plugin/internallibkonq/konq_popupmenu.h 56fb765e7367469f253a1444fff2009f41520439 containments/folder/plugin/internallibkonq/konq_popupmenuplugin.h a4e33f5a02838d63db016571d440ca92282dc8ed Diff: https://git.reviewboard.kde.org/r/120954/diff/ Testing --- built plasma-desktop in an environment without libkonq_export.h Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120954: drop libkonq_export for internal libkonq copy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- (Updated Nov. 3, 2014, 8:58 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- as suggested by David Faure to fix the build fail introduced in b29f85d since the internal libkonq does not have an export header Diffs - containments/folder/plugin/internallibkonq/konq_copytomenu.h a830c5d8b6d19ae05636919acbb8b1c47e0bd524 containments/folder/plugin/internallibkonq/konq_dndpopupmenuplugin.h f92cce9d8dee65bdbad4fe7ef26768e081f97ef4 containments/folder/plugin/internallibkonq/konq_operations.h 1b36516d8c1993a65e90949187985722e95f6b3c containments/folder/plugin/internallibkonq/konq_popupmenu.h 56fb765e7367469f253a1444fff2009f41520439 containments/folder/plugin/internallibkonq/konq_popupmenuplugin.h a4e33f5a02838d63db016571d440ca92282dc8ed Diff: https://git.reviewboard.kde.org/r/120954/diff/ Testing --- built plasma-desktop in an environment without libkonq_export.h Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120577/ --- (Updated Nov. 3, 2014, 8:59 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Aleix Pol Gonzalez. Bugs: 339453 https://bugs.kde.org/show_bug.cgi?id=339453 Repository: plasma-workspace Description --- Logging out from the locked screen is impossible. Logging out means interaction with the session due to the session manager. The session manager asks all applications to quit and applications are allowed to ask for example saving changes. The session manager stopps the logout in this case and asks the window manager to focus this window and the session manager will only continue the logout once the application resolved the situation. At any time in this process the user is still able to abort the logout! Switching to the application which needs interaction is impossible, though as the screen is still locked. The result is a seemingly frozen system as the logout cannot continue and there is no indication what is going on. Of course the lock screen cannot unlock the session for the logout as that would circumvent the security. If the lock screen would unlock one would just have to click the button and abort the logout really fast to have the system unlocked. So this is clearly not an option. The result is: we cannot implement this functionality in a working and secure manner, so it's better to remove it. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp fd1d20b824dd7781cb5c2e96895694f290a46877 lookandfeel/contents/lockscreen/LockScreen.qml 7d730cf1ebd8241dfe1c00a2bef86ec4a3f0212d ksmserver/screenlocker/greeter/greeterapp.h f3033c701fb3c3ce5fa8f12f58ee8c6af739444b Diff: https://git.reviewboard.kde.org/r/120577/diff/ Testing --- run kscreenlocker_greeter --testing and locked the screen - button is gone. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120954: drop libkonq_export for internal libkonq copy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/#review69712 --- Ship it! Ship It! - Martin Gräßlin On Nov. 3, 2014, 9:58 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- (Updated Nov. 3, 2014, 9:58 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- as suggested by David Faure to fix the build fail introduced in b29f85d since the internal libkonq does not have an export header Diffs - containments/folder/plugin/internallibkonq/konq_copytomenu.h a830c5d8b6d19ae05636919acbb8b1c47e0bd524 containments/folder/plugin/internallibkonq/konq_dndpopupmenuplugin.h f92cce9d8dee65bdbad4fe7ef26768e081f97ef4 containments/folder/plugin/internallibkonq/konq_operations.h 1b36516d8c1993a65e90949187985722e95f6b3c containments/folder/plugin/internallibkonq/konq_popupmenu.h 56fb765e7367469f253a1444fff2009f41520439 containments/folder/plugin/internallibkonq/konq_popupmenuplugin.h a4e33f5a02838d63db016571d440ca92282dc8ed Diff: https://git.reviewboard.kde.org/r/120954/diff/ Testing --- built plasma-desktop in an environment without libkonq_export.h Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120954: drop libkonq_export for internal libkonq copy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- (Updated Nov. 3, 2014, 9:09 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- as suggested by David Faure to fix the build fail introduced in b29f85d since the internal libkonq does not have an export header Diffs - containments/folder/plugin/internallibkonq/konq_copytomenu.h a830c5d8b6d19ae05636919acbb8b1c47e0bd524 containments/folder/plugin/internallibkonq/konq_dndpopupmenuplugin.h f92cce9d8dee65bdbad4fe7ef26768e081f97ef4 containments/folder/plugin/internallibkonq/konq_operations.h 1b36516d8c1993a65e90949187985722e95f6b3c containments/folder/plugin/internallibkonq/konq_popupmenu.h 56fb765e7367469f253a1444fff2009f41520439 containments/folder/plugin/internallibkonq/konq_popupmenuplugin.h a4e33f5a02838d63db016571d440ca92282dc8ed Diff: https://git.reviewboard.kde.org/r/120954/diff/ Testing --- built plasma-desktop in an environment without libkonq_export.h Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_master_qt5 #779
See http://build.kde.org/job/plasma-desktop_master_qt5/779/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120946: Add thumbnailAvailable property to WindowThumbnail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120946/ --- (Updated Nov. 3, 2014, 9:13 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Martin Gräßlin and Eike Hein. Bugs: 332003 http://bugs.kde.org/show_bug.cgi?id=332003 Repository: plasma-framework Description --- This adds a thumbnailAvailable property which tells us whether it's actually displaying a window thumbnail or just the fallback window icon. Diffs - src/declarativeimports/core/windowthumbnail.h a313cd9 src/declarativeimports/core/windowthumbnail.cpp 84d8bc8 Diff: https://git.reviewboard.kde.org/r/120946/diff/ Testing --- Tested with taskmanager both with compositing on and off and minimized window (thumbnail gone and property false), restored window (thumbnail there again and property true). Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/#review69715
---
Heh, looking at the code again on my way in the office I saw a few weird
things. And some questions to the original authors :)
applets/notifications/package/contents/ui/NotificationDelegate.qml
https://git.reviewboard.kde.org/r/120943/#comment48829
Just in case you were wondering:
If you have a JS Array in a ListModel role, that thing is automatically
converted into another ListModel :)
applets/notifications/package/contents/ui/NotificationDelegate.qml
https://git.reviewboard.kde.org/r/120943/#comment48830
Do we really need that?
applets/notifications/package/contents/ui/NotificationPopup.qml
https://git.reviewboard.kde.org/r/120943/#comment48827
Actually we could just bind those to notificationProperties.foo instead of
assigning everything manually
applets/notifications/package/contents/ui/NotificationPopup.qml
https://git.reviewboard.kde.org/r/120943/#comment48828
I think that is not needed
applets/notifications/package/contents/ui/NotificationPopup.qml
https://git.reviewboard.kde.org/r/120943/#comment48826
Whoops.
applets/notifications/package/contents/ui/NotificationPopup.qml
https://git.reviewboard.kde.org/r/120943/#comment48831
Somehow I now no longer get line breaks in KMail notifications. But
StyledText does support br, b and stuff
- Kai Uwe Broulik
On Nov. 2, 2014, 8 nachm., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
---
(Updated Nov. 2, 2014, 8 nachm.)
Review request for Plasma and Martin Klapetek.
Repository: plasma-workspace
Description
---
This moves duplicate code (notification icon, heading, text, action buttons)
into a separate NotificationItem {} component used by both the notification
popup as well as the notification list delegate.
If we ever were to provide richer notifications for specific usecases (you
can provide custom hints in notifications after all) this would ease this and
less duplication is always good :)
I also cleaned up a bit of commented/unused code and changed complicated
anchoring to QtQuick Layouts where applicable.
Diffs
-
applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2
applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION
applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2
Diff: https://git.reviewboard.kde.org/r/120943/diff/
Testing
---
Ran knotificationdbustest and didn't notice anything unusual, visually the
thing should look and behave exactly like it did before. Additional testing
is welcomed, however.
File Attachments
New popup
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
standalone build of konqueror is broken
in order to test standalone builds, I created a staging directory whit
symlinks to all the components of kde-baseapps.
The probelm seems to be that libkonq installs
/opt/qt5/share/dbus-1/interfaces/org.kde.FavIcon.xml
but cmake does not know how to include it
The same problem occurs with keditbookmarks, however dolphin builds pk
The problem is caused by the relative includes , which should probably refer
to DBUS_INTERFACES_INSTALL_DIR
$ git grep FavIcon.xml
keditbookmarks/CMakeLists.txt:qt5_add_dbus_interface(
keditbookmarks_KDEINIT_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/../lib/konq/src/favicons/org.kde.FavIcon.xml
favicon_interface)
konqueror/sidebar/web_module/CMakeLists.txt:qt5_add_dbus_interface(konqsidebar_web_PART_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/../../../lib/konq/favicons/org.kde.FavIcon.xml
favicon_interface)
konqueror/src/CMakeLists.txt:qt5_add_dbus_interface(konquerorprivate_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/../../lib/konq/src/favicons/org.kde.FavIcon.xml
favicon_interface)
lib/konq/autotests/CMakeLists.txt:qt5_add_dbus_interface(favicontest_SRCS
${LibKonq_SOURCE_DIR}/src/favicons/org.kde.FavIcon.xml favicon_interface)
lib/konq/src/favicons/CMakeLists.txt:qt5_add_dbus_adaptor(kded_favicons_SRCS
org.kde.FavIcon.xml favicons.h FavIconsModule favicons_adaptor
FavIconsAdaptor)
lib/konq/src/favicons/CMakeLists.txt:install(FILES org.kde.FavIcon.xml
DESTINATION ${DBUS_INTERFACES_INSTALL_DIR})
Building in dir: /usr/src/konqueror
konquerorframeworks
INSTALL_PREFIX=/opt/qt5
-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is GNU 4.9.2
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PythonInterp: /usr/bin/python (found version 2.7.8)
-- Found KF5: success (found version 5.4.0) found components: Parts
KCMUtils KHtml KDELibs4Support Archive
-- Found KF5: success (found version 5.4.0) found components: Activities
-- Found KF5: success (found version 5.4.0) found components: KHtml
--
-- The following OPTIONAL packages have been found:
* KF5Activities
-- The following REQUIRED packages have been found:
* ECM (required version = 1.3.0)
* Qt5Core
* Gettext
* PythonInterp
* KF5Parts
* KF5KCMUtils
* KF5KDELibs4Support
* KF5Archive
* KF5Konq
* Qt5DBus
* Qt5Widgets
* Qt5 (required version = 5.2)
* KDED
* ZLIB , Support for gzip compressed files and data streams ,
http://www.zlib.net
Required for building Konqueror
* KF5KHtml
* KF5
-- Configuring done
-- Generating done
-- Build files have been written to: /usr/src/konqueror/build
ninja: error:
'/var/git/qt5/staging/lib/konq/src/favicons/org.kde.FavIcon.xml', needed by
'src/favicon_interface.h', missing and no known rule to make it
Regards, Treeve
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QScreen vs. KScreen in plasmashell
On Friday, October 24, 2014 10:20:04 Daniel Vratil wrote: On Friday 24 of October 2014 10:15:17 Pier Luigi Fiorini wrote: 2014-10-24 9:58 GMT+02:00 Daniel Vratil dvra...@redhat.com: the current state of multi-monitor support in Plasma 5 is rather bad as both Plasma 5 and KWin keep crashing every time there's any change (+ the desktop is extremely sluggish for about 15 seconds after that). Many colleagues in my office would love to switch to Plasma 5 already, but this is one of the major blockers that scares most people away, so it needs to be fixed. I was looking into plasmashell code to fix it (and also for a different reason, more on that later) and realized that the code is mixing use of KScreen and QScreen, and I couldn't resist asking myself why. QScreen provides subset of information that KScreen and all I can see in the code is just endless conversion between QScreen and respective KScreen::Output and hoping they both behave the same. Would it make sense to get rid of QScreen completely and use KScreen exclusively? I think it would solve most of the crashes I'm currently getting. I'm of course volunteering to do all the work, but before I start, I want to make sure there's no real obscure reason for keeping both QScreen and KScreen. (For the other reason I was looking into plasmashell: I'm currently working on a big KScreen API and design changes, which includes using QSharedPointers, having async API, and running platform backends in a separate process to improve performance and stability, but I'll send a separate email on that once the API is finished, as that will affect all KScreen-enabled applications) I can think of one reason why QScreen would be better: for Wayland support. A wl_output can be taken from a QScreen easily using the platform native API, how do we do with KScreen? Sebas is working on a Wayland backend for KScreen. Moreover, there's also a QScreen-based backend for KScreen, so if someone wants to test if the problems arising come from the dichotomy between XRandR and QScreen, one can force kscreen to use the QScreen backend by exporting KSCREEN_BACKEND=qscreen before starting Plasma. This can give some additional information where the actual problem is. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120949: Add imageprovider to fifteenpuzzle.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69718 --- looks a bit overkill? - Marco Martin On Nov. 2, 2014, 10:09 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/ --- (Updated Nov. 2, 2014, 10:09 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now, but need to come from the qml. This is a first attempt posting to get feedback about the approach etc. Diffs - applets/fifteenPuzzle/package/contents/config/main.xml 0dd804a12ddb0c7c2daaced1b92582f0deff494f applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml bf9581bd78c1c7690fc16f01e440adad0fc98766 applets/fifteenPuzzle/package/contents/ui/Piece.qml c386570aebdf4323e3132aa05445b38383149dea applets/fifteenPuzzle/package/contents/ui/configAppearance.qml d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 applets/fifteenPuzzle/package/contents/ui/main.qml c76eaeb4d936fe917d99375722905c2f002c33e6 applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION applets/fifteenPuzzle/plugin/qmldir PRE-CREATION applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 Diff: https://git.reviewboard.kde.org/r/120949/diff/ Testing --- It builds and runs, currently doesn't shuffle, to test the result image works and appears. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120538: Update default applications in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review69719 --- Can this RR be closed or abandoned? - Sebastian Kügler On Oct. 9, 2014, 8:41 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- (Updated Oct. 9, 2014, 8:41 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- instead of defaulting to konqueror find the first browser from a list change konsole to ktp-contactlist, we want to appeal to non geeks change kmail for kontact, we provide a lovely PIM suite so we should show it by default Diffs - applets/kickoff/core/favoritesmodel.cpp e26cf802a186b5a0f7627124ee1013e8b022bfe2 Diff: https://git.reviewboard.kde.org/r/120538/diff/ Testing --- make a new user, start up plasma Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120538: Update default applications in kickoff
On Nov. 3, 2014, 9:56 a.m., Sebastian Kügler wrote: Can this RR be closed or abandoned? I kind of forgot what the result was, but I remember writing most of the Kicker patch and then abandoning it for $reasons ... I guess the idea was to implement it in kamd instead because of the kamd faves thing? - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review69719 --- On Oct. 9, 2014, 8:41 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- (Updated Oct. 9, 2014, 8:41 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- instead of defaulting to konqueror find the first browser from a list change konsole to ktp-contactlist, we want to appeal to non geeks change kmail for kontact, we provide a lovely PIM suite so we should show it by default Diffs - applets/kickoff/core/favoritesmodel.cpp e26cf802a186b5a0f7627124ee1013e8b022bfe2 Diff: https://git.reviewboard.kde.org/r/120538/diff/ Testing --- make a new user, start up plasma Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma Hangout
Minutes Plasma Hangout, 3-11-2014 Present: David, Harald, Jonathan, Kai Uwe, Marco, Martin G., Martin K., Sebastian David: - plugged memleak in SDDM - worked with Aleix on trying to fix multiscreen, ran into more problems - We really need to fix QScreen Harald: - We have weekly ISOs again! - volume mixer plasmoid C++ bits looking solid - testing needs to be figured out - Creating vision and personas for its UI design - new phonon coming, - please test git://anongit.kde.org/scratch/sitter/plasma-volume-control.git Jonathan: - Releasing Plasma 5.1.1 tarballs on Thursday - Get your patches for that in! - Kubuntu will ship Plasma 5.2 for 15.04 - scheduling releases so we don't clash again Kai Uwe: - returned from vacation - forwarded wheel events to panels (helps w/ Fitt's Law) - smaller -addons fixes all over the place - investigating broken klipper entries (short version: Chrome does wrong things, Qt falls on its face over them): https://code.google.com/p/chromium/issues/detail?id=428646 and https://bugreports.qt-project.org/browse/QTBUG-42285 Marco: - bugfixes in panel - Implemented undo for removing Plasmoids, fixing fallout (TextArea seems broken post-restore) Martin: - working with VDG for a redesign of desktop grid and present windows: https://forum.kde.org/viewtopic.php?f=285t=123481 - worked on kdecoration2, in review now - working on windecos around thumbnails: https://forum.kde.org/viewtopic.php?f=285t=123480 - will resume Wayland work this week Martin: - Working on akonadi and facebook stuff, nothing plasma-specific to report Sebas: - Went diving to promote Plasma among tropical fish - Reviewing Dan Vratil's kscreen API changes - To work on plugin indexing and kscreen wayland support -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma port to Wayland
Hi, As some of you might know I've been working on the Plasma port to Wayland. I would like to give you some pointers where the on going effort is. Last month I've been super busy with other stuff, but I plan to resume my work on Wayland during November. You can see it in action on my compositor, Green Island: http://imgur.com/8F4Emax http://imgur.com/Q69CB2v Here's the components I've been working on: - kwayland git clone -b plasma kde:clones/kwayland/pierluigifiorini/plasma.git The plasma branch contains patches to add Plasma protocols. The wlscanner branch makes use of the new find module for wayland-scanner that I recently made; it can be merged as soon as a new ECM version comes out, see https://git.reviewboard.kde.org/r/120656/ All is currently rebased on top of master. - kwindowsystem git clone -b wayland kde:clones/kwindowsystem/pierluigifiorini/wayland.git - plasma-framework git clone -b wayland kde:clones/plasma-framework/pierluigifiorini/wayland.git - plasma-workspace git clone -b wayland kde:clones/plasma-workspace/pierluigifiorini/wayland.git Ported ksplashqml and plasmashell (panels and desktop view); I'll reread the patch when I get back to this stuff. Review is not started: blocked by the review of my changes to kwayland. Currently rebased on top of v5.1.0 -- Out of the box experience http://www.maui-project.org/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120538: Update default applications in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- (Updated Nov. 3, 2014, 1:36 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- instead of defaulting to konqueror find the first browser from a list change konsole to ktp-contactlist, we want to appeal to non geeks change kmail for kontact, we provide a lovely PIM suite so we should show it by default Diffs - applets/kickoff/core/favoritesmodel.cpp e26cf802a186b5a0f7627124ee1013e8b022bfe2 Diff: https://git.reviewboard.kde.org/r/120538/diff/ Testing --- make a new user, start up plasma Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #781
See http://build.kde.org/job/plasma-desktop_master_qt5/781/changes Changes: [hein] Launch new instances on Shift+Click. -- [...truncated 1187 lines...] http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:275:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:287:39: warning: ‘void KUrl::List::populateMimeData(QMimeData*, const MetaDataMap, KUrl::MimeDataFlags) const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:221) [-Wdeprecated-declarations] urls.populateMimeData(mimeData); ^ [ 35%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/processrunner.cpp.o [ 35%] Building CXX object containments/folder/CMakeFiles/folderplugin.dir/plugin/menuhelper.cpp.o [ 35%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/rootmodel.cpp.o [ 35%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/leavemodel.cpp.o [ 35%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/models.cpp.o [ 36%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/runnermodel.cpp.o [ 36%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/runnermatchesmodel.cpp.o [ 37%] Building CXX object containments/folder/CMakeFiles/folderplugin.dir/plugin/mimetypesmodel.cpp.o [ 37%] Building CXX object containments/folder/CMakeFiles/folderplugin.dir/plugin/placesmodel.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:37:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp: In member function ‘void Kickoff::LeaveModel::updateModel()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:169:85: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:74) [-Wdeprecated-declarations] QSet Solid::PowerManagement::SleepState spdMethods = Solid::PowerManagement::supportedSleepStates(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:169:106: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:74) [-Wdeprecated-declarations] QSet Solid::PowerManagement::SleepState spdMethods = Solid::PowerManagement::supportedSleepStates(); ^ In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.cpp:21:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ [ 37%] Building CXX object containments/folder/CMakeFiles/folderplugin.dir/plugin/positioner.cpp.o [ 37%] Building CXX object containments/folder/CMakeFiles/folderplugin.dir/plugin/previewpluginsmodel.cpp.o [ 37%] Building CXX object containments/folder/CMakeFiles/folderplugin.dir/plugin/rubberband.cpp.o In file included from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qglobal.h:1068:0, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qshareddata.h:45, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/QSharedDataPointer:1, from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kserviceaction.h:24,
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: Thanks for your time on this, good stuff :) Tried it and the only caveat is that after login is done I have to press the back button (the one on the pmc controller) to get my album list. That should be fixed. Yeah I also figured the same. But I was not able to find out why it is happening and the way to correct it :/ On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 https://git.reviewboard.kde.org/r/120855/diff/3/?file=324518#file324518line60 where do you get these from? I made these keys from my own Google Account. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #1021
See http://build.kde.org/job/plasma-workspace_master_qt5/1021/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 3, 2014, 9:18 a.m., Shantanu Tushar wrote: browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 https://git.reviewboard.kde.org/r/120855/diff/3/?file=324518#file324518line60 where do you get these from? Ashish Bansal wrote: I made these keys from my own Google Account. I think KDE e.V. holds some API keys for google.. which can be used instead of your own personal keys so in case of some conflict KDE e.V. can help us. - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- On Nov. 2, 2014, 9:04 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 9:04 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_master_qt5 #782
See http://build.kde.org/job/plasma-desktop_master_qt5/782/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120957: Oxygen: Sync advanced settings to KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen Description --- Sync advanced settings to KDE4 Diffs - kstyle/config/oxygenstyleconfig.cpp 8185910 Diff: https://git.reviewboard.kde.org/r/120957/diff/ Testing --- Copies data correctly. Oxygen KDE4 apps update after reload. They don't update immediately but that bug is unrelated as that isn't happening when running kcmshell4 style Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/#review69731 --- I think is the right way for Oxygen, since doesn't require any modification to the kde4 version. Breeze will need the same thing.. even tough perhaps would be better to just make the kde4 version of breeze read/write into ~/.config as well, so they would just use the same config file - Marco Martin On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/ --- (Updated Nov. 3, 2014, 2:24 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen Description --- Sync advanced settings to KDE4 Diffs - kstyle/config/oxygenstyleconfig.cpp 8185910 Diff: https://git.reviewboard.kde.org/r/120957/diff/ Testing --- Copies data correctly. Oxygen KDE4 apps update after reload. They don't update immediately but that bug is unrelated as that isn't happening when running kcmshell4 style Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4
On Nov. 3, 2014, 3:44 p.m., Marco Martin wrote: I think is the right way for Oxygen, since doesn't require any modification to the kde4 version. Breeze will need the same thing.. even tough perhaps would be better to just make the kde4 version of breeze read/write into ~/.config as well, so they would just use the same config file changing the kde4 version is way more difficult as it's a stable release and we cannot control whether distros would ship the update. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/#review69731 --- On Nov. 3, 2014, 3:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/ --- (Updated Nov. 3, 2014, 3:24 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen Description --- Sync advanced settings to KDE4 Diffs - kstyle/config/oxygenstyleconfig.cpp 8185910 Diff: https://git.reviewboard.kde.org/r/120957/diff/ Testing --- Copies data correctly. Oxygen KDE4 apps update after reload. They don't update immediately but that bug is unrelated as that isn't happening when running kcmshell4 style Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4
On Nov. 3, 2014, 2:44 p.m., Marco Martin wrote: I think is the right way for Oxygen, since doesn't require any modification to the kde4 version. Breeze will need the same thing.. even tough perhaps would be better to just make the kde4 version of breeze read/write into ~/.config as well, so they would just use the same config file Martin Gräßlin wrote: changing the kde4 version is way more difficult as it's a stable release and we cannot control whether distros would ship the update. yeah, that's why i think this is right for oxygen, while for breeze is different, but that's ot here - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/#review69731 --- On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/ --- (Updated Nov. 3, 2014, 2:24 p.m.) Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen Description --- Sync advanced settings to KDE4 Diffs - kstyle/config/oxygenstyleconfig.cpp 8185910 Diff: https://git.reviewboard.kde.org/r/120957/diff/ Testing --- Copies data correctly. Oxygen KDE4 apps update after reload. They don't update immediately but that bug is unrelated as that isn't happening when running kcmshell4 style Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120949: Add imageprovider to fifteenpuzzle.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69710 --- image provider is the best way I can think to solve it too. applets/fifteenPuzzle/package/contents/ui/Piece.qml https://git.reviewboard.kde.org/r/120949/#comment48824 I probably would have gone for image://fifteenpuzzle/path?number that way I wouldn't need the refresh hack or to expose the provider as a contextProperty IMHO clearer, but it's up to you. why is shuffle commented out if this works? - David Edmundson On Nov. 2, 2014, 10:09 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/ --- (Updated Nov. 2, 2014, 10:09 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now, but need to come from the qml. This is a first attempt posting to get feedback about the approach etc. Diffs - applets/fifteenPuzzle/package/contents/config/main.xml 0dd804a12ddb0c7c2daaced1b92582f0deff494f applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml bf9581bd78c1c7690fc16f01e440adad0fc98766 applets/fifteenPuzzle/package/contents/ui/Piece.qml c386570aebdf4323e3132aa05445b38383149dea applets/fifteenPuzzle/package/contents/ui/configAppearance.qml d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 applets/fifteenPuzzle/package/contents/ui/main.qml c76eaeb4d936fe917d99375722905c2f002c33e6 applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION applets/fifteenPuzzle/plugin/qmldir PRE-CREATION applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 Diff: https://git.reviewboard.kde.org/r/120949/diff/ Testing --- It builds and runs, currently doesn't shuffle, to test the result image works and appears. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120949: Add imageprovider to fifteenpuzzle.
On Nov. 3, 2014, 1:47 a.m., Sebastian Kügler wrote: What's the purpose of this approach? It was the only way I could think of to split the image, I'm open to better ideas though. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69707 --- On Nov. 2, 2014, 3:09 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/ --- (Updated Nov. 2, 2014, 3:09 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- ImageProvider plugin start, pieceWidth and pieceHeight are both 30 for now, but need to come from the qml. This is a first attempt posting to get feedback about the approach etc. Diffs - applets/fifteenPuzzle/package/contents/config/main.xml 0dd804a12ddb0c7c2daaced1b92582f0deff494f applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml bf9581bd78c1c7690fc16f01e440adad0fc98766 applets/fifteenPuzzle/package/contents/ui/Piece.qml c386570aebdf4323e3132aa05445b38383149dea applets/fifteenPuzzle/package/contents/ui/configAppearance.qml d78c91b6e4182a2e461c1ee355b6ad30b63fbc68 applets/fifteenPuzzle/package/contents/ui/main.qml c76eaeb4d936fe917d99375722905c2f002c33e6 applets/fifteenPuzzle/plugin/fifteenimageprovider.h PRE-CREATION applets/fifteenPuzzle/plugin/fifteenimageprovider.cpp PRE-CREATION applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.h PRE-CREATION applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp PRE-CREATION applets/fifteenPuzzle/plugin/qmldir PRE-CREATION applets/fifteenPuzzle/CMakeLists.txt c7e6a718a6211e0cde1121609ed28ec0fe8448f7 Diff: https://git.reviewboard.kde.org/r/120949/diff/ Testing --- It builds and runs, currently doesn't shuffle, to test the result image works and appears. Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/#review69738
---
I think it's a good approach and quite possibly worth pursuing, cheers ^_-
Can you also post a screenshot of the history popup please?
File Attachment: New popup - newnotificationpopup.png
https://git.reviewboard.kde.org//r/120943/#fcomment272
The icon was always aligned to the top, together with the title. I'm not
sure this looks better...add vdg?
applets/notifications/package/contents/ui/NotificationDelegate.qml
https://git.reviewboard.kde.org/r/120943/#comment48844
The plasma qml style[1] says all properties need to be on top; makes it
also better readable
[1] https://community.kde.org/Plasma/QMLStyle
applets/notifications/package/contents/ui/NotificationItem.qml
https://git.reviewboard.kde.org/r/120943/#comment48845
I know this is just copied but I wonder - is there any reason for this? I
mean do notifications have urls in the title? (question to whoever put it there
originally)
- Martin Klapetek
On Nov. 2, 2014, 9 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
---
(Updated Nov. 2, 2014, 9 p.m.)
Review request for Plasma and Martin Klapetek.
Repository: plasma-workspace
Description
---
This moves duplicate code (notification icon, heading, text, action buttons)
into a separate NotificationItem {} component used by both the notification
popup as well as the notification list delegate.
If we ever were to provide richer notifications for specific usecases (you
can provide custom hints in notifications after all) this would ease this and
less duplication is always good :)
I also cleaned up a bit of commented/unused code and changed complicated
anchoring to QtQuick Layouts where applicable.
Diffs
-
applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2
applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION
applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2
Diff: https://git.reviewboard.kde.org/r/120943/diff/
Testing
---
Ran knotificationdbustest and didn't notice anything unusual, visually the
thing should look and behave exactly like it did before. Additional testing
is welcomed, however.
File Attachments
New popup
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem
On Nov. 3, 2014, 10:18 a.m., Kai Uwe Broulik wrote:
applets/notifications/package/contents/ui/NotificationDelegate.qml, lines
273-278
https://git.reviewboard.kde.org/r/120943/diff/2/?file=324533#file324533line273
Do we really need that?
I'm really not sure, I can look into this afterwards if you want
On Nov. 3, 2014, 10:18 a.m., Kai Uwe Broulik wrote:
applets/notifications/package/contents/ui/NotificationPopup.qml, lines 48-51
https://git.reviewboard.kde.org/r/120943/diff/2/?file=324535#file324535line48
Actually we could just bind those to notificationProperties.foo instead
of assigning everything manually
Ah yeah, that's something I was thinking about doing some time ago, I can do
that as well if you don't want to
On Nov. 3, 2014, 10:18 a.m., Kai Uwe Broulik wrote:
applets/notifications/package/contents/ui/NotificationPopup.qml, line 54
https://git.reviewboard.kde.org/r/120943/diff/2/?file=324535#file324535line54
I think that is not needed
Wouldn't it just keep appending then?
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/#review69715
---
On Nov. 2, 2014, 9 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
---
(Updated Nov. 2, 2014, 9 p.m.)
Review request for Plasma and Martin Klapetek.
Repository: plasma-workspace
Description
---
This moves duplicate code (notification icon, heading, text, action buttons)
into a separate NotificationItem {} component used by both the notification
popup as well as the notification list delegate.
If we ever were to provide richer notifications for specific usecases (you
can provide custom hints in notifications after all) this would ease this and
less duplication is always good :)
I also cleaned up a bit of commented/unused code and changed complicated
anchoring to QtQuick Layouts where applicable.
Diffs
-
applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2
applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION
applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2
Diff: https://git.reviewboard.kde.org/r/120943/diff/
Testing
---
Ran knotificationdbustest and didn't notice anything unusual, visually the
thing should look and behave exactly like it did before. Additional testing
is welcomed, however.
File Attachments
New popup
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.
https://bugs.kde.org/show_bug.cgi?id=340580 Martin Klapetek mklape...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WORKSFORME CC||mklape...@kde.org --- Comment #1 from Martin Klapetek mklape...@kde.org --- Can you try deleting $XDG_CACHE_HOME/icon-cache.kcache and log out/in. Does that fix it? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.
https://bugs.kde.org/show_bug.cgi?id=340580 Martin Klapetek mklape...@kde.org changed: What|Removed |Added Resolution|WORKSFORME |WAITINGFORINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.
https://bugs.kde.org/show_bug.cgi?id=340580 --- Comment #2 from donniezazen sud...@sudhirkhanger.com --- Already tried that and it doesn't do anything. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
On Oct. 30, 2014, 11:39 a.m., Ian Wadham wrote: The following ideas are concerns about design, rather than coding. I do not know what the underlying objectives of Frameworks are, including who is intended to use it and for what, so I will be guided by you and Thomas and the Frameworks team. IF Frameworks is for use in KDE software only and IF the bugs.kde.org database is the same for all users of KDE software world-wide (both KDE 4 and KF 5) and will never go back to using cookies, THEN you can actually dispense with all the Bugzilla version-checking code in the current patch and all the security methods except for UsePasswords. This is because UsePasswords has actually been supported since Bugzilla version 3.2 (i.e. since before the UseCookies version of Bugzilla [4.3.x] which KDE software had in June/July and before). I spotted this potential simplification late in the https://git.reviewboard.kde.org/r/120431/ process: too late to bring it up at that point. It is, in fact, why I was able to test UsePasswords mode... :-) OTOH, IF Frameworks is also for use in non-KDE software (presumably based on Qt), THEN you need to keep the version checking, because you probably cannot know what database and Bugzilla version that other software might prefer to use. This scenario can happen. I saw an enquiry by a FOSS developer only recently (on one of the Apple FOSS lists I think). He liked KCrash and Dr Konqi, wanted to use them in his own software package and was asking what might be involved. In both potential uses of Frameworks, you can dispense with the UseTokens security method altogether and go straight to UsePasswords. At first reading, I thought that was what you had done in your original patch, Hrvoje... :-) So you could have UseCookies and UsePasswords --- or just UsePasswords. Also you can, I think, drop the call to Bugzilla's login when using UsePasswords mode. Support for login calls will be discontinued in a future version of Bugzilla (after 4.5.0). I do not think you need a login call if you are sending a user name and password with every database update call. If I am right about that, dropping the login call will give Dr K even more future-proofing against currently announced Bugzilla changes. Of course, you will still need a login dialog or some way to get a username and password, from KWallet or whatever... I wrote a message about this stuff and it was forwarded to the k-f-d list recently (I am not subscribed there). Did you see it? You might also be able to strip out the Dr Konqi code that checks if the KCookieJar is available, or make it conditionally compiled. You could avoid a few more of Dr Konqi's dependencies that way. Finally, whatever you decide, it would be good to keep the basics of the Bugzilla-version-checking code, in case of other announced changes to Bugzilla software in the future. I am thinking particularly of changes to the database schema, call parameters, return values, etc. as Bugzilla evolves. I do not know what the underlying objectives of Frameworks are, including who is intended to use it and for what, so I will be guided by you and Thomas and the Frameworks team. Frameworks are just more/less splitted, fine grained kdelibs + bits pieces from kde-runtime, with relevant features pushed to upstream Qt. I wrote a message about this stuff and it was forwarded to the k-f-d list recently (I am not subscribed there). Did you see it? I did not, but i shall check the archives. Just to be clear, i am not working on DrKonqi in the KF5/Plasma 5 world - i just wanted to have DrKonqi in that world functional again. Hence, it would be nice if someone approves until 5.1.1 tagging. We can take a look at the design for the code in master, there is no hurry ;-) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/#review69516 --- On Oct. 29, 2014, 9:41 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Oct. 29, 2014, 9:41 p.m.) Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399
Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
---
(Updated Nov. 3, 2014, 8:26 nachm.)
Review request for Plasma and Martin Klapetek.
Changes
---
- No more links in titles, clients that require that are broken
- Bind item to notificationProperties directly instead of assigning each
property
- Remove explicit StyledText, Qt figures that out by itself (fixes KMail) and
it never resorts to RichText (which was my initial reason for this) by itself
- Re-order properties for better readability
- Restored timer stuff in containsMouseChanged
- No longer vertically align icon (I like it better, especially for the smaller
popups which are the majority but outside the scope of this patch, sorry for
that)
- Added history screenshot
Repository: plasma-workspace
Description
---
This moves duplicate code (notification icon, heading, text, action buttons)
into a separate NotificationItem {} component used by both the notification
popup as well as the notification list delegate.
If we ever were to provide richer notifications for specific usecases (you can
provide custom hints in notifications after all) this would ease this and less
duplication is always good :)
I also cleaned up a bit of commented/unused code and changed complicated
anchoring to QtQuick Layouts where applicable.
Diffs (updated)
-
applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2
applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION
applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2
Diff: https://git.reviewboard.kde.org/r/120943/diff/
Testing
---
Ran knotificationdbustest and didn't notice anything unusual, visually the
thing should look and behave exactly like it did before. Additional testing is
welcomed, however.
File Attachments (updated)
New popup
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
New history
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/03/e7efdf8f-09de-4eaf-a7a2-d37979bad28b__newnotificationhistory.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/#review69755
---
applets/notifications/package/contents/ui/NotificationPopup.qml
https://git.reviewboard.kde.org/r/120943/#comment48852
summary: notificationProperties ? notificationProperties.summary:
text: notificationProperties ? notificationProperties.body :
icon: notificationProperties ? notificationProperties.appIcon :
image: notificationProperties ? notificationProperties.image : undefined
Fixes the warnings :)
- Kai Uwe Broulik
On Nov. 3, 2014, 8:26 nachm., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
---
(Updated Nov. 3, 2014, 8:26 nachm.)
Review request for Plasma and Martin Klapetek.
Repository: plasma-workspace
Description
---
This moves duplicate code (notification icon, heading, text, action buttons)
into a separate NotificationItem {} component used by both the notification
popup as well as the notification list delegate.
If we ever were to provide richer notifications for specific usecases (you
can provide custom hints in notifications after all) this would ease this and
less duplication is always good :)
I also cleaned up a bit of commented/unused code and changed complicated
anchoring to QtQuick Layouts where applicable.
Diffs
-
applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2
applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION
applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2
Diff: https://git.reviewboard.kde.org/r/120943/diff/
Testing
---
Ran knotificationdbustest and didn't notice anything unusual, visually the
thing should look and behave exactly like it did before. Additional testing
is welcomed, however.
File Attachments
New popup
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
New history
https://git.reviewboard.kde.org/media/uploaded/files/2014/11/03/e7efdf8f-09de-4eaf-a7a2-d37979bad28b__newnotificationhistory.png
Thanks,
Kai Uwe Broulik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120961: Use Loader for More Settings menu in panelcontroller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120961/ --- Review request for Plasma. Repository: plasma-desktop Description --- Panelcontroller already takes quite some time to load, so we should not load the More Settings menu if it is not opened. I usually only open the panelcontroller to quickly remove an applet I accidentally added to my panel, I hardly ever use the settings menu. That import org.kde.plasma.configuration 2.0 looks unused to me. Diffs - desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml PRE-CREATION desktoppackage/contents/configuration/panelconfiguration/Ruler.qml c4c2ed3 desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 828147c Diff: https://git.reviewboard.kde.org/r/120961/diff/ Testing --- There's still a noticeable delay but it's less than before though I hoped that patch helped more significantly. Other than that works as expected. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120961: Use Loader for More Settings menu in panelcontroller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120961/#review69757 --- Ship it! Inviala! - Marco Martin On Nov. 3, 2014, 8:47 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120961/ --- (Updated Nov. 3, 2014, 8:47 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Panelcontroller already takes quite some time to load, so we should not load the More Settings menu if it is not opened. I usually only open the panelcontroller to quickly remove an applet I accidentally added to my panel, I hardly ever use the settings menu. That import org.kde.plasma.configuration 2.0 looks unused to me. Diffs - desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml PRE-CREATION desktoppackage/contents/configuration/panelconfiguration/Ruler.qml c4c2ed3 desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 828147c Diff: https://git.reviewboard.kde.org/r/120961/diff/ Testing --- There's still a noticeable delay but it's less than before though I hoped that patch helped more significantly. Other than that works as expected. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120965: Base panelcontroller and more settings menu on button sizes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120965/ --- Review request for Plasma. Repository: plasma-desktop Description --- Not every language has short fancy expressions for things and thus stuff breaks when using it in German, for example the Windows can cover or Add spacer button were cut off. This fixes this by accounting the button widths in the minimum width. Diffs - desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml 2ab662c desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 7cf567e Diff: https://git.reviewboard.kde.org/r/120965/diff/ Testing --- No more cut off buttons, but it seems there's an issue with re-layouting when dragging a horizontal to a side. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 340617] New: Breeze dark theme has bright breeze dialog background
https://bugs.kde.org/show_bug.cgi?id=340617 Bug ID: 340617 Summary: Breeze dark theme has bright breeze dialog background Product: Breeze Version: 5.1.0 Platform: Ubuntu Packages URL: https://dl.dropboxusercontent.com/u/3454148/breeze_dar k.png OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: a.prono...@gmail.com When changing the desktop theme to breeze dark, I still have the bright breeze dialog background as shown in the attached screenshot. The panel color and text color changes as expected. Other downloaded themes successfully change that background, only breeze dark does not work as expected. Reproducible: Always Steps to Reproduce: 1. Go to settings-desktop theme 2. Select Breeze Dark 3. Apply Actual Results: The panel gets dark, but the K menu and all plasma dialogs, krunner etc. remain bright. Text color changes as expected. Expected Results: Everything is themed with dark background. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
