Re: Review Request 123271: improve kickoff representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78570 --- Err, i don't see an error in the vertical before version. The kickoff icon simply scales to the new available width, that's how it's supposed to work, right? I'm not 100% sure. A plasma dev will probably jump in and correct me if i'm wrong :) - Mark Gaiser On apr 6, 2015, 11:40 a.m., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated apr 6, 2015, 11:40 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122842: Allow selecting notifications position on screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/ --- (Updated April 6, 2015, 6:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit 9429c845ae3fee1d65b026b2d496aae1305db232 by Martin Klapetek to branch master. Bugs: 344841 https://bugs.kde.org/show_bug.cgi?id=344841 Repository: plasma-workspace Description --- Allows to select each corner and top or bottom edges of the screen. The radio selection thing is currently a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG here but there's no vdg group (?) so I'll post in the forums). Diffs - applets/notifications/CMakeLists.txt 113d731 applets/notifications/lib/CMakeLists.txt PRE-CREATION applets/notifications/lib/notificationsapplet.h PRE-CREATION applets/notifications/lib/notificationsapplet.cpp PRE-CREATION applets/notifications/package/contents/ui/Notifications.qml 4312774 applets/notifications/package/contents/ui/ScreenPositionSelector.qml PRE-CREATION applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 applets/notifications/package/metadata.desktop 333fa2c applets/notifications/plugin/notificationshelper.h ca0b63b applets/notifications/plugin/notificationshelper.cpp cd8a5a5 Diff: https://git.reviewboard.kde.org/r/122842/diff/ Testing --- All positions work File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png New Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
On April 6, 2015, 5:18 nachm., Mark Gaiser wrote: Err, i don't see an error in the vertical before version. The kickoff icon simply scales to the new available width, that's how it's supposed to work, right? I'm not 100% sure. A plasma dev will probably jump in and correct me if i'm wrong :) It's a regression compared to plasma 1 and this patch just restores the behaviour from plasma 1. If it uses the available width for it's height, it looks enormous, takes much of the vertical space and is also distracting. With the patch, the button is still using the full width as click area and just limits the height. - Mathias --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78570 --- On April 6, 2015, 11:40 vorm., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 11:40 vorm.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 5.3 changelog
Hiyo, we're freezing this week, so it's time to gather the changes for the promo folks again. I'll start with the noteworthy stuff in my components: * The Desktop and Folder View containment codebases were unified, and have seen performance improvements, code cleanups and porting to newer Qt APIs. * The Desktop and Folder View containments have improved widget handling, fixing bugs e.g. in the size calculation for the widget placeholder rectangle shown while moving widgets. * The Desktop and Folder View containments have a new experimental Press and hold mode for widget management, available as an option on the new Tweaks config page. In this mode, widgets can be moved after pressing and holding anywhere on the widget, and the widget handle will only be shown after press and hold rather than on hover. When this mode is enabled, unlocking the desktop will show a helpful instruction notification (which can be dismissed forever from the popup). * The Desktop and Folder View containments have a new option to hide the Desktop Toolbox, available on the new Tweaks config page. (^ This last one is not yet pushed, but will be by freeze time.) * The rubberband selection code in Folder View was rewritten and now selects icons as soon as the rubberband touches the bounding box of icon and text label, instead of testing for the midpoint a the folder item. --- * The Recent Documents and Recent Applications sections in Application Menu (Kicker) are now powered by KDE activities. This e.g. means Recent Applications will pick up on apps launched outside the menu provided those other launchers hook into KDE activities as well. * Application Menu (Kicker) has a new Recent Contacts section that lists IM contacts in order of recently talked to, with realtime status icon information. As this requires a new release of KDE Telepathy (or other messengers) that enters conversation info into the KDE activities db, this section will still be disabled by default in 5.3. * There's config (and context menu actions) for enabling and disabling the Recent * menu sections. * The context menu of application items (including sidebar favorites) in Application Menu (Kicker) now shows per-app- lication recent documents entries, also powered by KDE activities. This makes it very easy to relaunch an app on a recently-used document. * Keyboard navigation in Application Menu (Kicker) was over- hauled with many subtle behavior and bug fixes. * Improved subdialog focus handling in Application Menu (Kicker). --- * Task Manager and Icons-only Task Manager now show entries for recent documents in the context menus of launcher items, making it very easy to relaunch an app on a recently-used document. * Task Manager and Icons-only Task Manager gained a new config option to disable switching tasks by mouse wheel scroll. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123271: improve kickoff representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78577 --- Personally I think this patch makes sense, having the button all over the panel seems like a waste of space to me... applets/kickoff/package/contents/ui/CompactRepresentation.qml (line 43) https://git.reviewboard.kde.org/r/123271/#comment53753 This should use the plasmoid.configuration.icon I believe - Martin Klapetek On April 6, 2015, 1:40 p.m., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 6, 2015, 1:40 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123280: Kickoff - Properly register recent applications right after startup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/ --- Review request for Plasma. Repository: plasma-desktop Description --- This does two things: - Instantiate the RecentlyUsedModel at startup, otherwise it's not available until the History tab is opened and this leads to some mixing in the recent apps list/the list not being updated until then. - Move the registration of the service handler to the launcher, so that the apps launched from the Favorites tab are registered without having to open the Applications tab first. Diffs - applets/kickoff/core/applicationmodel.cpp 9af58a36d5c3349ad1f2bffd0f7f93eebd99663e applets/kickoff/core/urlitemlauncher.cpp 58a6c20cec60ede54ea55d927064eaf8af9b4f46 applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde962f2321d9b186c9d73246491dc48b398bb applets/kickoff/package/contents/ui/RecentlyUsedView.qml df25db21db4a6bd764dee3ff8583e2bdc35fe341 Diff: https://git.reviewboard.kde.org/r/123280/diff/ Testing --- Launched applications from Favorites and Applications tab without opening the History tab first, items are added correctly. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123280: Kickoff - Properly register recent applications right after startup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/#review78581 --- I don't understand the moving the recently used model startup part. What's broken about loading it later? - David Edmundson On April 6, 2015, 9:35 p.m., Anthony Vital wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/ --- (Updated April 6, 2015, 9:35 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- This does two things: - Instantiate the RecentlyUsedModel at startup, otherwise it's not available until the History tab is opened and this leads to some mixing in the recent apps list/the list not being updated until then. - Move the registration of the service handler to the launcher, so that the apps launched from the Favorites tab are registered without having to open the Applications tab first. Diffs - applets/kickoff/core/applicationmodel.cpp 9af58a36d5c3349ad1f2bffd0f7f93eebd99663e applets/kickoff/core/urlitemlauncher.cpp 58a6c20cec60ede54ea55d927064eaf8af9b4f46 applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde962f2321d9b186c9d73246491dc48b398bb applets/kickoff/package/contents/ui/RecentlyUsedView.qml df25db21db4a6bd764dee3ff8583e2bdc35fe341 Diff: https://git.reviewboard.kde.org/r/123280/diff/ Testing --- Launched applications from Favorites and Applications tab without opening the History tab first, items are added correctly. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123274/#review78580
---
ship it.
applets/timer/package/contents/ui/configAdvanced.qml (line 31)
https://git.reviewboard.kde.org/r/123274/#comment53757
sexy optimisation:
Make this the top level item.
i.e instead of
Item {
property alias
ColumnLayout {
GroupBox {
}
}
}
become
ColumnLayout {
property alias
GroupBox {
}
}
then you should be able to remove the explicit width/height properties too
applets/timer/package/contents/ui/configAdvanced.qml (line 47)
https://git.reviewboard.kde.org/r/123274/#comment53756
enabled: runCommand.checked
- David Edmundson
On April 6, 2015, 4:05 p.m., Bernhard Friedreich wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123274/
---
(Updated April 6, 2015, 4:05 p.m.)
Review request for Plasma.
Repository: kdeplasma-addons
Description
---
Added tab General and Appearance in the config ui
General contains the bits about command execution after the timer has
completed
Appearance contains the ability to hide seconds and showing the title
The configuration option for showing the title is a bit buggy (again)
This bugreport explains the wrong scaling of the title: 304923
I've converted this plasmoid from being qml only to c++ and qml because it
looks like KProcess has no qml interface yet (and I didn't find any place
where to start)
[Edit 1]: updated to use QProcess
[Edit 2]: renamed General to Advanced and moved it down to make Appearance
the default tab on opening
Diffs
-
applets/timer/plugin/timerplugin.cpp PRE-CREATION
applets/timer/plugin/timer.cpp PRE-CREATION
applets/timer/plugin/timerplugin.h PRE-CREATION
applets/timer/plugin/timer.h PRE-CREATION
applets/timer/plugin/qmldir PRE-CREATION
applets/timer/package/contents/ui/timer.qml
f675b93bda59eb161fe10b5f575eaa2082b822e0
applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION
applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION
applets/timer/package/contents/config/config.qml PRE-CREATION
applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f
Diff: https://git.reviewboard.kde.org/r/123274/diff/
Testing
---
Tested using plasmashell directly and using plasmoidviewer
File Attachments
Appearance Tab
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png
Advanced Tab
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png
Thanks,
Bernhard Friedreich
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123280: Kickoff - Properly register recent applications right after startup
On avr. 6, 2015, 11:20 après-midi, David Edmundson wrote: I don't understand the moving the recently used model startup part. What's broken about loading it later? When you launch an application right after startup, an internal list is populated by loading the recent applications previously saved from the config file. Only then, the application launched is added to the list, at the end. If the RecentlyUsedModel is instantiated after that, the list will be used as it is, meaning the most recently used application will be at the bottom. The RecentlyUsedModel is supposed to catch a signal when a new application has been launched, effectively sorting the list. So by instantiating the model early, we ensure that the list will be sorted. Maybe this could be fixed differently, but it makes sense to me to have the model available immediately. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/#review78581 --- On avr. 6, 2015, 9:35 après-midi, Anthony Vital wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/ --- (Updated avr. 6, 2015, 9:35 après-midi) Review request for Plasma. Repository: plasma-desktop Description --- This does two things: - Instantiate the RecentlyUsedModel at startup, otherwise it's not available until the History tab is opened and this leads to some mixing in the recent apps list/the list not being updated until then. - Move the registration of the service handler to the launcher, so that the apps launched from the Favorites tab are registered without having to open the Applications tab first. Diffs - applets/kickoff/core/applicationmodel.cpp 9af58a36d5c3349ad1f2bffd0f7f93eebd99663e applets/kickoff/core/urlitemlauncher.cpp 58a6c20cec60ede54ea55d927064eaf8af9b4f46 applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde962f2321d9b186c9d73246491dc48b398bb applets/kickoff/package/contents/ui/RecentlyUsedView.qml df25db21db4a6bd764dee3ff8583e2bdc35fe341 Diff: https://git.reviewboard.kde.org/r/123280/diff/ Testing --- Launched applications from Favorites and Applications tab without opening the History tab first, items are added correctly. Thanks, Anthony Vital ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123273: Image Wallpaper: Don't show duplicates after removing some of the wallpapers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123273/#review78558 --- wallpapers/image/backgroundlistmodel.cpp (line 246) https://git.reviewboard.kde.org/r/123273/#comment53745 I am putting this comment here as an example. I could either remove this comment before pushing the patch or keeping it as a reference. - Antonis Tsiapaliokas On April 6, 2015, 12:53 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123273/ --- (Updated April 6, 2015, 12:53 p.m.) Review request for Plasma. Bugs: 345914 https://bugs.kde.org/show_bug.cgi?id=345914 Repository: plasma-workspace Description --- After removing some local wallpapers, if we click on the apply the remaining wallpapers are being shown twice. This patch is fixing this issue. In the bug report, there is an image which is showing up the bug after it has been reproduced. Diffs - wallpapers/image/backgroundlistmodel.cpp 9aaf514 Diff: https://git.reviewboard.kde.org/r/123273/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug.cgi?id=344384 Repository: plasma-workspace Description --- After removing a wallpaper the currentIndex is remaining the same. As a result of that our model has checked the wrong wallpaper. This patch is fixing this bug. Diffs - wallpapers/image/imagepackage/contents/ui/config.qml 22408ef Diff: https://git.reviewboard.kde.org/r/123275/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- File Attachment: General Tab - tab_general.png https://git.reviewboard.kde.org//r/123274/#fcomment390 Given this looks like advanced feature, I'd rather we hid it away so it wasn't the first thing that comes up in the config. So I'm clear, what do you see the use case of this being? applets/timer/plugin/timer.cpp (line 28) https://git.reviewboard.kde.org/r/123274/#comment53747 QProcess::stateDetached(touch /tmp/asdf); doesn't behave quite as you think it should, the args need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. - David Edmundson On April 6, 2015, 1:11 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/ --- Review request for Plasma. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick/appletquickitem.cpp 1abedf0 Diff: https://git.reviewboard.kde.org/r/123276/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123273: Image Wallpaper: Don't show duplicates after removing some of the wallpapers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123273/ --- Review request for Plasma. Bugs: 345914 https://bugs.kde.org/show_bug.cgi?id=345914 Repository: plasma-workspace Description --- After removing some local wallpapers, if we click on the apply the remaining wallpapers are being shown twice. This patch is fixing this issue. In the bug report, there is an image which is showing up the bug after it has been reproduced. Diffs - wallpapers/image/backgroundlistmodel.cpp 9aaf514 Diff: https://git.reviewboard.kde.org/r/123273/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- Just a question - why is the current suggested name wrong? autotests/globaltest.cpp (line 96) https://git.reviewboard.kde.org/r/123224/#comment53746 This should be (1).txt? - Martin Klapetek On April 4, 2015, 3:15 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 3:15 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123272: improve digital clock representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123272/#review78557 --- File Attachment: clock-vertical-after2 - clock-vertical-after2.png https://git.reviewboard.kde.org//r/123272/#fcomment389 As you can see here, the date is now cramped to the burger menu; that's because of the height: change; that one should not be there - Martin Klapetek On April 6, 2015, 1:55 p.m., Mathias Kraus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123272/ --- (Updated April 6, 2015, 1:55 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- On vertical panels, the date of the digital clock doesn't fit on the panel. This patch sets the size of the date label to fit the panel. Diffs - applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1 Diff: https://git.reviewboard.kde.org/r/123272/diff/ Testing --- see screenshots File Attachments clock-horizontal-before1 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/23b26092-8a78-41c5-af9c-4f8ce6abc782__clock-horizontal-befor1.png clock-horizontal-after1 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/7898603f-037f-4fcf-b219-db095a167be5__clock-horizontal-after1.png clock-horizontal-before2 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f22e29d7-9fcd-4a3c-8d46-859d4f3fbe3e__clock-horizontal-befor2.png clock-horizontal-after2 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3d189422-5929-44c2-b8a3-7b5470833390__clock-horizontal-after2.png clock-vertical-before1 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/8b870753-d2e9-437b-adf8-dce8dba8b49e__clock-vertical-before1.png clock-vertical-after1 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/f1eef7c8-b02b-41bc-8c91-10fe778dae73__clock-vertical-after1.png clock-vertical-before2 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/3939f8f4-f618-438f-b908-c72861286004__clock-vertical-before2.png clock-vertical-after2 https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/fa52c342-96d7-4176-83ea-37eb76e31910__clock-vertical-after2.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123271: improve kickoff representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION applets/kickoff/package/contents/ui/Kickoff.qml 33b49eb Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments (updated) General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 nachm., David Edmundson wrote: File Attachment: General Tab - tab_general.png https://git.reviewboard.kde.org/r/123274/#fcomment391 Given this looks like advanced feature, I'd rather we hid it away so it wasn't the first thing that comes up in the config. So I'm clear, what do you see the use case of this being? Well primarily I readded those configuration options because they were there originally, and looking at the bugreports also used. I guess they got lost in the port to kf5/qml. In the config xml they where still there and I guess some people want them back. Personally I could imagine usecases like custom notifications - e.g. I'll take a short nap of about half an hour - after the timer is done please start playing some music - this could be set as a command I guess. Other ideas instead of command execution? Could we hook something else into this? Your argument about the advanced feature is of course correct - any suggestions? Rename the tab from General to Advanced (?) and move it down below the Appearance so the appearance tab is shown when opening the config dialog? On April 6, 2015, 2:29 nachm., David Edmundson wrote: applets/timer/plugin/timer.cpp, line 28 https://git.reviewboard.kde.org/r/123274/diff/1/?file=360283#file360283line28 QProcess::stateDetached(touch /tmp/asdf); doesn't behave quite as you think it should, the args need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. Oh I thought KProcess was the preferred way.. Meh.. yeah this will need fixing of course.. Thanks for the review :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 1:11 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 3:55 nachm.) Review request for Plasma. Changes --- Updated to use QProcess Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: Updated to use QProcess Diffs (updated) - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/#review78561 --- Ship it! Ship It! - David Edmundson On April 6, 2015, 2:07 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/ --- (Updated April 6, 2015, 2:07 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick/appletquickitem.cpp 1abedf0 Diff: https://git.reviewboard.kde.org/r/123276/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: Just a question - why is the current suggested name wrong? In name filename-1.6.tar.gz, 1.6 denotes package version and new suggested name changes it to filename-1 2.6.tar.gz. It should add 1 after the package version and should not increment package name from 1.6 to 2.6. If i keep calling suggestName, it changes it further to 3.6, 4.6 and so on. So, I hope that explains the current suggested name is wrong :) On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? imho if my any file starts with ., that's my dot file and I would not like suggestName to remove the dotness of file instead it should append/increment no. at end. But if you still find no. at the starting as better use case, then no problem I'll change it right away. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 nachm., David Edmundson wrote: applets/timer/plugin/timer.cpp, line 28 https://git.reviewboard.kde.org/r/123274/diff/1/?file=360283#file360283line28 QProcess::stateDetached(touch /tmp/asdf); doesn't behave quite as you think it should, the args need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. Bernhard Friedreich wrote: Oh I thought KProcess was the preferred way.. Meh.. yeah this will need fixing of course.. Thanks for the review :) QProcess::startDetached(touch /home/friedreb/blah); works for me as expected (file is created/touched) - imho using this method I won't have to parse the arguments manually.. do I miss something here what you've ment? - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 1:11 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 4:05 nachm.) Review request for Plasma. Changes --- Rename General to Advanced and make Appearance the first tab shown when opening the config dialog Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs (updated) - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments (updated) Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 p.m., David Edmundson wrote: applets/timer/plugin/timer.cpp, line 28 https://git.reviewboard.kde.org/r/123274/diff/1/?file=360283#file360283line28 QProcess::stateDetached(touch /tmp/asdf); doesn't behave quite as you think it should, the args need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. Bernhard Friedreich wrote: Oh I thought KProcess was the preferred way.. Meh.. yeah this will need fixing of course.. Thanks for the review :) Bernhard Friedreich wrote: QProcess::startDetached(touch /home/friedreb/blah); works for me as expected (file is created/touched) - imho using this method I won't have to parse the arguments manually.. do I miss something here what you've ment? it means I was wrong and you were right. Make the most of it :) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 4:05 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 4:05 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 nachm., David Edmundson wrote: File Attachment: General Tab - tab_general.png https://git.reviewboard.kde.org/r/123274/#fcomment392 Given this looks like advanced feature, I'd rather we hid it away so it wasn't the first thing that comes up in the config. So I'm clear, what do you see the use case of this being? Bernhard Friedreich wrote: Well primarily I readded those configuration options because they were there originally, and looking at the bugreports also used. I guess they got lost in the port to kf5/qml. In the config xml they where still there and I guess some people want them back. Personally I could imagine usecases like custom notifications - e.g. I'll take a short nap of about half an hour - after the timer is done please start playing some music - this could be set as a command I guess. Other ideas instead of command execution? Could we hook something else into this? Your argument about the advanced feature is of course correct - any suggestions? Rename the tab from General to Advanced (?) and move it down below the Appearance so the appearance tab is shown when opening the config dialog? Regarding the run command usecase: https://bugs.kde.org/show_bug.cgi?id=264934#c1 - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 4:05 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 4:05 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
