Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 30, 2015, 9:05 a.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- fixed issues Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123570: Add a method to insert new known structures
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- (Updated April 30, 2015, 9:31 a.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description (updated) --- When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much broken, since they can't find the structure instance. in order to load packages one can subclass packageloader, but listing still doesn't work. this makes possible for apps to insert new structure types without having to subclass. an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in libplasma, because then any user of libplasma could replace the packageloader again, breaking it. or alternatively all internal plasma package types could become plugins as well (that i fear would become necessary at some point if we want to be able to fully replace plasmapkg2 with kpackagetool) Diffs - src/kpackage/packageloader.h 4cc40e6 src/kpackage/packageloader.cpp 174f54b Diff: https://git.reviewboard.kde.org/r/123570/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123556: KPackage::findPackages with a filter callback
On April 29, 2015, 8:53 p.m., Alex Richardson wrote: src/kpackage/packageloader.cpp, line 273 https://git.reviewboard.kde.org/r/123556/diff/2/?file=364383#file364383line273 This will crash if there is no filter. `if (!filter || filter(plugin))` should work. done, thanks - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79698 --- On April 29, 2015, 12:12 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 12:12 p.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- Add a KPackage::findPackages function similar to KPluginLoader::findPlugins Diffs - src/kpackage/packageloader.h 2761d98 src/kpackage/packageloader.cpp 00defbd Diff: https://git.reviewboard.kde.org/r/123556/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
ISO for 2015-04-30
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist Earlier ISO this week because tomorrow is a holiday in Austria. This ISO is back to using unstable builds (i.e. git master; what will be Plasma 5.4). If you installed one of the previous two ISOs please reinstall or manually change the CI repository from stable to unstable. # changes - back to unstable integration - new volume applet kcm available - sudo apt install plasma-volume-control (needs manual adding to systray) # errata - installer window decoration uses !breeze colors. fix discussed; needs implementation in the installer code itself. # long standing errata - the ISO is rolled using the CI landing PPA due to stabilization blockage from missing bluez5. this in turn means that upgrades potentially won't work or break half way through as the underlying PPA breaks ever so often. ^ to be resolved for next ISO; tech to deal with this landed earlier this week. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 28, 2015, 2:35 p.m., David Faure wrote:
src/core/global.cpp, line 407
https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407
startsWith('.') (using the QChar overload)
Do we even need this special case, with the way the code is now? It
seems to me that removing this first if() branch would work just the same.
Ashish Bansal wrote:
The first if() has been used for getting . (1).txt instead of .txt (1)
But yeah, code looks nasty with this special case. Should I remove this?
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79629
---
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 30, 2015, 9:05 a.m.)
Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.
Bugs: 341773
https://bugs.kde.org/show_bug.cgi?id=341773
Repository: kio
Description
---
For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong
name(something like filename-1 2.6.tar.gz).
Expected name: filename-1.6 (1).tar.gz
Diffs
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123570: Add a method to insert new known structures
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Description --- When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much broken, since they can't find the structure instance. in order to load packages one can subclass packageloader, but listing still doesn't work. this makes possible for apps to insert new structure types without having to subclass. an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in libplasma, because then any user of libplasma could replace the packageloader again, breaking it. Diffs - src/kpackage/packageloader.h 4cc40e6 src/kpackage/packageloader.cpp 174f54b Diff: https://git.reviewboard.kde.org/r/123570/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] New: Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 Bug ID: 346972 Summary: Star rating icons in amarok always black with breeze theme Product: Breeze Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: evors...@gmail.com The star ratings in Amarok is always black in the breeze theme, but works fine in the Oxygen theme. Reproducible: Always Steps to Reproduce: 1.Apply Breeze theme. 2.Open Amarok 3.Try to rate a song Actual Results: Stars stay black Expected Results: Expect yellow stars showing when clicking on them Just noticed this when upgrading to Plasma desktop on Arch, and installed breeze theme with it. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123575: Improve debug information for some plasmoids
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: plasma-framework Description --- I've been trying to figure out why there's so many qml scripts which errors always specify Unknown Files. This patch is not ideal, but improves the situation slightly. Diffs - src/plasmaquick/appletquickitem.cpp 0748a8d Diff: https://git.reviewboard.kde.org/r/123575/diff/ Testing --- * Tests still pass. * some warnings have a filename when running plasmawindowed org.kde.plasma.systemtray. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123575: Improve debug information for some plasmoids
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/#review79740 --- Ship it! Ship It! - Marco Martin On April 30, 2015, 5:35 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/ --- (Updated April 30, 2015, 5:35 p.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: plasma-framework Description --- I've been trying to figure out why there's so many qml scripts which errors always specify Unknown Files. This patch is not ideal, but improves the situation slightly. Diffs - src/plasmaquick/appletquickitem.cpp 0748a8d Diff: https://git.reviewboard.kde.org/r/123575/diff/ Testing --- * Tests still pass. * some warnings have a filename when running plasmawindowed org.kde.plasma.systemtray. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||jamboar...@gmail.com --- Comment #2 from Andrew Lake jamboar...@gmail.com --- Fixed in 5.3 (commit 89d85cc3a) *** This bug has been marked as a duplicate of bug 339863 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 --- Comment #1 from Evert Vorster evors...@gmail.com --- This bug was reported against Amarok with number 346711, but it was claimed that this is not an Amarok bug, as it works fine in Oxygen theme -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #4 from David Edmundson k...@davidedmundson.co.uk --- kdelibs is still getting releases, Christoph is it worth backporting your change? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Resolution|DUPLICATE |FIXED --- Comment #6 from Andrew Lake jamboar...@gmail.com --- Sorry, I maybe should not have marked this as duplicate. Let me explain. The problem for the Breeze icon theme is that the rating icon was monochrome black (Icon Grey technically). This was reported earlier against Breeze in bug 339863. During that bug review it was decided to re-assign it to KRatingPainter and Christopher Feck attempted to update KRatingPainter to improve how it handles monochrome low-saturation icons. Unfortunately, despite Christopher's effort, it somehow didn't work out. So the Breeze icon theme was updated to use a yellow icon, which is similar to oxygen and so should work similar to Oxygen. So while the problem is technically RESOLVED-FIXED for Breeze, KRatingPainter might still have a little trouble with monochrome low-saturation icons until we figure out why Christopher's patch didn't seem to work. I'll change this to fixed for Breeze here. Hrvoje Senjan has already re-opened the KRatingPainter bug 339863. If that bug gets resolved then we can update the icon theme to take advantage of the fix to provide an even more distinct full vs empty rating star icon. Hope this helps. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 --- Comment #3 from Christoph Feck cf...@kde.org --- Amarok is a KDE4 application, so it's not fixed. *** This bug has been marked as a duplicate of bug 346625 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme
https://bugs.kde.org/show_bug.cgi?id=346972 --- Comment #5 from Christoph Feck cf...@kde.org --- The change apparently does not work :/ -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
5.4 Kickoff Meeting Minutes
Plasma 5.4 Kickstart Meeting = schedule agreement https://techbase.kde.org/Schedules/Plasma_5 - https://www.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.comctz=Europe/Madrid - agreed = what will happen with baloo/kfilemetadata/baloo-widgets - move baloo/kfilemetadata in july - release baloo-widgets with applications (standalone or as part of dolphin) - added to TODO = consider moving kio-extras to applications in july too - added to TODO = Review TODO items https://todo.kde.org/?controller=boardaction=shttps://www.google.com/search?client=ubuntuchannel=fsq=fsie=utf-8oe=utf-8howproject_id=44 - cards were moved = consider if systemd-kcm should be included - needs UI review and use cases - Jonathan proposed to include it but as standalone tar - sebas to reply on mailing list - discussion to continue on mailing list = Dividing up the most major bugs in 5.3.0 between us for priority fixing - bugs were allocated - except ksyscoca as root + sudo putting root files in $HOME/.cache, discussion continued on IRC = different wallpapers on different virtual desktops. We should discuss it a bit - push bblas - d_ed to send jens bug report - get VDG onto nice designs for activities - ivan to be voluntold = System Tray - speaking of recurring piece of feedback: xembed systray - qt 4 apps can use the sni patch but only if distros pick it up and sni-qt is installed which isn't always the case with e.g. skype - gtk old API apps need ported to new API - we don't want to implement xembed (which gnome has). conclusion: sit it out - kubuntu to add to kubuntu-notifier to install sni-qt:i386 with skype - jr to report to firefox/thunderbird extensions - jr to report to wine [ Lync and office with sharepoint only work in windows or wine] - jr to report to dropbox - others problems include keepassx systray-on-start apps, wine = New CI intro - sgclark - running now at https://build.kde.org/ = Formats / locale configuration: people are missing KLocale - QLocale better in some ways, worse in other. jlayt off radar - Eike to work on it, ltinkl volunteers too = Wayland mgraesslin so 5.4 is planned to be the first release with proper Wayland support mgraesslin that's two areas mgraesslin * managing Wayland client mgraesslin * drm backend mgraesslin drm backend is already merged into master mgraesslin but it still needs love (mostly multi-screen) mgraesslin Wayland client support is currently a branch with 80 commits which depending on how much time I find for it could go into master in about two weekd sebas the libkscreen stuff is pretty far along, needs a bit more polishing, then we can integrate it with kwin sebas and going through review, obviously mgraesslin Plasma itself will probably need to stick on X in the next release mgraesslin many things will break on Wayland mgraesslin which needs protocols mgraesslin e.g. taskmanager, clipboard, page, absolute positioning etc = KActivities - There's a lot of development that should be put in common - not covered, ivan had to leave alas = VDG plans and focus - keep fleshing out missing icons - Add high contrast cursor theme + other variations - use mouse cursor theme kcm as opportunity to define standard kcm UI patterns - taskbar tooltip layout design improvement (within no-resizing constraints) - reduce +VisualDesign bugs backlog - wallpaper for 5.4 - high contrast color scheme - coordinate with devs and complete a design target for integrated activities and virtual desktop - consider if gtk 2 theme should be merged https://forum.kde.org/viewtopic.php?f=285t=125246start=15 - numix doing gtk 3 theme (get them talking to gtk 2 dude above) = System Settings - Design target: https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application - Updated overview page - New Search mode - Start with consistent Module layout - Developer needed = Breeze theme as backup instead of Oxygen - admin (red) color scheme - 16:04 htietze I read andreas_k in this way: Default theme should be Breeze instead of Oxygen. And the fallback solution if something fails is Breeze. - 16:05 notmart that's i guess is in frameworkintegration and there is breeze already? - to investigate = Desktop Configuration Vision - Design target: https://community.kde.org/KDE_Visual_Design_Group/Plasma_5_Desktop_Configuration - to send to mailing list = Solid::Power - new library to solve Plasma dependency on kdelibs4support - fully async, atm 2 backends (systemd+upower / HAL) - currently hosted at https://github.com/caybro/solid-power, planning to move it to kde.git real soon - 1st phase: port PowerDevil to it, cut the nasty circular runtime dependency, adjusting the API as we need it - 2nd phase: plasma-workspace + plasma-desktop porting (shell, dataengines, etc.) - 3rd phase: make Solid::Power a framework (hopefully before 5.4 freeze so that we can depend on a released version thereof)
