Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

2015-11-12 Thread Elias Probst 


> On Nov. 11, 2015, 11:46 p.m., David Edmundson wrote:
> > pretty sure this breaks slackware
> > 
> > might have to make it an option
> 
> Martin Gräßlin wrote:
> yes it breaks slackware and probably also BSDs. So -2 on this approach.

Thanks for the comments - I see, it breaks in non-PAM setups (which we also 
want to support in Gentoo).
I'll try to come up with something better - closing RR for now.


- Elias


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/#review88275
---


On Nov. 11, 2015, 11:37 p.m., Elias Probst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126037/
> ---
> 
> (Updated Nov. 11, 2015, 11:37 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Martin Gräßlin.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> ---
> 
> Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.
> 
> kcheckpass works just fine without setuid nowadays and quite a few
> distributions already dropped setuid of if since quite some time.
> 
> Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants 
> for consistency.
> 
> 
> Diffs
> -
> 
>   config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
>   greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
>   kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 
> 
> Diff: https://git.reviewboard.kde.org/r/126037/diff/
> 
> 
> Testing
> ---
> 
> `kcheckpass` and `kscreenlocker_greet` end up in the expected target 
> directory (`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected.
> I'm not sure yet about `kscreenlocker_greet` as I ended up with an 
> un-unlockable session but also saw this issue before.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

2015-11-12 Thread Elias Probst 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/
---

(Updated Nov. 12, 2015, 8:23 a.m.)


Status
--

This change has been discarded.


Review request for Plasma, Bhushan Shah and Martin Gräßlin.


Repository: kscreenlocker


Description
---

Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.

kcheckpass works just fine without setuid nowadays and quite a few
distributions already dropped setuid of if since quite some time.

Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants 
for consistency.


Diffs
-

  config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
  greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
  kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 

Diff: https://git.reviewboard.kde.org/r/126037/diff/


Testing
---

`kcheckpass` and `kscreenlocker_greet` end up in the expected target directory 
(`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected.
I'm not sure yet about `kscreenlocker_greet` as I ended up with an 
un-unlockable session but also saw this issue before.


Thanks,

Elias Probst

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread Eike Hein 


> On Nov. 12, 2015, 9:57 a.m., David Edmundson wrote:
> >

Thanks!


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88282
---


On Nov. 11, 2015, 9 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 9 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>   applets/kickoff/core/qmldir d454d1b 
>   applets/kickoff/core/recentapplications.h b73d526 
>   applets/kickoff/core/recentapplications.cpp 2dd6781 
>   applets/kickoff/core/recentlyusedmodel.h 2530fb4 
>   applets/kickoff/core/recentlyusedmodel.cpp afeed23 
>   applets/kickoff/core/systemmodel.h 5da49ad 
>   applets/kickoff/core/systemmodel.cpp 461a2ed 
>   applets/kickoff/core/urlitemlauncher.h 05c414d 
>   applets/kickoff/core/urlitemlauncher.cpp c350680 
>   applets/kickoff/package/contents/code/tools.js PRE-CREATION 
>   applets/kickoff/package/contents/config/config.qml fe059b8 
>

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88282
---

Ship it!


- David Edmundson


On Nov. 11, 2015, 9 p.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 11, 2015, 9 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>   applets/kickoff/core/qmldir d454d1b 
>   applets/kickoff/core/recentapplications.h b73d526 
>   applets/kickoff/core/recentapplications.cpp 2dd6781 
>   applets/kickoff/core/recentlyusedmodel.h 2530fb4 
>   applets/kickoff/core/recentlyusedmodel.cpp afeed23 
>   applets/kickoff/core/systemmodel.h 5da49ad 
>   applets/kickoff/core/systemmodel.cpp 461a2ed 
>   applets/kickoff/core/urlitemlauncher.h 05c414d 
>   applets/kickoff/core/urlitemlauncher.cpp c350680 
>   applets/kickoff/package/contents/code/tools.js PRE-CREATION 
>   applets/kickoff/package/contents/config/config.qml fe059b8 
>   applets/kickoff/package/contents/config/main.xml 00dfdf9 
>

Re: Review Request 125973: Remove completely duplicated function

2015-11-12 Thread David Edmundson 


> On Nov. 10, 2015, 2:53 a.m., Martin Klapetek wrote:
> > By the duplicated function you mean PlasmoidTask::showMenu(int x, int y)? 
> > That one has only two args and is missing the "run associated application" 
> > action, which I'm not entirely sure what's it used for. The rest indeed 
> > looks about the same (though the showMenu could really use some commentary)

yes.

the extra arg isn't needed as it refers to "this" in PlasmoidTask.

run assoc action I maybe need, I'll double check. Thanks


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125973/#review88210
---


On Nov. 9, 2015, 10:42 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125973/
> ---
> 
> (Updated Nov. 9, 2015, 10:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Remove almost completely duplicated function.
> One was used for right clicking on expanded items, the other for full compact 
> items.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 
> a53be6cb0d9fae14e055a6d1381ad11fee0a236e 
>   applets/systemtray/plugin/host.h db6fc567666281c8b2fe81eab085ae4b950bf07d 
>   applets/systemtray/plugin/host.cpp 61e87050826a28409e44c8dac5baebe12e59bf63 
> 
> Diff: https://git.reviewboard.kde.org/r/125973/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread Eike Hein 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/
---

(Updated Nov. 12, 2015, 10:13 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Ivan Čukić.


Repository: plasma-desktop


Description
---

This is a roll-up of the various Kicker backend and ultimately Kickoff changes 
needed to obsolete Kickoff's old backend in favor of Kicker's. It raises 
Kickoff to Kicker's feature level (much more fleshed-out context menus with 
many additional features, pervasive favoriting, etc.) along with addressing 
numerous Kickoff bugs (e.g. sorting on the Computer page) and removing some 
cruft.

Migration from kickoffrc is done using a script and supports both favorites and 
ISV-customized system apps for the Computer page.

I suggest using the hein/kickeroff branch for review instead, as things are 
nicely split out into separate commits there.


Diffs
-

  applets/kicker/CMakeLists.txt bdb6419 
  applets/kicker/plugin/abstractentry.h e09b3cf 
  applets/kicker/plugin/abstractentry.cpp 846a548 
  applets/kicker/plugin/abstractmodel.h 142de27 
  applets/kicker/plugin/abstractmodel.cpp 18eed03 
  applets/kicker/plugin/actionlist.h 4aaa1d5 
  applets/kicker/plugin/appentry.h 3d0b1bd 
  applets/kicker/plugin/appentry.cpp 34bab3d 
  applets/kicker/plugin/appsmodel.h 3cd0577 
  applets/kicker/plugin/appsmodel.cpp 821ae88 
  applets/kicker/plugin/computermodel.h PRE-CREATION 
  applets/kicker/plugin/computermodel.cpp PRE-CREATION 
  applets/kicker/plugin/favoritesmodel.cpp 4931a16 
  applets/kicker/plugin/fileentry.h cd4e54a 
  applets/kicker/plugin/fileentry.cpp 693816d 
  applets/kicker/plugin/kickerplugin.cpp d31043a 
  applets/kicker/plugin/recentappsmodel.h 6ee55c1 
  applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
  applets/kicker/plugin/recentdocsmodel.h df12d1b 
  applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
  applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
  applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
  applets/kicker/plugin/rootmodel.h 5acdb8e 
  applets/kicker/plugin/rootmodel.cpp fde16fd 
  applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
  applets/kicker/plugin/runnermodel.h d827e6d 
  applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
  applets/kicker/plugin/systementry.h df0712b 
  applets/kicker/plugin/systementry.cpp ec527da 
  applets/kicker/plugin/systemmodel.h 1b3eab7 
  applets/kicker/plugin/systemmodel.cpp ef02892 
  applets/kickoff/CMakeLists.txt 339316d 
  applets/kickoff/STATUS-TODO f837793 
  applets/kickoff/core/applicationmodel.h cc28656 
  applets/kickoff/core/applicationmodel.cpp a292130 
  applets/kickoff/core/favoritesmodel.h 7a5f225 
  applets/kickoff/core/favoritesmodel.cpp be47347 
  applets/kickoff/core/itemhandlers.h 8f05490 
  applets/kickoff/core/itemhandlers.cpp d0cd423 
  applets/kickoff/core/kickoffabstractmodel.h be5ce21 
  applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
  applets/kickoff/core/kickoffmodel.h dd91f9b 
  applets/kickoff/core/kickoffmodel.cpp fd5bb62 
  applets/kickoff/core/kickoffplugin.h de839b3 
  applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
  applets/kickoff/core/kickoffproxymodel.h f1af640 
  applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp f8c031b 
  applets/kickoff/core/leavemodel.h f95a271 
  applets/kickoff/core/leavemodel.cpp 154eb1c 
  applets/kickoff/core/models.h 30e80be 
  applets/kickoff/core/models.cpp a63d363 
  applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
  applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
  applets/kickoff/core/processrunner.h 5d836eb 
  applets/kickoff/core/processrunner.cpp 6572386 
  applets/kickoff/core/qmldir d454d1b 
  applets/kickoff/core/recentapplications.h b73d526 
  applets/kickoff/core/recentapplications.cpp 2dd6781 
  applets/kickoff/core/recentlyusedmodel.h 2530fb4 
  applets/kickoff/core/recentlyusedmodel.cpp afeed23 
  applets/kickoff/core/systemmodel.h 5da49ad 
  applets/kickoff/core/systemmodel.cpp 461a2ed 
  applets/kickoff/core/urlitemlauncher.h 05c414d 
  applets/kickoff/core/urlitemlauncher.cpp c350680 
  applets/kickoff/package/contents/code/tools.js PRE-CREATION 
  applets/kickoff/package/contents/config/config.qml fe059b8 
  applets/kickoff/package/contents/config/main.xml 00dfdf9 
  applets/kickoff/package/contents/ui/ActionMenu.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ApplicationsView.qml ad5272a 
  applets/kickoff/package/contents/ui/BaseView.qml e628614 
  applets/kickoff/package/contents/ui/Breadcrumb.qml 016cf25 
  applets/kickoff/package/contents/ui/ComputerView.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/kickoff/package/contents/ui/ContextMenu.qml e8f681e

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88307
---


Nice!

It doesn't seem to show recently launched apps, though, and the number of 
recent documents is too large imo.

- Kai Uwe Broulik


On Nov. 12, 2015, 10:13 vorm., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 12, 2015, 10:13 vorm.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>   applets/kickoff/core/qmldir d454d1b 
>   applets/kickoff/core/recentapplications.h b73d526 
>   applets/kickoff/core/recentapplications.cpp 2dd6781 
>   applets/kickoff/core/recentlyusedmodel.h 2530fb4 
>   applets/kickoff/core/recentlyusedmodel.cpp afeed23 
>   applets/kickoff/core/systemmodel.h 5da49ad 
>   applets/kickoff/core/systemmodel.cpp 461a2ed 
>   applets/kickoff/core/urlitemlauncher.h 05c414d 
>   applets/kickoff/core/urlitemlauncher.cpp c350680 
>   applets/kickoff/package/contents/code/tools.js PRE-CREATION 
>

Re: Review Request 126037: Drop setuid of `kcheckpass`/Use LIBEXEC_INSTALL_DIR wherever appropriate

2015-11-12 Thread Andreas Sturmlechner 


> On Nov. 11, 2015, 11:46 p.m., David Edmundson wrote:
> > pretty sure this breaks slackware
> > 
> > might have to make it an option
> 
> Martin Gräßlin wrote:
> yes it breaks slackware and probably also BSDs. So -2 on this approach.
> 
> Elias Probst wrote:
> Thanks for the comments - I see, it breaks in non-PAM setups (which we 
> also want to support in Gentoo).
> I'll try to come up with something better - closing RR for now.

Required for those systems it might be, but shouldn't it only be executed if 
!HAVE_PAM? And does that code actually work? At least here, the path is wrong:

chown: cannot access 
‘/var/tmp/portage/kde-plasma/kscreenlocker-/image/lib64/libexec/kcheckpass’:
 No such file or directory


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126037/#review88275
---


On Nov. 12, 2015, 8:23 a.m., Elias Probst wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126037/
> ---
> 
> (Updated Nov. 12, 2015, 8:23 a.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Martin Gräßlin.
> 
> 
> Repository: kscreenlocker
> 
> 
> Description
> ---
> 
> Drop obsolete 'setuid' of kcheckpass and fragile code using $ENV{DESTDIR}.
> 
> kcheckpass works just fine without setuid nowadays and quite a few
> distributions already dropped setuid of if since quite some time.
> 
> Also use `LIBEXEC_INSTALL_DIR` instead of one of the dozens of other variants 
> for consistency.
> 
> 
> Diffs
> -
> 
>   config-kscreenlocker.h.cmake 2a034dee8ec21e426bc1db1d56b0ed152d3de2ca 
>   greeter/CMakeLists.txt 317bfa3cdadf05a9a8597ed40a3dc3c0af4d144d 
>   kcheckpass/CMakeLists.txt a63fa1403e897e70989dc2e1ba7eed4bc69cbb51 
> 
> Diff: https://git.reviewboard.kde.org/r/126037/diff/
> 
> 
> Testing
> ---
> 
> `kcheckpass` and `kscreenlocker_greet` end up in the expected target 
> directory (`/usr/lib64/libexec` on Gentoo). `kcheckpass` works as expected.
> I'm not sure yet about `kscreenlocker_greet` as I ended up with an 
> un-unlockable session but also saw this issue before.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

2015-11-12 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126036/#review88288
---


what are we supposed to do, putting other files in discarded until only 3-4 are 
left?

anyways to me the ones i prefer, in descending order are
* Autumn: just gorgeous
* Fallen leaf
* Colorful cups
* Uri's discards/Grey
* Uri's discards/summer
* Darkest hour
* By the Water
* One stand out
* Discarded according to alex/mirror facade

- Marco Martin


On Nov. 11, 2015, 10:56 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126036/
> ---
> 
> (Updated Nov. 11, 2015, 10:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace-wallpapers
> 
> 
> Description
> ---
> 
> As you know I start an wallpaper contest for plasma 5.5. The VDG make an 
> preselection and I hope the Plasma team will give feedback which wallpaper 
> should be included in the plasma 5.5 extra wallpaper package
> 
> 
> Diffs
> -
> 
>   Alps/contents/images/1280x1024.jpg c295fdc 
>   Alps/contents/images/1280x800.jpg b6edfe7 
>   Alps/contents/images/1440x900.jpg c94bcaa 
>   Alps/contents/images/1600x1200.jpg e09e592 
>   Alps/contents/images/1638x1024.jpg 0c06524 
>   Alps/contents/images/1680x1050.jpg 6c96d86 
>   Alps/contents/images/1920x1080.jpg 4b974d4 
>   Alps/contents/images/1920x1200.jpg 677a6aa 
>   Alps/contents/images/2560x1600.jpg 9bac171 
>   Alps/contents/images/2560x2440.jpg 2075d9b 
>   Alps/contents/images/640x480.jpg 7f6a74e 
>   Alps/contents/images/800x600.jpg 09a604d 
>   Alps/contents/screenshot.jpg 54c27e9 
>   Alps/metadata.desktop 002dba2 
>   BlueFlower/contents/images/1280x1024.jpg 195 
>   BlueFlower/contents/images/1280x800.jpg 5d9b62c 
>   BlueFlower/contents/images/1440x900.jpg e2677a4 
>   BlueFlower/contents/images/1600x1200.jpg da10f13 
>   BlueFlower/contents/images/1638x1024.jpg 76c6fc5 
>   BlueFlower/contents/images/1680x1050.jpg 79a298a 
>   BlueFlower/contents/images/1920x1080.jpg 20e763b 
>   BlueFlower/contents/images/1920x1200.jpg 39c4a4e 
>   BlueFlower/contents/images/2560x1440.jpg 2a32989 
>   BlueFlower/contents/images/2560x1600.jpg de59380 
>   BlueFlower/contents/images/640x480.jpg 1d35499 
>   BlueFlower/contents/images/800x600.jpg f9e9e29 
>   BlueFlower/contents/screenshot.jpg 7cdf224 
>   BlueFlower/metadata.desktop ed2a89a 
>   Dance_of_the_Spirits/contents/images/1280x1024.jpg 458a9d3 
>   Dance_of_the_Spirits/contents/images/1280x800.jpg 099dba5 
>   Dance_of_the_Spirits/contents/images/1440x900.jpg 710aad5 
>   Dance_of_the_Spirits/contents/images/1600x1200.jpg 369e081 
>   Dance_of_the_Spirits/contents/images/1920x1080.jpg d47bc94 
>   Dance_of_the_Spirits/contents/images/1920x1200.jpg 9fa01ac 
>   Dance_of_the_Spirits/contents/images/2560x1440.jpg 060148e 
>   Dance_of_the_Spirits/contents/images/2560x1600.jpg 28515f1 
>   Dance_of_the_Spirits/contents/screenshot.png 9b9c0c5 
>   Dance_of_the_Spirits/metadata.desktop 0b2f6c9 
>   GereatHeron/contents/images/1280x1024.jpg 8fa95fb 
>   GereatHeron/contents/images/1280x800.jpg 5f7e924 
>   GereatHeron/contents/images/1440x900.jpg 0336115 
>   GereatHeron/contents/images/1600x1200.jpg 6659dd6 
>   GereatHeron/contents/images/1680x1050.jpg 0243a4d 
>   GereatHeron/contents/images/1920x1080.jpg e3c04c0 
>   GereatHeron/contents/images/1920x1200.jpg 34ced65 
>   GereatHeron/contents/images/2560x1440.jpg ed5a835 
>   GereatHeron/contents/images/2560x1600.jpg ccba2c0 
>   GereatHeron/contents/images/640x480.jpg 8e30b41 
>   GereatHeron/contents/images/800x600.jpg fb956a3 
>   GereatHeron/contents/screenshot.jpg 25a514d 
>   GereatHeron/metadata.desktop 4274fbd 
>   Landmannalaugar/contents/images/1280x1024.jpg 83ac796 
>   Landmannalaugar/contents/images/1280x800.jpg 45f8cb1 
>   Landmannalaugar/contents/images/1440x900.jpg 1c28a72 
>   Landmannalaugar/contents/images/1600x1200.jpg e84d18d 
>   Landmannalaugar/contents/images/1638x1024.jpg dc9e4a3 
>   Landmannalaugar/contents/images/1680x1050.jpg 89ed042 
>   Landmannalaugar/contents/images/1920x1080.jpg be2a31e 
>   Landmannalaugar/contents/images/1920x1200.jpg 409dbcf 
>   Landmannalaugar/contents/images/2560x1440.jpg 70237d9 
>   Landmannalaugar/contents/images/2560x1600.jpg d966604 
>   Landmannalaugar/contents/images/640x480.jpg 1302268 
>   Landmannalaugar/contents/images/800x600.jpg 14de9cb 
>   Landmannalaugar/contents/screenshot.jpg 46be560 
>   Landmannalaugar/metadata.desktop ded464b 
>   Tauplitz/contents/images/1280x1024.jpg 3116e33 
>   Tauplitz/contents/images/1280x800.jpg 7ac2b77 
>   Tauplitz/contents/images/1440x900.jpg b13f4a2 
>   Tauplitz/contents/images/1600x1200.jpg 840cba1 
>

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

2015-11-12 Thread Marco Martin 


> On Nov. 12, 2015, 12:01 p.m., Marco Martin wrote:
> > what are we supposed to do, putting other files in discarded until only 3-4 
> > are left?
> > 
> > anyways to me the ones i prefer, in descending order are
> > * Autumn: just gorgeous
> > * Fallen leaf
> > * Colorful cups
> > * Uri's discards/Grey
> > * Uri's discards/summer
> > * Darkest hour
> > * By the Water
> > * One stand out
> > * Discarded according to alex/mirror facade

thanks reviewboard for formatting terribly
anyways to me the ones i prefer, in descending order are
* Autumn: just gorgeous

* Fallen leaf

* Colorful cups

* Uri's discards/Grey

* Uri's discards/summer

* Darkest hour

* By the Water

* One stand out

* Discarded according to alex/mirror facade


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126036/#review88288
---


On Nov. 11, 2015, 10:56 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126036/
> ---
> 
> (Updated Nov. 11, 2015, 10:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace-wallpapers
> 
> 
> Description
> ---
> 
> As you know I start an wallpaper contest for plasma 5.5. The VDG make an 
> preselection and I hope the Plasma team will give feedback which wallpaper 
> should be included in the plasma 5.5 extra wallpaper package
> 
> 
> Diffs
> -
> 
>   Alps/contents/images/1280x1024.jpg c295fdc 
>   Alps/contents/images/1280x800.jpg b6edfe7 
>   Alps/contents/images/1440x900.jpg c94bcaa 
>   Alps/contents/images/1600x1200.jpg e09e592 
>   Alps/contents/images/1638x1024.jpg 0c06524 
>   Alps/contents/images/1680x1050.jpg 6c96d86 
>   Alps/contents/images/1920x1080.jpg 4b974d4 
>   Alps/contents/images/1920x1200.jpg 677a6aa 
>   Alps/contents/images/2560x1600.jpg 9bac171 
>   Alps/contents/images/2560x2440.jpg 2075d9b 
>   Alps/contents/images/640x480.jpg 7f6a74e 
>   Alps/contents/images/800x600.jpg 09a604d 
>   Alps/contents/screenshot.jpg 54c27e9 
>   Alps/metadata.desktop 002dba2 
>   BlueFlower/contents/images/1280x1024.jpg 195 
>   BlueFlower/contents/images/1280x800.jpg 5d9b62c 
>   BlueFlower/contents/images/1440x900.jpg e2677a4 
>   BlueFlower/contents/images/1600x1200.jpg da10f13 
>   BlueFlower/contents/images/1638x1024.jpg 76c6fc5 
>   BlueFlower/contents/images/1680x1050.jpg 79a298a 
>   BlueFlower/contents/images/1920x1080.jpg 20e763b 
>   BlueFlower/contents/images/1920x1200.jpg 39c4a4e 
>   BlueFlower/contents/images/2560x1440.jpg 2a32989 
>   BlueFlower/contents/images/2560x1600.jpg de59380 
>   BlueFlower/contents/images/640x480.jpg 1d35499 
>   BlueFlower/contents/images/800x600.jpg f9e9e29 
>   BlueFlower/contents/screenshot.jpg 7cdf224 
>   BlueFlower/metadata.desktop ed2a89a 
>   Dance_of_the_Spirits/contents/images/1280x1024.jpg 458a9d3 
>   Dance_of_the_Spirits/contents/images/1280x800.jpg 099dba5 
>   Dance_of_the_Spirits/contents/images/1440x900.jpg 710aad5 
>   Dance_of_the_Spirits/contents/images/1600x1200.jpg 369e081 
>   Dance_of_the_Spirits/contents/images/1920x1080.jpg d47bc94 
>   Dance_of_the_Spirits/contents/images/1920x1200.jpg 9fa01ac 
>   Dance_of_the_Spirits/contents/images/2560x1440.jpg 060148e 
>   Dance_of_the_Spirits/contents/images/2560x1600.jpg 28515f1 
>   Dance_of_the_Spirits/contents/screenshot.png 9b9c0c5 
>   Dance_of_the_Spirits/metadata.desktop 0b2f6c9 
>   GereatHeron/contents/images/1280x1024.jpg 8fa95fb 
>   GereatHeron/contents/images/1280x800.jpg 5f7e924 
>   GereatHeron/contents/images/1440x900.jpg 0336115 
>   GereatHeron/contents/images/1600x1200.jpg 6659dd6 
>   GereatHeron/contents/images/1680x1050.jpg 0243a4d 
>   GereatHeron/contents/images/1920x1080.jpg e3c04c0 
>   GereatHeron/contents/images/1920x1200.jpg 34ced65 
>   GereatHeron/contents/images/2560x1440.jpg ed5a835 
>   GereatHeron/contents/images/2560x1600.jpg ccba2c0 
>   GereatHeron/contents/images/640x480.jpg 8e30b41 
>   GereatHeron/contents/images/800x600.jpg fb956a3 
>   GereatHeron/contents/screenshot.jpg 25a514d 
>   GereatHeron/metadata.desktop 4274fbd 
>   Landmannalaugar/contents/images/1280x1024.jpg 83ac796 
>   Landmannalaugar/contents/images/1280x800.jpg 45f8cb1 
>   Landmannalaugar/contents/images/1440x900.jpg 1c28a72 
>   Landmannalaugar/contents/images/1600x1200.jpg e84d18d 
>   Landmannalaugar/contents/images/1638x1024.jpg dc9e4a3 
>   Landmannalaugar/contents/images/1680x1050.jpg 89ed042 
>   Landmannalaugar/contents/images/1920x1080.jpg be2a31e 
>   Landmannalaugar/contents/images/1920x1200.jpg 409dbcf 
>   Landmannalaugar/contents/images/2560x1440.jpg 70237d9 
>   Landmannalaugar/contents/images/2560x1600.jpg d966604 
>   Landmannalaugar/contents/images/640x480.jpg

Re: Review Request 124585: Add pretty user switcher

2015-11-12 Thread andreas kainz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124585/#review88285
---


Hi Kai Uwe, I start an forum thread about the design. this isn't a showstopper 
for that request. I only want to let you know and hope you can join the 
discussion https://forum.kde.org/viewtopic.php?f=285=129283

- andreas kainz


On Nov. 8, 2015, 6:14 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124585/
> ---
> 
> (Updated Nov. 8, 2015, 6:14 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a user switcher dialog borrowing elements from the lock screen and 
> log out dialog. I never understood why KRunner was used for that.
> 
> It is not yet hooked up to the system (would make KRunner's "switchUser" 
> interface forward that to KSMServer so everybody using it (eg. kickoff) would 
> continue to work without adjustments). To test it run qdbus org.kde.ksmserver 
> /KSMServer openSwitchUserDialog
> 
> When it opens it defaults to "New Session", from an interaction POV the list 
> view behaves like the one on the lock screen.
> 
> It locks the screen when switching users only when the user has enabled the 
> lock screen (might need a separate option for that?) That unconditional 
> locking on session switching has turned out to be a major annoyance.
> 
> 
> Diffs
> -
> 
>   ksmserver/CMakeLists.txt b4eb9b8 
>   ksmserver/org.kde.KSMServerInterface.xml 3680ed7 
>   ksmserver/server.h 87e46cb 
>   ksmserver/server.cpp ffb15d2 
>   ksmserver/switchuserdialog.h PRE-CREATION 
>   ksmserver/switchuserdialog.cpp PRE-CREATION 
>   lookandfeel/contents/components/UserList.qml 778d8ea 
>   lookandfeel/contents/components/UserSelect.qml 5af566d 
>   lookandfeel/contents/userswitcher/UserSwitcher.qml e69de29 
> 
> Diff: https://git.reviewboard.kde.org/r/124585/diff/
> 
> 
> Testing
> ---
> 
> Looks pretty, switching to a new or existing session works.
> 
> Btw, weren't we able to click outside the dialog to dismiss it in 4.x? Seems 
> broken for the logout dialog as well.
> 
> 
> File Attachments
> 
> 
> No active sessions
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/6acd1764-db79-401b-936b-7a6fb5809c5a__userswitchera1.jpg
> Switch sessions
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/b21de001-c011-4733-a47f-e2966ac2b955__userswitchera2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126036: Update wallpaper package with plasma 5.5 wallpaper contest

2015-11-12 Thread andreas kainz 


> On Nov. 12, 2015, 12:01 nachm., Marco Martin wrote:
> > what are we supposed to do, putting other files in discarded until only 3-4 
> > are left?
> > 
> > anyways to me the ones i prefer, in descending order are
> > * Autumn: just gorgeous
> > * Fallen leaf
> > * Colorful cups
> > * Uri's discards/Grey
> > * Uri's discards/summer
> > * Darkest hour
> > * By the Water
> > * One stand out
> > * Discarded according to alex/mirror facade
> 
> Marco Martin wrote:
> thanks reviewboard for formatting terribly
> anyways to me the ones i prefer, in descending order are
> * Autumn: just gorgeous
> 
> * Fallen leaf
> 
> * Colorful cups
> 
> * Uri's discards/Grey
> 
> * Uri's discards/summer
> 
> * Darkest hour
> 
> * By the Water
> 
> * One stand out
> 
> * Discarded according to alex/mirror facade

thanks for your replay Marco. we start with 43 wallpapers to much for a poll 
and so we say everybody should move the discarded ones to a subfolder. We are 
now at 16 wallpapers my maximum was 15 so thanks for the feedback Marco.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126036/#review88288
---


On Nov. 11, 2015, 10:56 nachm., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126036/
> ---
> 
> (Updated Nov. 11, 2015, 10:56 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace-wallpapers
> 
> 
> Description
> ---
> 
> As you know I start an wallpaper contest for plasma 5.5. The VDG make an 
> preselection and I hope the Plasma team will give feedback which wallpaper 
> should be included in the plasma 5.5 extra wallpaper package
> 
> 
> Diffs
> -
> 
>   Alps/contents/images/1280x1024.jpg c295fdc 
>   Alps/contents/images/1280x800.jpg b6edfe7 
>   Alps/contents/images/1440x900.jpg c94bcaa 
>   Alps/contents/images/1600x1200.jpg e09e592 
>   Alps/contents/images/1638x1024.jpg 0c06524 
>   Alps/contents/images/1680x1050.jpg 6c96d86 
>   Alps/contents/images/1920x1080.jpg 4b974d4 
>   Alps/contents/images/1920x1200.jpg 677a6aa 
>   Alps/contents/images/2560x1600.jpg 9bac171 
>   Alps/contents/images/2560x2440.jpg 2075d9b 
>   Alps/contents/images/640x480.jpg 7f6a74e 
>   Alps/contents/images/800x600.jpg 09a604d 
>   Alps/contents/screenshot.jpg 54c27e9 
>   Alps/metadata.desktop 002dba2 
>   BlueFlower/contents/images/1280x1024.jpg 195 
>   BlueFlower/contents/images/1280x800.jpg 5d9b62c 
>   BlueFlower/contents/images/1440x900.jpg e2677a4 
>   BlueFlower/contents/images/1600x1200.jpg da10f13 
>   BlueFlower/contents/images/1638x1024.jpg 76c6fc5 
>   BlueFlower/contents/images/1680x1050.jpg 79a298a 
>   BlueFlower/contents/images/1920x1080.jpg 20e763b 
>   BlueFlower/contents/images/1920x1200.jpg 39c4a4e 
>   BlueFlower/contents/images/2560x1440.jpg 2a32989 
>   BlueFlower/contents/images/2560x1600.jpg de59380 
>   BlueFlower/contents/images/640x480.jpg 1d35499 
>   BlueFlower/contents/images/800x600.jpg f9e9e29 
>   BlueFlower/contents/screenshot.jpg 7cdf224 
>   BlueFlower/metadata.desktop ed2a89a 
>   Dance_of_the_Spirits/contents/images/1280x1024.jpg 458a9d3 
>   Dance_of_the_Spirits/contents/images/1280x800.jpg 099dba5 
>   Dance_of_the_Spirits/contents/images/1440x900.jpg 710aad5 
>   Dance_of_the_Spirits/contents/images/1600x1200.jpg 369e081 
>   Dance_of_the_Spirits/contents/images/1920x1080.jpg d47bc94 
>   Dance_of_the_Spirits/contents/images/1920x1200.jpg 9fa01ac 
>   Dance_of_the_Spirits/contents/images/2560x1440.jpg 060148e 
>   Dance_of_the_Spirits/contents/images/2560x1600.jpg 28515f1 
>   Dance_of_the_Spirits/contents/screenshot.png 9b9c0c5 
>   Dance_of_the_Spirits/metadata.desktop 0b2f6c9 
>   GereatHeron/contents/images/1280x1024.jpg 8fa95fb 
>   GereatHeron/contents/images/1280x800.jpg 5f7e924 
>   GereatHeron/contents/images/1440x900.jpg 0336115 
>   GereatHeron/contents/images/1600x1200.jpg 6659dd6 
>   GereatHeron/contents/images/1680x1050.jpg 0243a4d 
>   GereatHeron/contents/images/1920x1080.jpg e3c04c0 
>   GereatHeron/contents/images/1920x1200.jpg 34ced65 
>   GereatHeron/contents/images/2560x1440.jpg ed5a835 
>   GereatHeron/contents/images/2560x1600.jpg ccba2c0 
>   GereatHeron/contents/images/640x480.jpg 8e30b41 
>   GereatHeron/contents/images/800x600.jpg fb956a3 
>   GereatHeron/contents/screenshot.jpg 25a514d 
>   GereatHeron/metadata.desktop 4274fbd 
>   Landmannalaugar/contents/images/1280x1024.jpg 83ac796 
>   Landmannalaugar/contents/images/1280x800.jpg 45f8cb1 
>   Landmannalaugar/contents/images/1440x900.jpg 1c28a72 
>   Landmannalaugar/contents/images/1600x1200.jpg e84d18d 
>

Re: Review Request 125972: Don't list systray containment actions in systray context menu.

2015-11-12 Thread David Edmundson 


> On Nov. 9, 2015, 11:36 p.m., Thomas Pfeiffer wrote:
> > Why is that? How is the systray different from other widgets in the panel? 
> > And if we don't show panel options in the context menu of anything in the 
> > panel, how does a user get to them?
> > 
> > This is another issue that would be solved by a clear separation between a 
> > "usage mode" and a "config mode", btw.

Good question.

So before we had 3 bits of menu code:
 one for SNIs
 one for compact plasmoids
 one for expanded plasmoids
 
only one of them (expanded plasmoids) showed the panel options menu entry. So 
definitely something is wrong
I went with the logic "the odd one out is the wrong one"

sys tray is arguably a bit different as it is already adding an entry "system 
tray options" so we're already going one level up - but I'm not completely 
attached to that argument.

>And if we don't show panel options in the context menu of anything in the 
>panel, how does a user get to them?

There's the burger menu on the right in all cases anyway. AFAIK you can't turn 
that one off in the UI.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125972/#review88207
---


On Nov. 9, 2015, 10:43 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125972/
> ---
> 
> (Updated Nov. 9, 2015, 10:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> as in "panel options" when systray is in the panel.
> 
> Only one of the formerly two (see https://git.reviewboard.kde.org/r/125973/) 
> methods did this, so I think it's safe to remove from the one I'm keeping.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 
> d378be14a4102144079b6a7819208e7bbd9b1bb7 
> 
> Diff: https://git.reviewboard.kde.org/r/125972/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88286
---



applets/kicker/plugin/computermodel.cpp (line 81)


you don't want the mapToSource

indexes here are already source indexes.


- David Edmundson


On Nov. 12, 2015, 10:13 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 12, 2015, 10:13 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>   applets/kickoff/core/qmldir d454d1b 
>   applets/kickoff/core/recentapplications.h b73d526 
>   applets/kickoff/core/recentapplications.cpp 2dd6781 
>   applets/kickoff/core/recentlyusedmodel.h 2530fb4 
>   applets/kickoff/core/recentlyusedmodel.cpp afeed23 
>   applets/kickoff/core/systemmodel.h 5da49ad 
>   applets/kickoff/core/systemmodel.cpp 461a2ed 
>   applets/kickoff/core/urlitemlauncher.h 05c414d 
>   applets/kickoff/core/urlitemlauncher.cpp c350680 
>

Re: Review Request 126042: avoid QMenu::exec in plasmoid context menu

2015-11-12 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126042/#review88292
---

Ship it!


LGTM, thanks!

- Aleix Pol Gonzalez


On Nov. 12, 2015, 3:14 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126042/
> ---
> 
> (Updated Nov. 12, 2015, 3:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 354903
> https://bugs.kde.org/show_bug.cgi?id=354903
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> BUG: 354903
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 
> d378be14a4102144079b6a7819208e7bbd9b1bb7 
> 
> Diff: https://git.reviewboard.kde.org/r/126042/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126046: Load applet icons from the plugin name first

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126046/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This saves applets needlessly writing their plugin name twice in the metadata
files, and also leaves the metadata icon entry free for more semantic
purposes for use in tooltips and notifications


Diffs
-

  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 
5e35a075f80c3da5a1060655f4d8fe573e117a80 

Diff: https://git.reviewboard.kde.org/r/126046/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126042: avoid QMenu::exec in plasmoid context menu

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126042/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

BUG: 354903


Diffs
-

  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 
d378be14a4102144079b6a7819208e7bbd9b1bb7 

Diff: https://git.reviewboard.kde.org/r/126042/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126042: avoid QMenu::exec in plasmoid context menu

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126042/
---

(Updated Nov. 12, 2015, 3:14 p.m.)


Review request for Plasma.


Bugs: 354903
https://bugs.kde.org/show_bug.cgi?id=354903


Repository: plasma-workspace


Description
---

BUG: 354903


Diffs
-

  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 
d378be14a4102144079b6a7819208e7bbd9b1bb7 

Diff: https://git.reviewboard.kde.org/r/126042/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 12, 2015, 7:21 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList

Removed redundant imageFetched from LastFmImageFetcher
gotImage calls the signal imageFetched in PmcImageCache which is again 
connected to signalUpdate in PmcMetaDataModel


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126046: Load applet icons from the plugin name first

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126046/
---

(Updated Nov. 12, 2015, 3:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 1b77bd6c4798095b7498f9473b275d4b1a8ee7ad by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

This saves applets needlessly writing their plugin name twice in the metadata
files, and also leaves the metadata icon entry free for more semantic
purposes for use in tooltips and notifications


Diffs
-

  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 
5e35a075f80c3da5a1060655f4d8fe573e117a80 

Diff: https://git.reviewboard.kde.org/r/126046/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126042: avoid QMenu::exec in plasmoid context menu

2015-11-12 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126042/
---

(Updated Nov. 12, 2015, 3:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 4ea74276f1a58697c6441ca2cc3b14c09c7e7fdb by David 
Edmundson to branch master.


Bugs: 354903
https://bugs.kde.org/show_bug.cgi?id=354903


Repository: plasma-workspace


Description
---

BUG: 354903


Diffs
-

  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 
d378be14a4102144079b6a7819208e7bbd9b1bb7 

Diff: https://git.reviewboard.kde.org/r/126042/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126046: Load applet icons from the plugin name first

2015-11-12 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126046/#review88296
---

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 12, 2015, 2:46 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126046/
> ---
> 
> (Updated Nov. 12, 2015, 2:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This saves applets needlessly writing their plugin name twice in the metadata
> files, and also leaves the metadata icon entry free for more semantic
> purposes for use in tooltips and notifications
> 
> 
> Diffs
> -
> 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 
> 5e35a075f80c3da5a1060655f4d8fe573e117a80 
> 
> Diff: https://git.reviewboard.kde.org/r/126046/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread Ivan Čukić 


> On Nov. 12, 2015, 5:19 p.m., Ivan Čukić wrote:
> >

I know I'm a bit late, but it is easier like this than via email :)


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88304
---


On Nov. 12, 2015, 10:13 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 12, 2015, 10:13 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>   applets/kickoff/core/qmldir d454d1b 
>   applets/kickoff/core/recentapplications.h b73d526 
>   applets/kickoff/core/recentapplications.cpp 2dd6781 
>   applets/kickoff/core/recentlyusedmodel.h 2530fb4 
>   applets/kickoff/core/recentlyusedmodel.cpp afeed23 
>   applets/kickoff/core/systemmodel.h 5da49ad 
>   applets/kickoff/core/systemmodel.cpp 461a2ed 
>   applets/kickoff/core/urlitemlauncher.h 05c414d 
>   applets/kickoff/core/urlitemlauncher.cpp c350680 
>   applets/kickoff/package/contents/code/tools.js PRE-CREATION 
>

Re: Review Request 126027: Port Kickoff to the Kicker backend

2015-11-12 Thread Ivan Čukić 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126027/#review88304
---



applets/kicker/plugin/recentusagemodel.h (line 42)


- What about contacts?
- Why not Apps, Docs flags, they could be used below for appData, docData 
potentially



applets/kicker/plugin/recentusagemodel.cpp (line 64)


We probably ought to move this somewhere else "applications:" (do and will) 
appear everywhere.
Maybe even to have the checker is(Type) or something.



applets/kicker/plugin/recentusagemodel.cpp (line 101)


I so want to make you use auto here :)


- Ivan Čukić


On Nov. 12, 2015, 10:13 a.m., Eike Hein wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126027/
> ---
> 
> (Updated Nov. 12, 2015, 10:13 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a roll-up of the various Kicker backend and ultimately Kickoff 
> changes needed to obsolete Kickoff's old backend in favor of Kicker's. It 
> raises Kickoff to Kicker's feature level (much more fleshed-out context menus 
> with many additional features, pervasive favoriting, etc.) along with 
> addressing numerous Kickoff bugs (e.g. sorting on the Computer page) and 
> removing some cruft.
> 
> Migration from kickoffrc is done using a script and supports both favorites 
> and ISV-customized system apps for the Computer page.
> 
> I suggest using the hein/kickeroff branch for review instead, as things are 
> nicely split out into separate commits there.
> 
> 
> Diffs
> -
> 
>   applets/kicker/CMakeLists.txt bdb6419 
>   applets/kicker/plugin/abstractentry.h e09b3cf 
>   applets/kicker/plugin/abstractentry.cpp 846a548 
>   applets/kicker/plugin/abstractmodel.h 142de27 
>   applets/kicker/plugin/abstractmodel.cpp 18eed03 
>   applets/kicker/plugin/actionlist.h 4aaa1d5 
>   applets/kicker/plugin/appentry.h 3d0b1bd 
>   applets/kicker/plugin/appentry.cpp 34bab3d 
>   applets/kicker/plugin/appsmodel.h 3cd0577 
>   applets/kicker/plugin/appsmodel.cpp 821ae88 
>   applets/kicker/plugin/computermodel.h PRE-CREATION 
>   applets/kicker/plugin/computermodel.cpp PRE-CREATION 
>   applets/kicker/plugin/favoritesmodel.cpp 4931a16 
>   applets/kicker/plugin/fileentry.h cd4e54a 
>   applets/kicker/plugin/fileentry.cpp 693816d 
>   applets/kicker/plugin/kickerplugin.cpp d31043a 
>   applets/kicker/plugin/recentappsmodel.h 6ee55c1 
>   applets/kicker/plugin/recentappsmodel.cpp 3d167c5 
>   applets/kicker/plugin/recentdocsmodel.h df12d1b 
>   applets/kicker/plugin/recentdocsmodel.cpp ae7306f 
>   applets/kicker/plugin/recentusagemodel.h PRE-CREATION 
>   applets/kicker/plugin/recentusagemodel.cpp PRE-CREATION 
>   applets/kicker/plugin/rootmodel.h 5acdb8e 
>   applets/kicker/plugin/rootmodel.cpp fde16fd 
>   applets/kicker/plugin/runnermatchesmodel.cpp d375fd7 
>   applets/kicker/plugin/runnermodel.h d827e6d 
>   applets/kicker/plugin/runnermodel.cpp 4eb6ccc 
>   applets/kicker/plugin/systementry.h df0712b 
>   applets/kicker/plugin/systementry.cpp ec527da 
>   applets/kicker/plugin/systemmodel.h 1b3eab7 
>   applets/kicker/plugin/systemmodel.cpp ef02892 
>   applets/kickoff/CMakeLists.txt 339316d 
>   applets/kickoff/STATUS-TODO f837793 
>   applets/kickoff/core/applicationmodel.h cc28656 
>   applets/kickoff/core/applicationmodel.cpp a292130 
>   applets/kickoff/core/favoritesmodel.h 7a5f225 
>   applets/kickoff/core/favoritesmodel.cpp be47347 
>   applets/kickoff/core/itemhandlers.h 8f05490 
>   applets/kickoff/core/itemhandlers.cpp d0cd423 
>   applets/kickoff/core/kickoffabstractmodel.h be5ce21 
>   applets/kickoff/core/kickoffabstractmodel.cpp 43afb1b 
>   applets/kickoff/core/kickoffmodel.h dd91f9b 
>   applets/kickoff/core/kickoffmodel.cpp fd5bb62 
>   applets/kickoff/core/kickoffplugin.h de839b3 
>   applets/kickoff/core/kickoffplugin.cpp ef6cbdd 
>   applets/kickoff/core/kickoffproxymodel.h f1af640 
>   applets/kickoff/core/kickoffproxymodel.cpp 8c58d2b 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp f8c031b 
>   applets/kickoff/core/leavemodel.h f95a271 
>   applets/kickoff/core/leavemodel.cpp 154eb1c 
>   applets/kickoff/core/models.h 30e80be 
>   applets/kickoff/core/models.cpp a63d363 
>   applets/kickoff/core/org.kde.kickoff.recent.xml d013f62 
>   applets/kickoff/core/org.kde.kickoff.xml b0f5d09 
>   applets/kickoff/core/processrunner.h 5d836eb 
>   applets/kickoff/core/processrunner.cpp 6572386 
>

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Ashish Bansal 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88301
---



libs/mediacenter/lastfmimagefetcher.cpp (line 46)


Use latest Qt5 Signal/Slot signal syntax.



libs/mediacenter/lastfmimagefetcher.cpp (line 47)


This statement seems to be redundant. If no one outside this class listens 
to this signal, then just remove it, or modify it and make PmcImageCache listen 
to it.



libs/mediacenter/pmcimagecache.cpp (line 100)


As this slot is just emitting another signal, you should remove it and emit 
signal directly in connect function.


- Ashish Bansal


On Nov. 12, 2015, 4:23 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 12, 2015, 4:23 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList
> 
> To update this info, the signal imageFetched is absorbed by 
> imageFetchedFromLastFm in PmcImageCache.
> Inside this imageFetchedFromLastFm, another signalImageFetchedFromLastFm is 
> emitted which is then absorbed by signalUpdate in PmcMetaDataModel
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcimagecache.h 6399461 
>   libs/mediacenter/pmcimagecache.cpp fcfe2a8 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 12, 2015, 4:36 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList

To update this info, the signal imageFetched is absorbed by 
imageFetchedFromLastFm in PmcImageCache.
Inside this imageFetchedFromLastFm, another signalImageFetchedFromLastFm is 
emitted which is then absorbed by signalUpdate in PmcMetaDataModel


Diffs
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcimagecache.cpp fcfe2a8 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Aditya Dev Sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 12, 2015, 4:23 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcimagecache.cpp fcfe2a8 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Built and Tested.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Plasma Workspace Wallpapers] [Bug 354379] Wallpaper fails to rotate 90 on dual screen with external scr. on left. Stays horiz. and spills over onto right scr.

2015-11-12 Thread PhillB via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=354379

--- Comment #8 from PhillB  ---
The latest thing I've tried is to completely delete the .kde directory followed
by logging out and logging in. This was in the hope that the issue was related
to some setting within kde.

The activities were preserved, so I assume that information is not kept in the
.kde directory.

The issue of not rotating the external screen was still present.

I'm now suspecting that this issue is related to Activities. It seems that when
initializing an Activity the desktop does not listen (or only sometimes
listens) to the rotate -90 setting.

For the time being I've unrotated the physical screen (most inconvenient for
reading documents).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel