[Breeze] [Bug 357135] org.kde.breeze window specific overrides get lost everytime I click apply and ok

2015-12-27 Thread Hugo Pereira Da Costa via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=357135

Hugo Pereira Da Costa  changed:

   What|Removed |Added

  Component|general |window decoration
 CC||hugo.pere...@free.fr
   Assignee|plasma-devel@kde.org|hugo.pere...@free.fr

--- Comment #1 from Hugo Pereira Da Costa  ---
Can reproduce.
Something wrong with kconfig ... 
- note that if you press "ok" and only "ok" untill you quit the configuration,
it will work
you can then reoppen add a new rule and ok->ok->ok will keep both
Problem occurs as soon as you click apply+ok, or multiple apply+change+apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

robots.txt in quickgit.kde.org

2015-12-27 Thread Ashish Bansal 
Hi everyone,

"quickgit.kde.org" contains robots.txt[0] which is disallowing search
engines to fetch the project repos. I just wanted to know if this is
intentional or not?

If I recall correctly, mirror of kde repositories on github was created
just because it wasn't being indexed by the search engines.

[0] https://quickgit.kde.org/robots.txt

-- 

*Regards,*
*Ashish Bansal*
*http://ashish-bansal.in *
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-27 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review90139
---


Sorry for the delay; Christmas happened :-)

Just two more small (but important) things, and then we're ready to go!


kde-modules/KDEPackageAppTemplates.cmake (line 1)


This documentation won't be added to the generated docs unless you put a 
link file in the `docs/kde-module` directory. It's pretty straightforward - 
just copy and edit one of the other files in that directory.



kde-modules/KDEPackageAppTemplates.cmake (line 16)


I would phrase this as something like

INSTALL_DIR is the directory to install the template package to. In 
most cases you will want to use the variable KDE_INSTALL_KTEMPLATESDIR from 
:kde-module:`KDEInstallDirs`.

And then put a blank line before the bit about TEMPLATES, so they're 
separate paragraphs.


- Alex Merry


On Dec. 18, 2015, 10:55 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> ---
> 
> (Updated Dec. 18, 2015, 10:55 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Plasma, Aleix Pol Gonzalez, 
> and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake b7cd34d 
>   kde-modules/KDEPackageAppTemplates.cmake PRE-CREATION 
>   tests/CMakeLists.txt 1a66f56 
>   tests/KDEPackageAppTemplatesTest/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/check.cmake.in PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/CMakeLists.txt PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/Messages.sh PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/README PRE-CREATION 
>   
> tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/images/pairs.svgz
>  PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/contents/ui/main.qml 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/package/metadata.desktop 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.kdevtemplate 
> PRE-CREATION 
>   tests/KDEPackageAppTemplatesTest/qml-plasmoid/qml-plasmoid.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> ---
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

2015-12-27 Thread Ben Cooksley 
On Sun, Dec 27, 2015 at 11:53 PM, Ashish Bansal
 wrote:
> Hi everyone,

Hi Ashish,

>
> "quickgit.kde.org" contains robots.txt[0] which is disallowing search
> engines to fetch the project repos. I just wanted to know if this is
> intentional or not?
>
> If I recall correctly, mirror of kde repositories on github was created just
> because it wasn't being indexed by the search engines.

This is intentional, and is done to reduce the server load created by
indexers such as Google on the system hosting quickgit.kde.org.
(Generation of the pages, including the main index is substantially
more expensive than it appears due to the disk access required by
Git/SVN to return the needed information).

>
> [0] https://quickgit.kde.org/robots.txt
>
> --
>
> Regards,
> Ashish Bansal
> http://ashish-bansal.in

Regards,
Ben Cooksley
KDE Sysadmin

>
>
>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
>>> <<
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

2015-12-27 Thread Lydia Pintscher 
On Sun, Dec 27, 2015 at 12:08 PM, Ben Cooksley  wrote:
> On Sun, Dec 27, 2015 at 11:53 PM, Ashish Bansal
>  wrote:
>> Hi everyone,
>
> Hi Ashish,
>
>>
>> "quickgit.kde.org" contains robots.txt[0] which is disallowing search
>> engines to fetch the project repos. I just wanted to know if this is
>> intentional or not?
>>
>> If I recall correctly, mirror of kde repositories on github was created just
>> because it wasn't being indexed by the search engines.
>
> This is intentional, and is done to reduce the server load created by
> indexers such as Google on the system hosting quickgit.kde.org.
> (Generation of the pages, including the main index is substantially
> more expensive than it appears due to the disk access required by
> Git/SVN to return the needed information).

Is there some place where search engines can easily index our source
code or are we shooting ourselves in the foot here?


Cheers
Lydia

-- 
Lydia Pintscher - http://about.me/lydia.pintscher
KDE e.V. Board of Directors / KDE Community Working Group
http://kde.org - http://open-advice.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

2015-12-27 Thread Ben Cooksley 
On Mon, Dec 28, 2015 at 12:15 AM, Lydia Pintscher  wrote:
> On Sun, Dec 27, 2015 at 12:08 PM, Ben Cooksley  wrote:
>> On Sun, Dec 27, 2015 at 11:53 PM, Ashish Bansal
>>  wrote:
>>> Hi everyone,
>>
>> Hi Ashish,
>>
>>>
>>> "quickgit.kde.org" contains robots.txt[0] which is disallowing search
>>> engines to fetch the project repos. I just wanted to know if this is
>>> intentional or not?
>>>
>>> If I recall correctly, mirror of kde repositories on github was created just
>>> because it wasn't being indexed by the search engines.
>>
>> This is intentional, and is done to reduce the server load created by
>> indexers such as Google on the system hosting quickgit.kde.org.
>> (Generation of the pages, including the main index is substantially
>> more expensive than it appears due to the disk access required by
>> Git/SVN to return the needed information).
>
> Is there some place where search engines can easily index our source
> code or are we shooting ourselves in the foot here?

We could probably make it available by publishing the source trees
used by LXR / EBN.
This would only have the main branches obviously rather than everything though.

I haven't checked, but LXR may already make it's copy of the code accessible...

>
>
> Cheers
> Lydia

Regards,
Ben

>
> --
> Lydia Pintscher - http://about.me/lydia.pintscher
> KDE e.V. Board of Directors / KDE Community Working Group
> http://kde.org - http://open-advice.org
>
>>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Heiko Tietze 


> On Dec. 25, 2015, 4:37 p.m., Kai Uwe Broulik wrote:
> > Usability: I envisioned this to be used for auto-restarting shell services 
> > and not to be used by applications.
> > Another interesting thought could be enabling this by default for all 
> > applications but for regular applications trigger a desktop notification 
> > (with report bug / restart app) together with the tray icon.
> > 
> > Mockup: http://wstaw.org/m/2015/12/25/drkonqipassive.png

If I understand right the auto-restart notification does not have any restart 
button (which wouldn't make sense) but just the report bug interaction. When 
the user is presented with either restart or report in case of regular apps, 
and the notification disapears when the button is clicked, he or she would 
likely rather restart than going through the debug dialog (that usually lacks 
on debug info). Simple solution is to show the SNI with restart option only. 
And even more simple is to leave the crash handling to the app.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90100
---


On Dec. 25, 2015, 4:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dec. 25, 2015, 4:24 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---

Ship it!



drkonqi/main.cpp (line 159)


and -> or surely?

both in code and comments.


- David Edmundson


On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dec. 27, 2015, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126491: Set root context properties on the right context

2015-12-27 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126491/#review90181
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Dez. 23, 2015, 5:08 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126491/
> ---
> 
> (Updated Dez. 23, 2015, 5:08 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355885, 356545 and 356916
> https://bugs.kde.org/show_bug.cgi?id=355885
> https://bugs.kde.org/show_bug.cgi?id=356545
> https://bugs.kde.org/show_bug.cgi?id=356916
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> engine()->rootContext() will give a different result to
> rootContext() when using a shared engine.
> 
> One being in the right context, the other being the context of the
> shared engine. Using the latter means two panels end up sharing the same
> object which leads to some interesting results and QML crashes in
> QV4::QObjectWrapper::wrap when one gets deleted.
> 
> I've tested against 356545, but I think it's the cause of a lot of the
> mystery QML bugs we couldn't figure out.
> 
> BUG: 356545
> BUG: 355885
> BUG: 356916
> 
> 
> Diffs
> -
> 
>   shell/containmentconfigview.cpp bf2b9287acb8188d63068b5389b3d55bfbdbf76b 
>   shell/panelconfigview.cpp 29a50bc03d8750e2370c5c2b5cfe761a031c43e9 
>   shell/panelview.cpp 893def0ced7297271d03dd27f40f8f6599a2354f 
>   shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/126491/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-27 Thread David Edmundson 


> On Dec. 24, 2015, 3:22 a.m., Martin Klapetek wrote:
> > Screenshot? Also looks like a good candidate for QML-KMessageWidget (do we 
> > have a component for that already?)
> 
> David Edmundson wrote:
> You wrote one in the clock applet, you have not made it a component.
> If you do so, I will use it.
> 
> Kai Uwe Broulik wrote:
> I gave up on this because there were complaints that it didn't use the 
> widget style / QFrame which I couldn't because it's QML and the QQC desktop 
> style logic is a nightmare.
> 
> What about a simple tooltip on the disabled combobox? :)
> 
> On the other hand, the Plasma 4 one also had an "Unlock widgets" button.

>What about a simple tooltip on the disabled combobox? :)

No way to do tooltips on comboboxes without using private Qt API.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/#review90041
---


On Dec. 24, 2015, 1:43 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126499/
> ---
> 
> (Updated Dec. 24, 2015, 1:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> BUG: 356874
> 
> 
> Diffs
> -
> 
>   
> desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
> 9d04d0aa8b53f219e937228f91abee5ff439d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/126499/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-27 Thread Kai Uwe Broulik 


> On Dez. 24, 2015, 3:22 vorm., Martin Klapetek wrote:
> > Screenshot? Also looks like a good candidate for QML-KMessageWidget (do we 
> > have a component for that already?)
> 
> David Edmundson wrote:
> You wrote one in the clock applet, you have not made it a component.
> If you do so, I will use it.
> 
> Kai Uwe Broulik wrote:
> I gave up on this because there were complaints that it didn't use the 
> widget style / QFrame which I couldn't because it's QML and the QQC desktop 
> style logic is a nightmare.
> 
> What about a simple tooltip on the disabled combobox? :)
> 
> On the other hand, the Plasma 4 one also had an "Unlock widgets" button.
> 
> David Edmundson wrote:
> >What about a simple tooltip on the disabled combobox? :)
> 
> No way to do tooltips on comboboxes without using private Qt API.

Meh.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/#review90041
---


On Dez. 24, 2015, 1:43 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126499/
> ---
> 
> (Updated Dez. 24, 2015, 1:43 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> BUG: 356874
> 
> 
> Diffs
> -
> 
>   
> desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
> 9d04d0aa8b53f219e937228f91abee5ff439d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/126499/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 348 - Failure!

2015-12-27 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/348/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 27 Dec 2015 09:18:58 +
Build duration: 4 min 31 sec

CHANGE SET
Revision 66f97694fcdb18e22ee9ddc9ebeb66e9d07657f8 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/mediacontroller/metadata.desktop
  change: edit runners/kill/plasma-runner-kill.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik 


> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.

The and is correct:

- I never want to show the dialog or a notification when we're passive.
- I want to show the DrKonqi dialog instead of the KPassivePopup fallback in 
case no FDO notification service is available


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ivan Čukić 


> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote:
> > I have mixed feelings about this one. (to oppose those that are against it, 
> > and those that are for it)
> > 
> > I like the picture. It would be awesome as a background for some 
> > kde-plasma-related brochures, videos etc.
> > 
> > I'm not convinced that it is suitable as a (especially the default) 
> > wallpaper. It mixes too many styles in one place (dots, irregular 
> > triangles, regular dark triangles, regular colourful triangles, and the 
> > intel-glitch-bar).
> > 
> > But I'm afraid that removing any of them just might make the wallpaper 
> > ordinary, even boring. (I think that even removing the intel-glitch-bar 
> > might be problematic)
> 
> Ken Vermette wrote:
> I agree looking at the changes that dropping the glitch bar has definitly 
> eroded some of the personality of the image, but from a functional 
> perspective removing the intel-glitch-bar is making a huge difference in 
> pulling the styles together. Probably because the bar was so different 
> compared to anything else in the image.
> 
> Plus it's not really the wallpapers job to stand out that much, so I'm 
> coming around to simplifying things a bit. Compared to some other wallpapers 
> out there I wouldn't say we're boring in comparison, but I think it did need 
> to be reeled in a bit from the increasing craziness. If we do want to use 
> elements of this style in other materials, I definitly wouldn't want it 
> overpowering the more meaningful content as well.
> 
> Anyway, without the glitch bar, what are your thoughts? Roughly the same 
> or has it helped?

For some reason, I can't open it. Keep getting '403 forbidden' for all the new 
ones - like this:

You don't have permission to access 
/media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png
 on this server.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90131
---


On Dec. 27, 2015, 12:22 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
> screenshot.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
> 1280x1024.png

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-27 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/#review90157
---



desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
(line 103)


What is this Row for?



desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
(line 106)


You didn't specify a width, ie. there'll be no wrapping


- Kai Uwe Broulik


On Dez. 24, 2015, 1:43 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126499/
> ---
> 
> (Updated Dez. 24, 2015, 1:43 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> BUG: 356874
> 
> 
> Diffs
> -
> 
>   
> desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 
> 9d04d0aa8b53f219e937228f91abee5ff439d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/126499/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ken Vermette 


> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote:
> > I have mixed feelings about this one. (to oppose those that are against it, 
> > and those that are for it)
> > 
> > I like the picture. It would be awesome as a background for some 
> > kde-plasma-related brochures, videos etc.
> > 
> > I'm not convinced that it is suitable as a (especially the default) 
> > wallpaper. It mixes too many styles in one place (dots, irregular 
> > triangles, regular dark triangles, regular colourful triangles, and the 
> > intel-glitch-bar).
> > 
> > But I'm afraid that removing any of them just might make the wallpaper 
> > ordinary, even boring. (I think that even removing the intel-glitch-bar 
> > might be problematic)
> 
> Ken Vermette wrote:
> I agree looking at the changes that dropping the glitch bar has definitly 
> eroded some of the personality of the image, but from a functional 
> perspective removing the intel-glitch-bar is making a huge difference in 
> pulling the styles together. Probably because the bar was so different 
> compared to anything else in the image.
> 
> Plus it's not really the wallpapers job to stand out that much, so I'm 
> coming around to simplifying things a bit. Compared to some other wallpapers 
> out there I wouldn't say we're boring in comparison, but I think it did need 
> to be reeled in a bit from the increasing craziness. If we do want to use 
> elements of this style in other materials, I definitly wouldn't want it 
> overpowering the more meaningful content as well.
> 
> Anyway, without the glitch bar, what are your thoughts? Roughly the same 
> or has it helped?
> 
> Ivan Čukić wrote:
> For some reason, I can't open it. Keep getting '403 forbidden' for all 
> the new ones - like this:
> 
> You don't have permission to access 
> /media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png
>  on this server.

That's weird. Probably because I copied/pasted a bad link. It's listed in the 
files area of this review as "desktopWallpaper-graphite-3.3-kvermette.png".


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90131
---


On Dec. 27, 2015, 12:22 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
>

Re: Review Request 126472: Don't always load the timetracker

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/
---

(Updated Dec. 27, 2015, 7:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit ab135f4e8ed451f4f310732e6f5bc084aff69519 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Don't always load the timetracker

It has a timer that wakes up every 2 seconds and drains my battery just
simply because I have debug builds. This make it on demand.

Don't track containments twice.
Containments inherit from Applets which also have the same line


Diffs
-

  src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
  src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
  src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 

Diff: https://git.reviewboard.kde.org/r/126472/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/#review90184
---



shell/main.cpp 


oh, I probably want to keep this and set the flag as appropriate.


- David Edmundson


On Dec. 27, 2015, 9:10 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126538/
> ---
> 
> (Updated Dec. 27, 2015, 9:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> KCrash already has auto restart which copies the args and only respawns
> n times, resetting if we last longer than m seconds.
> 
> Timeouts are sligthly different, but if changes are genuinely needed we can 
> add options to KCrash.
> 
> 
> Diffs
> -
> 
>   shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
>   shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
>   shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 
> 
> Diff: https://git.reviewboard.kde.org/r/126538/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.

Timeouts are sligthly different, but if changes are genuinely needed we can add 
options to KCrash.


Diffs
-

  shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
  shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
  shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 

Diff: https://git.reviewboard.kde.org/r/126538/diff/


Testing
---

None.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ivan Čukić 


> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote:
> > I have mixed feelings about this one. (to oppose those that are against it, 
> > and those that are for it)
> > 
> > I like the picture. It would be awesome as a background for some 
> > kde-plasma-related brochures, videos etc.
> > 
> > I'm not convinced that it is suitable as a (especially the default) 
> > wallpaper. It mixes too many styles in one place (dots, irregular 
> > triangles, regular dark triangles, regular colourful triangles, and the 
> > intel-glitch-bar).
> > 
> > But I'm afraid that removing any of them just might make the wallpaper 
> > ordinary, even boring. (I think that even removing the intel-glitch-bar 
> > might be problematic)
> 
> Ken Vermette wrote:
> I agree looking at the changes that dropping the glitch bar has definitly 
> eroded some of the personality of the image, but from a functional 
> perspective removing the intel-glitch-bar is making a huge difference in 
> pulling the styles together. Probably because the bar was so different 
> compared to anything else in the image.
> 
> Plus it's not really the wallpapers job to stand out that much, so I'm 
> coming around to simplifying things a bit. Compared to some other wallpapers 
> out there I wouldn't say we're boring in comparison, but I think it did need 
> to be reeled in a bit from the increasing craziness. If we do want to use 
> elements of this style in other materials, I definitly wouldn't want it 
> overpowering the more meaningful content as well.
> 
> Anyway, without the glitch bar, what are your thoughts? Roughly the same 
> or has it helped?
> 
> Ivan Čukić wrote:
> For some reason, I can't open it. Keep getting '403 forbidden' for all 
> the new ones - like this:
> 
> You don't have permission to access 
> /media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png
>  on this server.
> 
> Ken Vermette wrote:
> That's weird. Probably because I copied/pasted a bad link. It's listed in 
> the files area of this review as 
> "desktopWallpaper-graphite-3.3-kvermette.png".

Still forbidden...


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90131
---


On Dec. 27, 2015, 12:22 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
>

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Boudhayan Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review90143
---


I love the final iteration (3.3). In fact I've started using it as my wallpaper 
and it looks very in-place.

- Boudhayan Gupta


On Dec. 27, 2015, 5:52 a.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dec. 27, 2015, 5:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/126319/diff/
> 
> 
> Testing
> ---
> 
> Dogfooded on several machines and my phone for a couple weeks now, doesn't 
> burn eyes out. Corner isn't as distracting as one might assume, especially 
> once a window is on screen. Got early feedback, adjustments made from 
> origional in order:
>  - Re-drew the "circuit/chip" pattern to be less noisy/distracting/cleaner. 
> Adjusted it so details are still seen on lower-res wallpapers.
>  - Lightened purple to avoid the "dark void" feeling people have mentioned 
> feeling from 5.5 wallpaper.
>  - Fixed minor pixel issues for triangles near edge
>  - Adjusted noise, shadows.
> 
> 
> File Attachments
> 
> 
> 1024x768.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/5e9e5db3-c8d4-43ec-8236-da5daa80be85__1024x768.png
> 1280x800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/41e11bb9-eaef-4eb1-bb4b-c7137becaca0__1280x800.png
> screenshot.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee643bd5-8162-4a9b-ae09-df090d4f0b43__screenshot.png
> 1280x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/054536c9-8160-418a-a1c9-c319e1e2b533__1280x1024.png
> 1440x900.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/c4c61ba4-10ea-4d87-9437-7b7e1701eaf7__1440x900.png
> 1600x1200.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/ee746ed5-428d-4423-8e20-d9786b25190f__1600x1200.png
> 1638x1024.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/233a9950-24bd-47b6-8c7a-8f3e6fe707df__1638x1024.png
> 1680x1050.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/4c86e45c-eb10-47fa-b1ff-736bd65918cc__1680x1050.png
> 1920x1080.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/93cc544a-a8a8-4291-91ff-58140ec5ed64__1920x1080.png
> 2560x1440.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/73ad5caf-5156-495b-939c-387ce4970140__2560x1440.png
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/1ff471aa-2e26-41d9-8921-2c62544d3415__2560x1600.png
> 3200x1800.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/7590da34-e5c5-4f55-9ac9-0a22c13a9c0d__3200x1800.png
> 3200x2000.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/11/229a429e-9633-4988-ad78-dfb039583fc4__3200x2000.png
> desktopWallpaper-graphite-3.3-kvermette.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/bc1de0b2-a753-4772-b5a7-8d5c27c0138b__desktopWallpaper-graphite-3.3-kvermette.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 43 - Failure!

2015-12-27 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 27 Dec 2015 16:35:45 +
Build duration: 11 sec

CHANGE SET
No changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread David Edmundson 


> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. 
> don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote 
> into the change summary.
> 
> passive | notifications running | action
> Yes | Yes.. | Show SNI
> Yes | No... | Show SNI
> No. | Yes.. | Show SNI and Notification
> No. | No... | Show DrKonqi dialog directly

If we go with this, we can effectively just swap the drop the passive flag 
addition in frameworks and re-use the AutoRestart flag?
and assume !AutoRestart == Passive

It's how you're describing the usage in your blog post.

(would involve Plasma using the existing autorestart rather than doing it's own 
thing, but I like the idea of that)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dec. 27, 2015, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 6 - Failure!

2015-12-27 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 27 Dec 2015 16:35:45 +
Build duration: 9.8 sec

CHANGE SET
No changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread David Edmundson 


> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available

Ah, I see. 
We've changed the --passive meaning so that this is no longer opt-in.

(you did say that in the updated description, but I didn't parse it properly)

So in matrix form:

passive|notifications running|action
---||---
Yes | Yes | Show SNI and notification
Yes | No  | Show SNI and notification
No  | Yes | Show SNI
No  | No  | Dialog directly

?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dec. 27, 2015, 4:11 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik 


> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?
> 
> Kai Uwe Broulik wrote:
> The "passive" is still opt in but I shifted the meaning a bit.
> 
> Passive now means "don't bother the user" or "don't draw attention", ie. 
> don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote 
> into the change summary.
> 
> passive | notifications running | action
> Yes | Yes.. | Show SNI
> Yes | No... | Show SNI
> No. | Yes.. | Show SNI and Notification
> No. | No... | Show DrKonqi dialog directly
> 
> David Edmundson wrote:
> If we go with this, we can effectively just swap the drop the passive 
> flag addition in frameworks and re-use the AutoRestart flag?
> and assume !AutoRestart == Passive
> 
> It's how you're describing the usage in your blog post.
> 
> (would involve Plasma using the existing autorestart rather than doing 
> it's own thing, but I like the idea of that)

+1 to that


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik 


> On Dez. 25, 2015, 4:37 nachm., Kai Uwe Broulik wrote:
> > Usability: I envisioned this to be used for auto-restarting shell services 
> > and not to be used by applications.
> > Another interesting thought could be enabling this by default for all 
> > applications but for regular applications trigger a desktop notification 
> > (with report bug / restart app) together with the tray icon.
> > 
> > Mockup: http://wstaw.org/m/2015/12/25/drkonqipassive.png
> 
> Heiko Tietze wrote:
> If I understand right the auto-restart notification does not have any 
> restart button (which wouldn't make sense) but just the report bug 
> interaction. When the user is presented with either restart or report in case 
> of regular apps, and the notification disapears when the button is clicked, 
> he or she would likely rather restart than going through the debug dialog 
> (that usually lacks on debug info). Simple solution is to show the SNI with 
> restart option only. And even more simple is to leave the crash handling to 
> the app.

There will be no auto-restart notification, just an SNI. For auto-restarting 
services there's no need to point out to the user something bad just happened, 
not that prominent, at least.

For regular apps I should just show the notification and no SNI? Okay.

Unfortunately we really suck at crash recovery, ie. the "Restart App" button 
will most likely just restart the app with an empty document or something like 
that rather than continuing where we left off (somewhat related to our broken 
session restore I guess). I personally have never used the restart button in 
DrKonqi.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90100
---


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik 


> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > 
> >
> > and -> or surely?
> > 
> > both in code and comments.
> 
> Kai Uwe Broulik wrote:
> The and is correct:
> 
> - I never want to show the dialog or a notification when we're passive.
> - I want to show the DrKonqi dialog instead of the KPassivePopup fallback 
> in case no FDO notification service is available
> 
> David Edmundson wrote:
> Ah, I see. 
> We've changed the --passive meaning so that this is no longer opt-in.
> 
> (you did say that in the updated description, but I didn't parse it 
> properly)
> 
> So in matrix form:
> 
> passive|notifications running|action
> ---||---
> Yes | Yes | Show SNI and notification
> Yes | No  | Show SNI and notification
> No  | Yes | Show SNI
> No  | No  | Dialog directly
> 
> ?

The "passive" is still opt in but I shifted the meaning a bit.

Passive now means "don't bother the user" or "don't draw attention", ie. don't 
show a notification or dialog whatsoever, only SNI. Sorry, I only wrote into 
the change summary.

passive | notifications running | action
Yes | Yes.. | Show SNI
Yes | No... | Show SNI
No. | Yes.. | Show SNI and Notification
No. | No... | Show DrKonqi dialog directly


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
---


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> ---
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This adds a new "--passive" option to DrKonqi where it will only show a 
> StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, 
> krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just 
> dump the user on the home screen than telling him something went wrong, so he 
> can just quickly start the app again instead of being annoyed by an error 
> message". On iOS you also just get dropped on the home screen. Windows 
> desktop shows a "Searching for a solution" dialog which was *the* major 
> annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> ---
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black 
> screen inbetween, just the panel restarting. Afterwards I got a SNI which 
> opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after 
> it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-27 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/
---

(Updated Dez. 28, 2015, 12:17 vorm.)


Review request for Plasma.


Changes
---

Rebased to master

The OSD issue I mentioned is nowhere to be seen


Summary (updated)
-

Don't animate from previous pixmap when IconItem has been invisible


Repository: plasma-framework


Description
---

We have a lot of reusable singletons that are just hidden when unneeded 
(tooltip, osd). IconItem, however, will always fade from the previous state, 
even if the previous action happened minutes ago.

This patch makes it track its visibility and skip the fade-and-wait dance when 
it just became visible. It also removes a visible false call in the tooltip 
which I didn't know what it was for. (With it in place, the IconItem always 
becomes visible when moving between tooltip areas, breaking the animation 
altogether).

@Eike: Could you check whether this makes it more viable for Kicker?


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 528f57c 
  src/declarativeimports/core/iconitem.cpp 1e8260e 
  src/declarativeimports/core/tooltip.cpp a5e223b 

Diff: https://git.reviewboard.kde.org/r/122859/diff/


Testing (updated)
---

Moving between tray icons - icon fades, moving relly rapidly causes it not 
to load any icon until you halt (dunno if that happened before but doesn't seem 
too bad)
Hovering tray icon, leaving, waiting, hovering another one - icon does not 
fade, is there right away
Notifications also don't fade from the previously issued notification icon


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

2015-12-27 Thread Michael Pyne 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126539/
---

Review request for KDE Frameworks and Plasma.


Repository: kwallet-pam


Description
---

Coverity strikes again, and notes in CID 1335116 that copying the socket name 
into a fixed-size buffer here could overflow the buffer. I don't see any reason 
it would be wrong in all cases, so best to double-check.

Submitting for review mostly because I don't use pam_kwallet, otherwise the 
check is simple enough that I'd feel comfortable committing directly. Note that 
the len that is already calculated includes the null terminator already.


Diffs
-

  pam_kwallet.c 345aa03 

Diff: https://git.reviewboard.kde.org/r/126539/diff/


Testing
---

Code still compiles.


Thanks,

Michael Pyne

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126539/#review90188
---

Ship it!


Ship It!

- David Edmundson


On Dec. 28, 2015, 12:17 a.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126539/
> ---
> 
> (Updated Dec. 28, 2015, 12:17 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> ---
> 
> Coverity strikes again, and notes in CID 1335116 that copying the socket name 
> into a fixed-size buffer here could overflow the buffer. I don't see any 
> reason it would be wrong in all cases, so best to double-check.
> 
> Submitting for review mostly because I don't use pam_kwallet, otherwise the 
> check is simple enough that I'd feel comfortable committing directly. Note 
> that the len that is already calculated includes the null terminator already.
> 
> 
> Diffs
> -
> 
>   pam_kwallet.c 345aa03 
> 
> Diff: https://git.reviewboard.kde.org/r/126539/diff/
> 
> 
> Testing
> ---
> 
> Code still compiles.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/#review90189
---



src/declarativeimports/core/iconitem.cpp (line 405)


huh? that just reloads the current image whenever visibility gets toggled. 

1) that's wrong since eike's patch. loadPixmap is deffered till a polish 
event before 

2) how does that fix anything?


- David Edmundson


On Dec. 28, 2015, 12:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122859/
> ---
> 
> (Updated Dec. 28, 2015, 12:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We have a lot of reusable singletons that are just hidden when unneeded 
> (tooltip, osd). IconItem, however, will always fade from the previous state, 
> even if the previous action happened minutes ago.
> 
> This patch makes it track its visibility and skip the fade-and-wait dance 
> when it just became visible. It also removes a visible false call in the 
> tooltip which I didn't know what it was for. (With it in place, the IconItem 
> always becomes visible when moving between tooltip areas, breaking the 
> animation altogether).
> 
> @Eike: Could you check whether this makes it more viable for Kicker?
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 528f57c 
>   src/declarativeimports/core/iconitem.cpp 1e8260e 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
> 
> Diff: https://git.reviewboard.kde.org/r/122859/diff/
> 
> 
> Testing
> ---
> 
> Moving between tray icons - icon fades, moving relly rapidly causes it 
> not to load any icon until you halt (dunno if that happened before but 
> doesn't seem too bad)
> Hovering tray icon, leaving, waiting, hovering another one - icon does not 
> fade, is there right away
> Notifications also don't fade from the previously issued notification icon
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

2015-12-27 Thread Michael Pyne 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126539/
---

(Updated Dec. 28, 2015, 1:34 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 9543cc4058b24e4e5bfe8d324de309ca7050058b by Michael Pyne 
to branch master.


Repository: kwallet-pam


Description
---

Coverity strikes again, and notes in CID 1335116 that copying the socket name 
into a fixed-size buffer here could overflow the buffer. I don't see any reason 
it would be wrong in all cases, so best to double-check.

Submitting for review mostly because I don't use pam_kwallet, otherwise the 
check is simple enough that I'd feel comfortable committing directly. Note that 
the len that is already calculated includes the null terminator already.


Diffs
-

  pam_kwallet.c 345aa03 

Diff: https://git.reviewboard.kde.org/r/126539/diff/


Testing
---

Code still compiles.


Thanks,

Michael Pyne

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126491: Set root context properties on the right context

2015-12-27 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126491/
---

(Updated Dec. 27, 2015, 10:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c692bc53a8c5cf5802084085b9aed11203998d38 by David 
Edmundson to branch Plasma/5.5.


Bugs: 355885, 356545 and 356916
https://bugs.kde.org/show_bug.cgi?id=355885
https://bugs.kde.org/show_bug.cgi?id=356545
https://bugs.kde.org/show_bug.cgi?id=356916


Repository: plasma-workspace


Description
---

engine()->rootContext() will give a different result to
rootContext() when using a shared engine.

One being in the right context, the other being the context of the
shared engine. Using the latter means two panels end up sharing the same
object which leads to some interesting results and QML crashes in
QV4::QObjectWrapper::wrap when one gets deleted.

I've tested against 356545, but I think it's the cause of a lot of the
mystery QML bugs we couldn't figure out.

BUG: 356545
BUG: 355885
BUG: 356916


Diffs
-

  shell/containmentconfigview.cpp bf2b9287acb8188d63068b5389b3d55bfbdbf76b 
  shell/panelconfigview.cpp 29a50bc03d8750e2370c5c2b5cfe761a031c43e9 
  shell/panelview.cpp 893def0ced7297271d03dd27f40f8f6599a2354f 
  shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 

Diff: https://git.reviewboard.kde.org/r/126491/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 349 - Unstable!

2015-12-27 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/349/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 28 Dec 2015 02:47:35 +
Build duration: 5 min 30 sec

CHANGE SET
Revision 4c16c5d533a919232d90d496ffcef663ce22c7ca by mpyne: (Fix errant 
logical-or in favor of bitwise-or.)
  change: edit appmenu/menuimporter.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1673/2105 
(79%)CONDITIONAL 1208/1810 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 104/152 (68%)CONDITIONAL 
37/62 (60%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel