[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

Martin Gräßlin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
URL||https://phabricator.kde.org
   ||/D2413

--- Comment #8 from Martin Gräßlin  ---
Removing the key-repeat check in https://phabricator.kde.org/D2413

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 2 lines] D2413: Trigger global shortcuts also on key-repeat

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  Restores feature parity with X11. Global shortcuts need to trigger
  also for repeat events. An example is the volume key or screen
  brightness.
  
  For other shortcuts like showing yakuake it does not make sense to
  trigger on repeat. Thus a long term solution is to add a flag to
  global shortcuts whether the key should trigger on repeat.
  
  BUG: 366608

REPOSITORY
  rKWIN KWin

BRANCH
  global-shortcut-key-repeat

REVISION DETAIL
  https://phabricator.kde.org/D2413

AFFECTED FILES
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 1 line] D2412: [applets] Show battery monitor on all platforms and not just desktop

[bshah (Bhushan Shah)]

bshah created this revision.
bshah added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This will also enable battery monitor on mobile.
  
  See also: https://phabricator.kde.org/D2411

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  show-battery-on-phone (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2412

AFFECTED FILES
  applets/batterymonitor/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: stylesheed folders

[kainz.a]

I think I will revert the folder stylesheed stuff.

Thanks for your feedback and that you help me find a solution.

As it's nice and I already blog about it where should I store this feature?

cheers
Andreas

[Differential] [Changed Subscribers] D2399: New new SDDM theme

[bshah (Bhushan Shah)]

bshah added inline comments.

INLINE COMMENTS

> davidedmundson wrote in KeyboardButton.qml:13
> It was...though that broke when this folder was moved. Good spot.

I wonder if it ever worked to translate those in SDDM? Given KDeclarative takes 
care of loading translation domain IIRC.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D2411: Remove clone of battery monitor from plasma-phone-components

[bshah (Bhushan Shah)]

bshah added a subscriber: plasma-devel.

REPOSITORY
  rPLASMAPHONECOMPONENTS plasma-phone-components

REVISION DETAIL
  https://phabricator.kde.org/D2411

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik, mart
Cc: plasma-devel

[Differential] [Updated, 5,202 lines] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud removed rPLASMADESKTOP Plasma Desktop as the repository for this 
revision.
ochurlaud updated this revision to Diff 5843.
ochurlaud added a comment.


  Added a desktop file, finished the app (KAboutData, CommandLineParser,...)
  
  Ready to ship, I just wait for your remarks.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2409?vs=5837=5843

REVISION DETAIL
  https://phabricator.kde.org/D2409

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colorscm.cpp
  kcms/colors/colorscm.h
  kcms/colors/colorsettings.ui
  kcms/colors/kcolorschemeeditor.cpp
  kcms/colors/kcolorschemeeditor.desktop
  kcms/colors/scmeditorcolors.cpp
  kcms/colors/scmeditorcolors.h
  kcms/colors/scmeditorcolors.ui
  kcms/colors/scmeditordialog.cpp
  kcms/colors/scmeditordialog.h
  kcms/colors/scmeditordialog.ui
  kcms/colors/scmeditoreffects.cpp
  kcms/colors/scmeditoreffects.h
  kcms/colors/scmeditoreffects.ui
  kcms/colors/scmeditoroptions.cpp
  kcms/colors/scmeditoroptions.h
  kcms/colors/scmeditoroptions.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, andreask, #vdg, mart
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in KeyboardButton.qml:13
> is this domain valid for sddm as well?

It was...though that broke when this folder was moved. Good spot.

> mart wrote in UserDelegate.qml:85
> this version you have is probably is significantly faster (and in this case 
> i'll shut up :p)
> 
> but wouldn't look cleaner to have something along the lines:
> 
> layer.enabled: true
> 
>   layer.effect: OpacityMask {
>   maskSource: Rectangle {
>   anchors.centerIn: parent
>   width: imageWrapper.width
>   height: width
>   radius: width/2
>   }
>   }

It's a bit more complex with the white frame that has to be transparent on the 
inside.

So that then needs to be drawn somehow. I guess making an SVG of a circle would 
work.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Review Request 128660: Add an optional reveal password button to TextField

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Similar to KPasswordWidget in kwidgetaddons


Diffs
-

  src/declarativeimports/plasmacomponents/qml/TextField.qml 
c0d9155df5bb584cd3070a66c99d98465b81a5ef 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 
05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
  tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 

Diff: https://git.reviewboard.kde.org/r/128660/diff/


Testing
---

Updated manual test. See screenshot.


File Attachments


Spectacle.B12253.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png


Thanks,

David Edmundson

[Differential] [Commented On] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  In https://phabricator.kde.org/D2409#45058, @whiting wrote:
  
  > I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.
  
  
  Done locally.
  
  The executable is now KColorSchemeEditor.
  
  If someone could tell me what the kcolorschemeditor.desktop should be as 
well? Then I'll update the review.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, andreask, #vdg, mart
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2409: Update Color KCM

[whiting (Jeremy Whiting)]

whiting added a comment.


  I like it. Nice work. I agree I would change Config Scheme to Edit Scheme.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, andreask, #vdg, mart
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D2409: Update Color KCM

[mart (Marco Martin)]

mart added a comment.


  as a name, what about  the whoefully uninspiring kcolorschemeeditor? :)
  
  I would like it in plasma-sdk. even keeping it there for a while is fine, 
it's just important that it's shipped when the new kcm is in, to not have a 
release with feature loss

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, andreask, #vdg, mart
Cc: colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> ivan wrote in shellcorona.cpp:550
> I agree with Martin. If the user is crazy enough...
> 
> D-Bus was never really meant to be something that the users should be calling 
> directly anyhow.

yeah, agree
so,, I'm thinking about exposing 2 functions
loadLookAndFeel(qstring name)
reloadLookAndFeel(QString name)

the first is not destructive the second is (just to not have a bool parameter)
the destructive version, even if it's loadedwith the current look and feel 
reloads anyways, because destroys the current setup.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> KeyboardButton.qml:13
>  
> -text: instantiator.objectAt(currentIndex).shortName
> +text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Keyboard Layout: 
> %1", instantiator.objectAt(currentIndex).shortName)
>  implicitWidth: minimumWidth

is this domain valid for sddm as well?

> UserDelegate.qml:85
>  
> -//if copying into another project don't forget to * qt_Opacity. It's 
> just unused here
> -//and connect themeChanged to update()
> +//if copying into another project don't forget to connect 
> themeChanged to update()
> +//but in SDDM that's a bit pointless

this version you have is probably is significantly faster (and in this case 
i'll shut up :p)

but wouldn't look cleaner to have something along the lines:

layer.enabled: true

  layer.effect: OpacityMask {
  maskSource: Rectangle {
  anchors.centerIn: parent
  width: imageWrapper.width
  height: width
  radius: width/2
  }
  }

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2399#45044, @davidedmundson wrote:
  
  > Screenshot as requested.
  >
  > F255167: Spectacle.h20090.png 
  >
  > Note the coloured icons for actions will be changing when Andreas pushes 
some change.
  >
  > Also I have some unresolved comments here: 
https://phabricator.kde.org/M58/178/
  
  
  what about white circles?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2399#44873, @apol wrote:
  
  > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.
  
  
  but also working QML code, that means, it must be maintained. if there are 
volunteers, awesome, if it stays there bitrotting, hmm, not so much

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: stylesheed folders

[Marco Martin]

On Thursday 11 August 2016 17:48:05 Ivan Čukić wrote:
> What does the window decoration have in common with a folder?
> 
> This is my screenshot:
> https://share.kde.org/index.php/s/l1eQjahyNee0sbO
> 

I liked the idea, but yeah, seeing it in action goes from "extremely cool"
to corner cases where it still really doesn't work, as the above screenshot

-- 
Marco Martin

[Differential] [Commented On] D2409: Update Color KCM

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  The KCM looks okay for a first iteration, although for the future, it would 
make more sense to design it like the Look And Feel or Desktop Theme KCMs, with 
a grid of bigger previews instead of list + one big preview.
  What I'd change right now is Config Scheme -> Edit Scheme
  
  For the editor app: The biggest problem is that it still looks and feels like 
a KCM or a config dialog, not like a proper application. That is okay for the 
first iteration, but in the future, it should be turned into a proper 
application layout (with a classical top toolbar, more spacing etc).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, andreask, #vdg
Cc: colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Screenshot as requested.
  
  F255167: Spectacle.h20090.png 
  
  Note the coloured icons for actions will be changing when Andreas pushes some 
change.
  
  Also I have some unresolved comments here: 
https://phabricator.kde.org/M58/178/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2341: Lazy guard for KServiceGroup::root() being null.

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPe1f5e0304d10: Lazy guard for 
KServiceGroup::root() being null. (authored by davidedmundson).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2341?vs=5645=5841

REVISION DETAIL
  https://phabricator.kde.org/D2341

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: stylesheed folders

[Ivan Čukić]

What does the window decoration have in common with a folder?

This is my screenshot:
https://share.kde.org/index.php/s/l1eQjahyNee0sbO

Cheers,
Ivan

[Differential] [Request, 10 lines] D2410: [wayland] Properly implement minimize of ShellClient

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  We need to call Workspace::clientHidden when minimizing. Otherwise
  Workspace doesn't update the active client and the now minimized
  window is still active.
  
  BUG: 366634

TEST PLAN
  Test case works now and also tested in nested setup that
  active window changes.

REPOSITORY
  rKWIN KWin

BRANCH
  minimize-shell-client

REVISION DETAIL
  https://phabricator.kde.org/D2410

AFFECTED FILES
  autotests/integration/shell_client_test.cpp
  shell_client.cpp
  shell_client.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

libtaskmanager, QIconItem, Timers cannot be stopped from internal code ?

[Michail Vourlakos]

Hello, I am using the new libtasksmanager with QIconItems for the tasks. 
For a few days I receive the following error when I close the 
plasmawindowed application:


QObject::~QObject: Timers cannot be stopped from another thread


and from plasmashell:

QObject::startTimer: Timers cannot be started from another thread

-

I believe both of them are by the same issue...

I created I test code that reproduces it, this is the main.qml from a 
simple test plasmoid:


by commenting the line
icon: decoration

the error stops...

by using PlasmaCore.IconItem it also stops...

-

import QtQuick 2.0
import org.kde.kquickcontrolsaddons 2.0 as KQuickControlAddons

import org.kde.taskmanager 0.1 as TaskManager

Item{

TaskManager.TasksModel {
id: tasksModel
}

ListView{
width:350
height:120

model: tasksModel
orientation: Qt.Horizontal

delegate: KQuickControlAddons.QIconItem{
width: 40
height: width

icon: decoration
}
}
}

-

[Differential] [Closed] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP817b27f44d4a: [Applet Configuration] Match 
category sidebar style with Breeze widget… (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2398?vs=5838=5839#toc

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5838=5839

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, andreaska, davidedmundson, #plasma
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 196 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5838.
broulik added a comment.


  Let Layouts do the size calculations more

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5834=5838

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, andreaska, davidedmundson, #plasma
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Looks great now, thank you for digging into the focus stuff!

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, andreaska, #plasma, davidedmundson
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  In https://phabricator.kde.org/D2409#45025, @andreaska wrote:
  
  > Thanks Oliver,
  >
  > can you post some screenshots cause I can't compile it.
  
  
  Updated

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, andreask, #vdg
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud updated the summary for this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, andreask, #vdg
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.


  Seems good.

INLINE COMMENTS

> AppletConfiguration.qml:219
> +
> +Column {
> +id: categories

If you make this this a ColumnLayout the layout's implicitWidth will be the 
size of the largest item, simplifiying line 167-176 to be a single line.

Your loop works, so only change it if you want to.

> ConfigCategoryDelegate.qml:87
> +opacity: { // try to match Breeze style hover handling
> +var active = categoriesScroll.activeFocus && Window.active
> +if (current) {

get rid of the && Window.active

it does nothing.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, andreaska, #plasma, davidedmundson
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2409: Update Color KCM

[andreaska (Andreas Kainz)]

andreaska added a comment.


  Thanks Oliver,
  
  can you post some screenshots cause I can't compile it.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, andreask, #vdg
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 5,159 lines] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud created this revision.
ochurlaud added reviewers: Plasma, mart, andreask, VDG.
ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As discussed with the VDG, the color KCM had to be split in a very simple KCM 
to choose a color scheme, and a color scheme editor.
  
  What is here?
  -
  
  - I rewrote/refactor almost all the code so that it's easier to understand 
(hopefully).
  - I created a standalone app to edit.
  
  Here are the current issues:
  
  
  1. I reuse the headers/cpp files of the standalone app in the kcm. It would 
be better to directly call the app, but then I don't know how to repopulate the 
list when I'm done with the app (see in KColorCm::on_schemeEditButton_clicked)
  
  2. The standalone app has not a correct name (How should I call the 
executable and the app?)
  
  3. The standalone app doesn't have all the KAboutData + CommandParser things, 
because I'm a little lazy.
  
  To test directly, you can use the branch `andreas/kcm_update`

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2409

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colorscm.cpp
  kcms/colors/colorscm.h
  kcms/colors/colorsettings.ui
  kcms/colors/schemeeditor.cpp
  kcms/colors/scmeditorcolors.cpp
  kcms/colors/scmeditorcolors.h
  kcms/colors/scmeditorcolors.ui
  kcms/colors/scmeditordialog.cpp
  kcms/colors/scmeditordialog.h
  kcms/colors/scmeditordialog.ui
  kcms/colors/scmeditoreffects.cpp
  kcms/colors/scmeditoreffects.h
  kcms/colors/scmeditoreffects.ui
  kcms/colors/scmeditoroptions.cpp
  kcms/colors/scmeditoroptions.h
  kcms/colors/scmeditoroptions.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma, mart, andreask, #vdg
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Animate removal from Positioner?

[Michail Vourlakos]

On 10/08/2016 09:23 μμ, Kai Uwe Broulik wrote:

Hi,

the thing with positioners like Grid and the like is that they're dumb, ie. the 
item is just gone right away and thus cannot be animated. ListView keeps the 
item around to animate it but is probably overkill for your usecase.


after 12 hours of development... I moved to ListView for this...
-- all the animations work now but I have set,

width: contentWidth
height: contentHeight

in the ListView, even though I dont quite like the approach...

thanks a lot everyone...

regards,
michail

[Differential] [Updated, 179 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5834.
broulik added a comment.


  Replicate fainter colors when window has no focus (QtQuick Controls don't do 
that unfortunately but the sidebar does that which is the most prominent part 
of the window, color-wise)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5832=5834

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Animate removal from Positioner?

[Michail Vourlakos]

A shaderitem that isn't live (so keeps the rendered item seemingly around),
use that to render the removal animation while the delegate is already deleted
could work.


in that case the next to it and before items would ingnore it, so the 
animation would be
very strange... it needs a lot workarounds for a simple onremove 
animation this to work

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

Martin Klapetek  changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #7 from Martin Klapetek  ---
I think better use-case is volume controls - if you play a music
and your volume is too high and you don't realize, the panicky
solution is always hit the volume down key. Now pressing that
down and holding it down should imho continuously lower the
volume rather than having the finger pressed down, realizing
this doesn't do much and you need to press it repeatedly. That
is, imho, subpar.

Also all other DEs work with single press-down, we probably
shouldn't be the weird kid.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  In https://phabricator.kde.org/D2399#44873, @apol wrote:
  
  > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.
  
  
  Maybe, but this patch is against the SDDM theme that was nearly in 5.7, the 
old theme was already deleted. 
  It can be restored, but it's a bit irrelevant wrt to this patch.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: stylesheed folders

[kainz.a]

the contrast shouldn't be the problem cause I'd like to use the select
background color (already done) and the select text color (not selected now)

sebas screenshot. look the same at my desktop. it would be a bug that was
shown with the stylesheed stuff.

Yes it is something like cause we can, but also the design of the desktop
is cleaner (without some bugs), cause the window decoration, the plasma
theme task manager, the select something in dolphin the dolphin folder
icons all have the same color.

about colored icons, with the breeze folder icons you didn't see that much
difference between folder icon and blue folder icon also the difference to
folder cyan isn't that big.

I'm not sure if I sould add or remove this feature cause on one hand it is
very nice to have a consistent desktop and on the other hand it's something
new where we don't ask the user and where some bugs need to be fixed.

cheers
Andreas

[Differential] [Updated, 171 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.
broulik updated this revision to Diff 5832.
broulik added a comment.


  When tabbing through the dialog, ensure the item with focus is visible, 
scrolling if neccessary

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5829=5832

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: stylesheed folders

[Ivan Čukić]

+1 (for sebas' comment, not for the rainbow folders)

I don't mind the idea of being able to customize folder colours, but I
don't think that it should be done like this - we do not have the
'folder colour' settings in the colour scheme settings, which
means that some other colour will be used to do this (bad idea!).

We have had more than a few problems in plasma theming that came from
"we can use this element for something completely irrelevant, because
it looks pretty with the default theme".

Cheers,
Ivan

p.s. The message with the screenshot of what it looks like for me is
waiting for moderator approval.

Re: stylesheed folders

[Sebastian Kügler]

On Thursday, August 11, 2016 12:17:49 PM UTC Sebastian Kügler wrote:

> Did you test this with app-specific color schemes?
> This I assume is only for the default folders, but what about the folder
> icons that are already colored? If I'm using a green folder, and then
> change the highlight color to something green, the contrast between the
> green and normal folders is lost.

Also, folders with overlay previous look weirdly out of place now, see 
attached screenshot. (This could be a caching issue?)
-- 
sebas

http://www.kde.org | http://vizZzion.org

Minutes Monday Plasma Hangout

[Sebastian Kügler]

Sorry for the delay...

Minutes Plasma 'hangout', 8-8-2016, 12:00 CET

Present: mgraesslin, bshah, Sho, sebas, notmart, Riddell, romangg,  kbroulik

bshah:
* cleaned up patch to powerdevil: https://phabricator.kde.org/D2369
* Debugging the kaccounts and spacebar on phone

Sho:
- Minor changes to Qt Quick hover handling patch, got +2 to land in Qt 5.6.x 
and up now ...
- Rewrote the way hover handling activation and first geometry export to kwin 
in task delegates works, should be more reliable across Qt versions
- Fixed drag-onto-task-delegate-to-raise with one specific options combination
- Did UI and fixes work on Netrunner's Simple Menu launcher menu (scratch/
hein/simplemenu.git)
- Made a Konversation 1.6.2 hotfix release due to a prominent crash
- Various code review (FV patches, ..) and working with the GSoC student
- Bit of downtime due to minor food poisoning last week

mgraesslin:
* fixed the translucence/window move bug
* investigated and fixed why plasma doesn't pick up that compositing is on at 
startup
* Libinput touchpad gesture support added - how should we use it?
* libinput requirement raised to 1.2 in order to support wacom tablets in 
future
* Changed default background of lockscreen to the one requested by VDG
* fixed a few problems causing Xwayland to crash in nested setup
* new test infrastructure for mocked OpenGL - first test for GLPlatform.
* removal of unredirect fullscreen merged
* fixed incorrect pointer enter events
* ksmserver logout greeter refactoring waiting for reviews
* Launcher through modifier key - up for review D2356 and D2357

notmart:
* work on look and feel creator application
* separate lnf branch: make possible to pass the applet geometry in scripting, 
have to merge this week
** support to pass the applet size in applet creation in ContainmentInterface 
in plasma-framework
* new ksplash
* kirigami: fixed bugs in the bottom action buttons (investigating on a bug of 
undetected binding loop still), release should happen this week then
* merged kglobalaccel changes, please test if works well enough
* fixed some problems with the new multiscreen handling in plasmashell: 
removing a primary screen caused problems

Riddell:
* finalize the Plasma 5.8 schedule
* what is needed in Neon

romangg:
* https://phabricator.kde.org/D2370 first version of atomic mode setting on 
review \o/

kbroulik:
* Added back mnemonics (underlined letters) for task manager context menu, got 
lost in the port
* Plasma NM indicates flight mode in its icon now
* Worked on allowing Kicker to re-populate context menus asynchronously so we 
can bring back the "Uninstall app" context menu.


sebas:
* libkscreen bugfixing:
* fixed interesting CRTC problem https://phabricator.kde.org/D2336
* open review: https://phabricator.kde.org/D2330
* worked with marco to make plasmashell's primary display behave (notmart 
rocks.)
* bug triaging, especially dock usecases
* general situation: really happy with last week's progress, it works reliable 
on the systems here now
* please test!

-- 
sebas

http://www.kde.org | http://vizZzion.orgMinutes Plasma 'hangout', 1-8-2016, 12:00 CET

Present: mgraesslin, bshah, Sho, sebas, notmart, Riddell, romangg,  kbroulik

bshah:
* cleaned up patch to powerdevil: https://phabricator.kde.org/D2369
* Debugging the kaccounts and spacebar on phone

Sho:
- Minor changes to Qt Quick hover handling patch, got +2 to land in Qt 5.6.x 
and up now ...
- Rewrote the way hover handling activation and first geometry export to kwin 
in task delegates works, should be more reliable across Qt versions
- Fixed drag-onto-task-delegate-to-raise with one specific options combination
- Did UI and fixes work on Netrunner's Simple Menu launcher menu 
(scratch/hein/simplemenu.git)
- Made a Konversation 1.6.2 hotfix release due to a prominent crash
- Various code review (FV patches, ..) and working with the GSoC student
- Bit of downtime due to minor food poisoning last week

mgraesslin:
* fixed the translucence/window move bug
* investigated and fixed why plasma doesn't pick up that compositing is on at 
startup
* Libinput touchpad gesture support added - how should we use it?
* libinput requirement raised to 1.2 in order to support wacom tablets in future
* Changed default background of lockscreen to the one requested by VDG
* fixed a few problems causing Xwayland to crash in nested setup
* new test infrastructure for mocked OpenGL - first test for GLPlatform.
* removal of unredirect fullscreen merged
* fixed incorrect pointer enter events
* ksmserver logout greeter refactoring waiting for reviews
* Launcher through modifier key - up for review D2356 and D2357

notmart:
* work on look and feel creator application
* separate lnf branch: make possible to pass the applet geometry in scripting, 
have to merge this week
** support to pass the applet size in applet creation in ContainmentInterface 
in plasma-framework
* new ksplash
* kirigami: fixed bugs in the bottom action buttons 

Re: stylesheed folders

[Sebastian Kügler]

On Thursday, August 11, 2016 12:58:25 AM UTC kainz.a wrote:
> since a few days you can find in breeze-icons the posibility that folders
> follow the color scheme colors. 
> 
> https://kdeonlinux.wordpress.com/2016/08/08/rainbow-folders/
> 
> As visual changes for folders are very importend for the user (visible in
> dolphin quite often) I'd like to discuss if we should use the stylesheed
> color.
> 
> pro
> + unified layout the plasma theme, window decoration follow the color scheme
> + distros can brand default breeze easy without fork it
> + plasma designer get more power
> + no visual changes for the default color schemes (breeze and breeze-dark)
> 
> con
> - new features mean new bugs (select folder in dolphin)
> - visual changes via update. user can't switch to old blue folders
> 
> feedback is very welcome. please test the new feature it wasn't released in
> kf 5.25 it's only inmaster

I think the point of allowing icons to be styled was to improve contrast for 
monochrome icons. For at least three of the 7 colors you give as example in 
your blog, the contrast is actually reduced, so they're harder to recognize.
The lowest row with the grey overlay looks actually broken to me. 

For folders, I don't see a real usecase other than "because we can". Am I 
missing something?

Did you test this with app-specific color schemes?
This I assume is only for the default folders, but what about the folder icons 
that are already colored? If I'm using a green folder, and then change the 
highlight color to something green, the contrast between the green and normal 
folders is lost.
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Review Request 128313: useraccount icons 128 px and sorted

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128313/#review98313
---



Some names are now not centered under their images. Could you please either 
also add the same amount of spaces at the end, or change the code to strip 
spaces before displaying?

- Christoph Feck


On July 4, 2016, 8:23 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128313/
> ---
> 
> (Updated July 4, 2016, 8:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> all user account icons are now 128px in size in addition they were renamed to 
> get a good preview (grid layout) and a nice sorting. the svg files were 
> changed to svgz
> 
> 
> Diffs
> -
> 
>   kcms/useraccount/pics/Ada Lovelace.png 0fdda9f 
>   kcms/useraccount/pics/Alice in Wonderland.png 35e680a 
>   kcms/useraccount/pics/Blackbox.png 34ea61b 
>   kcms/useraccount/pics/Dragon.png f9db690 
>   kcms/useraccount/pics/Grace Hopper.png eeb51a0 
>   kcms/useraccount/pics/Green.png 3594e67 
>   kcms/useraccount/pics/Happy.png def7cbd 
>   kcms/useraccount/pics/Kati.png 6060fb2 
>   kcms/useraccount/pics/Konqui.png 1116764 
>   kcms/useraccount/pics/Leonardo da Vinci.png 6eedda1 
>   kcms/useraccount/pics/Listening.png ad9c595 
>   kcms/useraccount/pics/Logger.png 6c843ff 
>   kcms/useraccount/pics/Mahatma Gandhi.png feab431 
>   kcms/useraccount/pics/Mowgli jungle book.png ab3f4b3 
>   kcms/useraccount/pics/Notme.png 960c0f8 
>   kcms/useraccount/pics/Parley.png 33fdb84 
>   kcms/useraccount/pics/Rekonqui.png 4003e9e 
>   kcms/useraccount/pics/TV.png c46f82d 
>   kcms/useraccount/pics/User.png 6e4624b 
>   kcms/useraccount/pics/bomb.png 9ef2232 
>   kcms/useraccount/pics/sources/Ada Lovelace.svg 293bc74 
>   kcms/useraccount/pics/sources/Alice in Wonderland.svg e163c6f 
>   kcms/useraccount/pics/sources/Dragon.svg 2575e4c 
>   kcms/useraccount/pics/sources/Grace Hopper.svg 00e241f 
>   kcms/useraccount/pics/sources/Kati.svg a5a5645 
>   kcms/useraccount/pics/sources/Konqui.svg 191aa4d 
>   kcms/useraccount/pics/sources/Leonardo da Vinci.svg 2fdf2f2 
>   kcms/useraccount/pics/sources/Logger.svg 0c75a70 
>   kcms/useraccount/pics/sources/Mahatma Gandhi.svg 35cc122 
>   kcms/useraccount/pics/sources/Mowgli jungle book.svg cfd38c8 
>   kcms/useraccount/pics/sources/Parley.svg 7ad4359 
>   kcms/useraccount/pics/sources/Rekonqui.svg 4e372d9 
>   kcms/useraccount/pics/sources/User.svg 71d044d 
>   kcms/useraccount/pics/sources/blackbox.svgz d6899f1 
>   kcms/useraccount/pics/sources/bomb.svgz 771f6d2 
>   kcms/useraccount/pics/sources/green.svgz 2d43069 
>   kcms/useraccount/pics/sources/happy.svgz 7c9fc49 
>   kcms/useraccount/pics/sources/listening.svgz 7e0e5ef 
>   kcms/useraccount/pics/sources/notme.svgz 5b4a474 
>   kcms/useraccount/pics/sources/tv.svgz d666506 
> 
> Diff: https://git.reviewboard.kde.org/r/128313/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> File Attachments
> 
> 
> new layout
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/28/8605b935-8113-4d1c-a7bc-65961b2e0c25__change_your_face.png
> pic folder from /kcms/useraccount/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/06/28/78aff0aa-1814-4f80-8e35-df69510c03c2__pics.zip
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

Re: Animate removal from Positioner?

[Sebastian Kügler]

On Wednesday, August 10, 2016 8:24:15 PM UTC Marco Martin wrote:
> On Wednesday 10 August 2016 21:18:43 Michail Vourlakos wrote:

> > I am creating an alternative plasmoid for tasks and I would like your
> > wisdom around QML please..
> > 
> >
> > At some point of my code I am using a Grid(Positioner) and a Repeater
> > for the tasksModel but I can not find any way to animate the removal of
> > an item from the tasks model. There are add, move, populate transitions
> > but not for removals..
> 
> that's because when you remove it the thing gets deleted.
> the only way would be to execute such removal in an imperative way, having
> an  animation instance in the item, then calling item.animateRemoval()
> 
> but i guess if the removal happens because the model already removed the
> item,  that won't help you, because the instant the item goes away from the
> model, your delegate is deleted, so i don't see (clean) solutions

A shaderitem that isn't live (so keeps the rendered item seemingly around), 
use that to render the removal animation while the delegate is already deleted 
could work.
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/
---

(Updated Aug. 11, 2016, 11:49 vorm.)


Review request for Plasma, David Rosca and Hugo Pereira Da Costa.


Changes
---

Don't paint focus line for QQC buttons


Repository: breeze


Description
---

This enables painting the focus underline also for QtQuick Controls and fixes 
an off-by-one error which caused the line to be rendered outside the QtQuick 
Controls canvas and was thus invisible.


Diffs (updated)
-

  kstyle/breezestyle.cpp 12a2f35 

Diff: https://git.reviewboard.kde.org/r/128654/diff/


Testing
---

Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
(like the widgets logic) does, so we now get a faint blue line (hard to tell 
with default colorscheme) at the bottom of QQC push buttons :(


File Attachments


Focus underline
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
Spurious focus underline in Honeycomb
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png


Thanks,

Kai Uwe Broulik

[Differential] [Request, 25 lines] D2407: [libinput] Expose all input devices through DBus

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The Connection exposes a new service called org.kde.KWin.InputDevice
  and every Device registers an own object exposing all properties.
  
  This allows an external configuration tool to change the behavior of
  the devices at runtime. E.g. to test configuration settings.

REPOSITORY
  rKWIN KWin

BRANCH
  input-device-dbus

REVISION DETAIL
  https://phabricator.kde.org/D2407

AFFECTED FILES
  autotests/libinput/CMakeLists.txt
  libinput/connection.cpp
  libinput/device.cpp
  libinput/device.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/#review98311
---



>Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
>(like the widgets logic) does, so we now get a faint blue line (hard to tell 
>with default colorscheme) at the bottom of QQC push buttons :(

option->styleObject && option->styleObject->property("elementType") == 
QLatin1String("button")

- David Edmundson


On Aug. 11, 2016, 11:25 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128654/
> ---
> 
> (Updated Aug. 11, 2016, 11:25 a.m.)
> 
> 
> Review request for Plasma, David Rosca and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> This enables painting the focus underline also for QtQuick Controls and fixes 
> an off-by-one error which caused the line to be rendered outside the QtQuick 
> Controls canvas and was thus invisible.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 12a2f35 
> 
> Diff: https://git.reviewboard.kde.org/r/128654/diff/
> 
> 
> Testing
> ---
> 
> Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
> (like the widgets logic) does, so we now get a faint blue line (hard to tell 
> with default colorscheme) at the bottom of QQC push buttons :(
> 
> 
> File Attachments
> 
> 
> Focus underline
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
> Spurious focus underline in Honeycomb
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Updated, 143 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5829.
broulik added a comment.


  Disable activeFocusOnTab for the content ScrollView, when tabbing from the 
categories bar we should focus the first control in the page rather than the 
content ScrollView (it having focus isn't even visible because it doesn't have 
a frame)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5827=5829

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/
---

Review request for Plasma, David Rosca and Hugo Pereira Da Costa.


Repository: breeze


Description
---

This enables painting the focus underline also for QtQuick Controls and fixes 
an off-by-one error which caused the line to be rendered outside the QtQuick 
Controls canvas and was thus invisible.


Diffs
-

  kstyle/breezestyle.cpp 12a2f35 

Diff: https://git.reviewboard.kde.org/r/128654/diff/


Testing
---

Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
(like the widgets logic) does, so we now get a faint blue line (hard to tell 
with default colorscheme) at the bottom of QQC push buttons :(


File Attachments


Focus underline
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
Spurious focus underline in Honeycomb
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png


Thanks,

Kai Uwe Broulik

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F254921: Screenshot_20160811_125837.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 140 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5827.
broulik added a comment.


  More closely match focus behavior of Breeze widget style:
  Only if the sidebar has focus and the item is current will it get intense 
blue, white text and selected icon state, otherwise it's a fainter blue with 
black text

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5826=5827

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 111 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5826.
broulik added a comment.


  Implement focus handling for category sidebar to match System Settings:
  
  - If it has focus the line uses a strong blue and arrow keys can be used to 
switch between pages
  - If it has no focus, the line is fainter
  - Clicking a category button gives it focus

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2398?vs=5816=5826

REVISION DETAIL
  https://phabricator.kde.org/D2398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F254909: Screenshot_20160811_124328.png  
Fainter blue when it doesn't have focus

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2404: [Task Manager ToolTipDelegate] If there's room, show two lines of window title

[andreaska (Andreas Kainz)]

andreaska added a comment.


  is it possible to have the text two lines the same height than the app icon?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2404

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: andreaska, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 4 lines] D2404: [Task Manager ToolTipDelegate] If there's room, show two lines of window title

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If no subtext is shown (nowadays the common case, before we were displaying 
useless information like "on all desktops" although there was only one etc) 
there's room for two lines of window title text.

TEST PLAN
  As suggested by Andreas. Verified with and without subtext
  
  F254860: Screenshot_20160811_115822.png 
  
  F254861: Screenshot_20160811_115842.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2404

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > In System Settings, the full highlight color is only used on the sidebar 
when it is currently focused
  
  Yeah, noticed that, but focus handling in QML is just broken beyond repair so 
I didn't bother with that.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Selecting a Plasma logo

[Ivan Čukić]

Hi all,

For anyone interested I've also posted the SVG file (Andreas asked for it):

https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp

Cheers,
Ivan

[Differential] [Commented On] D2345: use a separate configuration per look and feel

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> mart wrote in shellcorona.cpp:550
> I hate this method.
> tough, i need a way from the kcm to reset the current layout to the default.
> it's quite dangerous and exporting a dbus method that effectively destroys 
> the current config is evil...
> other ideas?

I agree with Martin. If the user is crazy enough...

D-Bus was never really meant to be something that the users should be calling 
directly anyhow.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[andreaska (Andreas Kainz)]

andreaska accepted this revision.
andreaska added a reviewer: andreaska.
andreaska added a comment.
This revision is now accepted and ready to land.


  +1 for the design improvement

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I'm glad that you're fixing this inconsistency!
  
  Just for clarification since it can't be seen from the screenshots: In System 
Settings, the full highlight color is only used on the sidebar when it is 
currently focused. When the main window area is focused (initially when the 
sidebar is shown, or when interacting with the main content), the hover 
highlight visualization is used in the sidebar.
  
  Is that the same in your patch?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 84 lines] D2402: [wayland] Unset focused keyboard surface when handling key event internally

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  So far when KWin intercepted a key event a leave was not sent to the
  Wayland surface currently having keyboard focus. This could result in
  the Wayland application to start repeating keys. E.g.
  
  1. application gets key press event
  2. This triggers an internal window to show
  3. key release goes to KWin internal window
  4. application starts to repeat key as there is no release
  
  With this change whenever KWin intercepts the key event e.g. due to
  
  - internal window
  - Effects grabbing key event
  - Tabbox
  
  the focused keyboard surface is set to null, thus triggering a leave
  event and the client not starting to repeat the event.

REPOSITORY
  rKWIN KWin

BRANCH
  internal-window-unset-focus-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D2402

AFFECTED FILES
  autotests/integration/internal_window.cpp
  autotests/integration/kwin_wayland_test.h
  autotests/integration/test_helpers.cpp
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F254624: Screenshot_20160811_093330.png 
  Also on low-dpi looks identical to System Settings spacing-wise

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

--- Comment #6 from Martin Gräßlin  ---
> So KWin/Wayland requires non-Qt applications to link with KGlobalAccel to 
> register shortcuts ?

This is getting off-topic.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 70 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 11 Aug 2016 07:08:13 +
Build duration: 10 min

CHANGE SET
Revision 092aeb53d36e5d7f9bdf937b5fdb3388e8eaebe1 by kde: ([Pager] Hide 
minimized windows)
  change: edit applets/pager/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 70 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 11 Aug 2016 07:08:13 +
Build duration: 10 min

CHANGE SET
Revision 092aeb53d36e5d7f9bdf937b5fdb3388e8eaebe1 by kde: ([Pager] Hide 
minimized windows)
  change: edit applets/pager/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2289/3359 
(68%)CONDITIONAL 1556/3766 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 624/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Matthias Fauconneau via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

--- Comment #5 from Matthias Fauconneau  ---
I think notifying release events would be a better solution since it would
allow smoother/finer brightness adjustments than the low rate of key
repeats.

So KWin/Wayland requires non-Qt applications to link with KGlobalAccel to
register shortcuts ?


On Thu, Aug 11, 2016 at 7:11 AM, Martin Gräßlin via KDE Bugzilla <
bugzilla_nore...@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=366608
>
> --- Comment #4 from Martin Gräßlin  ---
> KGlobalAccel actions are only triggered on press events. There is no
> additional
> call when they are released.
>
> I played a little bit with my system and there the brightness key sends
> press/release combos constantly when being hold.
>
> > I think not repeating global shortcuts is the correct behaviour. Still
> it would make sense for PowerDevil to be notified when the shortcut is
> released.
>
> I'm not sure how we can combine those two. I either make it ignore repeat
> events or make it always trigger. To support this we would have to extend
> kglobalaccel to add a flag "allow repeat".
>
> > Also, where is the KGlobalAccel D-Bus interface documentation ?
>
> Nowhere, it's an internal detail of the KGlobalAccel framework and not a
> public
> and stable dbus interface.
>
> --
> You are receiving this mail because:
> You reported the bug.
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

--- Comment #4 from Martin Gräßlin  ---
KGlobalAccel actions are only triggered on press events. There is no additional
call when they are released.

I played a little bit with my system and there the brightness key sends
press/release combos constantly when being hold.

> I think not repeating global shortcuts is the correct behaviour. Still it 
> would make sense for PowerDevil to be notified when the shortcut is released.

I'm not sure how we can combine those two. I either make it ignore repeat
events or make it always trigger. To support this we would have to extend
kglobalaccel to add a flag "allow repeat".

> Also, where is the KGlobalAccel D-Bus interface documentation ?

Nowhere, it's an internal detail of the KGlobalAccel framework and not a public
and stable dbus interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D2396: [Pager] Hide minimized windows

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP092aeb53d36e: [Pager] Hide minimized windows 
(authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2396?vs=5811=5819

REVISION DETAIL
  https://phabricator.kde.org/D2396

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: Zren, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D2345: use a separate configuration per look and feel

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> mart wrote in shellcorona.cpp:550
> I hate this method.
> tough, i need a way from the kcm to reset the current layout to the default.
> it's quite dangerous and exporting a dbus method that effectively destroys 
> the current config is evil...
> other ideas?

You could do it like in KWin: make the KCM trigger a DBus signal which 
Plasmashell triggers to.

In the end it's going to be the same: one can destroy the current config 
through dbus, but it's not that exposed. Also I don't think it matters: if a 
user decides to shoot himself in the foot by manually triggering the DBus 
signal, let him.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Matthias Fauconneau via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

--- Comment #3 from Matthias Fauconneau  ---
I think not repeating global shortcuts is the correct behaviour.
Still it would make sense for PowerDevil to be notified when the shortcut
is released.
I am not clear on how KGlobalAccel signals actions.
Maybe it could just send another signal when a shortcut is released.
Maybe on the condition a flag is set when setting the shortcut.

I understand that disappointingly there is no plan for desktop-agnostic
global shortcut registration.
But at least it would be useful to have the KGlobalAccel D-Bus interface
less Qt specific to allow for easier cross toolkit integration.
Also, where is the KGlobalAccel D-Bus interface documentation ?

On Thu, Aug 11, 2016 at 5:58 AM, Martin Gräßlin via KDE Bugzilla <
bugzilla_nore...@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=366608
>
> --- Comment #2 from Martin Gräßlin  ---
> Just checked, kwin explicitly ignores key repeat events to trigger global
> shortcuts
>
> --
> You are receiving this mail because:
> You reported the bug.
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Selecting a Plasma logo

[Ivan Čukić]

Hi,

When I said that I don't really find any of these fitting as a
launcher icon, I obviously excluded the K-gear logo - was thinking
about the new proposals.

Though, the fact that K-gear looks better than the rest might be
because we are all accustomed to that one. The same goes for the
current Plasma logo, even if it is really off-balance (mind that this
is the original, not the altered one Clemens sent).


Cheers,
Ivan