[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

[Sebastian Kügler]

sebas updated this revision to Diff 5988.
sebas added a comment.


  - constness

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2465?vs=5987=5988

BRANCH
  sebas/lidopeninit

REVISION DETAIL
  https://phabricator.kde.org/D2465

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

[Sebastian Kügler]

sebas updated this revision to Diff 5987.
sebas added a comment.


  - --unused vars

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2465?vs=5986=5987

BRANCH
  sebas/lidopeninit

REVISION DETAIL
  https://phabricator.kde.org/D2465

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 109 lines] D2465: [kded] correctly restore lidOpened configuration on startup

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When shutting down the machine (or kded5, really) with the lid closed
  will leave a config with the laptop panel disabled, and also a config
  with the same id, but _lidOpened appended. The latter is the config that
  is restored when the lid is opened again. When the lid is opened while
  kded wasn't running (shut down), the config with the panel disabled is
  restored.
  
  We do want to restore the _lidOpened config, so check if it exists, and
  if it does, move it to the configId to have it restored.
  
  This effectively avoids a disabled laptop panel after the laptop has
  been shut down with an external monitor connected and the lid closed.
  
  BUG:353029

TEST PLAN
  - added autotest for this case
  - reproduced bug by killing kded with an external output connected and the 
laptop lid closed, after opening the lid, kded would correctly enable the 
laptop display on startup

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/lidopeninit

REVISION DETAIL
  https://phabricator.kde.org/D2465

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 128702: Use default weight rather than normal weight

[Jacopo De Simoi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128702/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Honor the choice of a user that has chosen a custom weight (e.g. light)
as default weight


Diffs
-

  applets/digital-clock/package/contents/ui/DigitalClock.qml 
48a310052eead844c2d7dbc22ee924a971733881 

Diff: https://git.reviewboard.kde.org/r/128702/diff/


Testing
---


Thanks,

Jacopo De Simoi

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

> On Aug. 16, 2016, 7:48 p.m., Marco Martin wrote:
> > I like it!
> > (btw, the blurred version wouldn't be needed anymore with the new design)

I meant to ask because I read something about this, and I can't for the life of 
me find the blog post about it;
Do both the lock screen and the login screen automatically use a blurred 
version of the wallpaper, or should I remove the blurred wallpaper entirely 
from the build scripts?


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98416
---


On Aug. 16, 2016, 7:26 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128699/
> ---
> 
> (Updated Aug. 16, 2016, 7:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.8
> 
> Bringing back some colour to our wallpapers - they kept getting darker and 
> some people were disappointed at that, so for the 5.8 LTS I think we can 
> celebrate a bit. 
> 
> This wallpaper will also be available in 4K resolution.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/128699/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
> preview.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Matthias Fauconneau via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

--- Comment #10 from Matthias Fauconneau  ---
1)
Works for me with Brightness Up (F7), Volume Down (F9) and Up (F10).
But strangely Brightness Down (F6) still does not repeat.
I see no difference between the keys (libinput-debug-events) and the
shortcuts (Global Keyboard Shortcuts).
Is there a way to gain more insight in this issue ?

2)
The typically long key repeat delay still makes this suboptimal, especially
in the urgent volume down case.
If handling pressed shortcut on the client side (Powerdevil, KMix) is too
complicated, would it be possible to skip the delay and repeat directly
based on the key repeat rate ?

On Mon, Aug 15, 2016 at 5:43 PM, Martin Gräßlin via KDE Bugzilla <
bugzilla_nore...@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=366608
>
> Martin Gräßlin  changed:
>
>What|Removed |Added
> 
> 
>  Status|CONFIRMED   |RESOLVED
>  Resolution|--- |FIXED
>   Latest Commit||
> http://commits.kde.org/kwin
>|
> |/b9c98bd2b977bd68d79240
>||ac4d60fcadc96b
>
> --- Comment #9 from Martin Gräßlin  ---
> Git commit b9c98bd2b977bd68d79240ac4d60fcadc96b by Martin Gräßlin.
> Committed on 15/08/2016 at 15:39.
> Pushed by graesslin into branch 'master'.
>
> Trigger global shortcuts also on key-repeat
>
> Summary:
> Restores feature parity with X11. Global shortcuts need to trigger
> also for repeat events. An example is the volume key or screen
> brightness.
>
> For other shortcuts like showing yakuake it does not make sense to
> trigger on repeat. Thus a long term solution is to add a flag to
> global shortcuts whether the key should trigger on repeat.
>
> Reviewers: #kwin, #plasma_on_wayland
>
> Subscribers: plasma-devel, kwin
>
> Tags: #plasma_on_wayland, #kwin
>
> Differential Revision: https://phabricator.kde.org/D2413
>
> M  +1-1input.cpp
>
> http://commits.kde.org/kwin/b9c98bd2b977bd68d79240ac4d60fcadc96b
>
> --
> You are receiving this mail because:
> You reported the bug.
>

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Help needed - Discussion concerning panels

[Michail Vourlakos]

the panel can expose a size hint, but it's the user that decides what is the
wiggle room of it.
if on the panel controller you put with the handles a very small minimum size
and a big maximum size, then the panel should be able to resize itself within
those limits
Let's say that the panel is at the bottom... I centered the panel and I 
used the handles

to go the minimum to the lowest and maximum at the edges of the screen.
For the root item in main.qml I used:

implicitWidth:300
Layout.minimumWidth: 300

but the panel does not grow its width...

In that case, that the panel is at the bottom, is it possible to adjust 
the height
of the panel or is only the user's setting? In my case because of the 
zoom effect
for the icons I would like theheight of the panel to be normal and when 
the animation

starts to grow its height.


no, not for panel containments, i would not be sure how to make a normal config
dialog available
this isnt a necessity if it is possible next to the default 
configuration that is shown
for the panel I could also shown my own for the settings needed. Is this 
possible?

How a new-implemented panel can show its own configurations?



this should be added into plasmashell, and may be a good idea
(would just be by setting plasmoid.backgroundHints to none)
I would like to try to add that, but should be a Plasma 5.9 feature i think


time is not essential for this... whenever you manage to add this we
will thank you! :)


---
concerning this development choice of implementing Now Dock as a panel 
instead of

a plasmoid I cant see any benefits yet... Am I wrong?
  Pros that do not meet:
1. I was hoping that I could at least set the height of the panel based 
on the visuals needs

  Pros that will be met:
1. enable transparency for the panel without changing the workspace theme

  Cons in question:
1. The user preferences how can be implemented in a panel environment (???)


Thanks a lot!!!

regards,
michail

Re: Help needed - Discussion concerning panels

[Marco Martin]

On Wednesday 17 August 2016 00:13:08 Michail Vourlakos wrote:
> 1. This panel should be able to set its size(width and height) according
> to the visual which is shown. I tried,
> 
> Layout.*widths and Layout.*heights to set them in a fixed size but
> nothing happened.
> 
> Is it possible to do that? to set the panels size with enforcement?

the panel can expose a size hint, but it's the user that decides what is the 
wiggle room of it.
if on the panel controller you put with the handles a very small minimum size 
and a big maximum size, then the panel should be able to resize itself within 
those limits

> 
> 2. The panel which was created is the default empty panel which is used
> in Plasma. When I right click my visual to go to old configuration
> dialog of the plasmoid instead of the configuration window, the panel's
> settings are appearing next to the panel (Add widgets, set size, etc)...
> is it possible to override this? or open the old configuration dialog?

no, not for panel containments, i would not be sure how to make a normal config 
dialog available

> 3. Is it possible to tell the panel to not draw its background, as the
> plasmoids can do? in order to support transparency? but keep the
> plasma's theme untouched?

this should be added into plasmashell, and may be a good idea
(would just be by setting plasmoid.backgroundHints to none)
I would like to try to add that, but should be a Plasma 5.9 feature i think

-- 
Marco Martin

Help needed - Discussion concerning panels

[Michail Vourlakos]

Hello everyone,


I have some questions concerning plasma panels and I hope you could 
help. A small brief, I implemented the Now Dock plasmoid which can be 
found in kdelook. There is a discussion that this should be a panel of 
its one. In other words not (in panel) but a panel. I changed the 
metadata.desktop file accordingly and now the new panel is shown. I add 
it in my environment and I can see a panel which contains the visual of 
my plasmoid. But to move on I need some important steps to go from there.



1. This panel should be able to set its size(width and height) according 
to the visual which is shown. I tried,


Layout.*widths and Layout.*heights to set them in a fixed size but 
nothing happened.


Is it possible to do that? to set the panels size with enforcement?


2. The panel which was created is the default empty panel which is used 
in Plasma. When I right click my visual to go to old configuration 
dialog of the plasmoid instead of the configuration window, the panel's 
settings are appearing next to the panel (Add widgets, set size, etc)... 
is it possible to override this? or open the old configuration dialog?



3. Is it possible to tell the panel to not draw its background, as the 
plasmoids can do? in order to support transparency? but keep the 
plasma's theme untouched?



Thank you very much!


with regards,

michail

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

[Pascal d'Hermilly via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362830

--- Comment #1 from Pascal d'Hermilly  ---
yes/no ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98416
---



I like it!
(btw, the blurred version wouldn't be needed anymore with the new design)

- Marco Martin


On Aug. 16, 2016, 7:26 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128699/
> ---
> 
> (Updated Aug. 16, 2016, 7:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.8
> 
> Bringing back some colour to our wallpapers - they kept getting darker and 
> some people were disappointed at that, so for the 5.8 LTS I think we can 
> celebrate a bit. 
> 
> This wallpaper will also be available in 4K resolution.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/128699/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
> preview.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

Re: [PATCH 6/7] add kirigami icons as resource

[Marco Martin]

did some comments inline but would be better if this was done in phabricator

On Tuesday 16 August 2016 20:23:51 Martin Gysel wrote:
> alias="icons/document-decrypt.svg">breeze-icons/icons/actions/32/document-d
> ecrypt.svg + alias="icons/folder-sync.svg">breeze-icons/icons/actions/32/folder-sync.svg
>  + alias="icons/go-next.svg">breeze-icons/icons/actions/24/go-next.svg

don't use 24 pixels icons, they tend to scale badly on sizes used by the app

-- 
Marco Martin

Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/
---

Review request for Plasma.


Repository: breeze


Description
---

New wallpaper for Plasma 5.8

Bringing back some colour to our wallpapers - they kept getting darker and some 
people were disappointed at that, so for the 5.8 LTS I think we can celebrate a 
bit. 

This wallpaper will also be available in 4K resolution.


Diffs
-

  wallpapers/Next/contents/images/1024x768.png 60e1205 
  wallpapers/Next/contents/images/1280x1024.png 36a9130 
  wallpapers/Next/contents/images/1280x800.png c33e594 
  wallpapers/Next/contents/images/1440x900.png 2c75b54 
  wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
  wallpapers/Next/contents/images/1638x1024.png a3c7492 
  wallpapers/Next/contents/images/1680x1050.png eddc47e 
  wallpapers/Next/contents/images/1920x1080.png ab6d950 
  wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
  wallpapers/Next/contents/images/2560x1600.png eeb08a1 
  wallpapers/Next/contents/images/3200x1800.png 7340567 
  wallpapers/Next/contents/images/3200x2000.png fd1a62c 
  wallpapers/Next/contents/screenshot.png a6d2b7b 

Diff: https://git.reviewboard.kde.org/r/128699/diff/


Testing
---


File Attachments


2560x1600.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
preview.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
splash.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png


Thanks,

Ken Vermette

Re: more Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016 20:42:46 Martin Gysel wrote:
> Hi Marco
> The last time I sent patches, I quickly looked into getting a dev
> account but it seemed like quite an effort (in regards to the
> contributions I've done so far) and also if I understood it correctly
> once I have a dev account I would be able to commit to all kde repos,
> which sounds a little bit frightening...
> let's see how much contribution the future brings

don't be afraid :) (that's why we have a review procedure for the patches on 
phabricator)
the procedure is just filling out the form there
https://identity.kde.org/index.php?r=developerApplication

and you would be more than welcome!

-- 
Marco Martin

Re: more Kirigami patches

[Martin Gysel]

Am 16.08.2016 um 20:28 schrieb Marco Martin:
> On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote:
>> Hi
>> Here are some patches I have in my branch.
>> It contains a script to (re)generate the qml file, one the generate a
>> resource file with possibly used icons and one to generaste a qmltypes file.
>> It adds the icon resource to the pri file and updates the qml resource
>> file. Furthermore the library target in the pro file seems to miss a
>> kirigami dir level.
> 
> Hi,
> thank you for the patches.
> do you have a developer account? it would be way more efficient if you can 
> post 
> the patches on phabricator (https://phabricator.kde.org) then after they are 
> reviewed, you can push them in master
> 

Hi Marco
The last time I sent patches, I quickly looked into getting a dev
account but it seemed like quite an effort (in regards to the
contributions I've done so far) and also if I understood it correctly
once I have a dev account I would be able to commit to all kde repos,
which sounds a little bit frightening...
let's see how much contribution the future brings

/martin

Re: more Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote:
> Hi
> Here are some patches I have in my branch.
> It contains a script to (re)generate the qml file, one the generate a
> resource file with possibly used icons and one to generaste a qmltypes file.
> It adds the icon resource to the pri file and updates the qml resource
> file. Furthermore the library target in the pro file seems to miss a
> kirigami dir level.

Hi,
thank you for the patches.
do you have a developer account? it would be way more efficient if you can post 
the patches on phabricator (https://phabricator.kde.org) then after they are 
reviewed, you can push them in master

-- 
Marco Martin

more Kirigami patches

[Martin Gysel]

Hi
Here are some patches I have in my branch.
It contains a script to (re)generate the qml file, one the generate a
resource file with possibly used icons and one to generaste a qmltypes file.
It adds the icon resource to the pri file and updates the qml resource file.
Furthermore the library target in the pro file seems to miss a kirigami dir 
level.

/martin

[PATCH 3/7] add script to gen a qmltypes file

[Martin Gysel]

---
 scripts/gen_qmltypes.sh | 17 +
 1 file changed, 17 insertions(+)
 create mode 100755 scripts/gen_qmltypes.sh

diff --git a/scripts/gen_qmltypes.sh b/scripts/gen_qmltypes.sh
new file mode 100755
index 000..4ea0bc7
--- /dev/null
+++ b/scripts/gen_qmltypes.sh
@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+
+QMLPLUGINDUMP=${QMLPLUGINDUMP-qmlplugindump}
+
+case $1 in
+-h|--help)
+   echo "usage: $(basename $0) IMPORT_PATH"
+   echo "it uses either '$(which qmlplugindump)' or the one set by 
'QMLPLUGINDUMP'"
+   exit 1
+   ;;
+esac
+
+[[ -z ${1} ]] && { echo "no import path not given, exit"; exit 1; }
+
+echo "using '${QMLPLUGINDUMP}' as dump tool" >&2
+
+${QMLPLUGINDUMP} -noinstantiate -platform xcb org.kde.kirigami 1.0 "${1}"
-- 
2.9.3

[PATCH 5/7] fix target/library path in qmake project file

[Martin Gysel]

---
 kirigami.pro | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kirigami.pro b/kirigami.pro
index f7d6fe6..735376d 100644
--- a/kirigami.pro
+++ b/kirigami.pro
@@ -7,7 +7,7 @@ SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp
 
 API_VER=1.0
 
-TARGET = $$qtLibraryTarget(org/kde/kirigamiplugin)
+TARGET = $$qtLibraryTarget(org/kde/kirigami/kirigamiplugin)
 
 importPath = $$[QT_INSTALL_QML]/org/kde/kirigami
 target.path = $${importPath}
-- 
2.9.3

[PATCH 7/7] update qml resource file

[Martin Gysel]

---
 kirigami.qrc | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kirigami.qrc b/kirigami.qrc
index 63d64ac..fe4400f 100644
--- a/kirigami.qrc
+++ b/kirigami.qrc
@@ -7,12 +7,13 @@
 src/controls/AbstractListItem.qml
 src/controls/SplitDrawer.qml
 src/controls/Theme.qml
+src/controls/ToolBarApplicationHeader.qml
 src/controls/private/RefreshableScrollView.qml
+src/controls/private/PageActionPropertyGroup.qml
 src/controls/private/CornerShadow.qml
 src/controls/private/ActionButton.qml
 src/controls/private/DefaultListItemBackground.qml
 src/controls/private/EdgeShadow.qml
-src/controls/private/PageActionPropertyGroup.qml
 src/controls/OverlayDrawer.qml
 src/controls/OverlaySheet.qml
 src/controls/GlobalDrawer.qml
@@ -42,9 +43,11 @@
 src/styles/Plasma/Theme.qml
 src/styles/Plasma/Units.qml
 src/styles/Plasma/Icon.qml
+src/styles/Desktop/AbstractListItem.qml
 src/styles/Desktop/Theme.qml
 src/styles/Desktop/OverlayDrawer.qml
 src/styles/Desktop/Units.qml
+src/styles/Desktop/SwipeListItem.qml
 src/styles/Desktop/ApplicationWindow.qml
 src/styles/Desktop/Icon.qml
 src/styles/Desktop/AbstractApplicationHeader.qml
-- 
2.9.3

[PATCH 6/7] add kirigami icons as resource

[Martin Gysel]

---
 kirigami-icons.qrc | 13 +
 kirigami.pri   |  1 +
 2 files changed, 14 insertions(+)
 create mode 100644 kirigami-icons.qrc

diff --git a/kirigami-icons.qrc b/kirigami-icons.qrc
new file mode 100644
index 000..7f3ffa9
--- /dev/null
+++ b/kirigami-icons.qrc
@@ -0,0 +1,13 @@
+
+
+breeze-icons/icons/actions/32/application-menu.svg
+breeze-icons/icons/actions/32/document-decrypt.svg
+breeze-icons/icons/actions/32/folder-sync.svg
+breeze-icons/icons/actions/24/go-next.svg
+breeze-icons/icons/actions/24/go-previous.svg
+breeze-icons/icons/actions/24/go-up.svg
+breeze-icons/icons/actions/22/handle-left.svg
+breeze-icons/icons/actions/22/handle-right.svg
+breeze-icons/icons/actions/32/view-list-icons.svg
+
+
diff --git a/kirigami.pri b/kirigami.pri
index fc88c4c..43065ae 100644
--- a/kirigami.pri
+++ b/kirigami.pri
@@ -8,5 +8,6 @@ DEFINES += KIRIGAMI_BUILD_TYPE_STATIC
 API_VER=1.0
 
 RESOURCES += $$PWD/kirigami.qrc
+RESOURCES += $$PWD/kirigami-icons.qrc
 
 #QML_IMPORT_PATH += $$PWD
-- 
2.9.3

[PATCH 2/7] add script to find possible used icons in kirigami

[Martin Gysel]

---
 scripts/gen_icons_qrc.sh | 59 
 1 file changed, 59 insertions(+)
 create mode 100755 scripts/gen_icons_qrc.sh

diff --git a/scripts/gen_icons_qrc.sh b/scripts/gen_icons_qrc.sh
new file mode 100755
index 000..dff68df
--- /dev/null
+++ b/scripts/gen_icons_qrc.sh
@@ -0,0 +1,59 @@
+#!/usr/bin/env bash
+
+SRC_DIR="src/"
+BREEZEICONS_DIR="breeze-icons"
+ICONS_SIZES=(48 32 24 22)
+TAB=""
+
+kirigami_dir="$(dirname $(readlink -f $0))/.."
+
+case $1 in
+-h|--help)
+   echo "usage: $(basename $0)"
+   exit 1
+   ;;
+esac
+
+if [[ ! -d ${kirigami_dir}/${BREEZEICONS_DIR} ]]; then
+   echo "could not find ${BREEZEICONS_DIR}, please clone breeze-icons 
frist into ${BREEZEICONS_DIR}:"
+   echo "cd ${kirigami_dir} && git clone --depth 1 
git://anongit.kde.org/breeze-icons.git ${BREEZEICONS_DIR}"
+   exit 1
+fi
+
+pushd ${kirigami_dir} > /dev/null
+
+# find strings associated to variable with 'icon' in name and put them into an 
array
+if [[ -n $(which ag 2>/dev/null) ]]; then
+   possible_icons=($(ag --ignore Icon.qml --file-search-regex "\.qml" 
--only-matching --nonumbers --noheading --nofilename "icon.*\".+\"" ${SRC_DIR} 
| egrep -o "*\".+\""))
+   # try to find in Icon { ... source: "xyz" ... }
+   possible_icons+=($(ag --ignore Icon.qml --file-search-regex "\.qml" -A 
15 "Icon\s*{" ${SRC_DIR} | egrep "source:" | egrep -o "*\".+\""))
+else
+   possible_icons=($(find ${SRC_DIR} -name "*.qml" -and -not -name 
"Icon.qml" -exec egrep "icon.*\".+\"" {} \; | egrep -o "*\".+\""))
+fi
+
+# sort array and filter out all entry which are not a string ("...")
+IFS=$'\n' icons=($(sort -u <<<"${possible_icons[*]}" | egrep -o "*\".+\"" | 
sed 's/\"//g'))
+unset IFS
+
+#printf "%s\n" "${icons[@]}"
+
+# generate .qrc
+echo ""
+echo "${TAB}"
+
+for icon in ${icons[@]}; do
+   for size in ${ICONS_SIZES[@]}; do
+   file=$(find breeze-icons/icons/*/${size}/ -name "${icon}.*" 
-print -quit)
+
+   if [[ -n ${file} ]]; then
+   echo -e "${TAB}${TAB}${file}"
+   #echo ${file}
+   break
+   fi
+   done
+done
+
+echo "${TAB}"
+echo ""
+
+popd > /dev/null
-- 
2.9.3

[PATCH 4/7] improve kirigami dir detection

[Martin Gysel]

---
 scripts/gen_icons_qrc.sh | 2 +-
 scripts/gen_qml_qrc.sh   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/gen_icons_qrc.sh b/scripts/gen_icons_qrc.sh
index dff68df..164b807 100755
--- a/scripts/gen_icons_qrc.sh
+++ b/scripts/gen_icons_qrc.sh
@@ -5,7 +5,7 @@ BREEZEICONS_DIR="breeze-icons"
 ICONS_SIZES=(48 32 24 22)
 TAB=""
 
-kirigami_dir="$(dirname $(readlink -f $0))/.."
+kirigami_dir="$(cd $(dirname $(readlink -f $0))/.. && pwd)"
 
 case $1 in
 -h|--help)
diff --git a/scripts/gen_qml_qrc.sh b/scripts/gen_qml_qrc.sh
index 6e1c378..df61e07 100755
--- a/scripts/gen_qml_qrc.sh
+++ b/scripts/gen_qml_qrc.sh
@@ -2,7 +2,7 @@
 
 TAB=""
 
-kirigami_dir="$(dirname $(readlink -f $0))/.."
+kirigami_dir="$(cd $(dirname $(readlink -f $0))/.. && pwd)"
 
 case $1 in
 -h|--help)
-- 
2.9.3

[PATCH 1/7] add simple script to generate a qrc containing all qml files

[Martin Gysel]

---
 scripts/gen_qml_qrc.sh | 39 +++
 1 file changed, 39 insertions(+)
 create mode 100755 scripts/gen_qml_qrc.sh

diff --git a/scripts/gen_qml_qrc.sh b/scripts/gen_qml_qrc.sh
new file mode 100755
index 000..6e1c378
--- /dev/null
+++ b/scripts/gen_qml_qrc.sh
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+TAB=""
+
+kirigami_dir="$(dirname $(readlink -f $0))/.."
+
+case $1 in
+-h|--help)
+   echo "usage: $(basename $0) [QRC_FILE]"
+   exit 1
+   ;;
+esac
+
+pushd ${kirigami_dir} > /dev/null
+
+tmpfile=$(mktemp)
+
+echo "" > ${tmpfile}
+echo "${TAB}" >> ${tmpfile}
+
+for i in $(find src/controls/ -name *.qml); do
+   echo -e "${TAB}${TAB}${i}" >> 
${tmpfile};
+done
+for i in $(find src/styles/ -name *.qml); do
+echo -e "${TAB}${TAB}${i}" >> 
${tmpfile};
+done
+
+echo "${TAB}" >> ${tmpfile}
+echo "" >> ${tmpfile}
+
+if [[ -n $1 ]]; then
+   cat ${tmpfile} > $1
+else
+   cat ${tmpfile}
+fi
+
+unlink ${tmpfile}
+
+popd > /dev/null
-- 
2.9.3

[Differential] [Request, 442 lines] D2464: [effects] Add new effect for touch point visualization

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The new effect is based on the mouse click effect and uses the same
  rendering code (this could be improved by merging them better).
  
  Unlike mouse click there is no keyboard shortcut needed to activate:
  as soon as the effect is loaded all touch points are visualized.
  
  The visualization creates an animated circle for each touch down
  position, motion and up position. The ids are tracked and each touch
  id gets the same color. The first ten different touch ids get a
  different color. As touch ids are stable the first finger will always
  have the same color.

REPOSITORY
  rKWIN KWin

BRANCH
  touch-points-effect

REVISION DETAIL
  https://phabricator.kde.org/D2464

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/touchpoints/touchpoints.cpp
  effects/touchpoints/touchpoints.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 1,363 lines] D2449: small utility to create L packages

[mart (Marco Martin)]

mart updated this revision to Diff 5983.
mart added a comment.


  - take into account different config key

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5978=5983

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  CMakeLists.txt
  lookandfeelexplorer/CMakeLists.txt
  lookandfeelexplorer/Messages.sh
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml
  lookandfeelexplorer/package/metadata.desktop
  lookandfeelexplorer/src/CMakeLists.txt
  lookandfeelexplorer/src/lnflistmodel.cpp
  lookandfeelexplorer/src/lnflistmodel.h
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/lnflogic.h
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2449: small utility to create L packages

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in lnflogic.cpp:155
> Edit: This kwin saving stuff is *still* wrong.
> 
> In systemCG (kwinrc) it is "TabBox".
> However, in the LnF it is "WindowSwitcher."
> 
> You "fixed" the wrong one.
> 
> You are also missing DesktopSwitcher.
> 
> I'll just write the code for you:
> 
>   systemCG = 
> KConfigGroup(KSharedConfig::openConfig(QStringLiteral("kwinrc")), "TabBox");
>   defaultsConfigGroup = KConfigGroup(, "WindowSwitcher");
>   defaultsConfigGroup.writeEntry("LayoutName", 
> systemCG.readEntry("LayoutName", QStringLiteral("org.kde.breeze.desktop")));
>   
>   defaultsConfigGroup = KConfigGroup(, "DesktopSwitcher");
>   defaultsConfigGroup.writeEntry("LayoutName", 
> systemCG.readEntry("DesktopLayout", QStringLiteral("org.kde.breeze.desktop")))

gah, that's what i forgotten,
that the config key is different between kwinrc and the defaults file :/

meh, meh, meh

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Requested Changes To] D2449: small utility to create L packages

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> davidedmundson wrote in lnflogic.cpp:155
> That's the wrong group name. 
> It should be TabBox.
> 
> (and if this is copy pastad from somewhere, then fix that too.)

Edit: This kwin saving stuff is *still* wrong.

In systemCG (kwinrc) it is "TabBox".
However, in the LnF it is "WindowSwitcher."

You "fixed" the wrong one.

You are also missing DesktopSwitcher.

I'll just write the code for you:

  systemCG = KConfigGroup(KSharedConfig::openConfig(QStringLiteral("kwinrc")), 
"TabBox");
  defaultsConfigGroup = KConfigGroup(, "WindowSwitcher");
  defaultsConfigGroup.writeEntry("LayoutName", systemCG.readEntry("LayoutName", 
QStringLiteral("org.kde.breeze.desktop")));
  
  defaultsConfigGroup = KConfigGroup(, "DesktopSwitcher");
  defaultsConfigGroup.writeEntry("LayoutName", 
systemCG.readEntry("DesktopLayout", QStringLiteral("org.kde.breeze.desktop")))

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016, Dirk Hohndel wrote:
> > ah, if what you have now works, then that's fine :)
> > was something to try if it wasn't working yet :)
> 
> So here are the kirigami patches that I now use. The last one I don't

thanks, I'll take a look at all of them

> think you want to take. But I'd love to see a property that a program
> using Kirigami can use to overwrite the fairly narrow defauly of 20 grid
> units.

sure, you can do:

ApplicationWindow {
...
pageStack.defaultColumnWidth: Units.gridUnit * 30
...
}

you can set/access all the properties of pagerow in the above way

-- 
Marco Martin

Re: Kirigami patches

[Dirk Hohndel]

On Tue, Aug 16, 2016 at 03:48:49PM +0200, Marco Martin wrote:
> On Tuesday 16 August 2016, Dirk Hohndel wrote:
> > Just to make sure I understand this correctly... You are suggesting that I
> > shouldn't build Kirigami as a separate library, but that I should include
> > the kirigami.pri file from the Subsurface-mobile.pro file? And I assume
> > that i then don't need much of what I spent all weekend trying to make
> > work?
> 
> ah, if what you have now works, then that's fine :)
> was something to try if it wasn't working yet :)

So here are the kirigami patches that I now use. The last one I don't
think you want to take. But I'd love to see a property that a program
using Kirigami can use to overwrite the fairly narrow defauly of 20 grid
units.

/D
>From 12d43e899ee28493098bb8d78f17413bddd10fd2 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 16:39:21 -0700
Subject: [PATCH 1/4] More qmake fixes

The .pro file didn't include the resource file, which made things not work when
built with qmake.

Also, the .pri file was missing the enums .cpp/.h files.

Signed-off-by: Dirk Hohndel 
---
 kirigami.pri | 4 ++--
 kirigami.pro | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/kirigami.pri b/kirigami.pri
index fc88c4c..8bf35a3 100644
--- a/kirigami.pri
+++ b/kirigami.pri
@@ -1,7 +1,7 @@
 
 QT  += qml quick gui svg
-HEADERS += $$PWD/src/kirigamiplugin.h
-SOURCES += $$PWD/src/kirigamiplugin.cpp
+HEADERS += $$PWD/src/kirigamiplugin.h $$PWD/src/enums.h
+SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp
 INCLUDEPATH += $$PWD/src
 DEFINES += KIRIGAMI_BUILD_TYPE_STATIC
 
diff --git a/kirigami.pro b/kirigami.pro
index f7d6fe6..87af61f 100644
--- a/kirigami.pro
+++ b/kirigami.pro
@@ -4,6 +4,7 @@ CONFIG += plugin
 QT  += qml quick gui svg
 HEADERS += $$PWD/src/kirigamiplugin.h $$PWD/src/enums.h
 SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp
+RESOURCES   += $$PWD/kirigami.qrc
 
 API_VER=1.0
 
-- 
2.7.4 (Apple Git-66)

>From a7db5877074d1ee6edc258827b54337eb67ca8f1 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 16:42:08 -0700
Subject: [PATCH 2/4] Q_RESOURCE_INIT macro has to be called by user

Calling this from within the library doesn't seem to be the right thing to do,
according to the documentation at http://doc.qt.io/qt-5/resources.html

Signed-off-by: Dirk Hohndel 
---
 src/kirigamiplugin.cpp | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/kirigamiplugin.cpp b/src/kirigamiplugin.cpp
index fc530b3..83b4dc2 100644
--- a/src/kirigamiplugin.cpp
+++ b/src/kirigamiplugin.cpp
@@ -43,10 +43,6 @@ QString KirigamiPlugin::componentPath(const QString ) const
 
 void KirigamiPlugin::registerTypes(const char *uri)
 {
-#ifdef KIRIGAMI_BUILD_TYPE_STATIC
-Q_INIT_RESOURCE(kirigami);
-#endif
-
 Q_ASSERT(uri == QLatin1String("org.kde.kirigami"));
 const QString style = QString::fromLatin1(qgetenv("QT_QUICK_CONTROLS_STYLE"));
 
-- 
2.7.4 (Apple Git-66)

>From 6fcefdfd9cc8c44dda9334a84a5f35da23d62adf Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 19:15:36 -0700
Subject: [PATCH 3/4] Don't exit the app on iOS.

iOS users perceive that as "the app has crashed"

Signed-off-by: Dirk Hohndel 
---
 src/controls/ApplicationWindow.qml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controls/ApplicationWindow.qml b/src/controls/ApplicationWindow.qml
index 5060214..2526453 100644
--- a/src/controls/ApplicationWindow.qml
+++ b/src/controls/ApplicationWindow.qml
@@ -145,7 +145,7 @@ AbstractApplicationWindow {
 }
 }
 
-if (Settings.isMobile && !backEvent.accepted) {
+if (Settings.isMobile && !backEvent.accepted && Qt.platform.os !== "ios") {
 Qt.quit();
 }
 }
-- 
2.7.4 (Apple Git-66)

>From 555b0062b777e9120fb749ecde5a81c85156be6b Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 19:58:12 -0700
Subject: [PATCH 4/4] 20 gridUnits is too narrow

Signed-off-by: Dirk Hohndel 
---
 src/controls/templates/private/PageRow.qml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controls/templates/private/PageRow.qml b/src/controls/templates/private/PageRow.qml
index 00e25d6..2b154e7 100644
--- a/src/controls/templates/private/PageRow.qml
+++ b/src/controls/templates/private/PageRow.qml
@@ -61,7 +61,7 @@ Item {
  * Pages can override it with their Layout.fillWidth,
  * implicitWidth Layout.minimumWidth etc.
  */
-property int defaultColumnWidth: Units.gridUnit * 20
+property int defaultColumnWidth: Units.gridUnit * 30
 
 /**
  * interactive: bool
-- 
2.7.4 (Apple Git-66)

[Differential] [Accepted] D2449: small utility to create L packages

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMASDK Plasma SDK

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Kirigami patches

[Dirk Hohndel]

> On Aug 16, 2016, at 6:48 AM, Marco Martin  wrote:
> 
> On Tuesday 16 August 2016, Dirk Hohndel wrote:
>> Just to make sure I understand this correctly... You are suggesting that I
>> shouldn't build Kirigami as a separate library, but that I should include
>> the kirigami.pri file from the Subsurface-mobile.pro file? And I assume
>> that i then don't need much of what I spent all weekend trying to make
>> work?
> 
> ah, if what you have now works, then that's fine :)
> was something to try if it wasn't working yet :)

Well, the .pri approach means fewer changes to Subsurface (and Kirigami),
so in that sense I think it's preferable. I just need to test if it actually 
works
(it's still early morning here, haven't had time to try it)

/D

[Differential] [Updated, 372 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 5980.
mart added a comment.


  - prototype for support of per-looknfeel layout
  - monitor for file creation
  - delete views and arrays in the proper order
  - be silent
  - prototype of JS config dump
  - more complete config js dumper
  - generic kconfiggroup dumper
  - complete the dump of the panel
  - export the layout dump to js
  - createActivity(existingName) returns the existing one
  - support creating applets by id in script engine
  - Merge branch 'master' into mart/separateLookAndFeelLayout
  - prettier javascript code
  - crash--
  - delete all graphics objects as well on switching
  - Merge branch 'master' into mart/separateLookAndFeelLayout
  - make sure desktop containments exist before script
  - Merge branch 'master' into mart/separateLookAndFeelLayout
  - more explanatory comments
  - possible pass geometry to containment.addWidget()
  - generate some comments in js
  - use QRectF
  - use AppletOrder from the panel config
  - always use renamed file
  - internal config migration
  - remove the optional applet id parameter
  - remove graphicsobject hack
  - rework script generation
  - add a reloadDefaultLayout method to reset layout
  - methods to switch lnf
  - comments++
  - Merge branch 'master' into mart/separateLookAndFeelLayout

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=5979=5980

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Reopened] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart reopened this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd2f0ec63c60b: methods to switch lnf (authored 
by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2345?vs=5927=5979#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=5927=5979

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016, Dirk Hohndel wrote:
> Just to make sure I understand this correctly... You are suggesting that I
> shouldn't build Kirigami as a separate library, but that I should include
> the kirigami.pri file from the Subsurface-mobile.pro file? And I assume
> that i then don't need much of what I spent all weekend trying to make
> work?

ah, if what you have now works, then that's fine :)
was something to try if it wasn't working yet :)

-- 
Marco Martin

Re: Kirigami patches

[Dirk Hohndel]

-- 
Sent from my phone

On August 16, 2016 5:59:06 AM PDT, Marco Martin  wrote:
>On Tuesday 16 August 2016, Tomaz Canabrava wrote:
>> > > - use the .pri file when directly linking in kirigami into the
>(parent)
>> > > project (include directive in PROJECT.pro), then the
>Q_INIT_RESOURCE is
>> > > not necessary. using qmake this seems to be the easiest way and
>at
>> > > least seems to compile for different platforms.
>> > 
>> > subsurface is cmake based, so the pri file can't be used
>> 
>> Subsurface is cmake based only on all platforms besides ios, I didn't
>> managed to make the ios build work on cmake.
>
>ah.
>if it's qmake tThis is where I admit that I don't understand the subtleties..

Just to make sure I understand this correctly... You are suggesting that I 
shouldn't build Kirigami as a separate library, but that I should include the 
kirigami.pri file from the Subsurface-mobile.pro file? And I assume that i then 
don't need much of what I spent all weekend trying to make work?

/D

Binding loop in AppletConfiguration.qml

[Michail Vourlakos]

Hello everyone,

there is a binding loop in the AppletConfiguration.qml in 
org.kde.plasma.desktop/contents/configuration/ and it influences all the 
configuration dialogs of applets. Is it important?


It is found in lines 163,164

---

width: categoriesScroll.viewport.width
height: Math.max(categoriesScroll.viewport.height, categories.height)

---

It is found in the categories in the configuration dialog.. the child of 
a QtControls.ScrollView is using its viewport to count its size and that 
creates a binding loop. I changed them with:


---

width: units.gridUnit * 7 - 4
height: categories.childrenRect.height

---

and the bindings were removed and the appearance looks the same.


regards,

michail

[Differential] [Updated, 1,361 lines] D2449: small utility to create L packages

[mart (Marco Martin)]

mart updated this revision to Diff 5978.
mart added a comment.


  - use deleteLater

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5976=5978

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  CMakeLists.txt
  lookandfeelexplorer/CMakeLists.txt
  lookandfeelexplorer/Messages.sh
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml
  lookandfeelexplorer/package/metadata.desktop
  lookandfeelexplorer/src/CMakeLists.txt
  lookandfeelexplorer/src/lnflistmodel.cpp
  lookandfeelexplorer/src/lnflistmodel.h
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/lnflogic.h
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016, Tomaz Canabrava wrote:
> > > - use the .pri file when directly linking in kirigami into the (parent)
> > > project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is
> > > not necessary. using qmake this seems to be the easiest way and at
> > > least seems to compile for different platforms.
> > 
> > subsurface is cmake based, so the pri file can't be used
> 
> Subsurface is cmake based only on all platforms besides ios, I didn't
> managed to make the ios build work on cmake.

ah.
if it's qmake there then, can you try with just including the .pri instead?


-- 
Marco Martin

[Differential] [Requested Changes To] D2449: small utility to create L packages

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> lnflogic.cpp:92
>  emit messageRequested(ErrorLevel::Error, i18n("Cannot retrieve 
> the current Plasma layout."));
> +delete watcher;
>  return;

watcher->deleteLater();

because:

1. you should never delete a QObject in a slot. You crash if something else is 
connected to the same signal

2. you only need one line then at the top. Otherwise you crash if used after 
free.

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Kirigami patches

[Tomaz Canabrava]

Subsue

Em 16 de ago de 2016 04:43, "Marco Martin"  escreveu:
>
> On Tuesday 16 August 2016, Martin Gysel wrote:
> > Am 16.08.2016 um 01:55 schrieb Dirk Hohndel:
> > > It's pretty clear that no one ever tested the kirigami.pro qmake file.
> > > The second patch I'm not 100% sure about, but it seems to match what
the
> > > documentation tells us SHOULD be done.
> >
> > maybe my understanding of the qt build system, tools and libraries is
> > wrong, but wouldn't it be better to
> >
> > - use the .pri file when directly linking in kirigami into the (parent)
> > project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is
> > not necessary. using qmake this seems to be the easiest way and at least
> > seems to compile for different platforms.
>
> subsurface is cmake based, so the pri file can't be used

Subsurface is cmake based only on all platforms besides ios, I didn't
managed to make the ios build work on cmake.

> > - use the .pro file when using kirigami as library/plugin (static or
> > dynamic, from a parent 'subdirs' pro file). then the static variant
> > needs the Q_INIT_RESOURCE. using this approach leads at least on iOS to
> > various problems linking the app and not finding the resources at
> > runtime (so it did so while I tested this)
> >
> > this also means we probably need another define like
> > KIRIGAMI_BUILD_TYPE_STATIC_PLUGIN and/or
KIRIGAMI_BUILD_TYPE_DYNAMIC_PLUGIN
>
> why the one define used right now wouldn't be enough?
>
> --
> Marco Martin

[Differential] [Closed] D2450: Add support for touch events in the Effect system

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN6af0cc6ebe67: Add support for touch events in the Effect 
system (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2450?vs=5934=5977

REVISION DETAIL
  https://phabricator.kde.org/D2450

AFFECTED FILES
  effects.cpp
  effects.h
  effects/presentwindows/presentwindows.cpp
  effects/presentwindows/presentwindows.h
  input.cpp
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2462: Remove deprecated code in kscreenlocker theme

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in LockScreen.qml:32
> It's in the original commit message that got hidden.
> 
> This code existed in case you ran the new theme with an old plasma.
> 
> Useful for a while but it doesn't make sense to keep that forever. 
> I don't know what our policy on skipped upgrades is. (i.e going 5.3 -> 5.6)
> 
> I'm not particularly desperate to kill it, I just was doing some lock screen 
> changes and had no intention of properly testing this bit.

We don't have policies on the supported upgrade path. Given that I would keep 
it.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2462

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2462: Remove deprecated code in kscreenlocker theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in LockScreen.qml:32
> this change I don't understand. It's not described in the change.

It's in the original commit message that got hidden.

This code existed in case you ran the new theme with an old plasma.

Useful for a while but it doesn't make sense to keep that forever. 
I don't know what our policy on skipped upgrades is. (i.e going 5.3 -> 5.6)

I'm not particularly desperate to kill it, I just was doing some lock screen 
changes and had no intention of properly testing this bit.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2462

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D2462: Remove deprecated code in kscreenlocker theme

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in LockScreen.qml:32
> this change I don't understand. It's not described in the change.

is that a context property?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2462

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: mart, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2455: Use new inline revealpassword action

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  
  
  > phabricator closes the review when commits on a relevant branch is done... 
for no reason
  
  Yeah, but Kai's commit is even in a different repository. Makes even less 
sense.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2455

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2455: Use new inline revealpassword action

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2455#45873, @davidedmundson wrote:
  
  > what on Earth is phab doing?
  >  Kai's commit doesn't close this at all.
  
  
  phabricator closes the review when commits on a relevant branch is done... 
for no reason

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2455

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 1,361 lines] D2449: small utility to create L packages

[mart (Marco Martin)]

mart updated this revision to Diff 5976.
mart added a comment.


  - prototype of basic editor for lookandfeel packages
  - correctly list look and feel packages
  - make the theme list a simple list
  - load theme name in textbox
  - complete metadata editor
  - sic creation (of an empty theme)
  - start with layout file generator
  - function to set a screenshot
  - open file dialog to update screenshots
  - fix layout
  - possibility to update default layout
  - async dbus call
  - start port to kirigami
  - actions in GlobalDrawer
  - remove the timer hack
  - remove some leaks
  - lnf just themes tabbox

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5975=5976

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  CMakeLists.txt
  lookandfeelexplorer/CMakeLists.txt
  lookandfeelexplorer/Messages.sh
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml
  lookandfeelexplorer/package/metadata.desktop
  lookandfeelexplorer/src/CMakeLists.txt
  lookandfeelexplorer/src/lnflistmodel.cpp
  lookandfeelexplorer/src/lnflistmodel.h
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/lnflogic.h
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Reopened] D2449: small utility to create L packages

[mart (Marco Martin)]

mart reopened this revision.

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2449: small utility to create L packages

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMASDKdbc63d9b5de0: remove some leaks (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2449?vs=5974=5975#toc

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5974=5975

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 1,367 lines] D2449: small utility to create L packages

[mart (Marco Martin)]

mart updated this revision to Diff 5974.
mart added a comment.


  - remove some leaks

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5953=5974

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  CMakeLists.txt
  lookandfeelexplorer/CMakeLists.txt
  lookandfeelexplorer/Messages.sh
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml
  lookandfeelexplorer/package/metadata.desktop
  lookandfeelexplorer/src/CMakeLists.txt
  lookandfeelexplorer/src/lnflistmodel.cpp
  lookandfeelexplorer/src/lnflistmodel.h
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/lnflogic.h
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Requested Changes To] D2462: Remove deprecated code in kscreenlocker theme

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> LockScreen.qml:32
>  property UserSelect userSelect: null
> -property int interfaceVersion: 
> org_kde_plasma_screenlocker_greeter_interfaceVersion ? 
> org_kde_plasma_screenlocker_greeter_interfaceVersion : 0
> -signal clearPassword()
> +property int interfaceVersion: 
> org_kde_plasma_screenlocker_greeter_interfaceVersion
>  

this change I don't understand. It's not described in the change.

> LockScreen.qml:59-63
> -Component.onCompleted: {
> -if (root.interfaceVersion < 2) {
> -mainLoader.source = "LockScreenUi.qml";
> -}
> -}

why is that removed?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2462

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2449: small utility to create L packages

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.cpp:70
> UncreatableType * 2

I think in this case it's betterthis form, as i don't want to give an url to 
it, i just want properties of those instances to be readable

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 9 lines] D2462: Remove deprecated code in kscreenlocker theme

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Remove now deprecated logic for lockscreen theme working on old Plasma
  
  remove unused clearPassword signal
  Nothing connected to it (including in kscreenlocker)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2462

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreen.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

[Burkhard Lück]

> On Aug. 16, 2016, 7:05 vorm., David Faure wrote:
> > doc/kcontrol/khtml-general/index.docbook, line 51
> > 
> >
> > Well, qt5-webkit and kwebkitpart do still exist. They're just not 
> > really maintained (but then again that is a problem for konqueror itself as 
> > well, especially due to being built on top of deprecated web engines...). 
> > (I hate this situation.)

Thanks to your hints I just detected that kwebkitpart has a frameworks branch. 
Building this branch I get the webkit engine back in konqueror kf5.
But kwebkitpart frameworks branch is unreleased, stable/released branch is 1.3 
kde4 based, master as well.
So should I update the docbooks for konqueror with kwebkitpart/frameworks 
branch?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128684/#review98408
---


On Aug. 15, 2016, 11:40 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128684/
> ---
> 
> (Updated Aug. 15, 2016, 11:40 vorm.)
> 
> 
> Review request for Documentation, KDE Base Apps, Plasma, and David Faure.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread + update
> comment webkit
> 
> code in kde-baseapps - docbook in plasma-desktop?
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/khtml-general/index.docbook 1b9c80e 
> 
> Diff: https://git.reviewboard.kde.org/r/128684/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Requested Changes To] D2449: small utility to create L packages

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> lnflogic.cpp:85
> +
> +QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pcall, 
> this);
> +

leaks

> lnflogic.cpp:155
> +defaultsConfigGroup = KConfigGroup(, 
> "DesktopSwitcher");
> +systemCG = 
> KConfigGroup(KSharedConfig::openConfig(QStringLiteral("kwinrc")), 
> "DesktopSwitcher");
> +defaultsConfigGroup.writeEntry("LayoutName", 
> systemCG.readEntry("LayoutName", QStringLiteral("org.kde.breeze.desktop")));

That's the wrong group name. 
It should be TabBox.

(and if this is copy pastad from somewhere, then fix that too.)

> main.cpp:62
> +//usually we have an ApplicationWindow here, so we do not need to create 
> a window by ourselves
> +KDeclarative::QmlObject *obj = new KDeclarative::QmlObject();
> +obj->setTranslationDomain(packagePath);

leaks

> main.cpp:70
> +qmlRegisterType();
> +qmlRegisterType();
> +

UncreatableType * 2

> main.cpp:72
> +
> +LnfLogic *lnfLogic = new LnfLogic;
> +obj->engine()->rootContext()->setContextProperty("lnfLogic", 
> QVariant::fromValue(lnfLogic));

leaks

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Christoph Feck]

> On Aug. 16, 2016, 2:27 a.m., Anthony Fieroni wrote:
> > Ping. For 5.7.4
> 
> Martin Gräßlin wrote:
> For master the focus in is removed. And I think that's absolutely no 
> stable branch material.

It looks like this is also fixed with Qt 5.6 branch, see commit 
17d68c4fc371c32bd58d0a94ac63f0170edaf29e


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98406
---


On Aug. 13, 2016, 5:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Aug. 13, 2016, 5:17 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Martin Gräßlin]

> On Aug. 16, 2016, 4:27 a.m., Anthony Fieroni wrote:
> > Ping. For 5.7.4

For master the focus in is removed. And I think that's absolutely no stable 
branch material.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98406
---


On Aug. 13, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Aug. 13, 2016, 7:17 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Closed] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE2c868c438033: New new SDDM theme (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2399?vs=5818=5968#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2399?vs=5818=5968

REVISION DETAIL
  https://phabricator.kde.org/D2399

AFFECTED FILES
  sddm-theme/ActionButton.qml
  sddm-theme/Background.qml
  sddm-theme/BatteryIcon.qml
  sddm-theme/Clock.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/README.txt
  sddm-theme/SessionButton.qml
  sddm-theme/UserDelegate.qml
  sddm-theme/UserList.qml
  sddm-theme/dummydata/sddm.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2399: New new SDDM theme

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  to me is ok (if is good design-wise for vdg) my only comment is wether is 
possible to make the faces avoiding the custom shader, but is not super 
important

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  sddm_stuff

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016, Martin Gysel wrote:
> Am 16.08.2016 um 01:55 schrieb Dirk Hohndel:
> > It's pretty clear that no one ever tested the kirigami.pro qmake file.
> > The second patch I'm not 100% sure about, but it seems to match what the
> > documentation tells us SHOULD be done.
> 
> maybe my understanding of the qt build system, tools and libraries is
> wrong, but wouldn't it be better to
> 
> - use the .pri file when directly linking in kirigami into the (parent)
> project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is
> not necessary. using qmake this seems to be the easiest way and at least
> seems to compile for different platforms.

subsurface is cmake based, so the pri file can't be used

> - use the .pro file when using kirigami as library/plugin (static or
> dynamic, from a parent 'subdirs' pro file). then the static variant
> needs the Q_INIT_RESOURCE. using this approach leads at least on iOS to
> various problems linking the app and not finding the resources at
> runtime (so it did so while I tested this)
> 
> this also means we probably need another define like
> KIRIGAMI_BUILD_TYPE_STATIC_PLUGIN and/or KIRIGAMI_BUILD_TYPE_DYNAMIC_PLUGIN

why the one define used right now wouldn't be enough?

-- 
Marco Martin

Re: Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016, Dirk Hohndel wrote:
> It's pretty clear that no one ever tested the kirigami.pro qmake file. The
> second patch I'm not 100% sure about, but it seems to match what the
> documentation tells us SHOULD be done.

because with the pro it was supposed to build the dynamic plugin.
however, since seems to be easier to build it in static mode, I'm fine with 
the change.


-- 
Marco Martin

Re: Review Request 128685: Proofread + update performance kcm docbook

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128685/#review98410
---


Ship it!




Can you move it to kde-baseapps, along with any other konqueror-related docbook?

- David Faure


On Aug. 15, 2016, 11:48 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128685/
> ---
> 
> (Updated Aug. 15, 2016, 11:48 a.m.)
> 
> 
> Review request for Documentation, KDE Base Apps, Plasma, and David Faure.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread + update
> remove obsolete comment
> 
> code in kde-baseapps - docbook in plasma-desktop?
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/performance/index.docbook 5ac5055 
> 
> Diff: https://git.reviewboard.kde.org/r/128685/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128684: Proofread + update khtml-general kcm docbook

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128684/#review98408
---




doc/kcontrol/khtml-general/index.docbook (line 7)


Yeah I don't understand what this docbook is doing here :-)



doc/kcontrol/khtml-general/index.docbook (line 51)


Well, qt5-webkit and kwebkitpart do still exist. They're just not really 
maintained (but then again that is a problem for konqueror itself as well, 
especially due to being built on top of deprecated web engines...). (I hate 
this situation.)


- David Faure


On Aug. 15, 2016, 11:40 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128684/
> ---
> 
> (Updated Aug. 15, 2016, 11:40 a.m.)
> 
> 
> Review request for Documentation, KDE Base Apps, Plasma, and David Faure.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread + update
> comment webkit
> 
> code in kde-baseapps - docbook in plasma-desktop?
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/khtml-general/index.docbook 1b9c80e 
> 
> Diff: https://git.reviewboard.kde.org/r/128684/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

[dfaure (David Faure)]

dfaure added a comment.


  Yes, and yes.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Branch inconsistencies

[David Faure]

kde-build-metadata/logical-module-structure points to Plasma/5.7
for kaccounts-mobile and plasma-tests, where that branch doesn't exist.

--  Forwarded Message  --

Subject: Cron  ~/bin/update_kf5.sh
Date: lundi 15 août 2016, 12:58:01 CEST
From: Cron Daemon 
To: fa...@kde.org

Error updating kaccounts-mobile, removing from list of packages to build.
 > Unable to perform a git checkout of origin/Plasma/5.7 to a local branch of 
Plasma/5.7
Error updating plasma-tests, removing from list of packages to build.
 > Unable to perform a git checkout of origin/Plasma/5.7 to a local branch of 
Plasma/5.7
-
-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Kirigami patches

[Martin Gysel]

Am 16.08.2016 um 01:55 schrieb Dirk Hohndel:
> It's pretty clear that no one ever tested the kirigami.pro qmake file. The
> second patch I'm not 100% sure about, but it seems to match what the
> documentation tells us SHOULD be done.

maybe my understanding of the qt build system, tools and libraries is
wrong, but wouldn't it be better to

- use the .pri file when directly linking in kirigami into the (parent)
project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is
not necessary. using qmake this seems to be the easiest way and at least
seems to compile for different platforms.

- use the .pro file when using kirigami as library/plugin (static or
dynamic, from a parent 'subdirs' pro file). then the static variant
needs the Q_INIT_RESOURCE. using this approach leads at least on iOS to
various problems linking the app and not finding the resources at
runtime (so it did so while I tested this)

this also means we probably need another define like
KIRIGAMI_BUILD_TYPE_STATIC_PLUGIN and/or KIRIGAMI_BUILD_TYPE_DYNAMIC_PLUGIN

/martin