Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 56 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 06:35:37 + Build duration: 24 min CHANGE SET Revision 6a19978f1dadd5490e0a911a402807db26aee31d by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit applets/appmenu/package/metadata.desktop JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 (39%)CONDITIONAL 1631/5912 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 119/3235 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
[Differential] [Request, 1 line] D4518: Ungrab mouse in taskmanager context menu
anthonyfieroni created this revision. anthonyfieroni added reviewers: hein, davidedmundson, broulik. anthonyfieroni added a subscriber: Plasma. anthonyfieroni set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In Qt 5.8, but i'm pretty sure i'm see it in Qt 5.7, ungrabMouse called in show() does not work (i don't know why). TEST PLAN Right click on task -> Start new instance -> mouse is still grabbed -> left click in taskmanager will activate element right clicked on it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4518 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, hein, davidedmundson, broulik Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 734 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/734/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 04:52:40 + Build duration: 6 min 47 sec CHANGE SET Revision e934f1404527a74d8e626627c7963fae93154fbb by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit components/shellprivate/widgetexplorer/plasmoids.knsrc change: edit runners/baloo/plasma-runner-baloosearch.desktop change: edit applets/appmenu/package/metadata.desktop change: edit wallpapers/image/wallpaper.knsrc JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 (39%)CONDITIONAL 1631/5912 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 119/3235 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
[Differential] [Updated, 23 lines] D4491: Let make taskmanager tooltip readable again
anthonyfieroni updated this revision to Diff 11096. anthonyfieroni added a comment. Stop binding loop on height REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4491?vs=11086=11096 REVISION DETAIL https://phabricator.kde.org/D4491 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, #plasma:_design Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 604 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/604/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 04:52:05 + Build duration: 6 min 46 sec CHANGE SET Revision f18d16e239d86622e3295c458d0c6c33a4398159 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit kcms/standard_actions/standard_actions.desktop change: edit kcms/desktoptheme/plasma-themes.knsrc change: edit kcms/colors/colors.desktop change: edit kcms/cursortheme/xcursor/xcursor.knsrc change: edit kcms/keys/keys.desktop change: edit kcms/colors/colorschemes.knsrc change: edit layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop change: edit runners/kwin/plasma-runner-kwin.desktop change: edit kcms/lookandfeel/lookandfeel.knsrc JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 (67%)CONDITIONAL 1546/3761 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 95/219 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 (100%)CONDITIONAL 54/108 (50%)
Look and Feel in 5.8
Hi, Long story short. We have 3 basics problems with Look and Feel in Plasma 5.8 1. While support for dependencies was implemented in KDE Frameworks 5.29, one needs Frameworks 5.31 (yet to be released) for more or less bug free experience. And I assume that most of the l themes will use this functionality, without it l themes are useless. 2. Plasma 5.8 doesn't support some rather basic features like import/export panel visibility with js, window decorations etc, and I am using them heavily in my L themes. 3. Combination of the two above can result in an unpredictable behavior, including broken plasma session. As a mater of fact, some time ago, I received rather unpleasant mail from some unknown guy who said that one of my themes broke his Plasma 5.8.x session. I spent a considerable amount of my free time testing, promoting and recently writing documentation [1] for this feature and it is really demotivating when somebody is saying that "I broke his desktop". However what saddens me the most is the fact that I warned you guys about potential issues before Plasma 5.8 release in September. [2]. Either way it is up to you how are going to solve this "problem". In any case, I still plan to work on this, especially on the promo/documentation side of things. Cheers, Łukasz Sawicki 1. https://community.kde.org/How_to_create_Look_and_Feel_Package 2. https://mail.kde.org/pipermail/plasma-devel/2016-September/058976.html
[Differential] [Updated] D4491: Let make taskmanager tooltip readable again
anthonyfieroni updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, #plasma:_design Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated] D4491: Let make taskmanager tooltip readable again
anthonyfieroni updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, #plasma:_design Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 20 lines] D4491: Let make taskmanager tooltip readable again
anthonyfieroni updated this revision to Diff 11086. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4491?vs=11039=11086 REVISION DETAIL https://phabricator.kde.org/D4491 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, #plasma:_design Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 129867: Complete oxygen look and feel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129867/ --- (Updated Feb. 8, 2017, 8:25 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Hugo Pereira Da Costa and Marco Martin. Changes --- Submitted with commit dee50cfd16e67014d9c839c554549e0f36f2101a by Anthony Fieroni to branch Plasma/5.9. Repository: oxygen Description --- Applying oxygen in lookandfeel kcm should set desktop theme and decorations to oxygen Diffs - lookandfeel/contents/defaults 571a7c65 Diff: https://git.reviewboard.kde.org/r/129867/diff/ Testing --- Thanks, Anthony Fieroni
[Differential] [Updated, 2,990 lines] D4508: [WIP] Plasma controls based on QtQuickControls2
mart updated this revision to Diff 11082. mart added a comment. - start a Plasma qqc2 style - add labels and button - add ToolButton - add checkboxes and check delegates - warnings-- - add ComboBox - add Container and Control - add Dialog, Popup - add Drawer - add Frame - iadd GroupBox - add RadioButton and RadioDelegate - add a progressbar - Menu and MenuItem - add TabBar andTabButton - animate transition - layout fixes - New controls - add BusyIndicator - Merge branch 'master' into mart/qqc2style - install the components as a separate import - separately install as style and import - remove smooth property - adapt to final api - proper sizehints for the busy widget - hardcoded numbers -- - use devicepixelratios REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11080=11082 BRANCH mart/qqc2style REVISION DETAIL https://phabricator.kde.org/D4508 AFFECTED FILES src/declarativeimports/CMakeLists.txt src/declarativeimports/plasmacomponents3/BusyIndicator.qml src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/CheckBox.qml src/declarativeimports/plasmacomponents3/CheckDelegate.qml src/declarativeimports/plasmacomponents3/CheckIndicator.qml src/declarativeimports/plasmacomponents3/ComboBox.qml src/declarativeimports/plasmacomponents3/Container.qml src/declarativeimports/plasmacomponents3/Control.qml src/declarativeimports/plasmacomponents3/Dial.qml src/declarativeimports/plasmacomponents3/Dialog.qml src/declarativeimports/plasmacomponents3/DialogButtonBox.qml src/declarativeimports/plasmacomponents3/Drawer.qml src/declarativeimports/plasmacomponents3/Frame.qml src/declarativeimports/plasmacomponents3/GroupBox.qml src/declarativeimports/plasmacomponents3/ItemDelegate.qml src/declarativeimports/plasmacomponents3/Label.qml src/declarativeimports/plasmacomponents3/Menu.qml src/declarativeimports/plasmacomponents3/MenuItem.qml src/declarativeimports/plasmacomponents3/Popup.qml src/declarativeimports/plasmacomponents3/ProgressBar.qml src/declarativeimports/plasmacomponents3/RadioButton.qml src/declarativeimports/plasmacomponents3/RadioDelegate.qml src/declarativeimports/plasmacomponents3/RadioIndicator.qml src/declarativeimports/plasmacomponents3/RangeSlider.qml src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/Slider.qml src/declarativeimports/plasmacomponents3/SpinBox.qml src/declarativeimports/plasmacomponents3/Switch.qml src/declarativeimports/plasmacomponents3/SwitchDelegate.qml src/declarativeimports/plasmacomponents3/SwitchIndicator.qml src/declarativeimports/plasmacomponents3/TabBar.qml src/declarativeimports/plasmacomponents3/TabButton.qml src/declarativeimports/plasmacomponents3/TextArea.qml src/declarativeimports/plasmacomponents3/TextField.qml src/declarativeimports/plasmacomponents3/ToolBar.qml src/declarativeimports/plasmacomponents3/ToolButton.qml src/declarativeimports/plasmacomponents3/ToolTip.qml src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml src/declarativeimports/plasmacomponents3/private/RoundShadow.qml src/declarativeimports/plasmacomponents3/private/TextFieldFocus.qml src/declarativeimports/plasmacomponents3/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Reopened] D4508: [WIP] Plasma controls based on QtQuickControls2
mart reopened this revision. mart added inline comments. INLINE COMMENTS > broulik wrote in BusyIndicator.qml:28 > Apparently in Qt 5.8 the implicit sizes now take into account padding but > since we want to support 5.7 (?) makes sense. > > Mentioned in the changelog: > https://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/dist/changes-5.8.0 would it break with an update to Qt 5.8? > broulik wrote in Button.qml:37 > Docs say > > > You can also enable or disable hover effects for all Qt Quick Controls 2 > > applications by setting the QT_QUICK_CONTROLS_HOVER_ENABLED environment > > variable. would this have evvect even if hoverEnabled: true is hardcoded that way? in that case we have a soluton for plasma mobile > broulik wrote in Button.qml:39 > What `Label` is this? I don't see any import/namespace that would provide > this here ourselves.. it's in this patch > broulik wrote in Button.qml:41 > QQC2 `Label` supposedly supports `font` (and probably other) inheritance yes, in order to apply the font at the qqc2 label subclass we are using there if the user specified a custom font for this button REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Closed] D4508: [WIP] Plasma controls based on QtQuickControls2
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b2f6a9503738: separately install as style and import (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4508?vs=11077=11080#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11077=11080 REVISION DETAIL https://phabricator.kde.org/D4508 AFFECTED FILES src/declarativeimports/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Updated, 5,900 lines] D4508: [WIP] Plasma controls based on QtQuickControls2
mart updated this revision to Diff 11077. mart added a comment. - separately install as style and import REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11076=11077 BRANCH mart/qqc2style REVISION DETAIL https://phabricator.kde.org/D4508 AFFECTED FILES src/declarativeimports/CMakeLists.txt src/declarativeimports/plasmacomponents3/BusyIndicator.qml src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/CheckBox.qml src/declarativeimports/plasmacomponents3/CheckDelegate.qml src/declarativeimports/plasmacomponents3/CheckIndicator.qml src/declarativeimports/plasmacomponents3/ComboBox.qml src/declarativeimports/plasmacomponents3/Container.qml src/declarativeimports/plasmacomponents3/Control.qml src/declarativeimports/plasmacomponents3/Dial.qml src/declarativeimports/plasmacomponents3/Dialog.qml src/declarativeimports/plasmacomponents3/DialogButtonBox.qml src/declarativeimports/plasmacomponents3/Drawer.qml src/declarativeimports/plasmacomponents3/Frame.qml src/declarativeimports/plasmacomponents3/GroupBox.qml src/declarativeimports/plasmacomponents3/ItemDelegate.qml src/declarativeimports/plasmacomponents3/Label.qml src/declarativeimports/plasmacomponents3/Menu.qml src/declarativeimports/plasmacomponents3/MenuItem.qml src/declarativeimports/plasmacomponents3/Popup.qml src/declarativeimports/plasmacomponents3/ProgressBar.qml src/declarativeimports/plasmacomponents3/RadioButton.qml src/declarativeimports/plasmacomponents3/RadioDelegate.qml src/declarativeimports/plasmacomponents3/RadioIndicator.qml src/declarativeimports/plasmacomponents3/RangeSlider.qml src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/Slider.qml src/declarativeimports/plasmacomponents3/SpinBox.qml src/declarativeimports/plasmacomponents3/Switch.qml src/declarativeimports/plasmacomponents3/SwitchDelegate.qml src/declarativeimports/plasmacomponents3/SwitchIndicator.qml src/declarativeimports/plasmacomponents3/TabBar.qml src/declarativeimports/plasmacomponents3/TabButton.qml src/declarativeimports/plasmacomponents3/TextArea.qml src/declarativeimports/plasmacomponents3/TextField.qml src/declarativeimports/plasmacomponents3/ToolBar.qml src/declarativeimports/plasmacomponents3/ToolButton.qml src/declarativeimports/plasmacomponents3/ToolTip.qml src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml src/declarativeimports/plasmacomponents3/private/RoundShadow.qml src/declarativeimports/plasmacomponents3/private/TextFieldFocus.qml src/declarativeimports/plasmacomponents3/qmldir src/declarativeimports/qqc2style/BusyIndicator.qml src/declarativeimports/qqc2style/Button.qml src/declarativeimports/qqc2style/CheckBox.qml src/declarativeimports/qqc2style/CheckDelegate.qml src/declarativeimports/qqc2style/CheckIndicator.qml src/declarativeimports/qqc2style/ComboBox.qml src/declarativeimports/qqc2style/Container.qml src/declarativeimports/qqc2style/Control.qml src/declarativeimports/qqc2style/Dial.qml src/declarativeimports/qqc2style/Dialog.qml src/declarativeimports/qqc2style/DialogButtonBox.qml src/declarativeimports/qqc2style/Drawer.qml src/declarativeimports/qqc2style/Frame.qml src/declarativeimports/qqc2style/GroupBox.qml src/declarativeimports/qqc2style/ItemDelegate.qml src/declarativeimports/qqc2style/Label.qml src/declarativeimports/qqc2style/Menu.qml src/declarativeimports/qqc2style/MenuItem.qml src/declarativeimports/qqc2style/Popup.qml src/declarativeimports/qqc2style/ProgressBar.qml src/declarativeimports/qqc2style/RadioButton.qml src/declarativeimports/qqc2style/RadioDelegate.qml src/declarativeimports/qqc2style/RadioIndicator.qml src/declarativeimports/qqc2style/RangeSlider.qml src/declarativeimports/qqc2style/ScrollBar.qml src/declarativeimports/qqc2style/Slider.qml src/declarativeimports/qqc2style/SpinBox.qml src/declarativeimports/qqc2style/Switch.qml src/declarativeimports/qqc2style/SwitchDelegate.qml src/declarativeimports/qqc2style/SwitchIndicator.qml src/declarativeimports/qqc2style/TabBar.qml src/declarativeimports/qqc2style/TabButton.qml src/declarativeimports/qqc2style/TextArea.qml src/declarativeimports/qqc2style/TextField.qml src/declarativeimports/qqc2style/ToolBar.qml src/declarativeimports/qqc2style/ToolButton.qml src/declarativeimports/qqc2style/ToolTip.qml src/declarativeimports/qqc2style/private/ButtonShadow.qml src/declarativeimports/qqc2style/private/DefaultListItemBackground.qml src/declarativeimports/qqc2style/private/RoundShadow.qml src/declarativeimports/qqc2style/private/TextFieldFocus.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, plasma-devel,
[Differential] [Commented On] D4508: [WIP] Plasma controls based on QtQuickControls2
broulik added a comment.
Skimmed through it until `ItemDelegate.qml`, few nitpicks for that below
INLINE COMMENTS
> BusyIndicator.qml:28
> +
> +implicitWidth: contentItem.implicitWidth + leftPadding + rightPadding
> +implicitHeight: contentItem.implicitHeight + topPadding + bottomPadding
Apparently in Qt 5.8 the implicit sizes now take into account padding but since
we want to support 5.7 (?) makes sense.
Mentioned in the changelog:
https://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/dist/changes-5.8.0
> BusyIndicator.qml:41
> +
> +anchors.centerIn: parent
> +width: Math.min(control.width, control.height)
You sure this doesn't break anything if you mess with anchors and sizes and
don't have a wrapper `Item` around it?
> BusyIndicator.qml:44
> +height: width
> +smooth: !control.running ||
> (control.hasOwnProperty("smoothAnimation") && control.smoothAnimation)
> +
I think with QtQuick 2 `smooth` doesn't matter anymore, other than making it
look worse.
>From docs
> In Qt Quick 2.0, this property has minimal impact on performance.
> Button.qml:37
> +
> +hoverEnabled: true //Qt.styleHints.useHoverEffects TODO: how to make
> this work in 5.7?
> +
Docs say
> You can also enable or disable hover effects for all Qt Quick Controls 2
> applications by setting the QT_QUICK_CONTROLS_HOVER_ENABLED environment
> variable.
> Button.qml:39
> +
> +contentItem: Label {
> +text: control.text
What `Label` is this? I don't see any import/namespace that would provide this
here
> Button.qml:41
> +text: control.text
> +font: control.font
> +opacity: enabled || control.highlighted || control.checked ? 1 : 0.4
QQC2 `Label` supposedly supports `font` (and probably other) inheritance
> CheckIndicator.qml:63
> +anchors.fill: parent
> +state: control.activeFocus ? "focus" : (control.hovered ? "hover" :
> "shadow")
> +}
Now that we have `activeFocusReason` we could potentially behave differently
whether it was user-focused or tab-focused (not now but keeping that in mind
for the future)
> ComboBox.qml:96
> +
> +popup: T.Popup {
> +y: control.height
in-window `Popup` makes me sad :(
> DialogButtonBox.qml:41
> +
> +contentItem: ListView {
> +implicitWidth: contentWidth
Do we really want a `ListView` here?
Also, how does it work with e.g. `HelpRole` and things that would go on the
left rather than the right? Dunno if it supports that though
> Drawer.qml:35
> +
> +topPadding: control.edge === Qt.BottomEdge ? 1 : 0
> +leftPadding: control.edge === Qt.RightEdge ? 1 : 0
`Math.round(units.devicePixelRatio)` instead of `1`?
> Frame.qml:34
> +
> +padding: 6
> +
Hardcoded number
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4508
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4503: Binary clock QML applet
mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > BinaryClock.qml:41 > + > +Layout.minimumWidth: w1 < 20 ? 20 : w1 > +Layout.maximumWidth: Infinity this should be in gridunits? > BinaryClock.qml:45 > + > +Layout.minimumHeight: 16+(units.smallSpacing * 5) > + // Layout.maximumHeight: vertical ? Layout.minimumHeight : Infinity pretty arbitrary? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4503 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Request, 2,947 lines] D4508: [WIP] Plasma controls based on QtQuickControls2
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This is a basic styling of a QtQuickControls2 series based on Plasma theme. it has the main controls available in Qt 5.7 it installs them as a separate import (org.kde.plasma.controls 3.0) for use restricted to plasmoids, is probably needed to be still installed as a style as well TEST PLAN tried with minimal QML files, a more comprehensive gallery may be needed. pending considerations: - some of the classes, like Drawer, the dialogs and ApplicationWindow *don't* make sense in plasmoids - it will probably still need to be installed also as a qqc2 style, as this should be used in Plasma mobile - probably only some of the controls should be installed as a separate import, the whole set as a style strictly for Plasma Mobile use. the same qml files would be used, so no maintainance overhead REPOSITORY R242 Plasma Framework (Library) BRANCH mart/qqc2style REVISION DETAIL https://phabricator.kde.org/D4508 AFFECTED FILES src/declarativeimports/CMakeLists.txt src/declarativeimports/plasmacomponents3/BusyIndicator.qml src/declarativeimports/plasmacomponents3/Button.qml src/declarativeimports/plasmacomponents3/CheckBox.qml src/declarativeimports/plasmacomponents3/CheckDelegate.qml src/declarativeimports/plasmacomponents3/CheckIndicator.qml src/declarativeimports/plasmacomponents3/ComboBox.qml src/declarativeimports/plasmacomponents3/Container.qml src/declarativeimports/plasmacomponents3/Control.qml src/declarativeimports/plasmacomponents3/Dial.qml src/declarativeimports/plasmacomponents3/Dialog.qml src/declarativeimports/plasmacomponents3/DialogButtonBox.qml src/declarativeimports/plasmacomponents3/Drawer.qml src/declarativeimports/plasmacomponents3/Frame.qml src/declarativeimports/plasmacomponents3/GroupBox.qml src/declarativeimports/plasmacomponents3/ItemDelegate.qml src/declarativeimports/plasmacomponents3/Label.qml src/declarativeimports/plasmacomponents3/Menu.qml src/declarativeimports/plasmacomponents3/MenuItem.qml src/declarativeimports/plasmacomponents3/Popup.qml src/declarativeimports/plasmacomponents3/ProgressBar.qml src/declarativeimports/plasmacomponents3/RadioButton.qml src/declarativeimports/plasmacomponents3/RadioDelegate.qml src/declarativeimports/plasmacomponents3/RadioIndicator.qml src/declarativeimports/plasmacomponents3/RangeSlider.qml src/declarativeimports/plasmacomponents3/ScrollBar.qml src/declarativeimports/plasmacomponents3/Slider.qml src/declarativeimports/plasmacomponents3/SpinBox.qml src/declarativeimports/plasmacomponents3/Switch.qml src/declarativeimports/plasmacomponents3/SwitchDelegate.qml src/declarativeimports/plasmacomponents3/SwitchIndicator.qml src/declarativeimports/plasmacomponents3/TabBar.qml src/declarativeimports/plasmacomponents3/TabButton.qml src/declarativeimports/plasmacomponents3/TextArea.qml src/declarativeimports/plasmacomponents3/TextField.qml src/declarativeimports/plasmacomponents3/ToolBar.qml src/declarativeimports/plasmacomponents3/ToolButton.qml src/declarativeimports/plasmacomponents3/ToolTip.qml src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml src/declarativeimports/plasmacomponents3/private/DefaultListItemBackground.qml src/declarativeimports/plasmacomponents3/private/RoundShadow.qml src/declarativeimports/plasmacomponents3/private/TextFieldFocus.qml src/declarativeimports/plasmacomponents3/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Closed] D4505: Stop linking X11_Xcursor_LIB in KScreenLocker
This revision was automatically updated to reflect the committed changes. Closed by commit R133:dd9a089cfaef: Stop linking X11_Xcursor_LIB in KScreenLocker (authored by broulik). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4505?vs=11068=11075 REVISION DETAIL https://phabricator.kde.org/D4505 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson, graesslin Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4505: Stop linking X11_Xcursor_LIB in KScreenLocker
graesslin accepted this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4505 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson, graesslin Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 603 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/603/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 16:30:58 + Build duration: 14 min CHANGE SET Revision f7e84d0de6e9066c13b4cd1986d6eed535d88490 by kde: ([Icons KCM] Take into account device pixel ratio for icon preview) change: edit kcms/icons/iconthemes.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 (67%)CONDITIONAL 1546/3761 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 95/219 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 (100%)CONDITIONAL 54/108 (50%)
[Differential] [Closed] D4504: [Icons KCM] Take into account device pixel ratio for icon preview
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f7e84d0de6e9: [Icons KCM] Take into account device pixel ratio for icon preview (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4504?vs=11067=11072 REVISION DETAIL https://phabricator.kde.org/D4504 AFFECTED FILES kcms/icons/iconthemes.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 733 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/733/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 16:28:44 + Build duration: 5 min 36 sec CHANGE SET Revision a7d56be57a1c1258608d8eb363191d69f40c12e3 by kde: ([System Tray] Introduce quot;effectiveStatusquot; property and update visibility) change: edit applets/systemtray/package/contents/ui/main.qml change: edit applets/systemtray/package/contents/ui/items/AbstractItem.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 (39%)CONDITIONAL 1631/5912 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 119/3235 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
[Differential] [Closed] D4488: [System Tray] Introduce "effectiveStatus" property and update visibility only when that changes
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a7d56be57a1c: [System Tray] Introduce "effectiveStatus" property and update visibility only… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4488?vs=11035=11071 REVISION DETAIL https://phabricator.kde.org/D4488 AFFECTED FILES applets/systemtray/package/contents/ui/items/AbstractItem.qml applets/systemtray/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 602 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/602/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 16:00:41 + Build duration: 15 min CHANGE SET Revision 8709b7edd5d17d2369e8ca4d261ec186387fa20e by David Edmundson: (Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting) change: edit applets/taskmanager/package/contents/ui/MouseHandler.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 (67%)CONDITIONAL 1546/3761 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 95/219 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 (100%)CONDITIONAL 54/108 (50%)
Plasma Meetings and To Do list
We traditionally have a kickoff meeting at the start of each Plasma cycle to review the schedule and todo board. This feels a bit weird since most of us are in the same room this week. We also pondered on a couple of other process features, first that we don't use the To Do board hardly at all between these kickoff meetings and secondly that our weekly Monday meetings are all about what we have done in the last week and not what we're blocked on or what we plan to do. https://phabricator.kde.org/project/view/35/ So I propose instead of a kickoff meeting we have a standing item at the weekly meeting to review the current WiP items on the board and ask why they're blocked if so and make it a weekly habit to add any items we plan to work on to the To Do and announce that at the meeting for discussion. If there's a more relevant board that should be used such as KWin that's fine too of course https://phabricator.kde.org/project/view/98/ Jonathan
[Differential] [Accepted] D4488: [System Tray] Introduce "effectiveStatus" property and update visibility only when that changes
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4488 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126016/#review102489 --- please post this again on phabricator if is still relevant - Marco Martin On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126016/ > --- > > (Updated Nov. 10, 2015, 6:54 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Previously the taskmanager library contained a special case logic for windows > of KDE-4 KCM modules (only). > These modules were recognised by finding wmClass=Kcmshell4. > This logic is extended to cover kcmshell5 windows as well, meaning that KCMs > written for Plasma 5 are properly recognised now. > The net benefit is that these KCMs are displayed in the task manager with > their proper KCM program icons. > > This patch can be pulled from the kcmshell5-task-url-fixes branch at: > g...@github.com:cmacq2/plasma-workspace.git > > > Diffs > - > > libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e > > Diff: https://git.reviewboard.kde.org/r/126016/diff/ > > > Testing > --- > > Built with kdesrc-build, and tested using: `plasmawindowed > org.kde.plasma.icontasks`. > I checked the change works as expected by running `which kcmshell5` style as > well as `kcmshell5 style`: the icon of the window matches that in system > settings (as expected). > > > Thanks, > > Johan Ouwerkerk > >
Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126016/ --- (Updated Feb. 8, 2017, 4:02 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- Previously the taskmanager library contained a special case logic for windows of KDE-4 KCM modules (only). These modules were recognised by finding wmClass=Kcmshell4. This logic is extended to cover kcmshell5 windows as well, meaning that KCMs written for Plasma 5 are properly recognised now. The net benefit is that these KCMs are displayed in the task manager with their proper KCM program icons. This patch can be pulled from the kcmshell5-task-url-fixes branch at: g...@github.com:cmacq2/plasma-workspace.git Diffs - libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e Diff: https://git.reviewboard.kde.org/r/126016/diff/ Testing --- Built with kdesrc-build, and tested using: `plasmawindowed org.kde.plasma.icontasks`. I checked the change works as expected by running `which kcmshell5` style as well as `kcmshell5 style`: the icon of the window matches that in system settings (as expected). Thanks, Johan Ouwerkerk
Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- (Updated Feb. 8, 2017, 4:02 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 343349 http://bugs.kde.org/show_bug.cgi?id=343349 Repository: plasma-framework Description --- For some fonts, QFontMetrics::boundingRect(QString) returns too high rect which makes the gridSize too big. It now returns correctly the actual height of M character. For backwards compatibility, the value is multiplied with 1.6. This affects eg. Noto Sans font that is now default for Plasma 5.5. Diffs - src/declarativeimports/core/units.h fa2256e src/declarativeimports/core/units.cpp 4e2adae src/plasma/theme.cpp c49ad4c Diff: https://git.reviewboard.kde.org/r/125773/diff/ Testing --- When switching to Noto Sans font, I noticed that icons in system tray grow to big size so it switched to 1 column in vertical panel. Basically everything in Plasma grow too much (even though the font is visually the same or even smaller than DejaVu Sans that I was using before - same font size 9 was used) - too big spacing in task manager, too big popups (application menu, system tray popups), etc ... This fixes the issue. This may also fix BUG 343349 File Attachments systray + popup before https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d409b391-e35e-451f-bb5b-aa42e7eb2bf3__before.png after https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png Thanks, David Rosca
Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/#review102488 --- please post this again on phabricator if is still relevant - Marco Martin On Oct. 29, 2015, 6:16 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125773/ > --- > > (Updated Oct. 29, 2015, 6:16 p.m.) > > > Review request for Plasma. > > > Bugs: 343349 > http://bugs.kde.org/show_bug.cgi?id=343349 > > > Repository: plasma-framework > > > Description > --- > > For some fonts, QFontMetrics::boundingRect(QString) returns too high rect > which makes the gridSize too big. > It now returns correctly the actual height of M character. For backwards > compatibility, the value is multiplied with 1.6. > > This affects eg. Noto Sans font that is now default for Plasma 5.5. > > > Diffs > - > > src/declarativeimports/core/units.h fa2256e > src/declarativeimports/core/units.cpp 4e2adae > src/plasma/theme.cpp c49ad4c > > Diff: https://git.reviewboard.kde.org/r/125773/diff/ > > > Testing > --- > > When switching to Noto Sans font, I noticed that icons in system tray grow to > big size so it switched to 1 column in vertical panel. Basically everything > in Plasma grow too much (even though the font is visually the same or even > smaller than DejaVu Sans that I was using before - same font size 9 was used) > - too big spacing in task manager, too big popups (application menu, system > tray popups), etc ... > > This fixes the issue. This may also fix BUG 343349 > > > File Attachments > > > systray + popup before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d409b391-e35e-451f-bb5b-aa42e7eb2bf3__before.png > after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/445009bc-a4a8-4998-8e82-996a0a4e33fb__after.png > > > Thanks, > > David Rosca > >
Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123682/
---
(Updated Feb. 8, 2017, 4:01 p.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Repository: plasma-desktop
Description
---
This patch ports the kcm fonts to QML.
Diffs
-
kcms/fonts/CMakeLists.txt d73636e
kcms/fonts/fonts.cpp 74da799
kcms/fonts/fonts.desktop 5b486ed
kcms/fonts/fonts.h d98bbe2
kcms/fonts/kcm_fonts.desktop PRE-CREATION
kcms/fonts/package/contents/ui/main.qml PRE-CREATION
kcms/fonts/package/metadata.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123682/diff/
Testing
---
Everything works execpt from the ComboBox and the FontDialog ("Configure Font").
* FontDialog
If you open the kcm inside from the system settings, everything is ok.
If you use kcmshell5 fonts, the FontDialog is opening behing the kcm window.
In order to solve this issue we must use the setTransientParent, but how can
i do that in the FontDialog?
* ComboBox
If you open the kcm with the "kcmshell5 fonts", the dropdown menu renders fine.
But if you open it inside from the system settings, the dropdown menu, renders
in the left of the ComboBox.
Also these two signals (main.qml line 295)
onDpiChanged
onAliasingChanged
are being emitted but the kcm.needsSave doesn't work...
File Attachments
fonts qml port
https://git.reviewboard.kde.org/media/uploaded/files/2015/05/19/467d70b7-69c8-4ad1-8da5-db0e9320bc03__fonts_qml2.png
Thanks,
Antonis Tsiapaliokas
Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123682/#review102487
---
please post this again on phabricator if is still relevant
- Marco Martin
On May 19, 2015, 2:47 p.m., Antonis Tsiapaliokas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123682/
> ---
>
> (Updated May 19, 2015, 2:47 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> ---
>
> This patch ports the kcm fonts to QML.
>
>
> Diffs
> -
>
> kcms/fonts/CMakeLists.txt d73636e
> kcms/fonts/fonts.cpp 74da799
> kcms/fonts/fonts.desktop 5b486ed
> kcms/fonts/fonts.h d98bbe2
> kcms/fonts/kcm_fonts.desktop PRE-CREATION
> kcms/fonts/package/contents/ui/main.qml PRE-CREATION
> kcms/fonts/package/metadata.desktop PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123682/diff/
>
>
> Testing
> ---
>
> Everything works execpt from the ComboBox and the FontDialog ("Configure
> Font").
>
> * FontDialog
>
> If you open the kcm inside from the system settings, everything is ok.
>
> If you use kcmshell5 fonts, the FontDialog is opening behing the kcm window.
> In order to solve this issue we must use the setTransientParent, but how can
> i do that in the FontDialog?
>
> * ComboBox
>
> If you open the kcm with the "kcmshell5 fonts", the dropdown menu renders
> fine.
>
> But if you open it inside from the system settings, the dropdown menu, renders
> in the left of the ComboBox.
>
>
> Also these two signals (main.qml line 295)
>
> onDpiChanged
> onAliasingChanged
>
> are being emitted but the kcm.needsSave doesn't work...
>
>
> File Attachments
>
>
> fonts qml port
>
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/19/467d70b7-69c8-4ad1-8da5-db0e9320bc03__fonts_qml2.png
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/#review102486 --- any news on this? please post this again on phabricator if is still relevant - Marco Martin On Sept. 12, 2015, 3:36 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125199/ > --- > > (Updated Sept. 12, 2015, 3:36 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > As requested by the VDG. > Rationale being that starting with an empty session all the time is > substantially less aggressive than potentially starting a gazillion > applications slowing down startup and greeting the user with a > cluttered desktop. > > > Diffs > - > > kcms/ksmserver/kcmsmserver.cpp fd8af008281e3fef016000280d670bd3ca54e53f > kcms/ksmserver/smserverconfigdlg.ui > 15a4d1cbb681e25f43f1d2cff438297c4412f81f > > Diff: https://git.reviewboard.kde.org/r/125199/diff/ > > > Testing > --- > > installed. wiped ksmserverrc. kcm shows empty session as default choice. > > > Thanks, > > Harald Sitter > >
Re: Review Request 125198: by default do not restore the previous session on next login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/ --- (Updated Feb. 8, 2017, 4 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- As requested by the VDG. Rationale being that starting with an empty session all the time is substantially less aggressive than potentially starting a gazillion applications slowing down startup and greeting the user with a cluttered desktop. Diffs - ksmserver/main.cpp 4808a80081c3f4322c0d1b3223fc65bcbfeb26c1 ksmserver/shutdown.cpp 636ae66fcce1d5c39fd697925b9094abc44e4808 Diff: https://git.reviewboard.kde.org/r/125198/diff/ Testing --- installed. wiped ksmserverrc. multiple logins always result in an empty session. Thanks, Harald Sitter
Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/ --- (Updated Feb. 8, 2017, 4:01 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- As requested by the VDG. Rationale being that starting with an empty session all the time is substantially less aggressive than potentially starting a gazillion applications slowing down startup and greeting the user with a cluttered desktop. Diffs - kcms/ksmserver/kcmsmserver.cpp fd8af008281e3fef016000280d670bd3ca54e53f kcms/ksmserver/smserverconfigdlg.ui 15a4d1cbb681e25f43f1d2cff438297c4412f81f Diff: https://git.reviewboard.kde.org/r/125199/diff/ Testing --- installed. wiped ksmserverrc. kcm shows empty session as default choice. Thanks, Harald Sitter
Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 601 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/601/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 15:43:51 + Build duration: 15 min CHANGE SET Revision ddb2e43cd4c8d3acc9eeece73ea7281a988ef8fa by David Edmundson: (Set buddy widgets in Font KCM) change: edit kcms/fonts/fonts.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 (67%)CONDITIONAL 1546/3761 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 600/1672 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 431/1110 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 95/219 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 (100%)CONDITIONAL 54/108 (50%)
Re: Review Request 125198: by default do not restore the previous session on next login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/#review102484 --- any news on this? please post this again on phabricator if is still relevant - Marco Martin On Sept. 12, 2015, 3:37 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125198/ > --- > > (Updated Sept. 12, 2015, 3:37 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > As requested by the VDG. > Rationale being that starting with an empty session all the time is > substantially less aggressive than potentially starting a gazillion > applications slowing down startup and greeting the user with a > cluttered desktop. > > > Diffs > - > > ksmserver/main.cpp 4808a80081c3f4322c0d1b3223fc65bcbfeb26c1 > ksmserver/shutdown.cpp 636ae66fcce1d5c39fd697925b9094abc44e4808 > > Diff: https://git.reviewboard.kde.org/r/125198/diff/ > > > Testing > --- > > installed. wiped ksmserverrc. multiple logins always result in an empty > session. > > > Thanks, > > Harald Sitter > >
Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128392/ --- (Updated Feb. 8, 2017, 3:59 p.m.) Status -- This change has been discarded. Review request for Plasma, KDE Usability and Eike Hein. Bugs: 365204 https://bugs.kde.org/show_bug.cgi?id=365204 Repository: plasma-desktop Description --- Likely kickoff should use icons from icon theme, not from plasma theme. https://bugs.kde.org/show_bug.cgi?id=365204 Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 Diff: https://git.reviewboard.kde.org/r/128392/diff/ Testing --- 1. Added kickoff applet to desktop 2. Swicthed from Breeze LAF to Oxygen 3. Rebooted 4. Kickoff got mixed Breeze and Oxygen icons (see screenshot in #365204) 5. Applied the patch 6. Rebooted 7. All Kickoff icons are properly set to Oxygen Thanks, Andrey Bondrov
Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128392/#review102483 --- please post this again on phabricator if is still relevant - Marco Martin On July 11, 2016, 10:51 a.m., Andrey Bondrov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128392/ > --- > > (Updated July 11, 2016, 10:51 a.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Bugs: 365204 > https://bugs.kde.org/show_bug.cgi?id=365204 > > > Repository: plasma-desktop > > > Description > --- > > Likely kickoff should use icons from icon theme, not from plasma theme. > > https://bugs.kde.org/show_bug.cgi?id=365204 > > > Diffs > - > > applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 > > Diff: https://git.reviewboard.kde.org/r/128392/diff/ > > > Testing > --- > > 1. Added kickoff applet to desktop > 2. Swicthed from Breeze LAF to Oxygen > 3. Rebooted > 4. Kickoff got mixed Breeze and Oxygen icons (see screenshot in #365204) > 5. Applied the patch > 6. Rebooted > 7. All Kickoff icons are properly set to Oxygen > > > Thanks, > > Andrey Bondrov > >
Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/ --- (Updated Feb. 8, 2017, 3:56 p.m.) Status -- This change has been discarded. Review request for Plasma, David Edmundson and Marco Martin. Repository: plasma-framework Description --- Enables to set rules that extends the #current-color-scheme CSS style of the Svg in order to change the Svg's items with currentColor fill to the specified in the customColors rules Diffs - src/plasma/private/svg_p.h 1d1000d src/plasma/svg.h 3a4ca1d src/plasma/svg.cpp 28abd00 Diff: https://git.reviewboard.kde.org/r/126720/diff/ Testing --- Thanks, Nico Rodsevich
Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review102482 --- please post this again on phabricator if is still relevant patch needed further work on it, if there will be need for this feature in the future probably better to rework it from the beginning - Marco Martin On Jan. 11, 2016, 9:37 p.m., Nico Rodsevich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126720/ > --- > > (Updated Jan. 11, 2016, 9:37 p.m.) > > > Review request for Plasma, David Edmundson and Marco Martin. > > > Repository: plasma-framework > > > Description > --- > > Enables to set rules that extends the #current-color-scheme CSS style of the > Svg in order to change the Svg's items with currentColor fill to the > specified in the customColors rules > > > Diffs > - > > src/plasma/private/svg_p.h 1d1000d > src/plasma/svg.h 3a4ca1d > src/plasma/svg.cpp 28abd00 > > Diff: https://git.reviewboard.kde.org/r/126720/diff/ > > > Testing > --- > > > Thanks, > > Nico Rodsevich > >
Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/ --- (Updated Feb. 8, 2017, 3:53 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: oxygen Description --- It's come up that there currently is no "official" preview for how checked menu items are rendered as a function of installed widget style. This patch explores a straightforward way of doing that via the most exhaustive style preview utility I am aware of, Oxygen's demo app. This demo already has menus in the MDI preview. The patch makes the layout items checkable and puts them in a QActionGroup so their mutually exclusive nature is taken into account. It also adds a "right to left" non-exclusive checkable item which is linked to the "Left to Right" checkbox in the demo frame. I looked for an appropriate way to uncheck the Tile/Cascade/Tabbed menu items (= when the user moves or resizes one of the MDI windows) but it seems those events are not available through signals and would thus require subclassing MdiSubWindow . Diffs - kstyle/demo/oxygendemodialog.h b296ec7 kstyle/demo/oxygendemodialog.cpp 4a742e3 kstyle/demo/oxygenmdidemowidget.h eafbeee kstyle/demo/oxygenmdidemowidget.cpp 3e5422e Diff: https://git.reviewboard.kde.org/r/128109/diff/ Testing --- On Linux and OS X with KF5 5.22.0 and Qt 5.6.0 File Attachments Screen Shot 2016-06-06 at 14.03.10.png https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/9d99ea87-8f35-4ad0-a15c-855ef80d7017__Screen_Shot_2016-06-06_at_14.03.10.png Screen Shot 2016-06-06 at 14.05.23.png https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/98364618-71c7-4715-864f-c6c0ce225544__Screen_Shot_2016-06-06_at_14.05.23.png Screen Shot 2016-06-06 at 14.07.04.png https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/948c598b-097c-438e-876f-88f6bbbfb30c__Screen_Shot_2016-06-06_at_14.07.04.png Thanks, René J.V. Bertin
Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/#review102481 --- please post this again on phabricator if is still relevant - Marco Martin On June 6, 2016, 12:08 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128109/ > --- > > (Updated June 6, 2016, 12:08 p.m.) > > > Review request for Plasma. > > > Repository: oxygen > > > Description > --- > > It's come up that there currently is no "official" preview for how checked > menu items are rendered as a function of installed widget style. > > This patch explores a straightforward way of doing that via the most > exhaustive style preview utility I am aware of, Oxygen's demo app. > > This demo already has menus in the MDI preview. The patch makes the layout > items checkable and puts them in a QActionGroup so their mutually exclusive > nature is taken into account. It also adds a "right to left" non-exclusive > checkable item which is linked to the "Left to Right" checkbox in the demo > frame. > > I looked for an appropriate way to uncheck the Tile/Cascade/Tabbed menu items > (= when the user moves or resizes one of the MDI windows) but it seems those > events are not available through signals and would thus require subclassing > MdiSubWindow . > > > Diffs > - > > kstyle/demo/oxygendemodialog.h b296ec7 > kstyle/demo/oxygendemodialog.cpp 4a742e3 > kstyle/demo/oxygenmdidemowidget.h eafbeee > kstyle/demo/oxygenmdidemowidget.cpp 3e5422e > > Diff: https://git.reviewboard.kde.org/r/128109/diff/ > > > Testing > --- > > On Linux and OS X with KF5 5.22.0 and Qt 5.6.0 > > > File Attachments > > > Screen Shot 2016-06-06 at 14.03.10.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/9d99ea87-8f35-4ad0-a15c-855ef80d7017__Screen_Shot_2016-06-06_at_14.03.10.png > Screen Shot 2016-06-06 at 14.05.23.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/98364618-71c7-4715-864f-c6c0ce225544__Screen_Shot_2016-06-06_at_14.05.23.png > Screen Shot 2016-06-06 at 14.07.04.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/948c598b-097c-438e-876f-88f6bbbfb30c__Screen_Shot_2016-06-06_at_14.07.04.png > > > Thanks, > > René J.V. Bertin > >
[Differential] [Commented On] D3562: [Task Manager] Create toolTipDelegate on demand
hein added a comment. In https://phabricator.kde.org/D3562#84078, @broulik wrote: > > destroy it when no longer needed > > When I disable the "show tooltips" setting or when I close the tooltip? I don't want to re-create the tooltip item everytime, though. Just the setting~ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3562 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 56 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 15:42:41 + Build duration: 6 min 25 sec CHANGE SET Revision 8709b7edd5d17d2369e8ca4d261ec186387fa20e by David Edmundson: (Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting) change: edit applets/taskmanager/package/contents/ui/MouseHandler.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 (67%)CONDITIONAL 1566/3802 (41%) By packages kcms.cursortheme.xcursor FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 22/98 (22%) kcms.keyboard FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 (49%)CONDITIONAL 619/1711 (36%) kcms.keyboard.preview FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 432/1112 (39%) kcms.keyboard.tests FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 236/358 (66%) kcms.krdb FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 108/196 (55%) kcms.lookandfeel FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 95/219 (43%) kcms.lookandfeel.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 (100%)CONDITIONAL 54/108 (50%)
Re: Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/ --- (Updated Feb. 8, 2017, 3:50 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- This is the first step towards not loosing the sort order of the task buttons in the task bar, even when plasmashell crashes and the user has a specific manual sort order. For now, we use the sort order imposed by the creation time (so the user can affect the sort order simply by ordering the creation of the windows). Once this patch is successful, we can expand sort order storage by storing the manual sort order offset in the X window properties each time that offset changes. This will make plasmashell crashes less damaging to a user who prefers a certain task button sort order (for the duration of the X session). Diffs - libtaskmanager/CMakeLists.txt 9c3e15e libtaskmanager/tasksmodel.cpp bf37042 libtaskmanager/xwindowtasksmodel.h d24a7d5 libtaskmanager/xwindowtasksmodel.cpp c1e9495 Diff: https://git.reviewboard.kde.org/r/128417/diff/ Testing --- Testing was performed under openSUSE 42.1 against KDE Plasma 5.7 Thanks, Xuân Baldauf
Re: Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/#review102480 --- please post this again on phabricator if is still relevant - Marco Martin On July 10, 2016, 12:15 a.m., Xuân Baldauf wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128417/ > --- > > (Updated July 10, 2016, 12:15 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This is the first step towards not loosing the sort order of the task buttons > in the task bar, even when plasmashell crashes and the user has a specific > manual sort order. For now, we use the sort order imposed by the creation > time (so the user can affect the sort order simply by ordering the creation > of the windows). > > Once this patch is successful, we can expand sort order storage by storing > the manual sort order offset in the X window properties each time that offset > changes. This will make plasmashell crashes less damaging to a user who > prefers a certain task button sort order (for the duration of the X session). > > > Diffs > - > > libtaskmanager/CMakeLists.txt 9c3e15e > libtaskmanager/tasksmodel.cpp bf37042 > libtaskmanager/xwindowtasksmodel.h d24a7d5 > libtaskmanager/xwindowtasksmodel.cpp c1e9495 > > Diff: https://git.reviewboard.kde.org/r/128417/diff/ > > > Testing > --- > > Testing was performed under openSUSE 42.1 against KDE Plasma 5.7 > > > Thanks, > > Xuân Baldauf > >
Re: Review Request 121207: Port the notes editor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/#review102478 --- please post this again on phabricator if is still relevant - Marco Martin On Nov. 22, 2014, 3:53 p.m., Giorgos Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121207/ > --- > > (Updated Nov. 22, 2014, 3:53 p.m.) > > > Review request for Plasma. > > > Repository: plasma-sdk > > > Description > --- > > This is a simple port of the noteseditor to KDevPlatform. > The internals have remained the same. > > Also I have attached an image showing the noteseditor inside > KDevelop > > > Diffs > - > > plasmate/noteseditor/noteseditor.h 2176456 > plasmate/noteseditor/noteseditor.cpp 6118d4e > plasmate/plugins/CMakeLists.txt 410080b > plasmate/plugins/noteseditor/CMakeLists.txt PRE-CREATION > plasmate/plugins/noteseditor/kdevnoteseditor.desktop.cmake PRE-CREATION > plasmate/plugins/noteseditor/kdevnoteseditor.rc PRE-CREATION > plasmate/plugins/noteseditor/noteseditorplugin.h PRE-CREATION > plasmate/plugins/noteseditor/noteseditorplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121207/diff/ > > > Testing > --- > > > File Attachments > > > noteseditor in kdevelop > > https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/6bdfb03a-444f-4368-b789-e7aeb9db6148__notes.png > > > Thanks, > > Giorgos Tsiapaliokas > >
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/#review102479 --- please post this again on phabricator if is still relevant - Marco Martin On April 7, 2015, 4:08 p.m., Giorgos Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121208/ > --- > > (Updated April 7, 2015, 4:08 p.m.) > > > Review request for Plasma. > > > Repository: plasma-sdk > > > Description > --- > > This is a port of the KConfigXtEditor to KDevPlatform. > The internals of the kconfigxteditor haven't changed. > > > Diffs > - > > CMakeLists.txt edf3938 > Plasmate.cmake PRE-CREATION > kconfigxteditor/CMakeLists.txt PRE-CREATION > plasmate/CMakeLists.txt 6e07b30 > plasmate/editors/kconfigxt/kconfigxteditor.h > plasmate/editors/kconfigxt/kconfigxteditor.cpp > plasmate/editors/kconfigxt/kconfigxteditor.ui > plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af > plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c > plasmate/editors/kconfigxt/kconfigxtreader.h > plasmate/editors/kconfigxt/kconfigxtreader.cpp > plasmate/editors/kconfigxt/kconfigxtwriter.h > plasmate/editors/kconfigxt/kconfigxtwriter.cpp > plasmate/editors/kconfigxt/standalone/main.cpp > plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 > plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp > plasmate/plugins/CMakeLists.txt 186880f > plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION > plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION > plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION > plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION > plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake > PRE-CREATION > plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION > plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121208/diff/ > > > Testing > --- > > > File Attachments > > > kconfigxteditor in kdevelop > > https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png > kconfig_xt_editor_document.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/fb1f6bb9-7af5-4ec5-980a-b6ee75588fc7__kconfig_xt_editor_document.png > > > Thanks, > > Giorgos Tsiapaliokas > >
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated Feb. 8, 2017, 3:49 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png kconfig_xt_editor_document.png https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/fb1f6bb9-7af5-4ec5-980a-b6ee75588fc7__kconfig_xt_editor_document.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 121207: Port the notes editor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/ --- (Updated Feb. 8, 2017, 3:49 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- This is a simple port of the noteseditor to KDevPlatform. The internals have remained the same. Also I have attached an image showing the noteseditor inside KDevelop Diffs - plasmate/noteseditor/noteseditor.h 2176456 plasmate/noteseditor/noteseditor.cpp 6118d4e plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/noteseditor/CMakeLists.txt PRE-CREATION plasmate/plugins/noteseditor/kdevnoteseditor.desktop.cmake PRE-CREATION plasmate/plugins/noteseditor/kdevnoteseditor.rc PRE-CREATION plasmate/plugins/noteseditor/noteseditorplugin.h PRE-CREATION plasmate/plugins/noteseditor/noteseditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121207/diff/ Testing --- File Attachments noteseditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/6bdfb03a-444f-4368-b789-e7aeb9db6148__notes.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 129095: KCM Cursor fix button size for select size
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129095/ --- (Updated Feb. 8, 2017, 3:48 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- fixe button height Diffs - kcms/cursortheme/xcursor/themepage.cpp 2a49e32 kcms/cursortheme/xcursor/themepage.ui 7e7d365 Diff: https://git.reviewboard.kde.org/r/129095/diff/ Testing --- Thanks, Andreas Kainz
Re: Review Request 129095: KCM Cursor fix button size for select size
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129095/#review102477 --- please post it again to phabricator if is still relevant - Marco Martin On Oct. 4, 2016, 2:17 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129095/ > --- > > (Updated Oct. 4, 2016, 2:17 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > fixe button height > > > Diffs > - > > kcms/cursortheme/xcursor/themepage.cpp 2a49e32 > kcms/cursortheme/xcursor/themepage.ui 7e7d365 > > Diff: https://git.reviewboard.kde.org/r/129095/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > >
Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/#review102476 --- any update on this? - Marco Martin On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129838/ > --- > > (Updated Jan. 15, 2017, 2:36 p.m.) > > > Review request for Plasma and Kåre Särs. > > > Bugs: 373776 > http://bugs.kde.org/show_bug.cgi?id=373776 > > > Repository: kdeplasma-addons > > > Description > --- > > See bug #373776 > The CPU bars do not show a value when using separate bars per CPU, and the > tooltip never > shows a value per CPU, since the data sources per CPU are not subscribed. > > AFAICT this could never have worked. > > > Diffs > - > > applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 > > Diff: https://git.reviewboard.kde.org/r/129838/diff/ > > > Testing > --- > > yes > > > Thanks, > > Martin Koller > >
Re: Review Request 126902: Set buddy widgets in Font KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126902/ --- (Updated Feb. 8, 2017, 3:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit ddb2e43cd4c8d3acc9eeece73ea7281a988ef8fa by David Edmundson to branch master. Repository: plasma-desktop Description --- So pressing alt+G (for General) focusses the relevant font requester button. Diffs - kcms/fonts/fonts.cpp 07297bb660e4fd16059978f3b0e539d377542de0 Diff: https://git.reviewboard.kde.org/r/126902/diff/ Testing --- Thanks, David Edmundson
[Differential] [Closed] D4476: Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8709b7edd5d1: Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4476?vs=11013=11070#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4476?vs=11013=11070 REVISION DETAIL https://phabricator.kde.org/D4476 AFFECTED FILES applets/taskmanager/package/contents/ui/MouseHandler.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, hein Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 129867: Complete oxygen look and feel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129867/#review102475 --- Ship it! should be either pushed quicly or moved to phabricator - Marco Martin On Jan. 22, 2017, 7:56 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129867/ > --- > > (Updated Jan. 22, 2017, 7:56 p.m.) > > > Review request for Plasma, Hugo Pereira Da Costa and Marco Martin. > > > Repository: oxygen > > > Description > --- > > Applying oxygen in lookandfeel kcm should set desktop theme and decorations > to oxygen > > > Diffs > - > > lookandfeel/contents/defaults 571a7c65 > > Diff: https://git.reviewboard.kde.org/r/129867/diff/ > > > Testing > --- > > > Thanks, > > Anthony Fieroni > >
Plasma 5.10 Schedule
I'm reminded that I'm wonderfully organised and already penciled in a release schedule for Plasma 5.10 and indeed 5.11 as well as some more 5.8LTS releases https://community.kde.org/Schedules/Plasma_5 https://calendar.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com=Europe/London This should not clash with Applications or Frameworks releases I think Three more months to go for 5.10 development. Repo freeze at end April, feature freeze and beta May 11, release tars May 25 for release end of May. Jonathan
Re: Review Request 129315: Don't install plasmoid desktop files as services
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- (Updated Feb. 8, 2017, 3:37 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- It shouldn't have an impact anymore. Diffs - KF5PlasmaMacros.cmake 5827854 Diff: https://git.reviewboard.kde.org/r/129315/diff/ Testing --- Thanks, Aleix Pol Gonzalez
Re: Review Request 128484: Don't set a Window Icon on Plamsa::Dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128484/ --- (Updated Feb. 8, 2017, 3:36 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- It's practically never visible. Window flags are always masked with FramelessWindowHint and we always have the state NET::SkipTaskbar | NET::SkipPager set. (There is theoretically a code path that would allow an icon to be visible in some kwin effects that overlay icons..but not triggerable by anything in Plasma, at which point why would you want a Plasma icon anyway) This saves a bit of memory (up to 512K) as window icons are always loaded at every size to set the _NET_WM_ICON. Diffs - src/plasmaquick/dialog.cpp be7406725ff0876f7ebee63c752e6ea84f90e577 Diff: https://git.reviewboard.kde.org/r/128484/diff/ Testing --- Thanks, David Edmundson
Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/ --- (Updated Feb. 8, 2017, 3:33 p.m.) Status -- This change has been discarded. Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- Allow to scroll navigate back/forward in DaysCalendar in the entire DaysCalendar component, not just on header label. Diffs - src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 Diff: https://git.reviewboard.kde.org/r/125891/diff/ Testing --- Thanks, David Rosca
Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/#review102473 --- this seems superseded by the zoom feature in the calendar. please move it to phabricator if still vlaid - Marco Martin On Oct. 31, 2015, 4:21 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125891/ > --- > > (Updated Oct. 31, 2015, 4:21 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-framework > > > Description > --- > > Allow to scroll navigate back/forward in DaysCalendar in the entire > DaysCalendar component, not just on header label. > > > Diffs > - > > src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 > > Diff: https://git.reviewboard.kde.org/r/125891/diff/ > > > Testing > --- > > > Thanks, > > David Rosca > >
Re: Review Request 126115: Unset environment variables before starting kwin_wayland
> On Feb. 8, 2017, 2:42 p.m., Marco Martin wrote: > > is this still valid? please move it to phabricator if still valid - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/#review102469 --- On Nov. 19, 2015, 12:22 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126115/ > --- > > (Updated Nov. 19, 2015, 12:22 p.m.) > > > Review request for Plasma, David Edmundson and Matthias Klumpp. > > > Repository: plasma-workspace > > > Description > --- > > Any environment variable which can be used to specify a path to a > binary object to be loaded in the KWin process bears the risk of > being abused to add code to KWin to perform as a key logger. > > E.g. an env variable pointing QT_PLUGIN_PATH to a location in $HOME > and adjusting QT_STYLE_OVERRIDE to load a specific QStyle plugin from > that location would allow to easily log all keys without KWin noticing. > > As env variables can be specified in scripts sourced before the session > starts there is not much KWin can do about that to protect itself. > > This affects all the LD_* variables and any library KWin uses and > loads plugins. > > The list here is based on what I could find: > * LD_* variables as specified in the man page > * LIBGL_* and EGL_* as specified on mesa page > * QT_* variables based on "git grep qgetenv" in qtbase and qtdeclarative > combined with Qt's documentation > * "git grep getenv" in various KDE frameworks based on ldd output of KWin > > Unfortunately the list is unlikely to be complete. If one env variable is > missed, there is a risk. Even more each change in any library might > introduce new variables. > > The approach is futile, but needed till Linux has a secure way to start > the session without sourcing env variable scripts from user owned > locations. > > > Diffs > - > > startkde/startplasmacompositor.cmake > 1e46e5be0a0d733fb01e1a87a34ee3c73a06bf8c > > Diff: https://git.reviewboard.kde.org/r/126115/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > >
Re: Review Request 126115: Unset environment variables before starting kwin_wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/ --- (Updated Feb. 8, 2017, 3:32 p.m.) Status -- This change has been discarded. Review request for Plasma, David Edmundson and Matthias Klumpp. Repository: plasma-workspace Description --- Any environment variable which can be used to specify a path to a binary object to be loaded in the KWin process bears the risk of being abused to add code to KWin to perform as a key logger. E.g. an env variable pointing QT_PLUGIN_PATH to a location in $HOME and adjusting QT_STYLE_OVERRIDE to load a specific QStyle plugin from that location would allow to easily log all keys without KWin noticing. As env variables can be specified in scripts sourced before the session starts there is not much KWin can do about that to protect itself. This affects all the LD_* variables and any library KWin uses and loads plugins. The list here is based on what I could find: * LD_* variables as specified in the man page * LIBGL_* and EGL_* as specified on mesa page * QT_* variables based on "git grep qgetenv" in qtbase and qtdeclarative combined with Qt's documentation * "git grep getenv" in various KDE frameworks based on ldd output of KWin Unfortunately the list is unlikely to be complete. If one env variable is missed, there is a risk. Even more each change in any library might introduce new variables. The approach is futile, but needed till Linux has a secure way to start the session without sourcing env variable scripts from user owned locations. Diffs - startkde/startplasmacompositor.cmake 1e46e5be0a0d733fb01e1a87a34ee3c73a06bf8c Diff: https://git.reviewboard.kde.org/r/126115/diff/ Testing --- Thanks, Martin Gräßlin
Re: Review Request 125926: [Image Wallpaper] Take into account orientation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125926/ --- (Updated Feb. 8, 2017, 3:30 nachm.) Status -- This change has been discarded. Review request for Plasma. Bugs: 352555 https://bugs.kde.org/show_bug.cgi?id=352555 Repository: plasma-workspace Description --- The distance method only cares for a match in terms of pixel numbers, not the actual orientation. Diffs - wallpapers/image/image.cpp 1b8d2dd Diff: https://git.reviewboard.kde.org/r/125926/diff/ Testing --- Placed a 1440x2560 picture in my image package, it used to get picked and stretched, not it properly takes the 2560x1440 image consistently, or if not present, fall back to a different resolution image. Thanks, Kai Uwe Broulik
[Differential] [Accepted] D4504: [Icons KCM] Take into account device pixel ratio for icon preview
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4504 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4505: Stop linking X11_Xcursor_LIB in KScreenLocker
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4505 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, graesslin, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Commented On] D4366: WIP: Add screen recorder interface
fredrik added a comment.
I know this revision has been abandoned, but I wanted to comment on a few
things for future reference.
INLINE COMMENTS
> screencast.cpp:105
> +
> +QRect geometry = effects->virtualScreenGeometry();
> +
I strongly suggest that you use the damage information from kwin and only
download the parts of the framebuffer that have actually changed. This can make
a massive difference in performance.
You can keep a screen sized QImage around and keep it in sync by updating areas
as they change.
> screencast.cpp:107
> +
> +GLTexture tex(GL_RGBA8, geometry.width(), geometry.height());
> +GLRenderTarget target(tex);
Why do you use an intermediate texture instead of reading directly from the
framebuffer in the desktop GL case?
You create the texture and blit the framebuffer into it in the GLES case, even
though you don't use it.
> screencast.cpp:109
> +GLRenderTarget target(tex);
> +target.blitFromFramebuffer(geometry);
> +
There is no need to use a RenderTarget here. Use glCopyTexSubImage2D() instead,
which copies from the framebuffer to the currently bound texture.
> screencast.cpp:114
> +
> +auto img = QImage(geometry.size(), QImage::Format_RGB888);
> +if (GLPlatform::instance()->isGLES()) {
Don't read back data directly to client memory. Instead create a
GL_PIXEL_PACK_BUFFER and download the image into it. That way
glReadPixels()/glGetTexImage() schedules the copy, but doesn't block and wait
for it to finish. Wait at least one frame before you access the contents of the
buffer.
> screencast.cpp:116
> +if (GLPlatform::instance()->isGLES()) {
> +glReadPixels(0, 0, img.width(), img.height(), GL_RGB,
> GL_UNSIGNED_BYTE, (GLvoid*)img.bits());
> +} else {
Never read back data as GL_RGB. Three component formats are not supported in
hardware, so this involves at least a partial software fallback.
The only format/type combination a GLES implementation is required to support
is also GL_RGBA/GL_UNSIGNED_BYTE.
I also note that you immediately convert the image to a four-component format
below.
> screencast.cpp:118
> +} else {
> +glGetTexImage(GL_TEXTURE_2D, 0, GL_RGB, GL_UNSIGNED_BYTE,
> (GLvoid*)img.bits());
> +}
If you need the image to be in QImage::Format_ARGB32, you should read back the
data as GL_BGRA/GL_UNSIGNED_INT_8_8_8_8_REV. This is the GL equivalent of
QImage::Format_ARGB32.
> screencast.cpp:121
> +img = img.convertToFormat(QImage::Format_ARGB32);
> +img = img.mirrored();
> +tex.unbind();
Use GL_MESA_pack_invert and GL_ANGLE_pack_reverse_row_order so the image is
downloaded in the correct orientation.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D4366
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: fredrik, graesslin, subdiff, plasma-devel, kwin, #kwin, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
[Differential] [Request, 1 line] D4505: Stop linking X11_Xcursor_LIB in KScreenLocker
broulik created this revision. broulik added reviewers: Plasma, graesslin. broulik set the repository for this revision to R133 KScreenLocker. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's not used. BUG: 376068 TEST PLAN Still builds REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4505 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, graesslin Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 124870: RTL support for Buttons and TabBar animation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124870/ --- (Updated Feb. 8, 2017, 3 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- Button and ToolButton icon is now properly reversed as well as the TabBar animation (Eg. in Kickoff) now matches the Tab order Diffs - src/declarativeimports/plasmacomponents/qml/TabGroup.qml 277ca47 src/declarativeimports/plasmastyle/ButtonStyle.qml 23adbcb src/declarativeimports/plasmastyle/ToolButtonStyle.qml 4872477 Diff: https://git.reviewboard.kde.org/r/124870/diff/ Testing --- Works. I was wondering if we should place a LayoutMirroring enabled/childrenInherit into our containments or applet appearance and what not? Thanks, Kai Uwe Broulik
[Differential] [Request, 13 lines] D4504: [Icons KCM] Take into account device pixel ratio for icon preview
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While at it, fill the pixmap with transparent color instead of window color as the background inside a tab page in Breeze is lighter than the window. TEST PLAN Originally posted as https://git.reviewboard.kde.org/r/125916 but with comments addressed REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4504 AFFECTED FILES kcms/icons/iconthemes.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 125916: [kcm icons] Take into account device pixel ratio for icon preview
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125916/ --- (Updated Feb. 8, 2017, 2:59 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- Take into account device pixel ratio for icon theme preview Diffs - kcms/icons/iconthemes.cpp 5304cf6 Diff: https://git.reviewboard.kde.org/r/125916/diff/ Testing --- No more blurry Breeze icons. Oxygen is blocky here a bit because the default size is 48px and there is no 96px icon size. Thanks, Kai Uwe Broulik
Re: Review Request 126115: Unset environment variables before starting kwin_wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126115/#review102469 --- is this still valid? - Marco Martin On Nov. 19, 2015, 12:22 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126115/ > --- > > (Updated Nov. 19, 2015, 12:22 p.m.) > > > Review request for Plasma, David Edmundson and Matthias Klumpp. > > > Repository: plasma-workspace > > > Description > --- > > Any environment variable which can be used to specify a path to a > binary object to be loaded in the KWin process bears the risk of > being abused to add code to KWin to perform as a key logger. > > E.g. an env variable pointing QT_PLUGIN_PATH to a location in $HOME > and adjusting QT_STYLE_OVERRIDE to load a specific QStyle plugin from > that location would allow to easily log all keys without KWin noticing. > > As env variables can be specified in scripts sourced before the session > starts there is not much KWin can do about that to protect itself. > > This affects all the LD_* variables and any library KWin uses and > loads plugins. > > The list here is based on what I could find: > * LD_* variables as specified in the man page > * LIBGL_* and EGL_* as specified on mesa page > * QT_* variables based on "git grep qgetenv" in qtbase and qtdeclarative > combined with Qt's documentation > * "git grep getenv" in various KDE frameworks based on ldd output of KWin > > Unfortunately the list is unlikely to be complete. If one env variable is > missed, there is a risk. Even more each change in any library might > introduce new variables. > > The approach is futile, but needed till Linux has a secure way to start > the session without sourcing env variable scripts from user owned > locations. > > > Diffs > - > > startkde/startplasmacompositor.cmake > 1e46e5be0a0d733fb01e1a87a34ee3c73a06bf8c > > Diff: https://git.reviewboard.kde.org/r/126115/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > >
Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 55 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 14:07:11 + Build duration: 27 min CHANGE SET Revision ee26a139378535042411a345fea7d73efc79a73f by kde: ([Clipboard plasmoid] Fix line breaks) change: edit applets/clipboard/contents/ui/ClipboardItemDelegate.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 (39%)CONDITIONAL 1631/5912 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 119/3235 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 732 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/732/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Feb 2017 14:07:36 + Build duration: 26 min CHANGE SET Revision ee26a139378535042411a345fea7d73efc79a73f by kde: ([Clipboard plasmoid] Fix line breaks) change: edit applets/clipboard/contents/ui/ClipboardItemDelegate.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.appstreamtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2332/5964 (39%)CONDITIONAL 1631/5912 (28%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 42/72 (58%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 37/72 (51%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 119/3235 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) runners.services FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 117/206 (57%) runners.services.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 50/90 (56%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 20/76 (26%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 15/30 (50%)
Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- (Updated Feb. 8, 2017, 2:32 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kdeplasma-addons Description --- port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start I'd like somebody to have a look at it to tell me, if I'm on the right way or if I'm completely wrong Diffs - applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 applets/binary-clock/CMakeLists.txt b42a6e76752af3cc800ad5455ba0678a18a0ce45 applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 applets/binary-clock/binaryclock.cpp 75c4548588ff15e2316dd1c2e888ad8c07f7f78b applets/binary-clock/clockConfig.ui 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 applets/binary-clock/package/contents/config/config.qml PRE-CREATION applets/binary-clock/package/contents/config/main.xml PRE-CREATION applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION applets/binary-clock/package/contents/ui/main.qml PRE-CREATION applets/binary-clock/plasma-applet-binaryclock.desktop 9f9229bd3ef2a2a31fc545cfbc60702f0bb411b5 Diff: https://git.reviewboard.kde.org/r/120325/diff/ Testing --- It works on the desktop, but the dots are too small in the panel Thanks, Joseph Wenninger
Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/#review102468 --- Cleaned up patch and moved into: https://phabricator.kde.org/D4503 - David Edmundson On Oct. 1, 2014, 8:21 p.m., Joseph Wenninger wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120325/ > --- > > (Updated Oct. 1, 2014, 8:21 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > port of the kde4 c++ based binary clock to kf5/qml only. It works on the > desktop, but some sizing/dot sizeing issues exist in the panels. At least it > is a start > > I'd like somebody to have a look at it to tell me, if I'm on the right way or > if I'm completely wrong > > > Diffs > - > > applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 > applets/binary-clock/CMakeLists.txt > b42a6e76752af3cc800ad5455ba0678a18a0ce45 > applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 > applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 > applets/binary-clock/binaryclock.cpp > 75c4548588ff15e2316dd1c2e888ad8c07f7f78b > applets/binary-clock/clockConfig.ui > 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 > applets/binary-clock/package/contents/config/config.qml PRE-CREATION > applets/binary-clock/package/contents/config/main.xml PRE-CREATION > applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION > applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION > applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION > applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION > applets/binary-clock/package/contents/ui/main.qml PRE-CREATION > applets/binary-clock/plasma-applet-binaryclock.desktop > 9f9229bd3ef2a2a31fc545cfbc60702f0bb411b5 > > Diff: https://git.reviewboard.kde.org/r/120325/diff/ > > > Testing > --- > > It works on the desktop, but the dots are too small in the panel > > > Thanks, > > Joseph Wenninger > >
[Differential] [Request, 1,077 lines] D4503: Binary clock QML applet
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Patch by Joseph Wenninger Taken from: https://git.reviewboard.kde.org/r/120325/ TEST PLAN Seems to work quite well; only issue is it goes into compact mode in a Panel a bit prematurely. Rest looks fine. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4503 AFFECTED FILES applets/CMakeLists.txt applets/binary-clock/CMakeLists.txt applets/binary-clock/Messages.sh applets/binary-clock/binaryclock.h applets/binary-clock/clockConfig.ui applets/binary-clock/package/contents/config/config.qml applets/binary-clock/package/contents/config/main.xml applets/binary-clock/package/contents/ui/BinaryClock.qml applets/binary-clock/package/contents/ui/Dot.qml applets/binary-clock/package/contents/ui/DotColumn.qml applets/binary-clock/package/contents/ui/configGeneral.qml applets/binary-clock/package/contents/ui/main.qml applets/binary-clock/package/metadata.desktop applets/binary-clock/plasma-applet-binaryclock.desktop EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 124543: Don't horizontally shift dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124543/ --- (Updated Feb. 8, 2017, 2:25 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- When placing an applet on the far right corner of the screen (eg. analog clock), its popup would appear diagonally shifted to the left rather than at the screen edge. Diffs - src/plasmaquick/dialog.cpp 6770c1a Diff: https://git.reviewboard.kde.org/r/124543/diff/ Testing --- It no longer does that but I don't know what other implications this voodoo has. On the other hand, the dialogs usually pop out at the top or bottom (for free floating) and this stuff isn't touched, just the horizontal shifting removed. Thanks, Kai Uwe Broulik
Re: Review Request 124310: Improve quick chat widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124310/ --- (Updated Feb. 8, 2017, 2:25 nachm.) Status -- This change has been discarded. Review request for Plasma and Telepathy. Repository: ktp-desktop-applets Description --- This improves the chat widget by: - Not hardcoding the hader size - Using a heading for the name so it stands out a bit more (since it's often not obvious at a glance who you're writing to) - Giving it a proper scroll bar - Making the auto scrolling a bit more robust - Cleaing up the code a bit Diffs - chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 4e802c7 Diff: https://git.reviewboard.kde.org/r/124310/diff/ Testing --- Been using it for a while, works nicely and looks better Thanks, Kai Uwe Broulik
Re: Review Request 125897: [Clipboard plasmoid] Fix line breaks
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125897/ --- (Updated Feb. 8, 2017, 2:24 nachm.) Status -- This change has been marked as submitted. Review request for Plasma, KDE Usability and Martin Gräßlin. Repository: plasma-workspace Description --- This fixes the list only showing one line of text instead of the supposed maximum of 3 lines. I'm unsure about the "m" modifier, however. With it, it highlights leading and trailing whitespace on any line which can be nice but also somewhat distracting depending on what you copied. On the other hand, only doing it for the first line (as is now but wasnt apparent because we only showed one line) is also strange. Especially when you use spaces rather than line breaks you can get quite a few "space" indicators.. (I can split the patch though, broken multiline display is definitely a bug) Diffs - applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 Diff: https://git.reviewboard.kde.org/r/125897/diff/ Testing --- Works File Attachments With multiline modifier https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png Without (currently) https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png Thanks, Kai Uwe Broulik
Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/ --- (Updated Feb. 8, 2017, 2:24 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- We have the version number of the theme and some mtime heuristic yet still we often end up with a broken theme after upgrades when it is changed, when downstreams forget to adjust the version in their theme and so on. (I just noticed I never delete the old theme caches...) Diffs - src/plasma/private/theme_p.cpp 18419bb Diff: https://git.reviewboard.kde.org/r/126642/diff/ Testing --- Thanks, Kai Uwe Broulik
Re: Review Request 127318: [Applet] Actually delete applet when undo times out
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127318/ --- (Updated Feb. 8, 2017, 2:23 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- When the undo timer fires the undo notification is removed but the applet isn't actually removed and re-appears after you restart plasma. Diffs - src/plasma/private/applet_p.cpp 14b1deb Diff: https://git.reviewboard.kde.org/r/127318/diff/ Testing --- Removed applet, pressed X on notification, restarted plasma -> applet permanently gone Removed applet, pressed "Undo" -> applet re-appeared Removed applet, waited 60s, restarted plasma -> applet permanently gone Thanks, Kai Uwe Broulik
Re: Review Request 128895: Return high-resolution line edit clear icon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128895/ --- (Updated Feb. 8, 2017, 2:09 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks, Plasma and Hugo Pereira Da Costa. Repository: frameworkintegration Description --- Qt just returns a 16px pixmap by default leading to blurry results when larger icon sizes for small icons are configured by the user. Diffs - src/kstyle/kstyle.cpp 3b47a74 Diff: https://git.reviewboard.kde.org/r/128895/diff/ Testing --- More upstream version of Review 128630 Thanks, Kai Uwe Broulik
[Differential] [Closed] D4497: [Clipboard plasmoid] Fix line breaks
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee26a1393785: [Clipboard plasmoid] Fix line breaks (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4497?vs=11057=11063 REVISION DETAIL https://phabricator.kde.org/D4497 AFFECTED FILES applets/clipboard/contents/ui/ClipboardItemDelegate.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, graesslin, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Differential] [Accepted] D4497: [Clipboard plasmoid] Fix line breaks
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4497 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, graesslin, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125568/ --- (Updated Feb. 8, 2017, 1:47 p.m.) Status -- This change has been discarded. Review request for Plasma. Description --- SVG elements done from scratch, reused only a small portion of the existing files. Colors now match Breeze colorscheme. Buttons now match widget style. Icons in the system tray are taken from the icon theme. Icons in Kickoff are not monochromatic as only 16px and 22px icons are monochrome in Breeze. Better padding overall for elements. New visual for both task manager widgets that matches the states of the buttons. Checkboxes, radio buttons, sliders and scrollbars now have the colors used in the Breeze colorscheme. Diffs - Diff: https://git.reviewboard.kde.org/r/125568/diff/ Testing ---     Thanks, Uri Herrera
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review102465 --- if this patch is still relevant, please repost it to phabricator.kde.org - Marco Martin On July 19, 2015, 2:25 p.m., Bernhard Friedreich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124394/ > --- > > (Updated July 19, 2015, 2:25 p.m.) > > > Review request for Plasma. > > > Bugs: 347492 > http://bugs.kde.org/show_bug.cgi?id=347492 > > > Repository: kdeplasma-addons > > > Description > --- > > I'm trying to fix a missing translation in the timer applets config file > (config.xml using kcfg) but I can't get it to work :( > > David Edmundson commented in the bug if this fixed it - I don't think so - or > at least I don't understand what to do with it.. > https://git.reviewboard.kde.org/r/123872/ > > Any suggestions? > > > Diffs > - > > applets/timer/package/contents/config/main.xml > 833bf8f45df4f0e468301a426852bf01c94e1221 > > Diff: https://git.reviewboard.kde.org/r/124394/diff/ > > > Testing > --- > > Tried adding the applet - the full i18n String is used instead of a > translation/the original string > > > Thanks, > > Bernhard Friedreich > >
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated Feb. 8, 2017, 1:46 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich
Re: Review Request 123382: System tray: Show more than 8 entries.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123382/ --- (Updated Feb. 8, 2017, 1:30 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 341165 https://bugs.kde.org/show_bug.cgi?id=341165 Repository: plasma-workspace Description --- When there are more than 8 hidden items in the system tray, the system tray doesn't show the rest. This patch is changing the default height of the system tray based on the total count of all of our entries. So if all of our entries become hidden, we will still have enought space to show all of them. Diffs - applets/systemtray/package/contents/ui/main.qml fd59a14 Diff: https://git.reviewboard.kde.org/r/123382/diff/ Testing --- Everything works fine. The opacity in the screenshots is because the popup is losing the focus.. File Attachments system tray with less items https://git.reviewboard.kde.org/media/uploaded/files/2015/04/16/ec87e90e-697b-4eaf-8ed6-d37501a18b90__systemtray.png system tray with more items https://git.reviewboard.kde.org/media/uploaded/files/2015/04/16/0067ff99-ec2f-4a74-a310-57c16f06f256__systemtray2.png Thanks, Antonis Tsiapaliokas
Re: Review Request 123382: System tray: Show more than 8 entries.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123382/#review102464 --- systray has been rewritten, not valid anymore - Marco Martin On April 16, 2015, 11:32 a.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123382/ > --- > > (Updated April 16, 2015, 11:32 a.m.) > > > Review request for Plasma. > > > Bugs: 341165 > https://bugs.kde.org/show_bug.cgi?id=341165 > > > Repository: plasma-workspace > > > Description > --- > > When there are more than 8 hidden items in the system tray, the system tray > doesn't show the rest. > This patch is changing the default height of the system tray based on the > total count of all of our entries. > So if all of our entries become hidden, we will still have enought space to > show all of them. > > > Diffs > - > > applets/systemtray/package/contents/ui/main.qml fd59a14 > > Diff: https://git.reviewboard.kde.org/r/123382/diff/ > > > Testing > --- > > Everything works fine. > The opacity in the screenshots is because the popup is losing the focus.. > > > File Attachments > > > system tray with less items > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/16/ec87e90e-697b-4eaf-8ed6-d37501a18b90__systemtray.png > system tray with more items > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/16/0067ff99-ec2f-4a74-a310-57c16f06f256__systemtray2.png > > > Thanks, > > Antonis Tsiapaliokas > >
Re: Review Request 123271: improve kickoff representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated Feb. 8, 2017, 1:29 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button. Diffs - applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123271/diff/ Testing --- see screenshots File Attachments kickoff-horizontal-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png kickoff-horizontal-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png kickoff-vertical-before https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png kickoff-vertical-after https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png Thanks, Mathias Kraus
[Differential] [Closed] D4492: [KHintsSettings] Emit QGuiApplication::paletteChanged when run as QApplication
This revision was automatically updated to reflect the committed changes. Closed by commit R135:ab3298b3f5f7: [KHintsSettings] Emit QGuiApplication::paletteChanged when run as QApplication (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4492?vs=11042=11062 REVISION DETAIL https://phabricator.kde.org/D4492 AFFECTED FILES src/platformtheme/khintssettings.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 123271: improve kickoff representation on vertical panels
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review102463 --- kickoff has been rewritten, the patch is not valid anymore. if still interested, please update on new kickoff implementation and post it on phabricator - Marco Martin On April 7, 2015, 9:56 p.m., Mathias Kraus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123271/ > --- > > (Updated April 7, 2015, 9:56 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > In vertical panels, the kickoff button is huge. This patch limits the size of > the kickoff button. > > > Diffs > - > > applets/kickoff/package/contents/ui/CompactRepresentation.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123271/diff/ > > > Testing > --- > > see screenshots > > > File Attachments > > > kickoff-horizontal-before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png > kickoff-horizontal-after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png > kickoff-vertical-before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png > kickoff-vertical-after > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png > > > Thanks, > > Mathias Kraus > >
Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122653/ --- (Updated Feb. 8, 2017, 1:28 p.m.) Status -- This change has been discarded. Review request for kdelibs, Plasma and Christoph Feck. Bugs: 339193 http://bugs.kde.org/show_bug.cgi?id=339193 Repository: kde-runtime Description --- KFileItem uses UDS_ACCESS to determine permissions. Readability is subsequently used to create the list of overlay icons. CCBUG: 339193 Diffs - kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661 Diff: https://git.reviewboard.kde.org/r/122653/diff/ Testing --- dolphin remote: -> no lock icon on smb:, mtp:, ... links Thanks, Stefan Brüns
Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122653/#review102462 --- kde4 patch, not valid anymore - Marco Martin On March 17, 2015, 4:49 p.m., Stefan Brüns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122653/ > --- > > (Updated March 17, 2015, 4:49 p.m.) > > > Review request for kdelibs, Plasma and Christoph Feck. > > > Bugs: 339193 > http://bugs.kde.org/show_bug.cgi?id=339193 > > > Repository: kde-runtime > > > Description > --- > > KFileItem uses UDS_ACCESS to determine permissions. Readability is > subsequently used to create the list of overlay icons. > > CCBUG: 339193 > > > Diffs > - > > kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661 > > Diff: https://git.reviewboard.kde.org/r/122653/diff/ > > > Testing > --- > > dolphin remote: > -> no lock icon on smb:, mtp:, ... links > > > Thanks, > > Stefan Brüns > >
Re: Review Request 127315: Icon applet: Set sensible minimum height
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127315/ --- (Updated Feb. 8, 2017, 1:24 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description --- ^^ Diffs - applets/icon/package/contents/ui/main.qml acc493a Diff: https://git.reviewboard.kde.org/r/127315/diff/ Testing --- Icon is now always visible Thanks, David Rosca
[Differential] [Closed] D4481: [Color Picker] Close popup when picking a color
This revision was automatically updated to reflect the committed changes. Closed by commit R114:b3fb3f4b7186: [Color Picker] Close popup when picking a color (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4481?vs=11020=11061 REVISION DETAIL https://phabricator.kde.org/D4481 AFFECTED FILES applets/colorpicker/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review102460 --- if this patch is still relevant, please repost it to phabricator.kde.org as is new features for baloo, that are not even planned to be used anymore, it's safer to just discard it. feel free to resurrect it on phabricator - Marco Martin On Dec. 2, 2014, 12:18 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120777/ > --- > > (Updated Dec. 2, 2014, 12:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > --- > > At the moment, Baloo doesn't provide a timeline, which is something that we > need for the activefilebrowser. > So this new component, is introducing support for the timeline. > > Notes > === > > * Baloocloud component contains the org.kde.baloo component inside it.The > reason behind that, is that the implementation for the timeline is kind of > terible because of its perfomance. > * I have put the new component inside the plasma-mobile repository, for the > above reason. But if the Baloo team, wants it inside the baloo repo then i > can move it. I am fine with both approaches (keep it here or in the baloo > repository. > * If someone has a better idea about the implementation, the pls shoot :) > > > > Diffs > - > > CMakeLists.txt 9466447 > components/CMakeLists.txt 536b60e > components/timelinemodel/CMakeLists.txt PRE-CREATION > components/timelinemodel/qmldir PRE-CREATION > components/timelinemodel/timelinemodel.h PRE-CREATION > components/timelinemodel/timelinemodel.cpp PRE-CREATION > components/timelinemodel/timelineplugin.h PRE-CREATION > components/timelinemodel/timelineplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120777/diff/ > > > Testing > --- > > Everything looks ok. The performance is not bad, except from the fact that > the implementation is a bit of hackish... > > > Thanks, > > Antonis Tsiapaliokas > >
Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Feb. 8, 2017, 12:49 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-mobile Description --- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs - CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/timelinemodel/CMakeLists.txt PRE-CREATION components/timelinemodel/qmldir PRE-CREATION components/timelinemodel/timelinemodel.h PRE-CREATION components/timelinemodel/timelinemodel.cpp PRE-CREATION components/timelinemodel/timelineplugin.h PRE-CREATION components/timelinemodel/timelineplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing --- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas
