KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 42 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/42/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 23 Apr 2020 04:37:18 +
 Build duration:
17 min and counting
   CONSOLE OUTPUT
  [...truncated 3048 lines...][2020-04-23T04:53:03.880Z] [ 41%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeconfig.cpp.o[2020-04-23T04:53:06.428Z] [ 41%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/cubeslideconfig.cpp.o[2020-04-23T04:53:07.801Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/desktopgridconfig.cpp.o[2020-04-23T04:53:09.696Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/diminactiveconfig.cpp.o[2020-04-23T04:53:11.075Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/fallapartconfig.cpp.o[2020-04-23T04:53:12.981Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/flipswitchconfig.cpp.o[2020-04-23T04:53:14.354Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/glideconfig.cpp.o[2020-04-23T04:53:15.288Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/lookingglassconfig.cpp.o[2020-04-23T04:53:15.854Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magiclampconfig.cpp.o[2020-04-23T04:53:17.243Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/magnifierconfig.cpp.o[2020-04-23T04:53:17.836Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mouseclickconfig.cpp.o[2020-04-23T04:53:19.214Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/mousemarkconfig.cpp.o[2020-04-23T04:53:19.788Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/presentwindowsconfig.cpp.o[2020-04-23T04:53:22.321Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/resizeconfig.cpp.o[2020-04-23T04:53:24.227Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/showfpsconfig.cpp.o[2020-04-23T04:53:26.135Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slideconfig.cpp.o[2020-04-23T04:53:27.514Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slidingpopupsconfig.cpp.o[2020-04-23T04:53:29.416Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/thumbnailasideconfig.cpp.o[2020-04-23T04:53:31.317Z] [ 42%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/trackmouseconfig.cpp.o[2020-04-23T04:53:32.691Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/windowgeometryconfig.cpp.o[2020-04-23T04:53:34.596Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/wobblywindowsconfig.cpp.o[2020-04-23T04:53:36.498Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/zoomconfig.cpp.o[2020-04-23T04:53:38.399Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/fallapart/fallapart.cpp.o[2020-04-23T04:53:40.938Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/highlightwindow/highlightwindow.cpp.o[2020-04-23T04:53:42.846Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/kscreen/kscreen.cpp.o[2020-04-23T04:53:44.743Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/kscreenconfig.cpp.o[2020-04-23T04:53:46.641Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/screenedge/screenedgeeffect.cpp.o[2020-04-23T04:53:49.161Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slideback/slideback.cpp.o[2020-04-23T04:53:51.055Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/slidingpopups/slidingpopups.cpp.o[2020-04-23T04:53:52.949Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/backgroundcontrast/contrast.cpp.o[2020-04-23T04:53:53.205Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/backgroundcontrast/contrastshader.cpp.o[2020-04-23T04:53:55.730Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/screenshot/screenshot.cpp.o[2020-04-23T04:53:55.730Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/sheet/sheet.cpp.o[2020-04-23T04:53:58.286Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/sheetconfig.cpp.o[2020-04-23T04:54:00.196Z] [ 43%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/snaphelper/snaphelper.cpp.o[2020-04-23T04:54:03.486Z] [ 44%] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/startupfeedback/startupfeedback.cpp.o[2020-04-23T04:54:06.009Z] [ 44%] Linking CXX shared library ../bin/libkwin4_effect_builtins.so[2020-04-23T04:54:09.310Z] [ 44%] Built target kwin4_effect_builtins[2020-04-23T04:54:09.310Z] Scanning dependencies of target effectversionplugin[2020-04-23T04:54:09.310Z] [ 44%] 

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  Also you can now use `Kirigami.PlaceholderMessage` in this diff instead of 
making the messages manually using level 3 Headings.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29117: [applet] Put the toolbar in the header area

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, jgrulich, niccolove, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements part of the mockup at T10470 
 by putting the toolbar  in a heading
  area visually connected to the titlebar.

TEST PLAN
  F8254838: Networks.png 

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  put-toolbar-in-header-area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29117

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: ngraham, #vdg, #plasma, jgrulich, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29116: [applets/batterymonitor] Put the toolbar in the header area

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik, niccolove, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements part of the mockup at T10470 
 by putting the power management
  checkbox and settings button in a heading area visually connected to the 
titlebar.
  
  In the process, I fixed a problem with the power management checkbox to make 
the layout's
  spacing work: the checkbox now has text of its own, instead of living in a 
mouse area
  with a separate label.

TEST PLAN
  F8254807: Battery monitor.png 
  F8254808: Gets a bit chunky.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  give-battery-applet-a-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29116

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

To: ngraham, #vdg, #plasma, broulik, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  JFYI once this is ready to land, before doing so, please do an `arc amend` 
locally to pick up the changes in the description that I've made and ensure 
that all those bugs get closed!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:6b76ce30811c: Icon: improve icon rendering on 
multi-screen multi-dpi setups (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29100?vs=80906=80944

REVISION DETAIL
  https://phabricator.kde.org/D29100

AFFECTED FILES
  src/icon.cpp

To: apol, davidedmundson
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28154: Add users KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:88
> Not sure it's actually a bug in the multi-page KCM system as @iasensio was 
> able to make this work properly in D28152 
> . Maybe you can see what he did there?

Seems to work for me now.

> ngraham wrote in user_manager.desktop:9
> You've moved it out of the Account details group. If this is intentional, 
> then we also need to move the KWallet KCM out of that group, or else Account 
> details has only one item and shows the KWallet KCM when clicked on, which is 
> confusing because the second level of navigation is collapsed and the group 
> name doesn't match the KCM name.
> 
> F8249318: Screenshot_20200420_081303.png 
> 
> 
> So move it back into the Account Details group or submit another patch to 
> move KWallet out of the group too.

Will do.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 80942.
cblack marked 11 inline comments as done.
cblack added a comment.


  Address feedback, needs fix for https://bugs.kde.org/show_bug.cgi?id=420439 
in order to function

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=79605=80942

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Niccolò Venerandi]

niccolove accepted this revision.
niccolove added a comment.
This revision is now accepted and ready to land.


  Yeah, I agree. I see that this behavior is consistent, so I'll accept it.

REPOSITORY
  R97 Bluedevil

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham added a comment.


  Well, this is the way we handle focus everywhere in KDE. When you press a 
focusable button, that button gains focus and retains it even after being 
pressed.
  
  IMO the only issue here is the super-obvious-bordering-on-overwhelming way we 
visually show focus, which turns the whole button blue and makes it stand out a 
bit //too//much (IMO).

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Niccolò Venerandi]

niccolove added a comment.


  Correct, but shouldn't the focus state stop after button press, or when I 
click away, or at least when I close the applet? Or am I getting the concept of 
focus wrong?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:a876b365bb22: Converted to page and added heading 
(authored by niccolove).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28996?vs=80589=80940

REVISION DETAIL
  https://phabricator.kde.org/D28996

AFFECTED FILES
  applet/contents/ui/main.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham added a comment.


  That's the focus state, not the hovered state. If I hit the tab key, focus 
goes somewhere else. Do you see the same?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28996: Converted to page and added heading

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29057: Introduce PlaceholderMessage component

[Nathaniel Graham]

ngraham added a comment.


  Oops. Fixed in 4c6252526c122081f7ac699d2655dc80306fde78 
.
  
  Sorry about that.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: nicolasfella, leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D28996: Converted to page and added heading

[Niccolò Venerandi]

niccolove added a comment.


  In D28996#652157 , @ngraham wrote:
  
  > Great! However the footer looks a bit weird since it doesn't touch the 
edges: F8247573: Screenshot_20200419_154306.png 

  
  
  True but it's unrelated to this patch - it's system tray cutting off 
everything that is outside of the applet container. I want to address that in 
another patch

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28996

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Niccolò Venerandi]

niccolove added a comment.


  It seems like the button never gets out of hovered state:
  F8254176: Screenshot_20200422_231804.png 


REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29111

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29057: Introduce PlaceholderMessage component

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> PlaceholderMessage.qml:26
> + * @code{.qml}
> + * import org.kde.kirigami 2.11 as Kirigami
> + ** used as a "this view is empty" message

This needs to be 2.12

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: nicolasfella, leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

[David Faure]

dfaure added a comment.


  OK, that's above my head. Shall I push this or you'll rework it all?
  
  I just want to be able to deprecated KRun::run and friends :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28990

To: dfaure, drosca, davidedmundson, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, drosca, niccolove.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch ports the Bluetooth applet to use `Kirigami.PlaceholderMessage`. 
In the
  process, and as a necessary precondition, it also refactors the code to be 
more
  declarative.

TEST PLAN
  Everything still works perfectly and there are no visual changes aside from 
the message
  having the same margins etc as all the other ones now: F8254152: 
vokoscreenNG-2020-04-22_15-02-49.webm 

REPOSITORY
  R97 Bluedevil

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29111

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> UserDetailsPage.qml:195
> +onClicked: {
> +if (kcm.deleteUser(usersDetailPage.user.uid)) {
> +kcm.pop()

This no longer asks if you want to delete that user's home directory, so it's 
always preserved.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, 
ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29110: [applet] port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, ivan, niccolove.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch ports the Vaults applet to use the new 
`Kirigami.PlaceholderMessage` that was
  just created to standardize the appearance of placeholder messages.

TEST PLAN
  F8254002: vaults.png 
  
  No change when there is at least one vault set up

REPOSITORY
  R845 Plasma Vault

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29110

AFFECTED FILES
  CMakeLists.txt
  plasma/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik, niccolove.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Clipboard and Notifications applets live in plasma-workspace; port them 
to use
  Kirigami.PlaceholderMessage

TEST PLAN
  Clipboard: F8253980: Clipboard.png 
  Notifications: F8253981: Notifications.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29109

AFFECTED FILES
  CMakeLists.txt
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/Menu.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, broulik, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29060: Port placeholder message to Kirigami.PlaceholderMessage

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1044:985d02fbb4da: Port placeholder message to 
Kirigami.PlaceholderMessage (authored by ngraham).

REPOSITORY
  R1044 Plasma Thunderbolt Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29060?vs=80826=80931

REVISION DETAIL
  https://phabricator.kde.org/D29060

AFFECTED FILES
  CMakeLists.txt
  src/kcm/package/contents/ui/DeviceList.qml

To: ngraham, #vdg, #plasma, dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29057: Introduce PlaceholderMessage component

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:5a434519aeb9: Introduce PlaceholderMessage component 
(authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29057?vs=80892=80929

REVISION DETAIL
  https://phabricator.kde.org/D29057

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc
  kirigami.qrc.in
  src/controls/PlaceholderMessage.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: ngraham, #vdg, #kirigami, mart
Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29059: Port BrowsingPage to PlaceholderMessage

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:24c3da41c422: Port BrowsingPage to PlaceholderMessage 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29059?vs=80824=80930

REVISION DETAIL
  https://phabricator.kde.org/D29059

AFFECTED FILES
  CMakeLists.txt
  discover/qml/BrowsingPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28841: Raise size of default fixed-width font from 9 to 10pt

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:f30c8ca7c5c8: Raise size of default fixed-width font from 
9 to 10pt (authored by ngraham).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28841?vs=80158=80926

REVISION DETAIL
  https://phabricator.kde.org/D28841

AFFECTED FILES
  src/platformtheme/kfontsettingsdata.cpp

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28842: Raise size of default fixed-width font from 9 to 10pt

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:010c7a5e895a: Raise size of default fixed-width font from 
9 to 10pt (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28842?vs=80159=80927#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28842?vs=80159=80927

REVISION DETAIL
  https://phabricator.kde.org/D28842

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml
  kcms/fonts/fontssettings.kcfg

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis
Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Nathaniel Graham]

ngraham updated this revision to Diff 80924.
ngraham added a comment.


  Make the title look more like Kirigami section separators

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29081?vs=80834=80924

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ngraham, #vdg, #breeze
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29106: Introduce RouterWindow control

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Convenience subclass of ApplicationWindow with a PageRouter all set up.

TEST PLAN
  `make test`

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/routerwindow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29106

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tst_routerwindow.qml
  src/controls/RouterWindow.qml
  src/kirigamiplugin.cpp

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> sdf.glsl:199
>  // This
> -const lowp float sdf_default_smoothing = 0.005;
> +const lowp float sdf_default_smoothing = 0.4;
>  

I played around with this value and found that 0.625 was pretty decent. It 
slightly improved the corners in bigscreen and made the corners of 
Kirigami.Card a bit smoother without making the lines blurry. Top: 0.625; 
Bottom: 0.4
F8253710: Screenshot_20200422_125706.png 

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29064: Support module commandline paramenter

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, and I fully support the overall goal of getting rid of kcmshell. 
Doing so will fix a ton of bugs (all the systemsettings | kcmshell bugs as well 
as all the bug reports about weird sizing in standalone KCMs, plus a bunch more 
about inconsistent behavior of KCMs in systemsettings vs kcmshell)
  
  Foor fod thought: we might want to also think about some of the consequences 
of removing kcmshell; we could need to add programmatic cross-KCM navigation 
into system settings itself. For example, in D29080 
, I'm calling kcmshell from inside a KCM to 
pop-up the KScreen KCM on top of the fonts KCM. Without kcmshell, that won't 
work as currently implemented, and it would need to navigate you to the KScreen 
KCM in the same systemsettings instance.
  
  Also a new way to get the information from `kcmshell5 --list` would be nice.
  
  Material for follow-up patches, I suppose.

REPOSITORY
  R124 System Settings

BRANCH
  phab/startupModule

REVISION DETAIL
  https://phabricator.kde.org/D29064

To: mart, #plasma, ngraham
Cc: bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29064: Support module commandline paramenter

[Marco Martin]

mart updated this revision to Diff 80913.
mart added a comment.


  - use namespace

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29064?vs=80904=80913

BRANCH
  phab/startupModule

REVISION DETAIL
  https://phabricator.kde.org/D29064

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuItem.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  icons/IconMode.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma
Cc: bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28711: WIP: OpenStore Integration

[Aleix Pol Gonzalez]

apol added a comment.


  Hey,
  I went through the review, the patch looks good. There's some fairly 
important bits missing:
  
  - un/installing
  - running
  - state of resources. Currently it searches only on the server but doesn't 
check if it's installed locally.
  - detecting if the runtime is available
  
  How do you suggest we proceed?
  
  If it makes your life any better, I'm happy with having this merged and 
disabled by default as it's being worked on.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28711

To: bhdouglass, apol
Cc: plasma-devel, nicolaas, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
semareit, jraleigh, zachus, fbampaloukas, ragreen, ixoos, ZrenBot, James, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D29064: Support module commandline paramenter

[Nathaniel Graham]

ngraham added a comment.


  This doesn't build for me:
  
/home/nate/kde/src/systemsettings/app/main.cpp: In function ‘int main(int, 
char**)’:
/home/nate/kde/src/systemsettings/app/main.cpp:115:91: error: ‘endl’ was 
not declared in this scope; did you mean ‘std::endl’?
  115 | std::cout << i18n("The following modules are 
available:").toLocal8Bit().data() << endl;

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29064

To: mart, #plasma
Cc: bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added a comment.


  This has a ShadowedRectangle underneath and a transparent Rectangle with a 
border on top: F8253587: Screenshot_20200422_115104.png 

  
  Is there nothing that can be done about that?

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29100: Icon: improve icon rendering on multi-screen multi-dpi setups

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Prefer the usage of QIcon::pixmap(QWindow*...) overload that will take into 
account which window it's rendering to.
  Otherwise it was assuming we were rendering on the primary screen and it 
would end up being unpredictable.

TEST PLAN
  All looks correct, if I move emojier from a scaled screen to a non-scaled 
one, icons re-render properly.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29100

AFFECTED FILES
  src/icon.cpp

To: apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29064: Support module commandline paramenter

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> IconMode.cpp:204
> +
> +if (!startupModule().isEmpty()) {
> +MenuItem *item = rootItem()->descendantForModule(startupModule());

Indentation is not correct

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29064

To: mart, #plasma
Cc: bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29064: Support module commandline paramenter

[Marco Martin]

mart updated this revision to Diff 80904.
mart marked 2 inline comments as done.
mart added a comment.


  - remove leftovers

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29064?vs=80903=80904

BRANCH
  phab/startupModule

REVISION DETAIL
  https://phabricator.kde.org/D29064

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuItem.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  icons/IconMode.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29064: [WIP] Support module commandline paramenter

[Marco Martin]

mart updated this revision to Diff 80903.
mart added a comment.


  - support for startup module arguments

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29064?vs=80790=80903

BRANCH
  phab/startupModule

REVISION DETAIL
  https://phabricator.kde.org/D29064

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/main.cpp
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuItem.h
  core/ModuleView.cpp
  core/ModuleView.h
  icons/IconMode.cpp
  icons/IconMode.h
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h

To: mart, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28916: fix(kded): center action OSD on wayland

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:b3b45721ee17: fix(kded): center action OSD on wayland 
(authored by bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28916?vs=80376=80899#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28916?vs=80376=80899

REVISION DETAIL
  https://phabricator.kde.org/D28916

AFFECTED FILES
  kded/osd.cpp
  kded/qml/OsdSelector.qml

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle 
availability before applying it (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28662?vs=80067=80895

REVISION DETAIL
  https://phabricator.kde.org/D28662

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is 
provided before applying it. (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28656?vs=79574=80896

REVISION DETAIL
  https://phabricator.kde.org/D28656

AFFECTED FILES
  kcms/ksplash/splashscreensettings.kcfg
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 80894.
crossi added a comment.


  use qAsConst, indent

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=80864=80894

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28333: Add a new daemon for stats monitoring

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> client.cpp:45
> +{
> +for (auto sensor : m_subscribedSensors) {
> +sensor->unsubscribe();

This should probably use `qAsConst`.

> ksysguarddaemon.cpp:76
> +auto factory = qobject_cast(plugin);
> +if (!factory) {
> +return;

Should we do some error logging here? Might help future plugin development.

> ksysguarddaemon.cpp:93
> +m_providers.append(provider);
> +for (auto container : provider->containers()) {
> +m_containers[container->id()] = container;

const auto containers = provider->containers();
  for(auto container : containers) {

> ksysguarddaemon.cpp:111
> +SensorInfoMap sensors;
> +for (auto c : m_containers) {
> +for(auto o : c->objects()) {

`qAsConst(m_containers)`

> ksysguarddaemon.cpp:112
> +for (auto c : m_containers) {
> +for(auto o : c->objects()) {
> +for (auto p : o->sensors()) {

Like above, objects() should be in a const variable. (Also for sensors on the 
line below).

> ksysguarddaemon.cpp:201
> +
> +for (auto client: m_clients) {
> +client->sendFrame();

`qAsConst(m_clients)`

> mart wrote in AggregateSensor.cpp:199
> if this timer is needed for compression, shouldn't be the same timer always 
> restarted?
> if i call singleshot 10 times, iirc that slot will be invoked delayed 10 times

It's guarded with "m_dataChangeQueued" which only gets reset after the timer 
triggers.

> SensorContainer.cpp:64
> +connect(object, ::destroyed, this, [object, this]() {
> +emit objectRemoved(object); //FIXME this is going to crash
> +});

Uh, so shouldn't we fix this?

> SensorContainer.h:56
> + */
> +void addSubObject(SensorObject *object);
> +Q_SIGNALS:

Maybe move this to private with `friend class SensorObject`? Though I don't 
really see why this is internal only. Also probably should rename it to 
`addObject`?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28333

To: davidedmundson, #plasma
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D29092: Various fixes to new Cards

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Much better and thanks! LGTM

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami, ndavis
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29057: Introduce PlaceholderMessage component

[Nathaniel Graham]

ngraham updated this revision to Diff 80892.
ngraham added a comment.


  Add another code example showing now you could use it as a loading indicator

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29057?vs=80825=80892

BRANCH
  placeholder-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29057

AFFECTED FILES
  Mainpage.dox
  kirigami.qrc
  kirigami.qrc.in
  src/controls/PlaceholderMessage.qml
  src/controls/plugins.qmltypes
  src/kirigamiplugin.cpp
  src/qmldir

To: ngraham, #vdg, #kirigami, mart
Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra added a comment.


  Urgh, I knew there was a point to that damn fwidth() call. As far as I can 
tell this version has about the same visual appearance without it changing 
dependent on resolution.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80891.
ahiemstra added a comment.


  - Restore fwidth() call in shader, tweak smoothing values more

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80885=80891

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0e40a1cadf48: [applets/notifications] Widen pop-up and 
reduce spacing when on top or bottom… (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28989?vs=80567=80888

REVISION DETAIL
  https://phabricator.kde.org/D28989

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack, bshah
Cc: bshah, IlyaBizyaev, ndavis, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

[Nathaniel Graham]

ngraham added a comment.


  In D29080#654508 , @romangg wrote:
  
  > I like that. KCMs should be more inter-connected anyway. The message could 
just be shown all the time instead of making it dependent on the font size 
selected but no need to change that now.
  
  
  Thanks! I didn't want to show the message all the time as I thought it might 
get really irritating to the kind of contrarian user who doesn't like being 
told what to do.
  
  In D29080#654442 , @ahmadsamir 
wrote:
  
  > Does InlineMessage have a "Don't show again" capability? it'll become 
irritating after seeing it 1-2 times.
  
  
  I was concerned about that too, which is why I set the visibility 
imperatively rather than with a binding. So with this patch, once you dismiss 
it, you won't see it again until and unless you change the settings again in a 
way that would tripped it once more.
  
  > IIUC, the fontsHaveChanged() signal, nothing is listening to it in KDE code 
doesn't mean other 3rd party software isn't, and it's a change in behaviour for 
the KCM; I am not sure if it can be repurposed.
  
  Seems a bit unlikely to me that other KDE software or even 3rd-party software 
would be listening for this signal, and IIRC the signal was added after 5.18 
anyway so it hasn't been released yet. But hopefully @bport or a #plasma 
 person can shed some light on whether 
or not this is a bad idea.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29080

To: ngraham, #vdg, #plasma, cblack, bport
Cc: romangg, ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80885.
ahiemstra added a comment.


  - Remove sdf_polygon, it is unused and causes breakage on Android

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80878=80885

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29081: [QStyle] Make menu titles look less like menu items

[Nathaniel Graham]

ngraham added a comment.


  In D29081#654374 , @broulik wrote:
  
  > Not a fan of making it hard to read. I agree that it makes it more obvious 
it's not clickable but we deliberately changed many places that used disabled 
menu items as sections to use proper sections for readability.
  
  
  That's true.
  
  Do you think we should try to mimic the Kirigami ListSectionHeader appearance 
then?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added a comment.


  Actually, width does affect the roughness. The corners are at their smoothest 
when the card is a square.
  
  F8253358: Screenshot_20200422_092539.png 

  
  F8253360: Screenshot_20200422_092453.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Noah Davis]

ndavis added a comment.


  I found something vary curious and I don't know what the cause could be. The 
corners are smoother when the cards are taller and rougher when they are 
shorter.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29092

To: ahiemstra, #kirigami
Cc: ndavis, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 80878.
ahiemstra added a comment.


  - Slightly increase smoothing, to avoid too harsh corners

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29092?vs=80876=80878

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29028: feat(wayland): add Wrapland plugin

[Roman Gilg]

romangg added a comment.


  In D29028#654542 , @davidedmundson 
wrote:
  
  > A new dependency also needs to actually solve an actual problem.
  >
  > If we say we should support wl_roots' protocol for wlroots users. Fair 
enough. There are some parts of Plasma used by 3rd parties. 
  >  I'd certainly be very happy for us both to switch to a new standard given 
they're upstreaming some stuff currently.
  >
  > But we then have to answer the technical question of why does that require 
a library with a different implementation of ConnectionThread/Registry and 
every client protocol in order to do so? Compared to using one technology 
throughout. Otherwise you're not really solving the original problem of having 
it available to users.
  
  
  For wlroots I have done in Wrapland a quick protocol implementation in two or 
three days. I have not done much testing and hope for more data from first use 
cases in the future to iterate it. Since KWayland is API/ABI-stable that won't 
be possible there. When at some point the implementation has become well tested 
why not copy-paste it too KWayland?
  
  But this is not only about support for the wlroots protocol. In Wrapland I 
have rewritten KWayland's org_kde_kwin_outputdevice 
 
protocol as kwinft_output_device_unstable_v1 
.
 It is mostly the same but I cleaned up some stuff, used semantics as it is 
standard nowadays and replaced the scale factor with a new way of defining the 
logical size of an output (basically D26311 
). So for libkscreen to work with KWinFT it 
needs to support this protocol. And I assume it isn't something that should go 
into KWayland. For API/ABI reasons again and because it already has one 
protocol, even if it's sub-optimal nowadays.
  
  Of course when the protocol is stabilized and shows its merit it can always 
go into KWayland or whatever KDE Framework there will be in the future. Or we 
go for a common protocol with wlroots. I talked with Simon some time ago about 
their protocol and they have a mechanism with custom modes, but I find defining 
the logical size better. But I might be wrong on that and the 
kwinft_output_device_unstable_v1 protocol will tell me so in the future

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D29092: Various fixes to new Cards

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This contains various small fixes to the new Cards.
  
  - Still show the border of AbstractCard on Cards with images.
  - Round bottom corners of the banner when the card doesn't have any other 
contents.
  - Don't use fwidth for smoothing, instead just use a fixed value, this 
increases the accuracy of lines rendered by cards.
  - Fix batching test for ShadowedTexture, prevents cards being rendered with 
the wrong texture.

TEST PLAN
  The new Kirigami Gallery displays more correct now, though there are some 
layout issues that are not regressions.

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29028: feat(wayland): add Wrapland plugin

[Roman Gilg]

romangg added a comment.


  In D29028#654535 , @anthonyfieroni 
wrote:
  
  > In D29028#653194 , @romangg 
wrote:
  >
  > > In D29028#653192 , @apol wrote:
  > >
  > > > I don't really see why we'd want to support something that is not 
offering ABI stability and doesn't push Plasma in any direction.
  > >
  > >
  > > It is offering in the same way ABI stability as most other components of 
Plasma, i.e. until a new minor Plasma release.
  >
  >
  > That's not true. Always use pimpl in library code, say KWin can break 
backward compatibility, KWayland, KScreen, etc. does not. If you do it as it 
should be then it may be accepted (i cannot guaranteed but will be step in 
right direction, at least).
  
  
  First, how is pimpl relevant to the discussion here? Second, KWin and 
libkscreen are both Plasma projects, so the library functionality they both 
provide to a certain degree are offered on the same stability premise. KWayland 
on the other hand is a KDE Framework and has a different stability guarantee. 
To my knowledge there is no equivalent guarantee in Plasma, not written down at 
least.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcm.cpp:315
>  ManagedConfigModule::defaults();
> -m_settings->defaults();
> +for (auto *behaviorSettings : m_behaviorSettingsList) {
> +behaviorSettings->setDefaults();

qAsConst(m_behaviorSettingsList), otherwise it will unfortunately detach.

> kcm.cpp:334
> +bool notDefault = std::any_of(m_behaviorSettingsList.cbegin(),
> +m_behaviorSettingsList.cend(),
> +[](const 
> NotificationManager::BehaviorSettings *settings) { return 
> !settings->isDefaults(); });

I'd align that (and the next line) with the previous parameter.

> kcm.cpp:335
> +m_behaviorSettingsList.cend(),
> +[](const 
> NotificationManager::BehaviorSettings *settings) { return 
> !settings->isDefaults(); });
> +return !notDefault;

This starts being a long line, please break it after the opening brace and 
again after the first semicolon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Roman Gilg]

romangg added a comment.


  In D29028#654526 , @tcanabrava 
wrote:
  
  > I understand David's point: Wrapland project has one developer and we don't 
know how successful it will be, while the other backends have developers. What 
would happen if you suddenly quit / disappear and the project dies? Then 
kscreen will have a folder of dead code.
  >
  > This is a Plugin, it can live in any folder / project, you already forked 
KWinFT, create a new project to put this KScreen plugin, we can't scale to N 
projects adding code as plugins that will need to be maintained for quite a 
while in the future.
  >
  > > Come on man, do you really want to make this ugly? I thought we would 
still treat each other with respect David. :(
  >
  > Your words. His words are technical, Please don't distort things and make 
it about you.
  
  
  I haven't noticed much technical words in what was said. I did ask about the 
headers-only proposal that was of technical nature. Also the tone made it seem 
to me personal, but that sadly might have been just what is often the default 
tone in Plasma reviews (no finger pointing intended, I have been guilty of that 
in the past too).
  
  >> Which "established practices" does this not satisfy?
  > 
  > It's an external library that does not solve any problem within the plasma, 
nor adds value to plasma users. It's an experimental project, with only one 
developer, not stable, not ready, not core. You can see on this picture that we 
are not blocking your project here because of $excuse, but this is something 
that we do if the project is not core, please check the date.
  >  F8253102: image.png 
  > 
  > There's more information on the full phabricator ticket:
  >  https://phabricator.kde.org/D20265
  
  I looked at that and suspected to see a hard dependency there. But it also is 
only an optional dependency with a check if the package is available. So I'm 
wondering what are the rules if something can become an //optional// dependency 
for a Plasma project? Is this written down somewhere?
  
  >> How would that look in detail?
  > 
  > That will give you the possibility to create plugins for KScreen that are 
not bound to KScreen code, then you can create your project in gitlab and have 
different release schedules, in a way that:
  >  1 - The plugin code is independent to KDE Releases
  >  2 - We have a clear separation on project responsabilities
  >  3 - Being independent means that it can also test with experimental 
libraries.
  > 
  >> Why is this even relevant?
  > 
  > We need to be sure that the code of the project will always be buildable 
through the lifespan of Plasma 5.19, and right now we can't guarantee it.
  
  Since the dependency is optional you are guaranteed to be able to build 
libkscreen by removing Wrapland or not installing it in the first place. Also 
Wrapland will have a 0.519.0 release as it has now a 0.518.0 release. Releases 
will be synced up with Plasma releases. Otherwise the KWinFT-Plasma integration 
would not work anyway.
  
  > Create this code outside of KSCreen as a plugin. We will gladly accept code 
that install the Interface Headers to make that possible. :)
  
  I think that this is unnecessary complicated because releases will be synced, 
but I can live with it. Would this mean only the first patch of this patch 
series would go in and I export the `wayland_interface.h` and `waylandoutput.h` 
headers (they are being used in the plugins)?
  
  Thanks for taking the time Tomaz.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 80864.
crossi added a comment.


  maange reset to default application notification

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=76004=80864

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.cpp
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[David Edmundson]

davidedmundson added a comment.


  A new dependency also needs to actually solve an actual problem.
  
  If we say we should support wl_roots' protocol for wlroots users. Fair 
enough. There are some parts of Plasma used by 3rd parties. 
  I'd certainly be very happy for us both to switch to a new standard given 
they're upstreaming some stuff currently.
  
  But we then have to answer the technical question of why does that require a 
library with a different implementation of ConnectionThread/Registry and every 
client protocol in order to do so? Compared to using one technology throughout.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D29028#653194 , @romangg wrote:
  
  > In D29028#653192 , @apol wrote:
  >
  > > I don't really see why we'd want to support something that is not 
offering ABI stability and doesn't push Plasma in any direction.
  >
  >
  > It is offering in the same way ABI stability as most other components of 
Plasma, i.e. until a new minor Plasma release.
  
  
  That's not true. Always use pimpl in library code, say KWin can break 
backward compatibility, KWayland, KScreen, etc. does not. If you do it as it 
should be then it may be accepted (i cannot guaranteed but will be step in 
right direction, at least).

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: anthonyfieroni, tcanabrava, apol, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D29028: feat(wayland): add Wrapland plugin

[Tomaz Canabrava]

tcanabrava added a comment.


  I understand David's point: Wrapland project has one developer and we don't 
know how successful it will be, while the other backends have developers. What 
would happen if you suddenly quit / disappear and the project dies? Then 
kscreen will have a folder of dead code.
  
  This is a Plugin, it can live in any folder / project, you already forked 
KWinFT, create a new project to put this KScreen plugin, we can't scale to N 
projects adding code as plugins that will need to be maintained for quite a 
while in the future.
  
  > Come on man, do you really want to make this ugly? I thought we would still 
treat each other with respect David. :(
  
  Your words. His words are technical, Please don't distort things and make it 
about you.
  
  > Which "established practices" does this not satisfy?
  
  It's an external library that does not solve any problem within the plasma, 
nor adds value to plasma users. It's an experimental project, with only one 
developer, not stable, not ready, not core. You can see on this picture that we 
are not blocking your project here because of $excuse, but this is something 
that we do if the project is not core, please check the date.
  F8253102: image.png 
  
  There's more information on the full phabricator ticket:
  https://phabricator.kde.org/D20265
  
  > How would that look in detail?
  
  That will give you the possibility to create plugins for KScreen that are not 
bound to KScreen code, then you can create your project in gitlab and have 
different release schedules, in a way that:
  1 - The plugin code is independent to KDE Releases
  2 - We have a clear separation on project responsabilities
  3 - Being independent means that it can also test with experimental libraries.
  
  > Why is this even relevant?
  
  We need to be sure that the code of the project will always be buildable 
through the lifespan of Plasma 5.19, and right now we can't guarantee it.
  
  Create this code outside of KSCreen as a plugin. We will gladly accept code 
that install the Interface Headers to make that possible. :)

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D29028

To: romangg, #plasma, davidedmundson, apol
Cc: tcanabrava, apol, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
ahiemstra, mart

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

[Roman Gilg]

romangg added a comment.


  I like that. KCMs should be more inter-connected anyway. The message could 
just be shown all the time instead of making it dependent on the font size 
selected but no need to change that now.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29080

To: ngraham, #vdg, #plasma, cblack, bport
Cc: romangg, ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.


  Sorry for delay in testing this, works fine!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  wider-notification-popu-when-on-top-or-bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28989

To: ngraham, #vdg, #plasma, broulik, ndavis, cblack, bshah
Cc: bshah, IlyaBizyaev, ndavis, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29057: Introduce PlaceholderMessage component

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Nice! Got a few places where this could be very handy :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29057

To: ngraham, #vdg, #kirigami, mart
Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D28509: RFC: [libnotificationmanager] introduce the notification watcher

[Bhushan Shah]

bshah updated this revision to Diff 80847.
bshah added a comment.


  - pass raw body data to the watcher

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28509?vs=80833=80847

BRANCH
  bshah/notification-watcher

REVISION DETAIL
  https://phabricator.kde.org/D28509

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/abstractnotificationsmodel.cpp
  libnotificationmanager/abstractnotificationsmodel.h
  libnotificationmanager/abstractnotificationsmodel_p.h
  libnotificationmanager/dbus/org.kde.notificationmanager.xml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/watchednotificationsmodel.cpp
  libnotificationmanager/watchednotificationsmodel.h

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old 
signal syntax (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28282?vs=80616=80846

REVISION DETAIL
  https://phabricator.kde.org/D28282

AFFECTED FILES
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/globalshortcuts.cpp
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/select_scheme_dialog.cpp

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

[Ahmad Samir]

ahmadsamir added a reviewer: bport.
ahmadsamir added a comment.


  Does InlineMessage have a "Don't show again" capability? it'll become 
irritating after seeing it 1-2 times.
  
  IIUC, the fontsHaveChanged() signal, nothing is listening to it in KDE code 
doesn't mean other 3rd party software isn't, and it's a change in behaviour for 
the KCM; I am not sure if it can be repurposed.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29080

To: ngraham, #vdg, #plasma, cblack, bport
Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27155: libnotificationmanager : add app-specific kconfig settings

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c56e12cc540d: libnotificationmanager : add app-specific 
kconfig settings (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27155?vs=77068=80845

REVISION DETAIL
  https://phabricator.kde.org/D27155

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/behaviorsettings.kcfg
  libnotificationmanager/kcfg/behaviorsettings.kcfgc
  libnotificationmanager/plasmanotifyrc

To: crossi, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

[Marco Martin]

mart added a comment.


  so in the end, vertical centering?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28664

To: cblack, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29081: [QStyle] Make menu titles look less like menu items

[Kai Uwe Broulik]

broulik added a comment.


  Not a fan of making it hard to read. I agree that it makes it more obvious 
it's not clickable but we deliberately changed many places that used disabled 
menu items as sections to use proper sections for readability.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart