[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  Looks great now, thank you for digging into the focus stuff!

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, andreaska, #plasma, davidedmundson
Cc: davidedmundson, andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F254921: Screenshot_20160811_125837.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F254909: Screenshot_20160811_124328.png  
Fainter blue when it doesn't have focus

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > In System Settings, the full highlight color is only used on the sidebar 
when it is currently focused
  
  Yeah, noticed that, but focus handling in QML is just broken beyond repair so 
I didn't bother with that.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, andreaska
Cc: andreaska, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I'm glad that you're fixing this inconsistency!
  
  Just for clarification since it can't be seen from the screenshots: In System 
Settings, the full highlight color is only used on the sidebar when it is 
currently focused. When the main window area is focused (initially when the 
sidebar is shown, or when interacting with the main content), the hover 
highlight visualization is used in the sidebar.
  
  Is that the same in your patch?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  F254624: Screenshot_20160811_093330.png 
  Also on low-dpi looks identical to System Settings spacing-wise

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2398

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas