[Differential] [Commented On] D2399: New new SDDM theme

2016-08-13 Thread mart (Marco Martin) 
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in UserDelegate.qml:85
> It's a bit more complex with the white frame that has to be transparent on 
> the inside.
> 
> So that then needs to be drawn somehow. I guess making an SVG of a circle 
> would work.

Using layers opacity mask, the white circle wouldn't be drawn, it's only used 
to cut a circle out of the user avatar. For the border, could be another 
rectangle rounded to a circle, which only the border is drawn?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-11 Thread davidedmundson (David Edmundson) 
davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in KeyboardButton.qml:13
> is this domain valid for sddm as well?

It was...though that broke when this folder was moved. Good spot.

> mart wrote in UserDelegate.qml:85
> this version you have is probably is significantly faster (and in this case 
> i'll shut up :p)
> 
> but wouldn't look cleaner to have something along the lines:
> 
> layer.enabled: true
> 
>   layer.effect: OpacityMask {
>   maskSource: Rectangle {
>   anchors.centerIn: parent
>   width: imageWrapper.width
>   height: width
>   radius: width/2
>   }
>   }

It's a bit more complex with the white frame that has to be transparent on the 
inside.

So that then needs to be drawn somehow. I guess making an SVG of a circle would 
work.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-11 Thread mart (Marco Martin) 
mart added inline comments.

INLINE COMMENTS

> KeyboardButton.qml:13
>  
> -text: instantiator.objectAt(currentIndex).shortName
> +text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Keyboard Layout: 
> %1", instantiator.objectAt(currentIndex).shortName)
>  implicitWidth: minimumWidth

is this domain valid for sddm as well?

> UserDelegate.qml:85
>  
> -//if copying into another project don't forget to * qt_Opacity. It's 
> just unused here
> -//and connect themeChanged to update()
> +//if copying into another project don't forget to connect 
> themeChanged to update()
> +//but in SDDM that's a bit pointless

this version you have is probably is significantly faster (and in this case 
i'll shut up :p)

but wouldn't look cleaner to have something along the lines:

layer.enabled: true

  layer.effect: OpacityMask {
  maskSource: Rectangle {
  anchors.centerIn: parent
  width: imageWrapper.width
  height: width
  radius: width/2
  }
  }

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-11 Thread mart (Marco Martin) 
mart added a comment.


  In https://phabricator.kde.org/D2399#45044, @davidedmundson wrote:
  
  > Screenshot as requested.
  >
  > F255167: Spectacle.h20090.png 
  >
  > Note the coloured icons for actions will be changing when Andreas pushes 
some change.
  >
  > Also I have some unresolved comments here: 
https://phabricator.kde.org/M58/178/
  
  
  what about white circles?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-11 Thread mart (Marco Martin) 
mart added a comment.


  In https://phabricator.kde.org/D2399#44873, @apol wrote:
  
  > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.
  
  
  but also working QML code, that means, it must be maintained. if there are 
volunteers, awesome, if it stays there bitrotting, hmm, not so much

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-11 Thread davidedmundson (David Edmundson) 
davidedmundson added a comment.


  Screenshot as requested.
  
  F255167: Spectacle.h20090.png 
  
  Note the coloured icons for actions will be changing when Andreas pushes some 
change.
  
  Also I have some unresolved comments here: 
https://phabricator.kde.org/M58/178/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-11 Thread davidedmundson (David Edmundson) 
davidedmundson added a comment.


  In https://phabricator.kde.org/D2399#44873, @apol wrote:
  
  > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.
  
  
  Maybe, but this patch is against the SDDM theme that was nearly in 5.7, the 
old theme was already deleted. 
  It can be restored, but it's a bit irrelevant wrt to this patch.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

2016-08-10 Thread apol (Aleix Pol Gonzalez) 
apol added a comment.


  Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas