D28462: [KCM][WIP] Add KCModuleData

2020-04-21 Thread Nathaniel Graham 
ngraham added a comment.


  +1 for a simple base class so we can avoid so much boilerplate

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28462

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28462: [KCM][WIP] Add KCModuleData

2020-04-21 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Only a small thing left I think

INLINE COMMENTS

> cursorthemedata.h:33
> +Q_OBJECT
> +//Q_PROPERTY(CursorThemeSettings *cursorThemeSettings READ 
> cursorThemeSettings CONSTANT)
> +

Needs a cleanup I guess

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28462

To: bport, #plasma, ervin, meven, crossi, hchain
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart