Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/
---

(Updated Aug. 15, 2016, 11:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Rosca and Hugo Pereira Da Costa.


Changes
---

Submitted with commit 6ecd3cad7448726807213274f66f08af79252f39 by Kai Uwe 
Broulik to branch master.


Repository: breeze


Description
---

This enables painting the focus underline also for QtQuick Controls and fixes 
an off-by-one error which caused the line to be rendered outside the QtQuick 
Controls canvas and was thus invisible.


Diffs
-

  kstyle/breezestyle.cpp 12a2f35 

Diff: https://git.reviewboard.kde.org/r/128654/diff/


Testing
---


File Attachments


Focus underline
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
Spurious focus underline in Honeycomb
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png


Thanks,

Kai Uwe Broulik

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/#review98400
---


Ship it!




Ship It!

- David Edmundson


On Aug. 15, 2016, 11 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128654/
> ---
> 
> (Updated Aug. 15, 2016, 11 a.m.)
> 
> 
> Review request for Plasma, David Rosca and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> This enables painting the focus underline also for QtQuick Controls and fixes 
> an off-by-one error which caused the line to be rendered outside the QtQuick 
> Controls canvas and was thus invisible.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 12a2f35 
> 
> Diff: https://git.reviewboard.kde.org/r/128654/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Focus underline
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
> Spurious focus underline in Honeycomb
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/
---

(Updated Aug. 15, 2016, 11 vorm.)


Review request for Plasma, David Rosca and Hugo Pereira Da Costa.


Changes
---

* Added Qt version check


Repository: breeze


Description
---

This enables painting the focus underline also for QtQuick Controls and fixes 
an off-by-one error which caused the line to be rendered outside the QtQuick 
Controls canvas and was thus invisible.


Diffs (updated)
-

  kstyle/breezestyle.cpp 12a2f35 

Diff: https://git.reviewboard.kde.org/r/128654/diff/


Testing (updated)
---


File Attachments


Focus underline
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
Spurious focus underline in Honeycomb
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png


Thanks,

Kai Uwe Broulik

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-15 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/#review98395
---


Fix it, then Ship it!





kstyle/breezestyle.cpp (line 3072)


else if


- David Edmundson


On Aug. 11, 2016, 11:49 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128654/
> ---
> 
> (Updated Aug. 11, 2016, 11:49 a.m.)
> 
> 
> Review request for Plasma, David Rosca and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> This enables painting the focus underline also for QtQuick Controls and fixes 
> an off-by-one error which caused the line to be rendered outside the QtQuick 
> Controls canvas and was thus invisible.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 12a2f35 
> 
> Diff: https://git.reviewboard.kde.org/r/128654/diff/
> 
> 
> Testing
> ---
> 
> Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
> (like the widgets logic) does, so we now get a faint blue line (hard to tell 
> with default colorscheme) at the bottom of QQC push buttons :(
> 
> 
> File Attachments
> 
> 
> Focus underline
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
> Spurious focus underline in Honeycomb
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-11 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/
---

(Updated Aug. 11, 2016, 11:49 vorm.)


Review request for Plasma, David Rosca and Hugo Pereira Da Costa.


Changes
---

Don't paint focus line for QQC buttons


Repository: breeze


Description
---

This enables painting the focus underline also for QtQuick Controls and fixes 
an off-by-one error which caused the line to be rendered outside the QtQuick 
Controls canvas and was thus invisible.


Diffs (updated)
-

  kstyle/breezestyle.cpp 12a2f35 

Diff: https://git.reviewboard.kde.org/r/128654/diff/


Testing
---

Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
(like the widgets logic) does, so we now get a faint blue line (hard to tell 
with default colorscheme) at the bottom of QQC push buttons :(


File Attachments


Focus underline
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
Spurious focus underline in Honeycomb
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png


Thanks,

Kai Uwe Broulik

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

2016-08-11 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/#review98311
---



>Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
>(like the widgets logic) does, so we now get a faint blue line (hard to tell 
>with default colorscheme) at the bottom of QQC push buttons :(

option->styleObject && option->styleObject->property("elementType") == 
QLatin1String("button")

- David Edmundson


On Aug. 11, 2016, 11:25 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128654/
> ---
> 
> (Updated Aug. 11, 2016, 11:25 a.m.)
> 
> 
> Review request for Plasma, David Rosca and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> This enables painting the focus underline also for QtQuick Controls and fixes 
> an off-by-one error which caused the line to be rendered outside the QtQuick 
> Controls canvas and was thus invisible.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 12a2f35 
> 
> Diff: https://git.reviewboard.kde.org/r/128654/diff/
> 
> 
> Testing
> ---
> 
> Unfortunately I couldn't figure out a way to tell whether we're a QQC Button 
> (like the widgets logic) does, so we now get a faint blue line (hard to tell 
> with default colorscheme) at the bottom of QQC push buttons :(
> 
> 
> File Attachments
> 
> 
> Focus underline
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
> Spurious focus underline in Honeycomb
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>