Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review102452 --- If this patch is still relevant please reopen on http://phabricator.kde.org - David Edmundson On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120855/ > --- > > (Updated Nov. 2, 2014, 3:34 p.m.) > > > Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu > Tushar, Sinny Kumari, and Sujith Haridasan. > > > Bugs: 336398 > http://bugs.kde.org/show_bug.cgi?id=336398 > > > Repository: plasma-mediacenter > > > Description > --- > > Changed auth method from Client Login to OAuth using libkgapi2 > > > Diffs > - > > browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d > browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 > browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 > browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml > e8f97f7 > browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 > browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 > browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 > > Diff: https://git.reviewboard.kde.org/r/120855/diff/ > > > Testing > --- > > Everything is working fine except that after successful login, user has to > press back to view all the albums. > > > Thanks, > > Ashish Bansal > >
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Feb. 8, 2017, 12:05 p.m.) Status -- This change has been discarded. Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: Thanks for your time on this, good stuff :) Tried it and the only caveat is that after login is done I have to press the back button (the one on the pmc controller) to get my album list. That should be fixed. Yeah I also figured the same. But I was not able to find out why it is happening and the way to correct it :/ On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 https://git.reviewboard.kde.org/r/120855/diff/3/?file=324518#file324518line60 where do you get these from? I made these keys from my own Google Account. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 3, 2014, 9:18 a.m., Shantanu Tushar wrote: browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 https://git.reviewboard.kde.org/r/120855/diff/3/?file=324518#file324518line60 where do you get these from? Ashish Bansal wrote: I made these keys from my own Google Account. I think KDE e.V. holds some API keys for google.. which can be used instead of your own personal keys so in case of some conflict KDE e.V. can help us. - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- On Nov. 2, 2014, 9:04 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 9:04 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- browsingbackends/onlineservices/picasa/CMakeLists.txt https://git.reviewboard.kde.org/r/120855/#comment48811 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example - Bhushan Shah On Oct. 28, 2014, 11:20 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 11:20 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 2, 2014, 1:31 p.m., Bhushan Shah wrote: browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Oct. 28, 2014, 5:50 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 2, 2014, 7:01 p.m., Bhushan Shah wrote: browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example Ashish Bansal wrote: Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. umm nope but like this, find_package(LibKGAPI2 REQUIRED) - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Oct. 28, 2014, 11:20 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 11:20 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 2, 2014, 1:31 p.m., Bhushan Shah wrote: browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example Ashish Bansal wrote: Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. Bhushan Shah wrote: umm nope but like this, find_package(LibKGAPI2 REQUIRED) Now, I am getting undefined references to all the functions and variables related to that Library. In ccmake, LibKGAPI2_DIR/usr/lib64/cmake/LibKGAPI2 - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Oct. 28, 2014, 5:50 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:17 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Removed HardCoded libkgapi2 path. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs (updated) - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 2, 2014, 7:01 p.m., Bhushan Shah wrote: browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example Ashish Bansal wrote: Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. Bhushan Shah wrote: umm nope but like this, find_package(LibKGAPI2 REQUIRED) Ashish Bansal wrote: Now, I am getting undefined references to all the functions and variables related to that Library. In ccmake, LibKGAPI2_DIR/usr/lib64/cmake/LibKGAPI2 See http://lxr.kde.org/source/kde/kdepim-runtime/CMakeLists.txt http://lxr.kde.org/source/kde/kdepim-runtime/resources/gmail/CMakeLists.txt To see how it is done.. - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Nov. 2, 2014, 8:47 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 8:47 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Now no libkgapi2 linking problems. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs (updated) - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- Thanks for your time on this, good stuff :) Tried it and the only caveat is that after login is done I have to press the back button (the one on the pmc controller) to get my album list. That should be fixed. browsingbackends/onlineservices/picasa/picasamodel.h https://git.reviewboard.kde.org/r/120855/#comment48822 where do you get these from? - Shantanu Tushar On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? - Aleix Pol Gonzalez On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-develm=141434675118408w=2). Is there any limitation of libkgapi2, so that I should use KAccounts?? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Ashish Bansal wrote: Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-develm=141434675118408w=2). Is there any limitation of libkgapi2, so that I should use KAccounts?? It's not about libkgapi, you'll end up using it with both, it's so that you can re-use the login information with KTp, KDEPIM, etc. You can ask about it in kdepim mailing lists. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Added kdepim and kdepimlibs in groups Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel