Re: intermittent failure of cpan/Pod-Simple/t/search50.t

2013-09-23 Thread Dave Mitchell
On Thu, Sep 19, 2013 at 09:47:59AM -0700, David E. Wheeler wrote:
 On Sep 19, 2013, at 4:50 AM, Dave Mitchell da...@iabyn.com wrote:
  Independently of that, perhaps that test file should check all pod files
  rather than just one at random, to make errors easier to spot?
 
 That sounds like a good idea. How does this work for you?
 
   
 https://github.com/theory/pod-simple/commit/b174dd0927d672ce3a10b1626f4004a8276fa449

Works for me, thanks!

-- 
But Pity stayed his hand. It's a pity I've run out of bullets,
he thought. -- Bored of the Rings


Re: intermittent failure of cpan/Pod-Simple/t/search50.t

2013-09-19 Thread David E. Wheeler
On Sep 19, 2013, at 4:50 AM, Dave Mitchell da...@iabyn.com wrote:

 I don't really understand whether:
 
 1) search50.t has unreasonable expectations;
 2) Pod::Simple::Search::survey() should be returning 'Pod::perldoc' as the
name rather than 'perldoc';
 3) perldoc.pod should be installed as lib/perldoc.pod rather than
lib/Pod/perldoc.pod;
 4) something in the content of perldoc.pod is wrong, and that is confusing
Pod::Simple::Search.

Neither do I. The search stuff is a bit of a black box to me. That test has 
failed a bunch of times on case-insensitive file systems, too, which drove me 
nuts until I figured it out and fixed it.

  
https://github.com/theory/pod-simple/commit/2e1cee24c9fe013729880de83bb5765a431886e3

It also used to get confused by .pod files, which I fixed here:

  
https://github.com/theory/pod-simple/commit/77391b2f2cf4268608ba9e6a2ccc44f3f9776cdf

Are these the correct fixes? I have no idea. I don’t use the search stuff 
myself, and have no idea how it’s supposed to work.

Maybe we can ask Sean?

 Independently of that, perhaps that test file should check all pod files
 rather than just one at random, to make errors easier to spot?

That sounds like a good idea. How does this work for you?

  
https://github.com/theory/pod-simple/commit/b174dd0927d672ce3a10b1626f4004a8276fa449

Best,

David