Re: [PATCH 0/4] Pull polkit forward to mozjs24

2016-08-22 Thread Kalev Lember 
On 08/18/2016 05:38 PM, Jeremy Linton wrote:
> On 08/17/2016 03:57 PM, Colin Walters wrote:
>> It might be worth looking at kalev's work to see what differs.
> 
> Are the patches visible anywhere? I don't see them in those threads.

They are in https://github.com/kalev/polkit , but rather unfinished. I
think it built, but I can't recall how much (if any) runtime testing
they've gotten.

-- 
Kalev
___
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel

Re: [PATCH 0/4] Pull polkit forward to mozjs24

2016-08-18 Thread Colin Walters 
On Thu, Aug 18, 2016, at 11:38 AM, Jeremy Linton wrote:

> The #ifdefs definitely restrict the code flow. The more recent versions 
> of JSAPI lean heavily on a RAII/construction model for rooting objects 
> in the GC.  So, removing them helps clear the way for reworking the code 
> flow to fit well with mozjs45+.

Yeah.

> 
> I will re-post with mozjs1.85 and 17 removed. Assuming everyone is happy 
> with this. 

Any "large" distribution will tend to package GNOME too which requires 24,
and for smaller ones it seems they could just bump the version.  I often
look at OE, it looks like there they have polkit here:
https://github.com/openembedded/meta-openembedded/tree/master/meta-oe/recipes-extended/polkit
which then uses:
https://github.com/openembedded/meta-openembedded/tree/master/meta-oe/recipes-extended/mozjs
which is just 17 at the moment, but I'm guessing it's the only user,
so they could just bump to 24 too.

___
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel

Re: [PATCH 0/4] Pull polkit forward to mozjs24

2016-08-17 Thread Miloslav Trmac 
2016-08-17 22:57 GMT+02:00 Colin Walters :

> I think my vote is actually for doing 24 only.  Does anyone object to that?
>

I would prefer that to the three variants in #ifdefs. (No opinion on the
substance of the patches so far I’m afraid.)
Mirek
___
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel

Re: [PATCH 0/4] Pull polkit forward to mozjs24

2016-08-17 Thread Colin Walters 


On Thu, Aug 4, 2016, at 12:57 PM, Jeremy Linton wrote:
> Polkit is out of date with respect to supported versions of mozjs. These
> patches start moving polkit forward again. Right now they are just to
> mozjs24 which is one of the first C++ only JSAPI versions of spidermonkey
> and is a good starting point for evolving polkit. Moving it forward to 38 or
> 45 involves further effort.

This came up before; see
https://lists.freedesktop.org/archives/polkit-devel/2014-April/000401.html
and
https://lists.freedesktop.org/archives/polkit-devel/2014-June/000404.html

It might be worth looking at kalev's work to see what differs.

I think my vote is actually for doing 24 only.  Does anyone object to that?

Aside from the additional #ifdefs, your patches look  clean and good to me at 
first glance.
___
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel

Re: [PATCH 0/4] Pull polkit forward to mozjs24

2016-08-15 Thread Jeremy Linton 

Ping?


On 08/04/2016 11:57 AM, Jeremy Linton wrote:

Polkit is out of date with respect to supported versions of mozjs. These
patches start moving polkit forward again. Right now they are just to
mozjs24 which is one of the first C++ only JSAPI versions of spidermonkey
and is a good starting point for evolving polkit. Moving it forward to 38 or
45 involves further effort.

Jeremy Linton (4):
  change mozjs interface module to c++
  Cleanup configure and add support for mozjs24
  Add support for mozjs24 to polkitbackendjsauthority.cpp
  Fix warnings caused by building with C++

 configure.ac   |  25 ++-
 src/polkitbackend/Makefile.am  |   7 +-
 ...djsauthority.c => polkitbackendjsauthority.cpp} | 228 -
 test/polkitbackend/Makefile.am |   3 +
 4 files changed, 158 insertions(+), 105 deletions(-)
 rename src/polkitbackend/{polkitbackendjsauthority.c => 
polkitbackendjsauthority.cpp} (92%)



___
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel

[PATCH 0/4] Pull polkit forward to mozjs24

2016-08-04 Thread Jeremy Linton 
Polkit is out of date with respect to supported versions of mozjs. These
patches start moving polkit forward again. Right now they are just to
mozjs24 which is one of the first C++ only JSAPI versions of spidermonkey
and is a good starting point for evolving polkit. Moving it forward to 38 or
45 involves further effort.

Jeremy Linton (4):
  change mozjs interface module to c++
  Cleanup configure and add support for mozjs24
  Add support for mozjs24 to polkitbackendjsauthority.cpp
  Fix warnings caused by building with C++

 configure.ac   |  25 ++-
 src/polkitbackend/Makefile.am  |   7 +-
 ...djsauthority.c => polkitbackendjsauthority.cpp} | 228 -
 test/polkitbackend/Makefile.am |   3 +
 4 files changed, 158 insertions(+), 105 deletions(-)
 rename src/polkitbackend/{polkitbackendjsauthority.c => 
polkitbackendjsauthority.cpp} (92%)

-- 
2.9.2

___
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel