Re: [Please, unbreak] multimedia/handbrake

2024-04-14 Thread Rubén Llorente

Hello,

I tried with H.264 (10-bit) and it worked here.

Give it try yourself.

Brad Smith wrote:

On 2024-04-13 11:00 p.m., Rubén Llorente wrote:
It looks like h.264 works with your diff, since I encoded a movie into 
h.264 + AAC with no issues.



You probably tried regular H.264. It's the high bit depth option 
(10-bit) that has an issue.


Thanks for testing.


Brad Smith wrote:

Rubén,

I'd love any and all feedback to try and get it into shape.









Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Brad Smith

On 2024-04-13 11:00 p.m., Rubén Llorente wrote:
It looks like h.264 works with your diff, since I encoded a movie into 
h.264 + AAC with no issues.



You probably tried regular H.264. It's the high bit depth option 
(10-bit) that has an issue.


Thanks for testing.


Brad Smith wrote:

Rubén,

I'd love any and all feedback to try and get it into shape.







Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Rubén Llorente
It looks like h.264 works with your diff, since I encoded a movie into 
h.264 + AAC with no issues.


Brad Smith wrote:

Rubén,

I'd love any and all feedback to try and get it into shape.





Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Rubén Llorente



Brad Smith wrote:
Testing Brad's diff and reporting back to the list is probably the 
best way to move this forward.



Rubén,

I'd love any and all feedback to try and get it into shape.



It is very late here. I managed to compile Handbrake 1.6.1 with your 
diff. I will encode a bunch of movies and report back with my findings 
next time I find the time for it.




Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Brian Callahan
On 4/13/2024 12:02 PM, Stuart Henderson wrote:
> On 2024/04/13 15:47, Rubén Llorente wrote:
>> Here you are.
> 
> There are definitely some problems with that one.
> 
> Testing Brad's diff and reporting back to the list is probably the best way 
> to move this forward.
> 

Agreed. I won't be able to look at this until the end of the month at
the earliest.

~Brian



Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Brad Smith

On 2024-04-13 12:02 p.m., Stuart Henderson wrote:

On 2024/04/13 15:47, Rubén Llorente wrote:

Here you are.

There are definitely some problems with that one.

Testing Brad's diff and reporting back to the list is probably the best way to 
move this forward.



Rubén,

I'd love any and all feedback to try and get it into shape.



Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Stuart Henderson
On 2024/04/13 15:47, Rubén Llorente wrote:
> Here you are.

There are definitely some problems with that one.

Testing Brad's diff and reporting back to the list is probably the best way to 
move this forward.

> Stuart Henderson wrote:
> > On 2024/04/13 14:48, Rubén Llorente wrote:
> > > Hello,
> > > 
> > > multimedia/handbrake has been broken for at least three releases already.
> > > 
> > > Please, either fix this port or remove it from the tree. Right now it is 
> > > as
> > > good as junk.
> > > 
> > > I am including a local mod of this port I have been using for a good 
> > > while,
> > > just in case somebody finds it useful. It updates Handbrake to version 
> > > 1.5.1
> > > which, while not the latest, it is not broken. I make no claim about the
> > > correctness of this port (ie. I have not checked the listed dependencies 
> > > are
> > > correct) but I hope it gets the ball rolling.
> > > 
> > 
> > Nothing attached.
> > 
> > https://marc.info/?l=openbsd-ports=171230094127744=2 needs 
> > tests/feedback.
> > 




Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Rubén Llorente

Here you are.

Stuart Henderson wrote:

On 2024/04/13 14:48, Rubén Llorente wrote:

Hello,

multimedia/handbrake has been broken for at least three releases already.

Please, either fix this port or remove it from the tree. Right now it is as
good as junk.

I am including a local mod of this port I have been using for a good while,
just in case somebody finds it useful. It updates Handbrake to version 1.5.1
which, while not the latest, it is not broken. I make no claim about the
correctness of this port (ie. I have not checked the listed dependencies are
correct) but I hope it gets the ball rolling.



Nothing attached.

https://marc.info/?l=openbsd-ports=171230094127744=2 needs tests/feedback.


handbrake.tar.gz
Description: application/gzip


Re: [Please, unbreak] multimedia/handbrake

2024-04-13 Thread Stuart Henderson
On 2024/04/13 14:48, Rubén Llorente wrote:
> Hello,
> 
> multimedia/handbrake has been broken for at least three releases already.
> 
> Please, either fix this port or remove it from the tree. Right now it is as
> good as junk.
> 
> I am including a local mod of this port I have been using for a good while,
> just in case somebody finds it useful. It updates Handbrake to version 1.5.1
> which, while not the latest, it is not broken. I make no claim about the
> correctness of this port (ie. I have not checked the listed dependencies are
> correct) but I hope it gets the ball rolling.
> 

Nothing attached.

https://marc.info/?l=openbsd-ports=171230094127744=2 needs tests/feedback.