Re: [ptxdist] [PATCH v3] lighttpd: Version bump, 1.4.67 -> 1.4.72
Hello Alexander, Am 19.10.23 um 11:16 schrieb Alexander Dahl: > Hello, > > got it sorted out, although the experience in #lighttpd IRC channel > was not as friendly as I hoped for. See below. > > Am Thu, Oct 19, 2023 at 10:33:47AM +0200 schrieb Alexander Dahl: >> Hello Andreas, >> >> sorry to bother you again. :-/ >> >> I just tested v3 of your patch on my target. See below. >> >> Am Wed, Oct 18, 2023 at 06:00:14PM +0200 schrieb Andreas Helmcke: >>> Bugfixes and several changes. e.g. >>> - Stronger TLS defaults >>> - HTTP/2 Support now as optional module >>> - Some former modules are now build in >>> >>> Link: https://www.lighttpd.net/2023/1/3/1.4.68/ >>> Link: https://www.lighttpd.net/2023/2/10/1.4.69/ >>> Link: https://www.lighttpd.net/2023/5/10/1.4.70/ >>> Link: https://www.lighttpd.net/2023/5/27/1.4.71/ >>> Link: https://www.lighttpd.net/2023/10/6/1.4.72/ >>> Signed-off-by: Andreas Helmcke >>> --- >>> rules/lighttpd.in | 35 +++ >>> rules/lighttpd.make | 15 +-- >>> 2 files changed, 16 insertions(+), 34 deletions(-) >>> >>> diff --git a/rules/lighttpd.in b/rules/lighttpd.in >>> index 910271087..670a00d15 100644 >>> --- a/rules/lighttpd.in >>> +++ b/rules/lighttpd.in >>> @@ -69,13 +69,6 @@ endmenu >>> >>> menu "modules " >>> >>> -config LIGHTTPD_MOD_ACCESS >>> - bool >>> - prompt "mod_access" >>> - default y >>> - help >>> - Deny access to some files. >>> - >>> config LIGHTTPD_MOD_ACCESSLOG >>> bool >>> prompt "mod_accesslog" >>> @@ -83,12 +76,6 @@ config LIGHTTPD_MOD_ACCESSLOG >>> help >>> flexible logging of requests served >>> >>> -config LIGHTTPD_MOD_ALIAS >>> - bool >>> - prompt "mod_alias" >>> - help >>> - Specify a special document-root for a given url-subset. >>> - >>> config LIGHTTPD_MOD_AUTH >>> bool >>> prompt "mod_auth" >>> @@ -123,11 +110,12 @@ config LIGHTTPD_BZ2LIB >>> Enable bzip2 support for mod_deflate. >>> endif >>> >>> -config LIGHTTPD_MOD_FASTCGI >>> +config LIGHTTPD_MOD_DIRLISTING >>> bool >>> - prompt "mod_fastcgi" >>> - >>> -if LIGHTTPD_MOD_FASTCGI >>> + prompt "mod_dirlisting" >>> + default y >>> + help >>> + Creates an HTML page listing the contents of the target directory. >>> >>> config LIGHTTPD_MOD_FASTCGI_PHP >>> bool >>> @@ -140,7 +128,12 @@ config LIGHTTPD_MOD_FASTCGI_PHP >>> comment "PHP CGI SAPI must be enabled" >>> depends on !PHP8_SAPI_CGI >>> >>> -endif >>> +config LIGHTTPD_MOD_H2 >>> + bool >>> + prompt "mod_h2" >>> + default y >>> + help >>> + HTTP/2 support >> >> I fear we can not make this an option (yet). > > If you do not load 'mod_h2', you need an additional setting in > lighttpd.conf to make lighttpd happy. Maybe we could add that in the > help text? Or in the commit message? It is this one: > > server.feature-flags += ( "server.h2proto" => "disable" ) > Maybe like this? help HTTP/2 support To use lighttpd without HTTP/2 you need to disable it in the configuration file: server.feature-flags += ( "server.h2proto" => "disable" ) >>> >>> config LIGHTTPD_MOD_MAGNET >>> bool >>> @@ -149,12 +142,6 @@ config LIGHTTPD_MOD_MAGNET >>> help >>> A module to control the request handling >>> >>> -config LIGHTTPD_MOD_REWRITE >>> - bool >>> - prompt "mod_rewrite" >>> - help >>> - Module for URL rewriting >>> - >>> config LIGHTTPD_MOD_WEBDAV >>> bool >>> prompt "mod_webdav" >>> diff --git a/rules/lighttpd.make b/rules/lighttpd.make >>> index 3aa54a1fb..a7e4b05c1 100644 >>> --- a/rules/lighttpd.make >>> +++ b/rules/lighttpd.make >>> @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd >>> # >>> # Paths and names >>> # >>> -LIGHTTPD_VERSION := 1.4.67 >>> -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b >>> +LIGHTTPD_VERSION := 1.4.72 >>> +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d >>> LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) >>> LIGHTTPD_SUFFIX:= tar.xz >>> LIGHTTPD_URL := >>> http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) >>> @@ -93,24 +93,19 @@ $(STATEDIR)/lighttpd.install: >>> # >>> >>> >>> LIGHTTPD_MODULES-y := >>> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESS)+= mod_access >>> LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESSLOG) += mod_accesslog >>> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ALIAS) += mod_alias >>> LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH) += mod_auth >>> LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH) += >>> mod_authn_file >>> LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DEFLATE) += mod_deflate >>> -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_FASTCGI) += mod_fastcgi >>> +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DIRLISTING)+=
Re: [ptxdist] [PATCH v3] lighttpd: Version bump, 1.4.67 -> 1.4.72
Hello, got it sorted out, although the experience in #lighttpd IRC channel was not as friendly as I hoped for. See below. Am Thu, Oct 19, 2023 at 10:33:47AM +0200 schrieb Alexander Dahl: > Hello Andreas, > > sorry to bother you again. :-/ > > I just tested v3 of your patch on my target. See below. > > Am Wed, Oct 18, 2023 at 06:00:14PM +0200 schrieb Andreas Helmcke: > > Bugfixes and several changes. e.g. > > - Stronger TLS defaults > > - HTTP/2 Support now as optional module > > - Some former modules are now build in > > > > Link: https://www.lighttpd.net/2023/1/3/1.4.68/ > > Link: https://www.lighttpd.net/2023/2/10/1.4.69/ > > Link: https://www.lighttpd.net/2023/5/10/1.4.70/ > > Link: https://www.lighttpd.net/2023/5/27/1.4.71/ > > Link: https://www.lighttpd.net/2023/10/6/1.4.72/ > > Signed-off-by: Andreas Helmcke > > --- > > rules/lighttpd.in | 35 +++ > > rules/lighttpd.make | 15 +-- > > 2 files changed, 16 insertions(+), 34 deletions(-) > > > > diff --git a/rules/lighttpd.in b/rules/lighttpd.in > > index 910271087..670a00d15 100644 > > --- a/rules/lighttpd.in > > +++ b/rules/lighttpd.in > > @@ -69,13 +69,6 @@ endmenu > > > > menu "modules " > > > > -config LIGHTTPD_MOD_ACCESS > > - bool > > - prompt "mod_access" > > - default y > > - help > > - Deny access to some files. > > - > > config LIGHTTPD_MOD_ACCESSLOG > > bool > > prompt "mod_accesslog" > > @@ -83,12 +76,6 @@ config LIGHTTPD_MOD_ACCESSLOG > > help > > flexible logging of requests served > > > > -config LIGHTTPD_MOD_ALIAS > > - bool > > - prompt "mod_alias" > > - help > > - Specify a special document-root for a given url-subset. > > - > > config LIGHTTPD_MOD_AUTH > > bool > > prompt "mod_auth" > > @@ -123,11 +110,12 @@ config LIGHTTPD_BZ2LIB > > Enable bzip2 support for mod_deflate. > > endif > > > > -config LIGHTTPD_MOD_FASTCGI > > +config LIGHTTPD_MOD_DIRLISTING > > bool > > - prompt "mod_fastcgi" > > - > > -if LIGHTTPD_MOD_FASTCGI > > + prompt "mod_dirlisting" > > + default y > > + help > > + Creates an HTML page listing the contents of the target directory. > > > > config LIGHTTPD_MOD_FASTCGI_PHP > > bool > > @@ -140,7 +128,12 @@ config LIGHTTPD_MOD_FASTCGI_PHP > > comment "PHP CGI SAPI must be enabled" > > depends on !PHP8_SAPI_CGI > > > > -endif > > +config LIGHTTPD_MOD_H2 > > + bool > > + prompt "mod_h2" > > + default y > > + help > > + HTTP/2 support > > I fear we can not make this an option (yet). If you do not load 'mod_h2', you need an additional setting in lighttpd.conf to make lighttpd happy. Maybe we could add that in the help text? Or in the commit message? It is this one: server.feature-flags += ( "server.h2proto" => "disable" ) > > > > > config LIGHTTPD_MOD_MAGNET > > bool > > @@ -149,12 +142,6 @@ config LIGHTTPD_MOD_MAGNET > > help > > A module to control the request handling > > > > -config LIGHTTPD_MOD_REWRITE > > - bool > > - prompt "mod_rewrite" > > - help > > - Module for URL rewriting > > - > > config LIGHTTPD_MOD_WEBDAV > > bool > > prompt "mod_webdav" > > diff --git a/rules/lighttpd.make b/rules/lighttpd.make > > index 3aa54a1fb..a7e4b05c1 100644 > > --- a/rules/lighttpd.make > > +++ b/rules/lighttpd.make > > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd > > # > > # Paths and names > > # > > -LIGHTTPD_VERSION := 1.4.67 > > -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b > > +LIGHTTPD_VERSION := 1.4.72 > > +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d > > LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) > > LIGHTTPD_SUFFIX:= tar.xz > > LIGHTTPD_URL := > > http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) > > @@ -93,24 +93,19 @@ $(STATEDIR)/lighttpd.install: > > # > > > > > > LIGHTTPD_MODULES-y := > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESS)+= mod_access > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESSLOG) += mod_accesslog > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ALIAS) += mod_alias > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH) += mod_auth > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH) += > > mod_authn_file > > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DEFLATE) += mod_deflate > > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_FASTCGI) += mod_fastcgi > > +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DIRLISTING)+= > > mod_dirlisting > > +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_H2)+= > > mod_h2 > > We probably need to always install mod_h2. I turned the option off > and now I get this at runtime > (`lighttpd -tt -f /etc/lighttpd/lighttpd.conf`): > > 2012-01-01 00:46:15: (plugin.c.209)
Re: [ptxdist] [PATCH v3] lighttpd: Version bump, 1.4.67 -> 1.4.72
Hello Andreas, sorry to bother you again. :-/ I just tested v3 of your patch on my target. See below. Am Wed, Oct 18, 2023 at 06:00:14PM +0200 schrieb Andreas Helmcke: > Bugfixes and several changes. e.g. > - Stronger TLS defaults > - HTTP/2 Support now as optional module > - Some former modules are now build in > > Link: https://www.lighttpd.net/2023/1/3/1.4.68/ > Link: https://www.lighttpd.net/2023/2/10/1.4.69/ > Link: https://www.lighttpd.net/2023/5/10/1.4.70/ > Link: https://www.lighttpd.net/2023/5/27/1.4.71/ > Link: https://www.lighttpd.net/2023/10/6/1.4.72/ > Signed-off-by: Andreas Helmcke > --- > rules/lighttpd.in | 35 +++ > rules/lighttpd.make | 15 +-- > 2 files changed, 16 insertions(+), 34 deletions(-) > > diff --git a/rules/lighttpd.in b/rules/lighttpd.in > index 910271087..670a00d15 100644 > --- a/rules/lighttpd.in > +++ b/rules/lighttpd.in > @@ -69,13 +69,6 @@ endmenu > > menu "modules " > > -config LIGHTTPD_MOD_ACCESS > - bool > - prompt "mod_access" > - default y > - help > - Deny access to some files. > - > config LIGHTTPD_MOD_ACCESSLOG > bool > prompt "mod_accesslog" > @@ -83,12 +76,6 @@ config LIGHTTPD_MOD_ACCESSLOG > help > flexible logging of requests served > > -config LIGHTTPD_MOD_ALIAS > - bool > - prompt "mod_alias" > - help > - Specify a special document-root for a given url-subset. > - > config LIGHTTPD_MOD_AUTH > bool > prompt "mod_auth" > @@ -123,11 +110,12 @@ config LIGHTTPD_BZ2LIB > Enable bzip2 support for mod_deflate. > endif > > -config LIGHTTPD_MOD_FASTCGI > +config LIGHTTPD_MOD_DIRLISTING > bool > - prompt "mod_fastcgi" > - > -if LIGHTTPD_MOD_FASTCGI > + prompt "mod_dirlisting" > + default y > + help > + Creates an HTML page listing the contents of the target directory. > > config LIGHTTPD_MOD_FASTCGI_PHP > bool > @@ -140,7 +128,12 @@ config LIGHTTPD_MOD_FASTCGI_PHP > comment "PHP CGI SAPI must be enabled" > depends on !PHP8_SAPI_CGI > > -endif > +config LIGHTTPD_MOD_H2 > + bool > + prompt "mod_h2" > + default y > + help > + HTTP/2 support I fear we can not make this an option (yet). > > config LIGHTTPD_MOD_MAGNET > bool > @@ -149,12 +142,6 @@ config LIGHTTPD_MOD_MAGNET > help > A module to control the request handling > > -config LIGHTTPD_MOD_REWRITE > - bool > - prompt "mod_rewrite" > - help > - Module for URL rewriting > - > config LIGHTTPD_MOD_WEBDAV > bool > prompt "mod_webdav" > diff --git a/rules/lighttpd.make b/rules/lighttpd.make > index 3aa54a1fb..a7e4b05c1 100644 > --- a/rules/lighttpd.make > +++ b/rules/lighttpd.make > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd > # > # Paths and names > # > -LIGHTTPD_VERSION := 1.4.67 > -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b > +LIGHTTPD_VERSION := 1.4.72 > +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d > LIGHTTPD := lighttpd-$(LIGHTTPD_VERSION) > LIGHTTPD_SUFFIX := tar.xz > LIGHTTPD_URL := > http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX) > @@ -93,24 +93,19 @@ $(STATEDIR)/lighttpd.install: > # > > > LIGHTTPD_MODULES-y := > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESS) += mod_access > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ACCESSLOG) += mod_accesslog > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_ALIAS) += mod_alias > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH)+= mod_auth > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_AUTH)+= > mod_authn_file > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DEFLATE) += mod_deflate > -LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_FASTCGI) += mod_fastcgi > +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_DIRLISTING) += mod_dirlisting > +LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_H2) += mod_h2 We probably need to always install mod_h2. I turned the option off and now I get this at runtime (`lighttpd -tt -f /etc/lighttpd/lighttpd.conf`): 2012-01-01 00:46:15: (plugin.c.209) dlopen() failed for: /usr/lib/lighttpd/mod_h2.so /usr/lib/lighttpd/mod_h2.so: cannot open shared object file: No such file or directory I asked the lighttpd devs on IRC about this, but got no helpful response yet. Apart of that my previous configuration does not work anymore, I get some "unknown config-key" messages in log and the webserver only returns 403. Have to look deeper into that, but I just wanted to get out that mod_h2 information first. Greets Alex > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_MOD_MAGNET) += mod_magnet > LIGHTTPD_MODULES-$(PTXCONF_LIGHTTPD_OPENSSL) += mod_openssl >
Re: [ptxdist] OSELAS Toolchain 2023.07.0 fails to build clang
On Wed, Oct 18, 2023 at 12:25:44PM +0200, Mircea Ciocan wrote: > - Ursprüngliche Mail - > Hi, > > On Tue, Oct 17, 2023 at 11:45:22AM +0200, Mircea Ciocan wrote: > > I was trying to compile the OSELAS-2023.07.0 from the original sources on a > > Ubuntu 22.04 and got the following error: > > > > --- > > target: cross-clang.extract > > --- > > > > extract: pkg_src=OSELAS.Toolchain-2023.07.0x/src/clang-16.0.6.src.tar.xz > > extract: > > pkg_extract_dir=OSELAS.Toolchain-2023.07.0x/platform-arm-v7a-linux-gnueabihf-gcc-13.1.1-clang-16.0.6-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/build-cross/clang-16.0.6 > > > > patchin: no patches found > > finished target cross-clang.extract > > make: *** No rule to make target > > '/home/dev/Software/Toolchain/OSELAS.Toolchain-2023.07.0x/platform-arm-v7a-linux-gnueabihf-gcc-13.1.1-clang-16.0.6-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/sysroot-cross/bin/llvm-config', > > needed by > > '/home/dev/Software/Toolchain/OSELAS.Toolchain-2023.07.0x/platform-arm-v7a-linux-gnueabihf-gcc-13.1.1-clang-16.0.6-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized/state/cross-llvm.prepare'. > > Stop. > > make: *** [build_all_v2.mk:44: > > gstate/arm-v7a-linux-gnueabihf-gcc-13.1.1-clang-16.0.6-glibc-2.37-binutils-2.40-kernel-6.3.6-sanitized.build] > > Error 2 > > > > It seems that the build directory is not even created. > > Do you have any idea what can I do ? > > Just a wild guess: You're using ptxdist-2023.10.0 to build the toolchain. > Don't do that. Use ptxdist-2023.07.0 as specified in the config files. > > Regards, > Michael > > Hello Michael and thanks for the answer, > should I stay then 2023.07.0 or should go to 2023.07.1, I remember it was a > regression, is that relevant for the toolchain project ? Either one works. The issue is mostly cosmetic anyways and you're probably not affected by that anyways. Regards, Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
Re: [ptxdist] [PATCH] lighttpd: Version bump, 1.4.67 -> 1.4.72
Hallo,
On Wed, Oct 18, 2023 at 02:38:56PM +0200, Alexander Dahl wrote:
> Am Wed, Oct 18, 2023 at 02:25:03PM +0200 schrieb Andreas Helmcke:
> > Am 18.10.23 um 13:38 schrieb Alexander Dahl:
> > > Am Wed, Oct 18, 2023 at 12:53:58PM +0200 schrieb Andreas Helmcke:
> > >> Am 18.10.23 um 07:54 schrieb Michael Olbrich:
> > >>> On Tue, Oct 17, 2023 at 08:05:11AM +0200, Alexander Dahl wrote:
> > Hello Andreas,
> >
> > first of all, thanks for taking care of this, my remarks below.
> >
> > Am Mon, Oct 16, 2023 at 07:07:34PM +0200 schrieb Andreas Helmcke:
> > > Bugfixes and several changes. e.g.
> > > - Stronger TLS defaults
> > > - HTTP/2 Support now as optional module
> > >
> > > see: https://www.lighttpd.net/releases/
> >
> > Link: https://www.lighttpd.net/2023/1/3/1.4.68/
> > Link: https://www.lighttpd.net/2023/2/10/1.4.69/
> > Link: https://www.lighttpd.net/2023/5/10/1.4.70/
> > Link: https://www.lighttpd.net/2023/5/27/1.4.71/
> > Link: https://www.lighttpd.net/2023/10/6/1.4.72/
> > >>
> > >> thanks, changed that
> > >>
> > > Signed-off-by: Andreas Helmcke
> > > ---
> > > rules/lighttpd.make | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/rules/lighttpd.make b/rules/lighttpd.make
> > > index 3aa54a1fb..7b7abf7d2 100644
> > > --- a/rules/lighttpd.make
> > > +++ b/rules/lighttpd.make
> > > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd
> > > #
> > > # Paths and names
> > > #
> > > -LIGHTTPD_VERSION := 1.4.67
> > > -LIGHTTPD_MD5 := 64822c5061001673162cf9775d91a80b
> > > +LIGHTTPD_VERSION := 1.4.72
> > > +LIGHTTPD_MD5 := 466f9fe131cd7d38d0fe47d2e6a2939d
> >
> > Builds fine, but …
> >
> > That 1.4.70 in particular needs a little more work on the ptxdist
> > package, because several modules are not built separate anymore, but
> > built-in now. This makes some of the LIGHTTPD_MOD_* options in menu
> > not necessary anymore, and breaks targetinstall if those should have
> > been installed before, e.g. like this:
> >
> > Error: ptxd_lib_install: cannot find library
> > 'lighttpd/mod_indexfile'!
> > >>
> > >> I can not (re)produce your error, but ...
> > >
> > > Interesting. It's one of the modules always installed. Maybe we have
> > > different options set? Comes from these lines:
> > >
> > > 111 # add modules that are always loaded
> > > 112 LIGHTTPD_MODULES_INSTALL := mod_indexfile mod_dirlisting
> > > mod_staticfile $(LIGHTTPD_MODULES-y)
> > >
> > > Please test with PTXCONF_LIGHTTPD_INSTALL_SELECTED_MODULES set and
> > > not set, and compare. I guess you will also find 'mod_staticfile'?
> >
> > Yes, you are right. I didn't use the option "Only install selected modules".
> > If I fix this by removing mod_indexfile and mod_staticfile (which works)
> > only
> > mod_dirlisting remains in the list of always loaded modules.
>
> Yes.
>
> > So it might be a good idea to completely do without a static list of always
> > loaded
> > modules and also make mod_dirlist configurable.
> > Any objections?
>
> Fine with me, if the module is installed by default as before.
>
> Michael added this with c37f05122341 ("lighttpd: rework options and
> configuration") back in 2013 for ptxdist-2013.03.0 when reworking the
> lighttpd package. Maybe he has an opinion?
I'm fine with an option but make that one 'default y'. I had the fixed list
because I considered those modules as essential. I guess upstream agreed
with that for two of those, since they are now builtin :-).
An option for the last one is fine.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
