[ptxdist] [PATCH 2/2] Revert "initmethod-systemd: add more empty folders for ifupdown"
Scripts in those folders not considered anymore since busybox 1.21.0 (ptxdist-2013.06.0). This reverts commit 09e94f459f26c5784a0440cb946fc97fc53f5879. Signed-off-by: Alexander Dahl --- rules/initmethod-systemd.make | 2 -- 1 file changed, 2 deletions(-) diff --git a/rules/initmethod-systemd.make b/rules/initmethod-systemd.make index be2a31817..8701a6bc1 100644 --- a/rules/initmethod-systemd.make +++ b/rules/initmethod-systemd.make @@ -48,10 +48,8 @@ ifdef PTXCONF_INITMETHOD_SYSTEMD_IFUPDOWN @$(call install_alternative, initmethod-systemd, 0, 0, 0644, /etc/network/interfaces) @$(call install_copy, initmethod-systemd, 0, 0, 0755, /etc/network/if-down.d) @$(call install_copy, initmethod-systemd, 0, 0, 0755, /etc/network/if-up.d) - @$(call install_copy, initmethod-systemd, 0, 0, 0755, /etc/network/if-pre-down.d) @$(call install_copy, initmethod-systemd, 0, 0, 0755, /etc/network/if-post-down.d) @$(call install_copy, initmethod-systemd, 0, 0, 0755, /etc/network/if-pre-up.d) - @$(call install_copy, initmethod-systemd, 0, 0, 0755, /etc/network/if-post-up.d) endif @$(call install_finish,initmethod-systemd) -- 2.39.2
[ptxdist] [PATCH 1/2] Revert "initmethod-bbinit: add more empty folders for ifupdown"
Scripts in those folders not considered anymore since busybox 1.21.0 (ptxdist-2013.06.0). This reverts commit eb2d9e63ae110b7f3069307ee89a4d281f12d118. Signed-off-by: Alexander Dahl --- rules/initmethod-bbinit.make | 2 -- 1 file changed, 2 deletions(-) diff --git a/rules/initmethod-bbinit.make b/rules/initmethod-bbinit.make index 75d381e29..4ae5c3284 100644 --- a/rules/initmethod-bbinit.make +++ b/rules/initmethod-bbinit.make @@ -59,10 +59,8 @@ ifdef PTXCONF_INITMETHOD_BBINIT_ETC_INITD_NETWORKING @$(call install_alternative, initmethod-bbinit, 0, 0, 0644, /etc/network/interfaces, n) @$(call install_copy, initmethod-bbinit, 0, 0, 0755, /etc/network/if-down.d) @$(call install_copy, initmethod-bbinit, 0, 0, 0755, /etc/network/if-up.d) - @$(call install_copy, initmethod-bbinit, 0, 0, 0755, /etc/network/if-pre-down.d) @$(call install_copy, initmethod-bbinit, 0, 0, 0755, /etc/network/if-post-down.d) @$(call install_copy, initmethod-bbinit, 0, 0, 0755, /etc/network/if-pre-up.d) - @$(call install_copy, initmethod-bbinit, 0, 0, 0755, /etc/network/if-post-up.d) endif ifdef PTXCONF_INITMETHOD_BBINIT_ETC_INITD_RT_SET_BANDWIDTH -- 2.39.2
[ptxdist] [PATCH 0/2] ifupdown: Remove not used hook folders again
After putting a script in /etc/network/if-post-up.d and wondering why it was not executed I found myself in a strange rabbit hole. busybox added support for the folders post-up and pre-down with 1.20.0 and according to the two patches reverted now, complained when those where missing. So after upgrading to busybox 1.20.1 for ptxdist-2012.07.0 those folders where created from ptxdist-2012.08.0 onwards. That busybox feature seemed to be incompatible with how Debian ifupdown (the original one) handles things, which considers those folders as aliases only. The claim "Treat post-up and pre-down as aliases for up and down." is probably only related to things you can set in file /etc/network/interfaces per interface, so post-up and pre-down probably work from interfaces but not from hook folders. The Debian manpage also says this: > Please note that as post-up and pre-down are aliases, no files in the > corresponding directories are processed. Please use if-up.d and > if-down.d directories instead. So busybox 1.21.0 removed executing scripts from post-up and pre-down folders again, without explicitly making that clear, only stating it would improve compatibility to Debian. With busybox 1.21.0 those warnings where gone again if those folders are not present, so from the hook script point of view everything as before 1.20.0. That update to busybox 1.21.0 came with ptxdist-2013.07.0 one year later and from then on we had two useless folders. Removing those now to avoid further confusion. Link: https://git.busybox.net/busybox/commit/?id=dd82443b92d7f5570fddc2eaeb634f1f971d Link: https://git.busybox.net/busybox/commit/?id=3a9365e2732f5df2cdef758bc1f6e5e9da8fbcef Alexander Dahl (2): Revert "initmethod-bbinit: add more empty folders for ifupdown" Revert "initmethod-systemd: add more empty folders for ifupdown" rules/initmethod-bbinit.make | 2 -- rules/initmethod-systemd.make | 2 -- 2 files changed, 4 deletions(-) base-commit: e7e42d3b81e1244a33533b9c7a6e41d8da5d7769 -- 2.39.2
