Re: [ptxdist] [PATCH 01/13] [fontconfig] Add custom fonts.conf option

2010-01-29 Thread Erwin Rol

Hallo,

The patches are also available from

http://git.hbelightingsystems.com/?p=ptxdist;a=shortlog;h=refs/heads/for-ptx

Most are simple things, the thing that needs a good look is the way how I
autogenerate the --enable and --disable flags.

- Erwin


--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 01/13] [fontconfig] Add custom fonts.conf option

2010-01-29 Thread Marc Kleine-Budde
Erwin Rol wrote:
 Hallo,
 
 The patches are also available from
 
 http://git.hbelightingsystems.com/?p=ptxdist;a=shortlog;h=refs/heads/for-ptx
 
 
 Most are simple things, the thing that needs a good look is the way how I
 autogenerate the --enable and --disable flags.

The idea is quite nice, however I don't want to have the magic
(--disable-$(subst $(space),$(space)--disable-,$(strip
$(GST_PLUGINS_GOOD_ENABLE- in all makefiles. Maybe we could
centralize it a bit.

But for now I think it can stay this way.

mol, what do you think?

Marc
-- 
Pengutronix e.K.  | Marc Kleine-Budde   |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund  | Fax:   +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



signature.asc
Description: OpenPGP digital signature
--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 01/13] [fontconfig] Add custom fonts.conf option

2010-01-29 Thread Michael Olbrich
On Fri, Jan 29, 2010 at 11:22:02AM +0100, mailingli...@erwinrol.com wrote:
 +ifdef PTXCONF_FONTCONFIG_CONFS_DEFAULT
   @$(call install_copy, fontconfig, 0, 0, 0644, -, \
   /etc/fonts/fonts.conf,n)
  
 @@ -99,6 +105,11 @@ ifdef PTXCONF_FONTCONFIG_CONFS
  #/etc/fonts/conf.d/autohint.conf,n)
  endif
  
 +ifdef PTXCONF_FONTCONFIG_CONFS_CUSTOM
 + @$(call install_alternative, fontconfig, 0, 0, 0644, \
 + /etc/fonts/fonts.conf)
 +endif

Marc: install_alternative should probably check in PKG_PKGDIR as well.
I think you mentioned that before. Lowest priority, right?
But I'll need to finish my install cleanups first.

Michael

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 01/13] [fontconfig] Add custom fonts.conf option

2010-01-29 Thread Erwin Rol

Marc Kleine-Budde wrote:

Erwin Rol wrote:

Hallo,

The patches are also available from

http://git.hbelightingsystems.com/?p=ptxdist;a=shortlog;h=refs/heads/for-ptx


Most are simple things, the thing that needs a good look is the way how I
autogenerate the --enable and --disable flags.


The idea is quite nice, however I don't want to have the magic
(--disable-$(subst $(space),$(space)--disable-,$(strip
$(GST_PLUGINS_GOOD_ENABLE- in all makefiles. Maybe we could
centralize it a bit.


I wouldn't know where to start to bring it into ptxdist, so i can't 
really help there.


- Erwin


--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 01/13] [fontconfig] Add custom fonts.conf option

2010-01-29 Thread Marc Kleine-Budde
Michael Olbrich wrote:
 On Fri, Jan 29, 2010 at 11:22:02AM +0100, mailingli...@erwinrol.com wrote:
 +ifdef PTXCONF_FONTCONFIG_CONFS_DEFAULT
  @$(call install_copy, fontconfig, 0, 0, 0644, -, \
  /etc/fonts/fonts.conf,n)
  
 @@ -99,6 +105,11 @@ ifdef PTXCONF_FONTCONFIG_CONFS
  #   /etc/fonts/conf.d/autohint.conf,n)
  endif
  
 +ifdef PTXCONF_FONTCONFIG_CONFS_CUSTOM
 +@$(call install_alternative, fontconfig, 0, 0, 0644, \
 +/etc/fonts/fonts.conf)
 +endif
 
 Marc: install_alternative should probably check in PKG_PKGDIR as well.
 I think you mentioned that before. Lowest priority, right?

ACK

 But I'll need to finish my install cleanups first.

ACK, I think we shouldn't touch the old code any more.

Marc
-- 
Pengutronix e.K.  | Marc Kleine-Budde   |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund  | Fax:   +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



signature.asc
Description: OpenPGP digital signature
--
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH 01/13] [fontconfig] Add custom fonts.conf option

2010-01-29 Thread Erwin Rol

Hello,

these are the cleaned up patches after mol's comments. If everything is 
OK, Marc knows where to pull them.


- Erwin


--
ptxdist mailing list
ptxdist@pengutronix.de