Re: [ptxdist] [Patch] openssl.make, corrected 'ifneq' to set the THUD variable correctly.
Hi Jürgen, On Mon, Mar 31, 2008 at 06:34:47PM +0200, Jürgen Kilb wrote: make was the problem :-( It works with a fresh build make-3.81 [EMAIL PROTECTED]:~/make-3.81 cd .. [EMAIL PROTECTED]:~ make-3.81/make FOO= BAR= [EMAIL PROTECTED]:~ make-3.81/make FOO=y BAR= [EMAIL PROTECTED]:~ make-3.81/make FOO= BAR=y [EMAIL PROTECTED]:~ make-3.81/make FOO=y BAR=y y [EMAIL PROTECTED]:~ Could you please try again, with latest trunk (= 7901)? I've applied the patch below, which should also work with make 3.80. On Tue, Apr 01, 2008 at 11:07:51AM +0200, [EMAIL PROTECTED] wrote: Author: rsc Date: 2008-04-01 11:07:50 +0200 (Tue, 01 Apr 2008) New Revision: 7901 Modified: trunks/ptxdist-trunk/rules/openssl.make Log: * openssl: use 'and' method that also works on make 3.81 Modified: trunks/ptxdist-trunk/rules/openssl.make === --- trunks/ptxdist-trunk/rules/openssl.make 2008-04-01 05:37:31 UTC (rev 7900) +++ trunks/ptxdist-trunk/rules/openssl.make 2008-04-01 09:07:50 UTC (rev 7901) @@ -24,19 +24,19 @@ OPENSSL_SOURCE = $(SRCDIR)/$(OPENSSL).tar.gz OPENSSL_DIR = $(BUILDDIR)/$(OPENSSL) -ifneq ($(and $(PTXCONF_ARCH_ARM),$(PTXCONF_ENDIAN_LITTLE)),) +ifeq ($(PTXCONF_ARCH_ARM)$(PTXCONF_ENDIAN_LITTLE),yy) THUD = linux-arm endif -ifneq ($(and $(PTXCONF_ARCH_ARM),$(PTXCONF_ENDIAN_BIG)),) +ifeq ($(PTXCONF_ARCH_ARM)$(PTXCONF_ENDIAN_BIG),yy) THUD = linux-armeb endif -ifneq ($(and $(PTXCONF_ARCH_MIPS),$(PTXCONF_ENDIAN_LITTLE)),) +ifeq ($(PTXCONF_ARCH_MIPS)$(PTXCONF_ENDIAN_LITTLE),yy) THUD = linux-mipsel endif -ifneq ($(and $(PTXCONF_ARCH_MIPS),$(PTXCONF_ENDIAN_BIG)),) +ifeq ($(PTXCONF_ARCH_MIPS)$(PTXCONF_ENDIAN_BIG),yy) THUD = linux-mips endif Robert -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Hannoversche Str. 2, 31134 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-9 -- ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [Patch] openssl.make, corrected 'ifneq' to set the THUD variable correctly.
On Tue, Apr 01, 2008 at 12:25:55PM +0200, Jürgen Kilb wrote: Could you please try again, with latest trunk (= 7901)? I've applied the patch below, which should also work with make 3.80. It's now OK. Great! I suppose it's better to fix it in that way, than relying on make newer than 3.81 only because of that one code sniplet. rsc -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Hannoversche Str. 2, 31134 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-9 -- ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [Patch] openssl.make, corrected 'ifneq' to set the THUD variable correctly.
Hi, [EMAIL PROTECTED] wrote on 31.03.2008 17:05:35: So the arguments are expanded as you described, the $(and) function expands to the expansion of the last argument (y), which is != nothing. Should be right. Stand alone example: [EMAIL PROTECTED]:~$ cat Makefile BAZ=$(and $(FOO),$(BAR)) all: @echo $(BAZ) [EMAIL PROTECTED]:~$ make FOO= BAR= [EMAIL PROTECTED]:~$ make FOO=y BAR= [EMAIL PROTECTED]:~$ make FOO= BAR=y [EMAIL PROTECTED]:~$ make FOO=y BAR=y y Q.E.D. If i do the same, the result is different... but why ? [EMAIL PROTECTED]:~ cat Makefile BAZ=$(and $(FOO),$(BAR)) all: @echo $(BAZ) [EMAIL PROTECTED]:~ make FOO= BAR= [EMAIL PROTECTED]:~ make FOO=y BAR= [EMAIL PROTECTED]:~ make FOO= BAR=y [EMAIL PROTECTED]:~ make FOO=y BAR=y [EMAIL PROTECTED]:~ Maybe the 'make' version ? [EMAIL PROTECTED]:~ make -v GNU Make 3.80 Copyright (C) 2002 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [EMAIL PROTECTED]:~ -Jürgen -- ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [Patch] openssl.make, corrected 'ifneq' to set the THUD variable correctly.
On Mon, Mar 31, 2008 at 05:54:09PM +0200, Jürgen Kilb wrote: If i do the same, the result is different... but why ? [EMAIL PROTECTED]:~ cat Makefile BAZ=$(and $(FOO),$(BAR)) all: @echo $(BAZ) [EMAIL PROTECTED]:~ make FOO= BAR= [EMAIL PROTECTED]:~ make FOO=y BAR= [EMAIL PROTECTED]:~ make FOO= BAR=y [EMAIL PROTECTED]:~ make FOO=y BAR=y [EMAIL PROTECTED]:~ Maybe the 'make' version ? [EMAIL PROTECTED]:~ make -v GNU Make 3.80 Copyright (C) 2002 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [EMAIL PROTECTED]:~ Hmm, I have 3.81. Does anyone have a better idea, or should we depend on 3.81? However, it would be a little bit uggly... Robert -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Hannoversche Str. 2, 31134 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-9 -- ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [Patch] openssl.make, corrected 'ifneq' to set the THUD variable correctly.
Hi, [EMAIL PROTECTED] wrote on 31.03.2008 18:22:23: On Mon, Mar 31, 2008 at 05:54:09PM +0200, Jürgen Kilb wrote: If i do the same, the result is different... but why ? [EMAIL PROTECTED]:~ cat Makefile BAZ=$(and $(FOO),$(BAR)) all: @echo $(BAZ) [EMAIL PROTECTED]:~ make FOO= BAR= [EMAIL PROTECTED]:~ make FOO=y BAR= [EMAIL PROTECTED]:~ make FOO= BAR=y [EMAIL PROTECTED]:~ make FOO=y BAR=y [EMAIL PROTECTED]:~ Maybe the 'make' version ? [EMAIL PROTECTED]:~ make -v GNU Make 3.80 Copyright (C) 2002 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [EMAIL PROTECTED]:~ Hmm, I have 3.81. Does anyone have a better idea, or should we depend on 3.81? However, it would be a little bit uggly... make was the problem :-( It works with a fresh build make-3.81 [EMAIL PROTECTED]:~/make-3.81 cd .. [EMAIL PROTECTED]:~ make-3.81/make FOO= BAR= [EMAIL PROTECTED]:~ make-3.81/make FOO=y BAR= [EMAIL PROTECTED]:~ make-3.81/make FOO= BAR=y [EMAIL PROTECTED]:~ make-3.81/make FOO=y BAR=y y [EMAIL PROTECTED]:~ -Jürgen -- ptxdist mailing list ptxdist@pengutronix.de
