Re: [pulseaudio-discuss] [RFC 06/12] bluetooth: Register MP3 endpoint for bluetooth

2012-02-10 Thread Dalleau, Frederic
Hi Pierre,

On Wed, Feb 8, 2012 at 9:07 PM, Pierre-Louis Bossart
pierre-louis.boss...@linux.intel.com wrote:

 +    static const a2dp_mpeg_t source_caps = {
 +        .channel_mode = BT_A2DP_CHANNEL_MODE_MONO |
 BT_A2DP_CHANNEL_MODE_STEREO |
 +                        BT_A2DP_CHANNEL_MODE_DUAL_CHANNEL |
 BT_A2DP_CHANNEL_MODE_JOINT_STEREO,
 +        .layer = BT_MPEG_LAYER_1 | BT_MPEG_LAYER_2 | BT_MPEG_LAYER_3,
 +        .crc = 0,
 +        .frequency = MPEG_SAMPLING_FREQ_44100|MPEG_SAMPLING_FREQ_48000,
 +        .rfa = 0,
 +        .mpf = 0,
 +        .bitrate = 0xff,
 +    };

 This doesn't seem right, I think A2DP allows for 32 kHz? 16kHz is probably
 not supported by anyone.



Hi Pierre,

A2DP allows for all frequencies, but only 44.1 and 48 are mandatory to
be supported by the headset.
As a source it makes sense to support all frequencies, since they will
be directly defined by the file being played.

Regards,
Frédéric
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss


Re: [pulseaudio-discuss] [RFC 06/12] bluetooth: Register MP3 endpoint for bluetooth

2012-02-08 Thread Pierre-Louis Bossart



+static const a2dp_mpeg_t source_caps = {
+.channel_mode = BT_A2DP_CHANNEL_MODE_MONO | 
BT_A2DP_CHANNEL_MODE_STEREO |
+BT_A2DP_CHANNEL_MODE_DUAL_CHANNEL | 
BT_A2DP_CHANNEL_MODE_JOINT_STEREO,
+.layer = BT_MPEG_LAYER_1 | BT_MPEG_LAYER_2 | BT_MPEG_LAYER_3,
+.crc = 0,
+.frequency = MPEG_SAMPLING_FREQ_44100|MPEG_SAMPLING_FREQ_48000,
+.rfa = 0,
+.mpf = 0,
+.bitrate = 0xff,
+};
This doesn't seem right, I think A2DP allows for 32 kHz? 16kHz is 
probably not supported by anyone.


___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss