Re: [pulseaudio-discuss] [PATCH] [module-loopback] Add new arguments sink_dont_move and source_dont_move to toggle module automatic unloading when the sink or source were not available

2011-01-03 Thread Colin Guthrie
'Twas brillig, and Colin Guthrie at 30/12/10 12:09 did gyre and gimble:
 'Twas brillig, and Cai Yuanqing at 30/12/10 07:18 did gyre and gimble:
  Hi Colin:

 Could you review this patch for a while,and give me some comments :-)
 
 Hmm, thought I'd replied to this already, but I guess I just looked...
 
 It seems fine. I'll include it when I next do some merging after the new
 year. Right now I'm off to lock myself in a cabin in the highlands with
 a bunch of mates and a few bottles of good whisky! Slàinte Mhath!

Head almost back to normal now!

Had a closer review and found a small bug (flags for the sink input were
overwritten further down the code). I've rejigged things a little and
made things a bit more symmetrical (although somewhat redundant) to make
things a little clearer.

Cheers

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss


[pulseaudio-discuss] What to do with the Smart 5.1 mixer element (VIA VT1708S)

2011-01-03 Thread Colin Guthrie
As detailed here:
https://qa.mandriva.com/show_bug.cgi?id=60467


Should be add this to the alsa init db or patch our mixer profiles?

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss


Re: [pulseaudio-discuss] What to do with the Smart 5.1 mixer element (VIA VT1708S)

2011-01-03 Thread David Henningsson

On 2011-01-03 13:01, Colin Guthrie wrote:

As detailed here:
https://qa.mandriva.com/show_bug.cgi?id=60467

Should be add this to the alsa init db or patch our mixer profiles?


Well, wouldn't the most logical thing be to enable Smart 5.1 if we 
have a surround profile, and disable it if we have line or mic input?


That is, assuming that the stuff actually works - I'm still trying to 
understand the Independent HP/Jack detect stuff (another strange 
thing in the VIA codec driver), what's causing headphones on Asus 
K50IJ/K60I not to work, and why toggling the switch crashes alsamixer... 
:-( I was hoping to be able to fix some of that by the time of merge 
window for 2.6.38, but I'm not sure I have the time/priority to do so.


--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss


Re: [pulseaudio-discuss] [PATCH] [module-loopback] Add new arguments sink_dont_move and source_dont_move to toggle module automatic unloading when the sink or source were not available

2011-01-03 Thread pl bossart
On Thu, Dec 23, 2010 at 5:40 AM, Cai Yuanqing yuanqing@tieto.com wrote:
    This patch add two new boolean arguments sink_dont_move and
 source_dont_move into module-loopback,so we can make the module unloading
 when the sink or source was unavailable.
 To enable this feature we can do something like:
load-module module-loopback source=bluez_source.00_22_A5_AA_BF_85
 sink=alsa_output.pci-_00_1b.0.analog-stereo source_dont_move=TRUE

 And you can just feel free to ignore these arguments.

I don't have any arguments against the source_dont_move, but I am
concerned about the sink_dont_move part. You may want to listen to
your music on speakers, headsets, HDMI, etc. Why would you restrict
the playback to the sink selected when you loaded the module? I can
see this interfering with the accessory management/audio policy, at
least in Meego. Falling back to the default sink should not add any
noises?
-Pierre
___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss


Re: [pulseaudio-discuss] [PATCH] [module-loopback] Add new arguments sink_dont_move and source_dont_move to toggle module automatic unloading when the sink or source were not available

2011-01-03 Thread Cai Yuanqing


On 01/04/2011 02:10 AM, pl bossart wrote:

On Thu, Dec 23, 2010 at 5:40 AM, Cai Yuanqingyuanqing@tieto.com  wrote:

This patch add two new boolean arguments sink_dont_move and
source_dont_move into module-loopback,so we can make the module unloading
when the sink or source was unavailable.
To enable this feature we can do something like:

load-module module-loopback source=bluez_source.00_22_A5_AA_BF_85
sink=alsa_output.pci-_00_1b.0.analog-stereo source_dont_move=TRUE

And you can just feel free to ignore these arguments.

I don't have any arguments against the source_dont_move, but I am
concerned about the sink_dont_move part. You may want to listen to
your music on speakers, headsets, HDMI, etc. Why would you restrict
the playback to the sink selected when you loaded the module? I can
see this interfering with the accessory management/audio policy, at
least in Meego. Falling back to the default sink should not add any
noises?
-Pierre

Thanks for your feedback.

In fact I also don't want to add sink_dont_move at very beginning,adding 
this sink_dont_move arguments because there is no reason to add 
source_dont_move only, it sounds weird and I can't answer question 
that Why the sink have no XX_dont_move here,I just want to do this for 
my reasons?.So I add this one .
IMHO,we can ignore this argument in mostly situations and move the sink 
to default sink or other sinks when current sink are not available.


Falling back to the default sink may make some noises sound but not 
always,It's very occasional and may related to compatibility issue.


--
B.R

Cai Yuanqing

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss