[pulseaudio-discuss] [PATCH 1/2] Log feature: Add a new log target to a file descriptor
This patch enables logging of text debug messages (pa_log feature) into a file
or a device driver.
Example : pulseaudio --log-target=file:./mylog.txt
---
src/daemon/cmdline.c |5 +++--
src/daemon/daemon-conf.c | 23 +++
src/pulsecore/log.c | 25 +
src/pulsecore/log.h |5 +
4 files changed, 56 insertions(+), 2 deletions(-)
diff --git a/src/daemon/cmdline.c b/src/daemon/cmdline.c
index f6cdcdc..caa5b2b 100644
--- a/src/daemon/cmdline.c
+++ b/src/daemon/cmdline.c
@@ -145,7 +145,8 @@ void pa_cmdline_help(const char *argv0) {
this time passed\n
--log-level[=LEVEL] Increase or set verbosity
level\n
-vIncrease the verbosity
level\n
- --log-target={auto,syslog,stderr} Specify the log target\n
+ --log-target={auto,syslog,stderr,\n
+ file:PATH} Specify the log target\n
--log-meta[=BOOL] Include code location in
log messages\n
--log-time[=BOOL] Include timestamps in log
messages\n
--log-backtrace=FRAMESInclude a backtrace in log
messages\n
@@ -318,7 +319,7 @@ int pa_cmdline_parse(pa_daemon_conf *conf, int argc, char
*const argv [], int *d
case ARG_LOG_TARGET:
if (pa_daemon_conf_set_log_target(conf, optarg) 0) {
-pa_log(_(Invalid log target: use either 'syslog',
'stderr' or 'auto'.));
+pa_log(_(Invalid log target: use either 'syslog',
'stderr' or 'auto' or a valid file name 'file:path'.));
goto fail;
}
break;
diff --git a/src/daemon/daemon-conf.c b/src/daemon/daemon-conf.c
index e38e67a..0d42f73 100644
--- a/src/daemon/daemon-conf.c
+++ b/src/daemon/daemon-conf.c
@@ -28,6 +28,7 @@
#include stdio.h
#include string.h
#include unistd.h
+#include fcntl.h
#ifdef HAVE_SCHED_H
#include sched.h
@@ -141,6 +142,8 @@ static const pa_daemon_conf default_conf = {
#endif
};
+static int log_fd = -1;
+
pa_daemon_conf* pa_daemon_conf_new(void) {
pa_daemon_conf *c;
@@ -166,6 +169,10 @@ pa_daemon_conf* pa_daemon_conf_new(void) {
void pa_daemon_conf_free(pa_daemon_conf *c) {
pa_assert(c);
+
+if (log_fd = 0)
+pa_close(log_fd);
+
pa_xfree(c-script_commands);
pa_xfree(c-dl_search_path);
pa_xfree(c-default_script_file);
@@ -211,6 +218,22 @@ int pa_daemon_conf_set_log_level(pa_daemon_conf *c, const
char *string) {
c-log_level = PA_LOG_WARN;
else if (pa_startswith(string, err))
c-log_level = PA_LOG_ERROR;
+else if (pa_startswith(string, file:)) {
+char file_path[512];
+
+pa_strlcpy(file_path, string + 5, sizeof(file_path));
+
+/* Open target file with user rights */
+if ((log_fd = open(file_path, O_RDWR|O_TRUNC|O_CREAT, S_IRWXU)) = 0) {
+ c-auto_log_target = 0;
+ c-log_target = PA_LOG_FD;
+ pa_log_set_fd(log_fd);
+}
+else {
+printf(Failed to open target file %s, error : %s\n, file_path,
pa_cstrerror(errno));
+return -1;
+}
+}
else
return -1;
diff --git a/src/pulsecore/log.c b/src/pulsecore/log.c
index 2c0e267..1494906 100644
--- a/src/pulsecore/log.c
+++ b/src/pulsecore/log.c
@@ -70,6 +70,7 @@ static pa_log_level_t maximum_level = PA_LOG_ERROR,
maximum_level_override = PA_
static unsigned show_backtrace = 0, show_backtrace_override = 0,
skip_backtrace = 0;
static pa_log_flags_t flags = 0, flags_override = 0;
static pa_bool_t no_rate_limit = FALSE;
+static int log_fd = -1;
#ifdef HAVE_SYSLOG_H
static const int level_to_syslog[] = {
@@ -128,6 +129,12 @@ void pa_log_set_flags(pa_log_flags_t _flags,
pa_log_merge_t merge) {
flags = _flags;
}
+void pa_log_set_fd(int fd) {
+pa_assert(fd = 0);
+
+log_fd = fd;
+}
+
void pa_log_set_show_backtrace(unsigned nlevels) {
show_backtrace = nlevels;
}
@@ -399,6 +406,24 @@ void pa_log_levelv_meta(
}
#endif
+case PA_LOG_FD: {
+if (log_fd != -1) {
+char metadata[256];
+
+pa_snprintf(metadata, sizeof(metadata), \n%c %s %s,
level_to_char[level], timestamp, location);
+
+if ((write(log_fd, metadata, strlen(metadata)) 0) ||
(write(log_fd, t, strlen(t)) 0)) {
+saved_errno = errno;
+pa_close(log_fd);
+fprintf(stderr, %s\n, Error writing logs to a file
descriptor. Redirect log messages to console.);
+fprintf(stderr, %s %s\n, metadata, t);
+pa_log_set_target(PA_LOG_STDERR);
+log_fd = -1;
+}
+
[pulseaudio-discuss] [PATCH] Update PA_MODULE_USAGE to be in line with actual implementation
---
src/modules/alsa/module-alsa-sink.c|4 +++-
src/modules/alsa/module-alsa-source.c |2 ++
src/modules/bluetooth/module-bluetooth-proximity.c |1 -
src/modules/module-equalizer-sink.c|4 +++-
src/modules/module-hal-detect.c|4 ++--
src/modules/module-pipe-sink.c |2 +-
src/modules/module-protocol-stub.c |4 ++--
src/modules/module-suspend-on-idle.c |1 +
src/modules/module-waveout.c |6 +++---
9 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/src/modules/alsa/module-alsa-sink.c
b/src/modules/alsa/module-alsa-sink.c
index 697fab4..465c8b9 100644
--- a/src/modules/alsa/module-alsa-sink.c
+++ b/src/modules/alsa/module-alsa-sink.c
@@ -40,7 +40,8 @@ PA_MODULE_LOAD_ONCE(FALSE);
PA_MODULE_USAGE(
name=name of the sink, to be prefixed
sink_name=name for the sink
-sink_properities=properties for the sink
+sink_properties=properties for the sink
+namereg_fail=pa_namereg_register() fail parameter value
device=ALSA device
device_id=ALSA card index
format=sample format
@@ -64,6 +65,7 @@ static const char* const valid_modargs[] = {
name,
sink_name,
sink_properties,
+namereg_fail,
device,
device_id,
format,
diff --git a/src/modules/alsa/module-alsa-source.c
b/src/modules/alsa/module-alsa-source.c
index 23da418..90ffea5 100644
--- a/src/modules/alsa/module-alsa-source.c
+++ b/src/modules/alsa/module-alsa-source.c
@@ -65,6 +65,7 @@ PA_MODULE_USAGE(
name=name for the source, to be prefixed
source_name=name for the source
source_properties=properties for the source
+namereg_fail=pa_namereg_register() fail parameter value
device=ALSA device
device_id=ALSA card index
format=sample format
@@ -84,6 +85,7 @@ static const char* const valid_modargs[] = {
name,
source_name,
source_properties,
+namereg_fail,
device,
device_id,
format,
diff --git a/src/modules/bluetooth/module-bluetooth-proximity.c
b/src/modules/bluetooth/module-bluetooth-proximity.c
index 3eed9ce..8c3a5b9 100644
--- a/src/modules/bluetooth/module-bluetooth-proximity.c
+++ b/src/modules/bluetooth/module-bluetooth-proximity.c
@@ -59,7 +59,6 @@ PA_MODULE_USAGE(
static const char* const valid_modargs[] = {
sink,
-rssi,
hci,
NULL,
};
diff --git a/src/modules/module-equalizer-sink.c
b/src/modules/module-equalizer-sink.c
index a28405b..bb350c3 100644
--- a/src/modules/module-equalizer-sink.c
+++ b/src/modules/module-equalizer-sink.c
@@ -77,7 +77,8 @@ PA_MODULE_DESCRIPTION(_(General Purpose Equalizer));
PA_MODULE_VERSION(PACKAGE_VERSION);
PA_MODULE_LOAD_ONCE(FALSE);
PA_MODULE_USAGE(
-_(sink_name=name of the sink
+_(sink_name=name of the sink
+ sink_properties=properties for the sink
master=sink to connect to
format=sample format
rate=sample rate
@@ -131,6 +132,7 @@ struct userdata {
static const char* const valid_modargs[] = {
sink_name,
+sink_properties,
master,
format,
rate,
diff --git a/src/modules/module-hal-detect.c b/src/modules/module-hal-detect.c
index 23d4010..941ac3a 100644
--- a/src/modules/module-hal-detect.c
+++ b/src/modules/module-hal-detect.c
@@ -57,13 +57,13 @@ PA_MODULE_VERSION(PACKAGE_VERSION);
PA_MODULE_LOAD_ONCE(TRUE);
#if defined(HAVE_ALSA) defined(HAVE_OSS_OUTPUT)
PA_MODULE_USAGE(api=alsa or oss
-tsched=enable system timer based scheduling mode?
+tsched=enable system timer based scheduling mode?
subdevices=init all subdevices);
#elif defined(HAVE_ALSA)
PA_MODULE_USAGE(api=alsa
tsched=enable system timer based scheduling mode?);
#elif defined(HAVE_OSS_OUTPUT)
-PA_MODULE_USAGE(api=oss
+PA_MODULE_USAGE(api=oss
subdevices=init all subdevices);
#endif
PA_MODULE_DEPRECATED(Please use module-udev-detect instead of
module-hal-detect!);
diff --git a/src/modules/module-pipe-sink.c b/src/modules/module-pipe-sink.c
index b1158d3..6623aef 100644
--- a/src/modules/module-pipe-sink.c
+++ b/src/modules/module-pipe-sink.c
@@ -61,7 +61,7 @@ PA_MODULE_USAGE(
sink_properties=properties for the sink
file=path of the FIFO
format=sample format
-rate=sample rate
+rate=sample rate
channels=number of channels
channel_map=channel map);
diff --git a/src/modules/module-protocol-stub.c
b/src/modules/module-protocol-stub.c
index 7ba5405..1a14596 100644
--- a/src/modules/module-protocol-stub.c
+++ b/src/modules/module-protocol-stub.c
@@ -137,7 +137,7 @@
PA_MODULE_DESCRIPTION(Native protocol SOCKET_DESCRIPTION);
PA_MODULE_USAGE(auth-anonymous=don't check for cookies?
[pulseaudio-discuss] [PATCH 2/2] bluetooth: Get rid of warnings about unused stuff when building against a D-Bus version that doesn't have fd-passing support.
---
src/modules/bluetooth/bluetooth-util.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/modules/bluetooth/bluetooth-util.c
b/src/modules/bluetooth/bluetooth-util.c
index 68ee808..cae7f16 100644
--- a/src/modules/bluetooth/bluetooth-util.c
+++ b/src/modules/bluetooth/bluetooth-util.c
@@ -519,6 +519,7 @@ static pa_dbus_pending*
send_and_add_to_pending(pa_bluetooth_discovery *y, DBusM
return p;
}
+#ifdef DBUS_TYPE_UNIX_FD
static void register_endpoint_reply(DBusPendingCall *pending, void *userdata) {
DBusError e;
DBusMessage *r;
@@ -559,6 +560,7 @@ finish:
pa_xfree(endpoint);
}
+#endif
static void list_devices_reply(DBusPendingCall *pending, void *userdata) {
DBusError e;
@@ -607,6 +609,7 @@ finish:
pa_dbus_pending_free(p);
}
+#ifdef DBUS_TYPE_UNIX_FD
static void register_endpoint(pa_bluetooth_discovery *y, const char *path,
const char *endpoint, const char *uuid) {
DBusMessage *m;
DBusMessageIter i, d;
@@ -654,6 +657,7 @@ static void register_endpoint(pa_bluetooth_discovery *y,
const char *path, const
send_and_add_to_pending(y, m, register_endpoint_reply,
pa_xstrdup(endpoint));
}
+#endif
static void found_adapter(pa_bluetooth_discovery *y, const char *path) {
DBusMessage *m;
@@ -968,11 +972,9 @@ int pa_bluetooth_transport_acquire(const
pa_bluetooth_transport *t, const char *
pa_log(Failed to parse org.bluez.MediaTransport.Acquire(): %s,
err.message);
ret = -1;
dbus_error_free(err);
-goto fail;
}
#endif
-fail:
dbus_message_unref(r);
return ret;
}
@@ -1013,6 +1015,7 @@ static int setup_dbus(pa_bluetooth_discovery *y) {
return 0;
}
+#ifdef DBUS_TYPE_UNIX_FD
static pa_bluetooth_transport *transport_new(pa_bluetooth_discovery *y, const
char *path, enum profile p, const uint8_t *config, int size) {
pa_bluetooth_transport *t;
@@ -1358,13 +1361,16 @@ static DBusHandlerResult
endpoint_handler(DBusConnection *c, DBusMessage *m, voi
return DBUS_HANDLER_RESULT_HANDLED;
}
+#endif /* DBUS_TYPE_UNIX_FD */
pa_bluetooth_discovery* pa_bluetooth_discovery_get(pa_core *c) {
DBusError err;
pa_bluetooth_discovery *y;
+#ifdef DBUS_TYPE_UNIX_FD
static const DBusObjectPathVTable vtable_endpoint = {
.message_function = endpoint_handler,
};
+#endif
pa_assert(c);
--
1.7.4.1
___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] Make pulse compile with clang
'Twas brillig, and Maarten Bosmans at 10/03/11 10:21 did gyre and gimble: As discussed on IRC. This is basically a correctly formatted version of the patch attached to http://pulseaudio.org/ticket/883 with a small improvement in configure.ac added. Applied. Thanks. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] bluetooth: Do not stop decoding because of a crc error
Luiz,
I can't remember if you ACKed this patch or not?
Also, I've pulled in lots of your BT changes. Will reply on the other
thread about that as it needed a couple tweaks
Col
'Twas brillig, and Maarten Lankhorst at 04/03/11 13:51 did gyre and gimble:
---
Letting my phone play music all night I noticed it was gone in the
morning because a crc error occurred. I don't think it should be as
fatal as it currently is, so just try our luck again on next frame
instead of stopping decode entirely.
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
From 0d3062e988c9a4f01b5bf38a48a90a685cf97078 Mon Sep 17 00:00:00 2001
From: Maarten Lankhorst m.b.lankho...@gmail.com
Date: Fri, 4 Mar 2011 14:43:58 +0100
Subject: [PATCH 2/2] bluetooth: Do not stop decoding because of a crc error
---
src/modules/bluetooth/module-bluetooth-device.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/modules/bluetooth/module-bluetooth-device.c
b/src/modules/bluetooth/module-bluetooth-device.c
index 6a33ef0..fad8e45 100644
--- a/src/modules/bluetooth/module-bluetooth-device.c
+++ b/src/modules/bluetooth/module-bluetooth-device.c
@@ -1457,7 +1457,7 @@ static int a2dp_process_push(struct userdata *u) {
pa_log_error(SBC decoding error (%li), (long) decoded);
pa_memblock_release(memchunk.memblock);
pa_memblock_unref(memchunk.memblock);
-return -1;
+return decoded 0 ? decoded : -1;
}
/* pa_log_debug(SBC: decoded: %lu; written: %lu, (unsigned long)
decoded, (unsigned long) written); */
@@ -1535,7 +1535,10 @@ static void thread_func(void *userdata) {
else
n_read = a2dp_process_push(u);
-if (n_read 0)
+if (n_read == -3)
+/* CRC error */
+n_read = 0;
+else if (n_read 0)
goto fail;
/* We just read something, so we are supposed to write
something, too */
--
1.7.2.3
___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] Flip default to no git pull on make dist
Applied. Thanks. -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 1/2] Log feature: Add a new log target to a file descriptor
-Original Message- From: pulseaudio-discuss-boun...@mail.0pointer.de [mailto:pulseaudio- discuss-boun...@mail.0pointer.de] On Behalf Of Colin Guthrie Sent: Friday, March 18, 2011 1:48 PM To: pulseaudio-discuss@mail.0pointer.de Subject: Re: [pulseaudio-discuss] [PATCH 1/2] Log feature: Add a new log target to a file descriptor 'Twas brillig, and Vincent Becker at 18/03/11 10:23 did gyre and gimble: This patch enables logging of text debug messages (pa_log feature) into a file or a device driver. Example : pulseaudio --log-target=file:./mylog.txt Many thanks for your perseverence here. We were beginning to worry we were annoying you too much with constant tweaks for a relatively simple patch. Hi Col, I actually crashed my Linux environment, this is why it took me some time to recover and get back to you. I did actually make a couple extra tweaks on top of this one which I've attached FYI. One of them was to fix the double close that Arun pointed out before and was still in this version. If I've cocked it up, please feel free to publicly humiliate me in a manner of your choosing. No worries! It's cleaner like that I admit. Thanks Vincent Many thanks. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] - Intel Corporation SAS (French simplified joint stock company) Registered headquarters: Les Montalets- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 6/6] Make pulse compile with clang
'Twas brillig, and Maarten Bosmans at 14/03/11 15:27 did gyre and gimble: This fixes the checking of supported compiler flags and the following error message for svolume_mmx: Applied (as stated in the other thread, but for completeness I'll mention here too). Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] Fix up some double spaces
'Twas brillig, and Maarten Bosmans at 14/03/11 20:53 did gyre and gimble: This is another whitespace fixup. I promise that it's the last coding style fix I'll send to the list for now ;-) Actually it is not all just coding style, as what got my attention in the first place was an extra space in the log output (the hunk at pulsecore/module.c) As with the previous patch, I tried to be a bit conservative in making changes, but the patch touches quite some files nonetheless. Applied Thanks. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] Update PA_MODULE_USAGE to be in line with actual implementation
Merged without much in the way of review (I'm getting lazy and it looked pretty safe with my minor glance). Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] bluetooth: Allow frame length changes when decoding a2dp
'Twas brillig, and Luiz Augusto von Dentz at 14/03/11 21:58 did gyre and gimble: Should this either/both your master or bluetooth trees be pulled into upstream master? Yep, I just rebase my tree it should be fine to be pulled. Great. I just pulled the tree. There were a couple issues with building afterwards but I've fixed them the following commit: http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=c66a1ba352860eb265171d6c48ebd01ce82a5083 I also tidied up the source definitions generally in here: http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=e908a4d43e8bc90d91dc9e339b87f81c3917acbc The above doesn't really change anything but I did add a couple extra header files into libbluetooth_sbc_la_SOURCES that were missing before. I then fixed the update-sbc Make rule here: http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=9a27b0c413980cb04179139b6a0b4347b2d83ac5 to fix the paths. I also ran update-sbc and it did pull in a couple changes - mostly copyright header changes, but a few code things too. It all looked quite trivial but didn't want to do it ad-hoc without your ACK :) Let me know if it's OK to run it and commit the results (or feel free to do it in your tree and an I can pull again). All the best Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] bluetooth: Allow frame length changes when decoding a2dp
Hi Colin, On Fri, Mar 18, 2011 at 10:16 AM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and Luiz Augusto von Dentz at 14/03/11 21:58 did gyre and gimble: Should this either/both your master or bluetooth trees be pulled into upstream master? Yep, I just rebase my tree it should be fine to be pulled. Great. I just pulled the tree. There were a couple issues with building afterwards but I've fixed them the following commit: http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=c66a1ba352860eb265171d6c48ebd01ce82a5083 I also tidied up the source definitions generally in here: http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=e908a4d43e8bc90d91dc9e339b87f81c3917acbc The above doesn't really change anything but I did add a couple extra header files into libbluetooth_sbc_la_SOURCES that were missing before. I then fixed the update-sbc Make rule here: http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=9a27b0c413980cb04179139b6a0b4347b2d83ac5 Great, I didn't know there was such a thing, nice catch. to fix the paths. I also ran update-sbc and it did pull in a couple changes - mostly copyright header changes, but a few code things too. It all looked quite trivial but didn't want to do it ad-hoc without your ACK :) ACK Let me know if it's OK to run it and commit the results (or feel free to do it in your tree and an I can pull again). Please go ahead. All the best Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] -- Luiz Augusto von Dentz Computer Engineer ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] bluetooth: Do not stop decoding because of a crc error
Hi Colin, Maarten, On Fri, Mar 18, 2011 at 9:56 AM, Colin Guthrie gm...@colin.guthr.ie wrote: Luiz, I can't remember if you ACKed this patch or not? Also, I've pulled in lots of your BT changes. Will reply on the other thread about that as it needed a couple tweaks While I agree we should ignore such packets I believe we should log when that happen because it maybe caused by a bug on sbc code or on remote stack. What you guys think? Regards, Col 'Twas brillig, and Maarten Lankhorst at 04/03/11 13:51 did gyre and gimble: --- Letting my phone play music all night I noticed it was gone in the morning because a crc error occurred. I don't think it should be as fatal as it currently is, so just try our luck again on next frame instead of stopping decode entirely. Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] -- Luiz Augusto von Dentz Computer Engineer ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] pulseaudio xbmc passthrough success
Good news :) I've just watched District 9 and Master and Commander in full dts-hd. A few minor glitches (a couple of pops, I think it might be buffer underruns), other than that it worked great! One thing I did notice with Master and Commander was that with standard dts the dialog was not nearly as clear as it was with dts-hd. dts-hd has about 4 times the bandwidth. I'll be putting up the newer code sometime tomorrow. I've been working pretty long hours on it and now I just want to relax a bit. ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
