Re: [pulseaudio-discuss] [PATCH] stream-restore: Enable database dumping if DEBUG_VOLUME is defined.

2011-04-28 Thread Colin Guthrie 
'Twas brillig, and Tanu Kaskinen at 27/04/11 11:08 did gyre and gimble:
 From: Tanu Kaskinen ext-tanu.kaski...@nokia.com
 
 ---
  src/modules/module-stream-restore.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/src/modules/module-stream-restore.c 
 b/src/modules/module-stream-restore.c
 index c1baf8f..56672f7 100644
 --- a/src/modules/module-stream-restore.c
 +++ b/src/modules/module-stream-restore.c
 @@ -1778,8 +1778,8 @@ static void apply_entry(struct userdata *u, const char 
 *name, struct entry *e) {
  }
  }
  
 -#if 0
 -static void dump_database(struct userdata *u) {
 +#ifdef DEBUG_VOLUME
 +PA_GCC_UNUSED static void stream_restore_dump_database(struct userdata *u) {
  pa_datum key;
  pa_bool_t done;
  

Forgive my ignorance here but I cannot see where this is called... Is
there some magic way to call this function?

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] Alsa-plugins: Pulse: Fix snd_pcm_avail returning 0 in some cases

2011-04-28 Thread Colin Guthrie 
'Twas brillig, and David Henningsson at 21/04/11 14:22 did gyre and gimble:
 Due to a round-off error, snd_pcm_avail could in some cases
 return 0 even though more data could be written to the stream.
 
 This was discovered by Maarten Lankhorst [1], and there is also a test
 program available that triggers this error [2].
 
 [1]
 https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-April/009935.html
 
 
 [2]
 https://tango.0pointer.de/pipermail/pulseaudio-discuss/attachments/20110420/3c852d6e/attachment.c

For completeness (on this list), this patch has now been committed to
alsa-lib.

Cheers

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] stream-restore: Enable database dumping if DEBUG_VOLUME is defined.

2011-04-28 Thread Tanu Kaskinen 
On Thu, 2011-04-28 at 12:48 +0300, Colin Guthrie wrote:
 'Twas brillig, and Tanu Kaskinen at 27/04/11 11:08 did gyre and gimble:
  From: Tanu Kaskinen ext-tanu.kaski...@nokia.com
  
  ---
   src/modules/module-stream-restore.c |4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
  
  diff --git a/src/modules/module-stream-restore.c 
  b/src/modules/module-stream-restore.c
  index c1baf8f..56672f7 100644
  --- a/src/modules/module-stream-restore.c
  +++ b/src/modules/module-stream-restore.c
  @@ -1778,8 +1778,8 @@ static void apply_entry(struct userdata *u, const 
  char *name, struct entry *e) {
   }
   }
   
  -#if 0
  -static void dump_database(struct userdata *u) {
  +#ifdef DEBUG_VOLUME
  +PA_GCC_UNUSED static void stream_restore_dump_database(struct userdata *u) 
  {
   pa_datum key;
   pa_bool_t done;
   
 
 Forgive my ignorance here but I cannot see where this is called... Is
 there some magic way to call this function?

You can call it in gdb.

-- 
Tanu

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] stream-restore: Enable database dumping if DEBUG_VOLUME is defined.

2011-04-28 Thread Colin Guthrie 
'Twas brillig, and Tanu Kaskinen at 28/04/11 10:57 did gyre and gimble:
  Forgive my ignorance here but I cannot see where this is called... Is
  there some magic way to call this function?
 You can call it in gdb.

Ahh of course. Silly me :)

OK, consider it merged.

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-28 Thread Colin Guthrie 
'Twas brillig, and Colin Guthrie at 20/04/11 15:04 did gyre and gimble:
 'Twas brillig, and Antti-Ville Jansson at 20/04/11 14:00 did gyre and
 gimble:
 The assert that this patch fixes can be reproduced with e.g. the
 following script:


 SAMPLE_PATH=/usr/share/sounds/alsa/
 SAMPLE=Front_Left

 pactl remove-sample $SAMPLE 2 /dev/null
 pactl upload-sample $SAMPLE_PATH$SAMPLE.wav

 mod1=`pactl load-module module-null-sink sink_name=null1`
 mod2=`pactl load-module module-null-sink sink_name=null2`

 pactl play-sample $SAMPLE null1

 input=`pactl list | grep Sink Input # | tail -n 1 | cut -d# -f2`

 echo Sample $SAMPLE playing as Sink Input #$input

 pactl move-sink-input $input null2
 pactl move-sink-input $input null1

 pactl unload-module $mod1
 pactl unload-module $mod2
 
 Thanks for the awesome test case. I'll take a look at this shortly :)

I've had a play with this and can reproduce the problem with current git
master and confirmed that your patch solved the issue.

I've modified the commit message to include the above test case for
completeness.

Many thanks.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] module: new null-source module

2011-04-28 Thread Colin Guthrie 
'Twas brillig, and Tanu Kaskinen at 27/04/11 12:59 did gyre and gimble:
 On Wed, 2011-04-27 at 14:50 +0300, Tanu Kaskinen wrote:
 From: Marc-André Lureau marcandre.lur...@gmail.com

 ---
  src/Makefile.am  |6 +
  src/modules/module-null-source.c |  294 
 ++
  2 files changed, 300 insertions(+), 0 deletions(-)
  create mode 100644 src/modules/module-null-source.c
 
 This module isn't actually used by anyone currently. We (at Nokia)
 switched to null-sink's monitor a long time ago (for reasons unknown to
 me), so the code hasn't had much testing lately. Even though there are
 no users for the module currently, I'm sending the patch anyway, just in
 case people think that the module might be useful in some situation.
 
 I quickly tested that I can record silence with parec from source.null -
 I can't give any further guarantees that the code is correct.

I have tested this but not 100% sure it's totally correct... I've
committed it anyway (we an always disable it easy enough if it doesn't
pass QA :p

I was able to load this and record from it but the vumeter in
pavucontrol was quite active and jumpy and when doing parec|pacat I did
get quite a lot of static (not a crazy amount, but more than I would
expect from pure silence... I doubt resampling would have caused the
level of static I saw).

So there might be some weirdness in there with the silence it produces
if anyone has a desire to have a peak

Cheers

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

___
pulseaudio-discuss mailing list
pulseaudio-discuss@mail.0pointer.de
https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss