Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Add workaround for some USB headsets
On 2011-04-05 22:57, Colin Guthrie wrote: 'Twas brillig, and David Henningsson at 05/04/11 13:03 did gyre and gimble: As I discussed with Tanu Kaskinen yesterday, we should do something about when one profile path prevents another from using the hw volume capabilities. However, with Ubuntu a few weeks from release, I went for the workaround approach and created a separate profile for the devices instead to minimise regression potential. So, until this is fixed the right way, feel free to use the attached patch. Bug reference: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/671560 While I appreciate this is a work around, is it worth committing (especially to stable-queue) in the short term? We'll likely push out stable-queue very soon. If you've got a fairly recent snapshot for Ubuntu already, then bumping the version to 0.9.23 should be uncontroversial (tho' version bumps may still be banned by policy regardless). What do you think? Col Good question. Maybe it would make more sense for distro maintainers than upstream. I guess it also depends on when someone actually makes the fix the right way :-) -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Add workaround for some USB headsets
On Wed, Apr 06, 2011 at 06:57:22AM EST, Colin Guthrie wrote: We'll likely push out stable-queue very soon. If you've got a fairly recent snapshot for Ubuntu already, then bumping the version to 0.9.23 should be uncontroversial (tho' version bumps may still be banned by policy regardless). What do you think? Given that beta 2 freeze is next Monday, and with each freeze things get progressively more locked down, I only plan on taking the bugfix elements of stable-queue. I understand the echo-cancel module and Lennart's new function are fixes, but they introduce new functionality, so I will not be including it in natty short of a crisis that require me to pull them in, and go begging to the release team. Luke ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Add workaround for some USB headsets
On Wed, 2011-04-06 at 16:57 +1000, Luke Yelavich wrote: On Wed, Apr 06, 2011 at 06:57:22AM EST, Colin Guthrie wrote: We'll likely push out stable-queue very soon. If you've got a fairly recent snapshot for Ubuntu already, then bumping the version to 0.9.23 should be uncontroversial (tho' version bumps may still be banned by policy regardless). What do you think? Given that beta 2 freeze is next Monday, and with each freeze things get progressively more locked down, I only plan on taking the bugfix elements of stable-queue. I understand the echo-cancel module and Lennart's new function are fixes, but they introduce new functionality, so I will not be including it in natty short of a crisis that require me to pull them in, and go begging to the release team. For what it's worth, the echo-cancel module is off-by-default, with the main purpose of pushing it out being to get early-adopter testing from those who want to enable it (and know enough to do so manually from the command line). Cheers, Arun ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Add workaround for some USB headsets
'Twas brillig, and David Henningsson at 06/04/11 07:39 did gyre and gimble: While I appreciate this is a work around, is it worth committing (especially to stable-queue) in the short term? We'll likely push out stable-queue very soon. If you've got a fairly recent snapshot for Ubuntu already, then bumping the version to 0.9.23 should be uncontroversial (tho' version bumps may still be banned by policy regardless). What do you think? Good question. Maybe it would make more sense for distro maintainers than upstream. I guess it also depends on when someone actually makes the fix the right way :-) I'd say that the times scales for fix the right way are certainly beyond the release stable queue time frame, so in that sense I'd be happy enough to push this for now, fully accepting it's a kludge. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] [PATCH] alsa-mixer: Add workaround for some USB headsets
As I discussed with Tanu Kaskinen yesterday, we should do something
about when one profile path prevents another from using the hw volume
capabilities. However, with Ubuntu a few weeks from release, I went for
the workaround approach and created a separate profile for the devices
instead to minimise regression potential.
So, until this is fixed the right way, feel free to use the attached patch.
Bug reference:
https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/671560
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
From 6f41a4140013dac7737847bb5eddc78906eb09b7 Mon Sep 17 00:00:00 2001
From: David Henningsson david.hennings...@canonical.com
Date: Tue, 5 Apr 2011 11:37:59 +0200
Subject: [PATCH] alsa-mixer: Add workaround for some USB headsets
This is a workaround - these usb headsets have one output volume
control only, labeled Speaker. This causes the default profile
set to not control the volume at all, which is a bug. Workaround
that by creating a separate profile set.
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
src/Makefile.am|3 +-
.../alsa/mixer/profile-sets/90-pulseaudio.rules|3 ++
.../alsa/mixer/profile-sets/usb-headset.conf | 35
3 files changed, 40 insertions(+), 1 deletions(-)
create mode 100644 src/modules/alsa/mixer/profile-sets/usb-headset.conf
diff --git a/src/Makefile.am b/src/Makefile.am
index cc38db2..0a4862f 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -115,7 +115,8 @@ ALSA_PROFILES = \
modules/alsa/mixer/profile-sets/native-instruments-audio4dj.conf \
modules/alsa/mixer/profile-sets/native-instruments-audio8dj.conf \
modules/alsa/mixer/profile-sets/native-instruments-traktorkontrol-s4.conf \
- modules/alsa/mixer/profile-sets/native-instruments-korecontroller.conf
+ modules/alsa/mixer/profile-sets/native-instruments-korecontroller.conf \
+ modules/alsa/mixer/profile-sets/usb-headset.conf
ALSA_PATHS = \
modules/alsa/mixer/paths/analog-input-aux.conf \
diff --git a/src/modules/alsa/mixer/profile-sets/90-pulseaudio.rules b/src/modules/alsa/mixer/profile-sets/90-pulseaudio.rules
index f964b00..ff91ccf 100644
--- a/src/modules/alsa/mixer/profile-sets/90-pulseaudio.rules
+++ b/src/modules/alsa/mixer/profile-sets/90-pulseaudio.rules
@@ -20,6 +20,9 @@ SUBSYSTEM!=sound, GOTO=pulseaudio_end
ACTION!=change, GOTO=pulseaudio_end
KERNEL!=card*, GOTO=pulseaudio_end
+SUBSYSTEMS==usb, ATTRS{idVendor}==046d, ATTRS{idProduct}==01ab, ENV{PULSE_PROFILE_SET}=usb-headset.conf
+SUBSYSTEMS==usb, ATTRS{idVendor}==046d, ATTRS{idProduct}==0a0c, ENV{PULSE_PROFILE_SET}=usb-headset.conf
+SUBSYSTEMS==usb, ATTRS{idVendor}==1395, ATTRS{idProduct}==0002, ENV{PULSE_PROFILE_SET}=usb-headset.conf
SUBSYSTEMS==usb, ATTRS{idVendor}==17cc, ATTRS{idProduct}==1978, ENV{PULSE_PROFILE_SET}=native-instruments-audio8dj.conf
SUBSYSTEMS==usb, ATTRS{idVendor}==17cc, ATTRS{idProduct}==0839, ENV{PULSE_PROFILE_SET}=native-instruments-audio4dj.conf
SUBSYSTEMS==usb, ATTRS{idVendor}==17cc, ATTRS{idProduct}==baff, ENV{PULSE_PROFILE_SET}=native-instruments-traktorkontrol-s4.conf
diff --git a/src/modules/alsa/mixer/profile-sets/usb-headset.conf b/src/modules/alsa/mixer/profile-sets/usb-headset.conf
new file mode 100644
index 000..adf78d1
--- /dev/null
+++ b/src/modules/alsa/mixer/profile-sets/usb-headset.conf
@@ -0,0 +1,35 @@
+# This file is part of PulseAudio.
+#
+# PulseAudio is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as
+# published by the Free Software Foundation; either version 2.1 of the
+# License, or (at your option) any later version.
+#
+# PulseAudio is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with PulseAudio; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
+
+; This is a workaround - these usb headsets have one output volume control only, labeled Speaker.
+; This causes the default profile set to not control the volume at all, which is a bug.
+
+[General]
+auto-profiles = yes
+
+[Mapping analog-mono]
+device-strings = hw:%f
+channel-map = mono
+paths-output = analog-output-speaker
+paths-input = analog-input analog-input-mic analog-input-linein analog-input-aux analog-input-video analog-input-tvtuner analog-input-fm analog-input-mic-line
+priority = 1
+
+[Mapping analog-stereo]
+device-strings = front:%f hw:%f
+channel-map = left,right
+paths-output = analog-output-speaker
+paths-input = analog-input analog-input-mic analog-input-linein analog-input-aux analog-input-video analog-input-tvtuner analog-input-fm analog-input-mic-line
+priority = 10
--
1.7.4.1
Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Add workaround for some USB headsets
'Twas brillig, and David Henningsson at 05/04/11 13:03 did gyre and gimble: As I discussed with Tanu Kaskinen yesterday, we should do something about when one profile path prevents another from using the hw volume capabilities. However, with Ubuntu a few weeks from release, I went for the workaround approach and created a separate profile for the devices instead to minimise regression potential. So, until this is fixed the right way, feel free to use the attached patch. Bug reference: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/671560 While I appreciate this is a work around, is it worth committing (especially to stable-queue) in the short term? We'll likely push out stable-queue very soon. If you've got a fairly recent snapshot for Ubuntu already, then bumping the version to 0.9.23 should be uncontroversial (tho' version bumps may still be banned by policy regardless). What do you think? Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
