Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
'Twas brillig, and Jorge Eduardo Candelaria at 19/05/11 19:04 did gyre and gimble: I'm not trying to make it all just work atm, only provide a basis to continue working on and advance the discussion. Awesome! My previous mail was my polite way of saying it may not get committed just yet in it's current form but your reply tells me you fully appreciate that. I'll let discussions continue in other branches of this thread. Cheers Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
On May 18, 2011, at 2:01 AM, Colin Guthrie wrote: 'Twas brillig, and Jorge Eduardo Candelaria at 18/05/11 07:22 did gyre and gimble: On May 17, 2011, at 8:56 AM, Lu Guanqun wrote: On Thu, May 12, 2011 at 02:56:04AM +0800, Jorge Eduardo Candelaria wrote: Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. Hi Jorge, I'm interested in your jack detection code, when do you decide to send it out? :-) Don't worry, I haven't forgotten about it :). I plan to send the new patches tomorrow if all goes well with testing. Have you spoken with David about this off-list by any chance? As I mentioned previously, we have quite specific needs for jack detection for it to be accepted so I hope further discussions have happened or that you have managed to be super awesome and make it all just work as we want it, otherwise more tweaks will be ultimately be needed :) Somehow I missed your reply yesterday, sorry I didn't answer. I submitted about an hour ago a new set of patches for jack detection code. I believe this set should be alright since it only provides the basic functionality without being majorly intrusive. I'm not trying to make it all just work atm, only provide a basis to continue working on and advance the discussion. I have incorporated some changes based on the comments made through this list, and the more complicated and specific code can be incorporated in incremental patches. Regards, Jorge Take care Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
On May 17, 2011, at 8:56 AM, Lu Guanqun wrote: On Thu, May 12, 2011 at 02:56:04AM +0800, Jorge Eduardo Candelaria wrote: Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. Hi Jorge, I'm interested in your jack detection code, when do you decide to send it out? :-) Don't worry, I haven't forgotten about it :). I plan to send the new patches tomorrow if all goes well with testing. Regards, Jorge -- guanqun ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
On Wed, May 18, 2011 at 02:22:06PM +0800, Jorge Eduardo Candelaria wrote: On May 17, 2011, at 8:56 AM, Lu Guanqun wrote: On Thu, May 12, 2011 at 02:56:04AM +0800, Jorge Eduardo Candelaria wrote: Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. Hi Jorge, I'm interested in your jack detection code, when do you decide to send it out? :-) Don't worry, I haven't forgotten about it :). I plan to send the new patches tomorrow if all goes well with testing. Thanks for the update :) Regards, Jorge -- guanqun -- guanqun ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
'Twas brillig, and Jorge Eduardo Candelaria at 18/05/11 07:22 did gyre and gimble: On May 17, 2011, at 8:56 AM, Lu Guanqun wrote: On Thu, May 12, 2011 at 02:56:04AM +0800, Jorge Eduardo Candelaria wrote: Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. Hi Jorge, I'm interested in your jack detection code, when do you decide to send it out? :-) Don't worry, I haven't forgotten about it :). I plan to send the new patches tomorrow if all goes well with testing. Have you spoken with David about this off-list by any chance? As I mentioned previously, we have quite specific needs for jack detection for it to be accepted so I hope further discussions have happened or that you have managed to be super awesome and make it all just work as we want it, otherwise more tweaks will be ultimately be needed :) Take care Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
On Thu, May 12, 2011 at 02:56:04AM +0800, Jorge Eduardo Candelaria wrote: Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. Hi Jorge, I'm interested in your jack detection code, when do you decide to send it out? :-) -- guanqun ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
'Twas brillig, and Jorge Eduardo Candelaria at 10/05/11 21:29 did gyre and gimble: This is the third version of the Pulseaudio and UCM integration. This set of patches cover adding ucm data to proplist, adding a ucm API to get and set data to proplist, and lets module-alsa-card scan ucm data when the card is probed. Another set of patches dealing with jack module detection will be sent separately. Thanks for this. I believe David will be helping review this stuff, but is currently at UDS. WRT the jack detection, I think we all agreed that it needs to be handled more internally in the alsa code rather than separated as a module. I'm not 100% sure of the finer details but I know David had ideas here too. We basically need to match up the jack stuff with the appropriate sink/source device on the system and then develop a way to automatically change sink/source ports accordingly (it may also require that we change the card profile too - e.g. change from a 5.1 profile to a stereo profile when plugging in stereo headphones). I'm not sure how to detect multiple jacks - e.g. if you plug in 3 jacks to do 5.1 output, should 5.1 be handled automatically? Anyway, all the jack detection stuff should be totally separate from UCM stuff and could in theory be committed first. UCM should just hook into port/profile changes for pushing new configs up to ucm and set the appropriate verb+modifiers on the device. (disclaimer, my UCM foo is still not awesome, but I think this is all the consensus we reached on the matter!). Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
On May 11, 2011, at 6:43 AM, Colin Guthrie wrote: 'Twas brillig, and Jorge Eduardo Candelaria at 10/05/11 21:29 did gyre and gimble: This is the third version of the Pulseaudio and UCM integration. This set of patches cover adding ucm data to proplist, adding a ucm API to get and set data to proplist, and lets module-alsa-card scan ucm data when the card is probed. Another set of patches dealing with jack module detection will be sent separately. Thanks for this. I believe David will be helping review this stuff, but is currently at UDS. WRT the jack detection, I think we all agreed that it needs to be handled more internally in the alsa code rather than separated as a module. I'm not 100% sure of the finer details but I know David had ideas here too. We basically need to match up the jack stuff with the appropriate sink/source device on the system and then develop a way to automatically change sink/source ports accordingly (it may also require that we change the card profile too - e.g. change from a 5.1 profile to a stereo profile when plugging in stereo headphones). Unfortunately, the jack matching to source is not that clever yet in the drivers. :( There is no way to really be sure that Jack X matches stream Y. This information should be available in the future though (for ASoC drivers at least) when the DAPM graphs are exported. In the mean time all we can do is know whether a jack is inserted or removed for a particular sound card. I'm not sure how to detect multiple jacks - e.g. if you plug in 3 jacks to do 5.1 output, should 5.1 be handled automatically? Again, this is something that requires better driver and core alsa support. Anyway, all the jack detection stuff should be totally separate from UCM stuff and could in theory be committed first. UCM should just hook into port/profile changes for pushing new configs up to ucm and set the appropriate verb+modifiers on the device. Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. (disclaimer, my UCM foo is still not awesome, but I think this is all the consensus we reached on the matter!). Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
'Twas brillig, and Jorge Eduardo Candelaria at 11/05/11 19:56 did gyre and gimble: On May 11, 2011, at 6:43 AM, Colin Guthrie wrote: 'Twas brillig, and Jorge Eduardo Candelaria at 10/05/11 21:29 did gyre and gimble: This is the third version of the Pulseaudio and UCM integration. This set of patches cover adding ucm data to proplist, adding a ucm API to get and set data to proplist, and lets module-alsa-card scan ucm data when the card is probed. Another set of patches dealing with jack module detection will be sent separately. Thanks for this. I believe David will be helping review this stuff, but is currently at UDS. WRT the jack detection, I think we all agreed that it needs to be handled more internally in the alsa code rather than separated as a module. I'm not 100% sure of the finer details but I know David had ideas here too. We basically need to match up the jack stuff with the appropriate sink/source device on the system and then develop a way to automatically change sink/source ports accordingly (it may also require that we change the card profile too - e.g. change from a 5.1 profile to a stereo profile when plugging in stereo headphones). Unfortunately, the jack matching to source is not that clever yet in the drivers. :( There is no way to really be sure that Jack X matches stream Y. This information should be available in the future though (for ASoC drivers at least) when the DAPM graphs are exported. In the mean time all we can do is know whether a jack is inserted or removed for a particular sound card. I thought it reported some fairly useful names I'm sure David had some way to see some degree of info. For example on my machine: [root@jimmy ~]# cat /proc/asound/cards 0 [Intel ]: HDA-Intel - HDA Intel HDA Intel at 0xefebc000 irq 43 [root@jimmy ~]# evtest /dev/input/event7 Input driver version is 1.0.1 Input device ID: bus 0x0 vendor 0x0 product 0x0 version 0x0 Input device name: HDA Intel Mic at Ext Right Jack Supported events: Event type 0 (Sync) Event type 5 (?) Event code 4 (?) Testing ... (interrupt to exit) So the string HDA Intel is present in both which we should be able to match up. I'm not sure how to detect multiple jacks - e.g. if you plug in 3 jacks to do 5.1 output, should 5.1 be handled automatically? Again, this is something that requires better driver and core alsa support. Well not sure. I'd expect the different jacks to have different /dev/input/event* inputs with different jack names on them, so we should (in theory) be able to match that up no? Anyway, all the jack detection stuff should be totally separate from UCM stuff and could in theory be committed first. UCM should just hook into port/profile changes for pushing new configs up to ucm and set the appropriate verb+modifiers on the device. Ok, I'll copy the jack code we have into module-alsa-card. This will allow for simple jack removal/insertion events to be propagated to pulseaudio. We won't be able to do the complicated stuff mentioned above, but should at least be able to do simple speaker/headphone switching. Cool. Like I say it's probably worth chatting with David about it before coding too much, but I'm not sure how contactable he is due to UDS focus right now. It's not possible to do anything with jack detect unless we can match up the events with the device. If we can't do that, then we're stuck (e.g. imagine if the user has two sound cards) so I hope what I wrote above is indeed true! Cheers Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/] ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] [PATCHv3 0/4] Read and store UCM data as proplist
This is the third version of the Pulseaudio and UCM integration. This set of patches cover adding ucm data to proplist, adding a ucm API to get and set data to proplist, and lets module-alsa-card scan ucm data when the card is probed. Another set of patches dealing with jack module detection will be sent separately. Changes from v2: - clean up and add documentation to some structures and functions. - changed commit subjects to better reflect changes in code. - used pa_log_debug() instead of pa_log() to avoid saturating the output. ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
