Re: [pulseaudio-discuss] Broken Volume Control
On Mon, 2010-10-18 at 16:43 -0500, pl bossart wrote: Looks like the volume control logic has taken a big hit, when I move the volume up and down with the slider on the Output Devices tab in pavucontrol, I have _huge_ pops and clicks, the volume goes to zero in the playback tab. I don't get the pops and clicks here but I do see the volume going to zero. Git bisect flags the following patch and I manually confirmed that this patch introduces the noises. Arun, can you look into this? I noticed that there are some inconsistencies on the use of !PA_VOLUME_IS_VALID, sometimes the ! is missing. I'm attaching a patch for this. It solved the volume-to-zero problem for me. Could you see if the pops and clicks go away too? Thanks, Arun ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] Broken volume control
Looks like the volume control logic has taken a big hit, when I move the volume up and down with the slider on the Output Devices tab in pavucontrol, I have _huge_ pops and clicks, the volume goes to zero in the playback tab. Git bisect flags the following patch and I manually confirmed that this patch introduces the noises. Arun, can you look into this? I noticed that there are some inconsistencies on the use of !PA_VOLUME_IS_VALID, sometimes the ! is missing. Thanks, -Pierre $ git bisect bad 49101fc540aec9a249e97a9f650be38f9f92f5ac is the first bad commit commit 49101fc540aec9a249e97a9f650be38f9f92f5ac Author: Arun Raghavan arun.ragha...@collabora.co.uk Date: Sat Oct 9 15:38:43 2010 +0530 volume: Clamp volume to PA_VOLUME_MAX This ensures that we always clamp the volume to PA_VOLUME_MAX. While this currently has no effect, it will be required for making sure we don't exceed PA_VOLUME_MAX when its value changes in the future. ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
