Re: [pulseaudio-tickets] [PulseAudio] #288: Smooth rate variation in module-combine
#288: Smooth rate variation in module-combine --+- Reporter: Chimrod | Owner: mkbosmans Type: enhancement | Status: closed Milestone: | Component: module-combine-* Resolution: fixed|Keywords: --+- Changes (by mkbosmans): * status: new = closed * resolution: = fixed Comment: The suggested changes are implemented in http://git.0pointer.de/?p=pulseaudio.git;a=commit;h=8b4cb54595baeeb1d9b7d11a842ef7946e43a55a -- Ticket URL: http://pulseaudio.org/ticket/288#comment:5 PulseAudio http://pulseaudio.org/ The PulseAudio Sound Server ___ pulseaudio-tickets mailing list pulseaudio-tickets@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets
Re: [pulseaudio-tickets] [PulseAudio] #288: Smooth rate variation in module-combine
#288: Smooth rate variation in module-combine --+- Reporter: Chimrod | Owner: mkbosmans Type: enhancement | Status: new Milestone: | Component: module-combine-* Resolution: |Keywords: --+- Comment(by mkbosmans): There is certainly value in that, but a proper patch should also account for other settings of adjust_time. Hmm, I was under the impression that the rate adjustment was gradually applied over adjust_time, but apparantly that is false. Thus any large deviation from actual_rate should indeed be clipped, regardless of adjust_time. I was confused by the calculation 1.01^20 = 1.22. This is not relevant, because here 1.01 would be the maximum adjustment allowed each time we're adjusting (which need to be smaller, as I said before) and 1.2 is the maximum (total) deviation from the base_rate, just a sanity check to make sure the applied sample rate does not walk away to 0 or inf. -- Ticket URL: http://pulseaudio.org/ticket/288#comment:4 PulseAudio http://pulseaudio.org/ The PulseAudio Sound Server ___ pulseaudio-tickets mailing list pulseaudio-tickets@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets
Re: [pulseaudio-tickets] [PulseAudio] #288: Smooth rate variation in module-combine
#288: Smooth rate variation in module-combine ---+ Reporter: Chimrod | Owner: lennart Type: enhancement | Status: new Priority: normal| Milestone: Component: module-combine-* |Severity: minor Resolution:|Keywords: ---+ Changes (by lennart): * milestone: 0.9.11 = -- Ticket URL: http://pulseaudio.org/ticket/288#comment:2 PulseAudio http://pulseaudio.org/ The PulseAudio Sound Server ___ pulseaudio-tickets mailing list pulseaudio-tickets@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets
Re: [pulseaudio-tickets] [PulseAudio] #288: Smooth rate variation in module-combine
#288: Smooth rate variation in module-combine ---+ Reporter: Chimrod | Owner: lennart Type: enhancement | Status: new Priority: normal| Milestone: 0.9.11 Component: module-combine-* |Severity: minor Resolution:|Keywords: ---+ Changes (by lennart): * milestone: = 0.9.11 Comment: Hmm, so if I understand you correctly, then you changed the following: * Decrease the adjust_time to 1s * Suppress very small sampling rate changes. Is that correct? Sounds like a reasonable change. -- Ticket URL: http://pulseaudio.org/ticket/288#comment:1 PulseAudio http://pulseaudio.org/ The PulseAudio Sound Server ___ pulseaudio-tickets mailing list pulseaudio-tickets@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets
