[issue29204] Add code deprecations in ElementTree

[Matthias Bussonnier]

Change by Matthias Bussonnier :


--
pull_requests: +6450

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The deprecation of the cElementTree module was excluded.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 762ec97ea68a1126b8855996c61fa8239dc9fff7 by Serhiy Storchaka in 
branch 'master':
bpo-29204: Emit warnings for already deprecated ElementTree features. (#773)
https://github.com/python/cpython/commit/762ec97ea68a1126b8855996c61fa8239dc9fff7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +679

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Stefan Behnel]

Stefan Behnel added the comment:

I'm ok with the deprecations.

Regarding the cElementTree module, this is a bit problematic. The idiomatic 
import has lost its use in Py2.5 when ET and cET were added to the stdlib, so 
code that was written for Py2.5 or later (e.g. because it uses generators) 
might no longer have that cascade. On the other hand, issuing a warning for the 
module would also hit this import cascade, even though the code would work just 
fine without cElementTree. One argument speaks for deprecation, the other for 
removal.

However, cElementTree is redundant now, so it should be removed eventually. And 
since that removal would break some code anyway, I'd be ok with just removing 
it without prior import warnings. People can then decide whether they want to 
fix their code by adding the well-known import cascade (and not get annoying 
warnings for it) or by switching entirely to plain ET and not looking back.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Yes, I have a doubt about this too.

Perhaps it can be just removed. The idiomatic code in Python 2 is:

try:
import xml.etree.cElementTree as ET
except ImportError:
import xml.etree.ElementTree as ET

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Martin Panter]

Martin Panter added the comment:

Isn’t cElementTree useful and recommended in 2.7? It would be awkward to 
deprecate it in Python 3. But I guess the other cases should be okay to 
deprecate in 3.7.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +eli.bendersky, scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29204] Add code deprecations in ElementTree

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Some deprecated ElementTree features are deprecated only in the documentation 
or in Python implementation (that is virtually the same since C implementation 
is default). Proposed patch adds missed deprecations is code. It also makes 
warnings be ignored only in tests where they are expected. This is possible 
since converting doctests to unittests some time ago.

Added deprecations:

* Element.getchildren() and Element.getiterator() methods. They were deprecated 
in the documentation and in Python implementation in 2.7 and 3.2.

* The xml.etree.cElementTree module. Deprecated in the documentation in 3.3.

* The html argument of XMLParser. Deprecated in the documentation in 3.4.

Ned, is it appropriate to commit the patch (or its part) in 3.6? The 
discrepancy between Python and C implementation can be considered as a bug. 
What are your thoughts?

--
components: Extension Modules, Library (Lib)
files: etree_deprecations.patch
keywords: patch
messages: 284975
nosy: ned.deily, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Add code deprecations in ElementTree
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file46211/etree_deprecations.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com