[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Xiang Zhang

Changes by Xiang Zhang :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:


New changeset 7a26464c6496c29244072fdd80f9b92c68174742 by Serhiy Storchaka 
(Louie Lu) in branch 'master':
bpo-29946: Fix "sqrtpi defined but not used" (#908)
https://github.com/python/cpython/commit/7a26464c6496c29244072fdd80f9b92c68174742


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Louie Lu

Changes by Louie Lu :


--
pull_requests: +808

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Mark Dickinson

Mark Dickinson added the comment:

This is almost certainly the result of #26121.

+1 to moving the `sqrtpi` definition inside the relevant `#if` blocks.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Antoine Pitrou

Changes by Antoine Pitrou :


--
nosy: +mark.dickinson, rhettinger, stutzbach

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Louie Lu

Louie Lu added the comment:

I can reproduce on ArchLinux 4.10.1-1, GCC 6.3.1:

/home/louielu/Python/cpython/Modules/mathmodule.c:74:21: warning: ‘sqrtpi’ 
defined but not used [-Wunused-const-variable=]
 static const double sqrtpi = 1.772453850905516027298167483341145182798;



Is used by `m_erfc_contfrac` and `m_erf_series`, and inside the block of "#if 
!defined(HAVE_ERF) || !defined(HAVE_ERFC)", maybe sqrtpi should do the same 
condition?

--
nosy: +louielu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29946] compiler warning "sqrtpi defined but not used"

2017-03-30 Thread Xiang Zhang

New submission from Xiang Zhang:

Ubuntu 16.10, GCC 6.2.0

/home/angwer/repos/cpython/Modules/mathmodule.c:74:21: warning: ‘sqrtpi’ 
defined but not used [-Wunused-const-variable=]
 static const double sqrtpi = 1.772453850905516027298167483341145182798;

--
components: Build
messages: 290836
nosy: xiang.zhang
priority: normal
severity: normal
status: open
title: compiler warning "sqrtpi defined but not used"
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com