Re: [Python-Dev] how bugfixes are handled?

2006-02-17 Thread Martin v. Löwis
Arkadiusz Miskiewicz wrote:
 I wasn't, thanks for information.
 
 Still few questions... one of developers/commiters reviews patch and commit
 it? Few developers has to review single patch?

As Neal says, a single committer can review and commit. However,
non-committers can also review; this is the point of asking for
patch reviews. In many cases, the initial patch will not be good
enough: it will lack documentation and test cases, it will contain
bugs, not follow the code formatting guidelines, and it will make
changes irrelevant to the issue being addressed (gratuitous changes).

A reviewer is supposed to sort these all out, and then end up with
a final recommendation (accept or reject). Of course, if it is
going to be reject, there is little point in making the submitter
comply with formal criteria.

Ideally, a committer then will only have to read the entire review
process, agree with it step-by-step, and commit the proposed change.

As a historical note: people doing a lot of reviews eventually end
up as committers, just because it is easier for the other committers
if they also do the final step.

Regards,
Martin
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] how bugfixes are handled?

2006-02-16 Thread Arkadiusz Miskiewicz
Guido van Rossum wrote:

 We're all volunteers here, and we get a large volume of bugs.
That's obvious (note, I'm not complaining, I'm asking ,,how it works for
python'').

 Unfortunately, bugfixes are reviewed on a voluntary basis.
 
 Are you aware of the standing offer that if you review 5 bugs/patches
 some of the developers will pay attention to your bug/patch?
I wasn't, thanks for information.

Still few questions... one of developers/commiters reviews patch and commit
it? Few developers has to review single patch?

Thanks,
-- 
Arkadiusz MiśkiewiczPLD/Linux Team
http://www.t17.ds.pwr.wroc.pl/~misiek/  http://ftp.pld-linux.org/

___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] how bugfixes are handled?

2006-02-15 Thread Arkadiusz Miskiewicz
Hi,

How bugfixes are handled? 

I've posted a bug and a patch + test case for a quite common issue (see
google, problem mentioned on this ml) long time ago and nothing happened
with it
http://sourceforge.net/tracker/index.php?func=detailaid=1380952group_id=5470atid=305470

Is anyone reviewing fixes on regular basis? Or just some bugfixes are
reviewed + commited depending on interest of commiters?

Thanks,
-- 
Arkadiusz MiśkiewiczPLD/Linux Team
http://www.t17.ds.pwr.wroc.pl/~misiek/  http://ftp.pld-linux.org/

___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] how bugfixes are handled?

2006-02-15 Thread Guido van Rossum
We're all volunteers here, and we get a large volume of bugs.
Unfortunately, bugfixes are reviewed on a voluntary basis.

Are you aware of the standing offer that if you review 5 bugs/patches
some of the developers will pay attention to your bug/patch?

On 2/15/06, Arkadiusz Miskiewicz [EMAIL PROTECTED] wrote:
 Hi,

 How bugfixes are handled?

 I've posted a bug and a patch + test case for a quite common issue (see
 google, problem mentioned on this ml) long time ago and nothing happened
 with it
 http://sourceforge.net/tracker/index.php?func=detailaid=1380952group_id=5470atid=305470

 Is anyone reviewing fixes on regular basis? Or just some bugfixes are
 reviewed + commited depending on interest of commiters?

 Thanks,
 --
 Arkadiusz MiśkiewiczPLD/Linux Team
 http://www.t17.ds.pwr.wroc.pl/~misiek/  http://ftp.pld-linux.org/

 ___
 Python-Dev mailing list
 Python-Dev@python.org
 http://mail.python.org/mailman/listinfo/python-dev
 Unsubscribe: 
 http://mail.python.org/mailman/options/python-dev/guido%40python.org



--
--Guido van Rossum (home page: http://www.python.org/~guido/)
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] how bugfixes are handled?

2006-02-15 Thread Neal Norwitz
On 2/15/06, Arkadiusz Miskiewicz [EMAIL PROTECTED] wrote:

 Still few questions... one of developers/commiters reviews patch and commit
 it? Few developers has to review single patch?

One developer can review and commit a patch.  Sometimes we request
more input from other developers or interested parties.

n
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com