[issue32408] Performance regression in urllib.proxy_bypass_environment
Xiang Zhang added the comment: Sorry, it's #39057 -- ___ Python tracker <https://bugs.python.org/issue32408> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32408] Performance regression in urllib.proxy_bypass_environment
Xiang Zhang added the comment:
I think this issue has already been solved by #39507. The time difference is:
before:
time python3 -c 'import urllib.request;
urllib.request.proxy_bypass_environment("1.1.1.1")'
real0m0.912s
user0m0.902s
sys 0m0.010s
after:
time python3 -c 'import urllib.request;
urllib.request.proxy_bypass_environment("1.1.1.1")'
real0m0.105s
user0m0.086s
sys 0m0.019s
--
nosy: +serhiy.storchaka
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue32408>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30434] multiprocessing AuthenticationError "digest sent was rejected"
Change by Xiang Zhang : -- resolution: -> out of date stage: test needed -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue30434> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39279] Don't allow non-Ascii digits in platform.py
Xiang Zhang added the comment: @Ezio, at least for my config they are all ASCII digits. But still I don't think there is any rush to change current behaviour. -- ___ Python tracker <https://bugs.python.org/issue39279> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39279] Don't allow non-Ascii digits in platform.py
Xiang Zhang added the comment: I can't understand the rational for rejecting localized digits though I don't know who will use them in practise. I'd rather fix it until there is a real problem with it. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue39279> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34953] Implement `mmap.mmap.__repr__`
Xiang Zhang added the comment: New changeset d8ca2354ed30c12b9ce37c4535222b700a727b32 by Xiang Zhang (Taine Zhao) in branch 'master': bpo-34953: Implement `mmap.mmap.__repr__` (GH-9891) https://github.com/python/cpython/commit/d8ca2354ed30c12b9ce37c4535222b700a727b32 -- ___ Python tracker <https://bugs.python.org/issue34953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34953] Implement `mmap.mmap.__repr__`
Change by Xiang Zhang : -- components: +Extension Modules -Interpreter Core resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.8 ___ Python tracker <https://bugs.python.org/issue34953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38391] Typo in tutorial code (does not compile)
Change by Xiang Zhang : -- assignee: -> docs@python components: +Documentation -Demos and Tools nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue38391> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38391] Typo in tutorial code (does not compile)
Xiang Zhang added the comment: New changeset 038503e08ac5b10601b95d5adc2c2cab7be10163 by Xiang Zhang (Krishna Oza) in branch 'master': bpo-38391: Fixing a typo for Py_DECREF (GH-16616) https://github.com/python/cpython/commit/038503e08ac5b10601b95d5adc2c2cab7be10163 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue38391> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38168] Refleaks in setint() of mmapmodule.c
Change by Xiang Zhang : -- components: +Extension Modules -Interpreter Core resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue38168> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38168] Refleaks in setint() of mmapmodule.c
Xiang Zhang added the comment: New changeset 68d8c122972d7a49627b983af4ccbfad9f5ade17 by Xiang Zhang in branch '2.7': [2.7] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16176) https://github.com/python/cpython/commit/68d8c122972d7a49627b983af4ccbfad9f5ade17 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue38168> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38168] Refleaks in setint() of mmapmodule.c
Change by Xiang Zhang : -- pull_requests: +15786 pull_request: https://github.com/python/cpython/pull/16176 ___ Python tracker <https://bugs.python.org/issue38168> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL
Xiang Zhang added the comment: >It may be better to apply it even to the developed version. There is nothing >wrong with creating the tee iterator in one thread and using it the other >thread. Or using the tee iterators with external locking. I afraid that PR >15567 can break a legitimate code. +1 on this. I think it's better to also apply #15625 to master branch. I don't think we should prevent creating the iterator in one thread and using it in others. -- ___ Python tracker <https://bugs.python.org/issue34410> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37451] Remove redudant test code in _testcapimodule.c
Change by Xiang Zhang : -- components: +Tests resolution: -> rejected stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python.org/issue37451> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding tests for PyUnicode_AsUTF8 and PyUnicode_AsUTF8AndSize
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed title: Adding a unit test of unicode in test_unicode.py -> Adding tests for PyUnicode_AsUTF8 and PyUnicode_AsUTF8AndSize ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding a unit test of unicode in test_unicode.py
Xiang Zhang added the comment: New changeset 5623ac87bbe5de481957eca5eeae06347612fbeb by Xiang Zhang (Hai Shi) in branch 'master': bpo-37476: Adding tests for asutf8 and asutf8andsize (GH-14531) https://github.com/python/cpython/commit/5623ac87bbe5de481957eca5eeae06347612fbeb -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
Change by Xiang Zhang : -- versions: -Python 3.5 ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
Xiang Zhang added the comment: In Py3, you should use `python -m test test_dtrace` to run the test suite. -- nosy: +xiang.zhang resolution: -> not a bug stage: patch review -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding a unit test of unicode in test_unicode.py
Change by Xiang Zhang : -- type: -> enhancement versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a wrong exception type in ctypes documentation
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed title: Fix a type error in ctypes.rst -> Fix a wrong exception type in ctypes documentation versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
Xiang Zhang added the comment: New changeset f6cdd3ff687ebbf8209d793a18a042ea495c4aeb by Xiang Zhang (Hai Shi) in branch 'master': bpo-37513: Change ValueError to TypeError in an example in ctypes doc (GH-14615) https://github.com/python/cpython/commit/f6cdd3ff687ebbf8209d793a18a042ea495c4aeb -- ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
Xiang Zhang added the comment: Should be TypeError. It's changed from ValueError to TypeError in https://bugs.python.org/issue1831. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37441] Fix a param error in exceptions.rst
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37441> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37441] Fix a param error in exceptions.rst
Xiang Zhang added the comment: New changeset aeecf380660ea459d85bb5f59d76bb54f757b5be by Xiang Zhang (Hai Shi) in branch 'master': bpo-37441: Fix wrong PyErr_SetImportErrorSubclass signature in doc (GH-14453) https://github.com/python/cpython/commit/aeecf380660ea459d85bb5f59d76bb54f757b5be -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue37441> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34763] Treat U+4E17 as a numeric value
Xiang Zhang added the comment: unicode.org doesn't list "丗" as numeric so I think there is nothing we can do. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34763> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Xiang Zhang added the comment: New changeset 92330c0b6d6c253c41a133cc50caea4853c7e311 by Xiang Zhang (Manjusaka) in branch 'master': bpo-35497: add versionadded tag for EPOLLEXCLUSIVE (GH-11162) https://github.com/python/cpython/commit/92330c0b6d6c253c41a133cc50caea4853c7e311 -- ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Change by Xiang Zhang : -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python, xiang.zhang versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Xiang Zhang added the comment: > I don't think to make selector be a public property is a good idea. It will > break the whole system integrity. If exposing a private property is not a good idea, another choice may be construct a selector with a customized I/O multiplexer, adding an optional parameter to the __init__. But actually I'm -1 to this change. `selectors` makes underlying implementations irrelavant to most users since we can simply use `DefaultSelector`(maybe why only read/write events are valid now?). But you are seeking to add implementation specific details back. If you know you want to add EPOLL_EXCLUSIVE, why not just use `select.epoll`? A single selector doesn't do much more than the underlying multiplexer. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35470] A deadly decref in _PyImport_FindExtensionObjectEx()
Xiang Zhang added the comment: What about version 3.6? -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue35470> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33106] Deleting a key in a read-only gdbm results in KeyError, not gdbm.error
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: behavior -> enhancement ___ Python tracker <https://bugs.python.org/issue33106> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33106] Deleting a key in a read-only gdbm results in KeyError, not gdbm.error
Xiang Zhang added the comment: New changeset 4fb0b8bc25c52aae8dcb4353e69c1c88999a9a53 by Xiang Zhang in branch 'master': bpo-33106: change dbm key deletion error for readonly file from KeyError to dbm.error (#6295) https://github.com/python/cpython/commit/4fb0b8bc25c52aae8dcb4353e69c1c88999a9a53 -- ___ Python tracker <https://bugs.python.org/issue33106> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32804] urllib.retrieve documentation doesn't mention context parameter
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue32804> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32804] urllib.retrieve documentation doesn't mention context parameter
Xiang Zhang added the comment: New changeset aa39c1ab6de6d3fb0204741efdde9b7eed25b093 by Xiang Zhang (Lysandros Nikolaou) in branch '2.7': [2.7] bpo-32804: Include the context parameter in urlretrieve documentation (GH-10203) https://github.com/python/cpython/commit/aa39c1ab6de6d3fb0204741efdde9b7eed25b093 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue32804> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35062> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field
Xiang Zhang added the comment: New changeset b08746bfdf64e55ce33516f2065fa2aa4f51be95 by Xiang Zhang in branch 'master': bpo-35062: Fix parsing _io.IncrementalNewlineDecoder's *translate* argument. (GH-10217) https://github.com/python/cpython/commit/b08746bfdf64e55ce33516f2065fa2aa4f51be95 -- ___ Python tracker <https://bugs.python.org/issue35062> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field
Change by Xiang Zhang : -- keywords: +patch pull_requests: +9534 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue35062> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34672] '%Z' strftime specifier never works with musl
Xiang Zhang added the comment: New changeset 163eca34c48f1b25e1504e37f4656773fd0fdc78 by Xiang Zhang in branch 'master': bpo-34672: fix a compiler warning in timemodule.c (GH-10176) https://github.com/python/cpython/commit/163eca34c48f1b25e1504e37f4656773fd0fdc78 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34672> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34672] '%Z' strftime specifier never works with musl
Change by Xiang Zhang : -- pull_requests: +9499 ___ Python tracker <https://bugs.python.org/issue34672> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35062] io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field
New submission from Xiang Zhang : io.IncrementalNewlineDecoder gets a *translate* bitwise struct field, but it could be assigned arbitrary int value. This leads to inconsistent behaviour, evens are evaluated to False and odds to True. >>> io.IncrementalNewlineDecoder(encodings.utf_8.IncrementalDecoder(), >>> 4).decode(b"abcd\r\n") u'abcd\r\n' >>> io.IncrementalNewlineDecoder(encodings.utf_8.IncrementalDecoder(), >>> 5).decode(b"abcd\r\n") u'abcd\n' -- components: IO messages: 328407 nosy: xiang.zhang priority: normal severity: normal stage: needs patch status: open title: io.IncrementalNewlineDecoder assign out-of-range value to bitwise struct field type: behavior versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue35062> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35056] Test leaks of memory not managed by Python allocator
Change by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue35056> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31722] _io.IncrementalNewlineDecoder doesn't inherit codecs.IncrementalDecoder
Xiang Zhang added the comment: Just find the same problem while investigating io. -- nosy: +xiang.zhang stage: patch review -> needs patch versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issue31722> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34748] Incorrect HTML link in functools.partial
Xiang Zhang added the comment: Thanks all. :-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34748> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34748] Incorrect HTML link in functools.partial
Xiang Zhang added the comment: New changeset 56a4a3aa555b3abc756cf837eddac4c0bf545db7 by Xiang Zhang in branch '2.7': [2.7] bpo-34748: link to :ref:`partial-objects` in functools.partial doc. (GH-9809) https://github.com/python/cpython/commit/56a4a3aa555b3abc756cf837eddac4c0bf545db7 -- ___ Python tracker <https://bugs.python.org/issue34748> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34748] Incorrect HTML link in functools.partial
Change by Xiang Zhang : -- pull_requests: +9386 ___ Python tracker <https://bugs.python.org/issue34748> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34748] Incorrect HTML link in functools.partial
Xiang Zhang added the comment: New changeset 83a07652e0033f0d9994ae7634b91d6581c56b00 by Xiang Zhang (Andrei Petre) in branch 'master': bpo-34748: link to :ref:`partial-objects` in functools.partial doc. (GH-9809) https://github.com/python/cpython/commit/83a07652e0033f0d9994ae7634b91d6581c56b00 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34748> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34973] Crash in bytes constructor with mutating list
Xiang Zhang added the comment: I carefully read both the two PRs. The first one, easy to understand. The second one, I spend some time to figure out why the test doesn't crash, why we need to have reference count checks in two places and make some experiments to test in different cases, how the reference counts will be. I am afraid I have to repeat this procedure after some time when reading the code again. :-( And while in some cases the second approach increases performance. But in others cases it might hurt. Codes storing the array in a variable will go into the iterator branch. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34973> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34953] Implement `mmap.mmap.__repr__`
Xiang Zhang added the comment: I don't like the idea to display the contents in the repr, no matter entire or clipped. I think it's not suitable and for contents, just read the object manually. For me, a closed status plus the constructor arguments is a good choice. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34979] Python throws “SyntaxError: Non-UTF-8 code start with \xe8...” when parse source file
Change by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34979> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34908] netrc parsing is overly strict
Xiang Zhang added the comment: My PR https://github.com/python/cpython/pull/127 has tried to solve some restrictions of the current netrc library. It's somewhat outdated since no reviewer for a long time. As you can see there are also other libraries suffering from the restrictions. Revising it I think it still doesn't solve the case here, although it should be easy. There is no formal spec we can refer to. :-( But since there is real world problem and curl allows it, we should take it into mind. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34908> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34850] Emit a syntax warning for "is" with a literal
Xiang Zhang added the comment: I have catched using `is` to do string equality check in our codebase by linters before. Not all my colleagues know what's not suitable here. The only common and suitable case I can think of is programmers are exploring CPython internals, like what stackoverflow Q and some Python blogs. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34850> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34763] Python lacks 0x4E17
Change by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34763> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34770] pyshellext.cpp: Possible null pointer dereference
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34770> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34786] ProcessPoolExecutor documentation reports wrong exception being raised
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34786> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34486] "RuntimeError: release unlocked lock" when starting a thread
Xiang Zhang added the comment: It's not right to replace with statement by manually calling __enter__ and __exit__. If there is any exception after __enter__ and before __exit__, __exit__ method will be skipped. That's not what we want. -- ___ Python tracker <https://bugs.python.org/issue34486> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34608] gc.get_referrers behavior change 3.6 to 3.7
Change by Xiang Zhang : -- nosy: +inada.naoki, pitrou ___ Python tracker <https://bugs.python.org/issue34608> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34505] urllib2 fails for proxy credentials that contains a '/' character
Change by Xiang Zhang : -- type: crash -> behavior ___ Python tracker <https://bugs.python.org/issue34505> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34563] invalid assert on big output of multiprocessing.Process
Change by Xiang Zhang : -- nosy: +davin, pitrou ___ Python tracker <https://bugs.python.org/issue34563> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34486] "RuntimeError: release unlocked lock" when starting a thread
Xiang Zhang added the comment: It looks to me pure Python implementation could not handle such cases. Put aside other possible bugs, threading.Condition.wait re-acquire the lock using threading.Condition._acquire_restore which could be interrupted and not able to acquire the lock. So it seems in any way using Pure Python, it's not possible to guarantee the lock is acquired. -- ___ Python tracker <https://bugs.python.org/issue34486> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34465] ipaddress should accept bytearray in addition to bytes
Xiang Zhang added the comment: I'm -1 on this change. I think the workaround is easy and direct. -- ___ Python tracker <https://bugs.python.org/issue34465> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't
Change by Xiang Zhang : -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL ___ Python tracker <https://bugs.python.org/issue24482> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34434] Removal of kwargs for built-in types not covered with "changed in Python" note in documentation
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34434> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34434] Removal of kwargs for built-in types not covered with "changed in Python" note in documentation
Xiang Zhang added the comment: New changeset 3fe89dac42809a7741d50ebf595be98833b79b97 by Xiang Zhang (Louis Sautier) in branch 'master': bpo-34434: Update doc for bool(), float() and int() arguments (GH-8834) https://github.com/python/cpython/commit/3fe89dac42809a7741d50ebf595be98833b79b97 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34434> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL
Xiang Zhang added the comment: I could. But currently I don't have a good idea how to fix it elegantly. If anyone else makes a PR, I'm willing to review it. -- stage: -> needs patch versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issue34410> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34503] Reference leak in PyErr_SetObject()
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34503> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34503] Reference leak in PyErr_SetObject()
Xiang Zhang added the comment: New changeset a2eefa67542c25617a58c03a27c17fd48e2a0856 by Xiang Zhang (Alexey Izbyshev) in branch 'master': bpo-34503: Fix refleak in PyErr_SetObject() (GH-8934) https://github.com/python/cpython/commit/a2eefa67542c25617a58c03a27c17fd48e2a0856 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34503> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23325] Turn SIG_DFL and SIG_IGN into functions
Xiang Zhang added the comment: I miss that. So this change seems to be user transparent and make more sense then. -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue23325> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23325] Turn SIG_DFL and SIG_IGN into functions
Xiang Zhang added the comment: I'm afraid this could break old codes so not sure it's worth or not. I've seen code like `SIGTERM = 15; signal.signal(SIGTERM, handler)`. I won't be surprised to see a handcraft SIG_DFL/IGN. -- nosy: +xiang.zhang versions: +Python 3.8 -Python 3.5 ___ Python tracker <https://bugs.python.org/issue23325> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34497] Remove needless set operator restriction
Change by Xiang Zhang : -- nosy: +rhettinger ___ Python tracker <https://bugs.python.org/issue34497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34465] ipaddress should accept bytearray in addition to bytes
Xiang Zhang added the comment: Why not just bytes(buf[:4]) before passing? -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34465> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34334] QueueHandler logs exc_info twice
Change by Xiang Zhang : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue34334> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34355] SIGSEGV (Address boundary error)
Xiang Zhang added the comment: So this is a dupliate of #34087 and we can close it? -- nosy: +inada.naoki, xiang.zhang ___ Python tracker <https://bugs.python.org/issue34355> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34486] "RuntimeError: release unlocked lock" when starting a thread
Change by Xiang Zhang : -- nosy: +vstinner, xiang.zhang ___ Python tracker <https://bugs.python.org/issue34486> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34491] _bsddb.c: Missing Py_DECREF() in DB_join()
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34491> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34491] _bsddb.c: Missing Py_DECREF() in DB_join()
New submission from Xiang Zhang : New changeset 032e85f3fb6d2e6668d4e860b40525ed6cb8dd69 by Xiang Zhang (Zackery Spytz) in branch '2.7': bpo-34491: Add missing Py_DECREF() in _bsddb's DB_join() (GH-8909) https://github.com/python/cpython/commit/032e85f3fb6d2e6668d4e860b40525ed6cb8dd69 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34491> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered
Xiang Zhang added the comment: Ahh, the infinite iterator could also releases GIL in `PyIter_Next`. -- ___ Python tracker <https://bugs.python.org/issue34410> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered
Xiang Zhang added the comment: It seems to me the problem is tee objects might encounter race conditions while `PyIter_Next` in `teedataobject_getitem` releases GIL. Other threads then might get into the same branch since `tdo->numread` haven't been updated yet. NULL slots are generated then, 2 objects are read from the underlying iterator and `tdo->numread` is updated twice while only one slot is set. As for multiprocessing.pool, there is a background task handling thread consuming one tee object and main thread consuming another one. The underlying iterator is `IMapIterator` which `next` method would block on a condition. While trying, I find the following snippet would also crash: import threading import itertools class C: def __iter__(self): return self def __next__(self): return 1 def test(i): print(list(i)) i1, i2 = itertools.tee(C()) threading.Thread(target=test, args=(i1,)).start() print(list(i2)) GDB shows it crashs in `teedataobject_dealloc` -> `teedataobject_clear`. I haven't understood what happened. -- ___ Python tracker <https://bugs.python.org/issue34410> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue30411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac
Xiang Zhang added the comment: New changeset 95f9e14e33b713f35f5368acf7be56750bbdb5a8 by Xiang Zhang in branch '2.7': [2.7] bpo-30411: Use --git-dir instead of -C to make git work under version below 1.8.5. (GH-8744) (GH-8838) https://github.com/python/cpython/commit/95f9e14e33b713f35f5368acf7be56750bbdb5a8 -- ___ Python tracker <https://bugs.python.org/issue30411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac
Change by Xiang Zhang : -- pull_requests: +8313 ___ Python tracker <https://bugs.python.org/issue30411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac
Xiang Zhang added the comment: New changeset 4c8555773a801f957297132a92c0acb382d640e4 by Xiang Zhang in branch 'master': bpo-30411: Use --git-dir instead of -C to make git work under version below 1.8.5. (GH-8744) https://github.com/python/cpython/commit/4c8555773a801f957297132a92c0acb382d640e4 -- ___ Python tracker <https://bugs.python.org/issue30411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered
Change by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34410> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30717] Add unicode grapheme cluster break algorithm
Change by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue30717> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30411] git doesn't support "-C" args under 1.8.5 occurs in configure.ac
Change by Xiang Zhang : -- keywords: +patch pull_requests: +8227 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue30411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34151] use malloc() for better performance of some list operations
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34151> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34151] use malloc() for better performance of some list operations
Xiang Zhang added the comment: New changeset 2fc46979b8c802675ca7fd51c6f2108a305001c8 by Xiang Zhang (Sergey Fedoseev) in branch 'master': bpo-34151: Improve performance of some list operations (GH-8332) https://github.com/python/cpython/commit/2fc46979b8c802675ca7fd51c6f2108a305001c8 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34151> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34310] Build error with option "--with-pydebug" on Mac OS 10.13.6
Change by Xiang Zhang : -- resolution: rejected -> not a bug ___ Python tracker <https://bugs.python.org/issue34310> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34310] Build error with option "--with-pydebug" on Mac OS 10.13.6
Xiang Zhang added the comment: I could not find the specific commit you mentioned on master branch. Maybe you are on a customized branch(what is master-dirty)? -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34310> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34134] multiprocessing memory huge usage
Xiang Zhang added the comment: I'm +1 for INADA's change, but not more examples trying to distinguish every detail difference. -- ___ Python tracker <https://bugs.python.org/issue34134> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34134] multiprocessing memory huge usage
Xiang Zhang added the comment: Why accessing the result outside of with block? The pool is terminated while exiting the block before the work is done. -- ___ Python tracker <https://bugs.python.org/issue34134> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34140] Possible multiprocessing deadlock when placing too many objects in Queue()
Change by Xiang Zhang : -- nosy: +davin, pitrou, xiang.zhang ___ Python tracker <https://bugs.python.org/issue34140> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34134] multiprocessing memory huge usage
Xiang Zhang added the comment: One thing worth a try here maybe turn `len` to `operator.length_hint`. But I am not sure it's a good idea and just a mention here. -- nosy: +xiang.zhang versions: -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue34134> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34132] Obscure netrc parser "bug"
Change by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue34132> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34084] possible free statically allocated string in compiler when easter egg on
Change by Xiang Zhang : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue34084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34084] possible free statically allocated string in compiler when easter egg on
Change by Xiang Zhang : -- title: possible free statically allocated string -> possible free statically allocated string in compiler when easter egg on ___ Python tracker <https://bugs.python.org/issue34084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34084] possible free statically allocated string
New submission from Xiang Zhang : While reviewing PR8222, I found `err_ret->text` is assigned a not malloced string, but it will finally get freed in `err_input`. -- keywords: easy messages: 321381 nosy: serhiy.storchaka, xiang.zhang priority: normal severity: normal status: open title: possible free statically allocated string versions: Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue34084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30256] Adding a SyncManager Queue proxy to a SyncManager dict or Namespace proxy raises an exception
Change by Xiang Zhang : -- nosy: +davin, pitrou, xiang.zhang ___ Python tracker <https://bugs.python.org/issue30256> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33978] logging.config.dictConfig with file handler leaks resources
Change by Xiang Zhang : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue33978> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33932] Calling Py_Initialize() twice now triggers a fatal error (Python 3.7)
Xiang Zhang added the comment: > Note: the doc doesn't say that the function must only be called once, nor > document the (current) new Python 3.7 restriction (must only be called once): But the doc says: This is a no-op when called for a second time (without calling Py_FinalizeEx() first). no-op means it could be called twice? -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue33932> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33936] OPENSSL_VERSION_1_1 never defined in _hashopenssl.c
Change by Xiang Zhang : -- nosy: +christian.heimes ___ Python tracker <https://bugs.python.org/issue33936> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
