Re: [QA AUTOMATION] Insert Sheet Tests

2022-10-18 Thread Carl Marcum

Hi Matthias,


On 10/18/22 09:08, Matthias Seidel wrote:

Hi Carl,

Thanks for the info and your continuing QA work!

I *think* the problem with "Update Links" came up when we introduced a
confirmation because of security reasons.

https://bz.apache.org/ooo/show_bug.cgi?id=127582



I guessed it was due to a change at some point.
Thanks for the link and all you do as well ;)

Best regards,
Carl



Regards,

    Matthias

Am 18.10.22 um 14:57 schrieb Carl Marcum:

Hi All,

There was an UNO FVT test uno/sc/sheetSheetBasicTest that was timing
out and throwing an error due to an "Update Links" confirmation dialog
that was waiting on a response that never comes.
This test created a source Excel spreadsheet with a formula in a cell
on each of three sheets and created a Calc document to copy these
sheets into it with each of the three linking modes: Normal, Value,
and None.

I wasn't able to get past the dialog using UNO only so I have set that
test to be ignored and created two additional mixed UNO/VCL test
classes to cover it.
mix/sc/sheet/InsertExcelSheetTest and InsertCalcSheetTest and instead
of one large test method it's one for each of the three link modes and
a class for Excel on one for Calc source documents.

Using VCL I was able to acknowledge the dialog and move on and then
use as much UNO after that.

I also added a do while loop to retry a VCL call that randomly throws
an VCLHookException so we don't fail a test because the dispatch
glitched. (This same method loop might also fix some other flaky tests
also.)

More information in the PR [1].

[1] https://github.com/apache/openoffice/pull/158

Best regards,
Carl

-
To unsubscribe, e-mail: qa-unsubscr...@openoffice.apache.org
For additional commands, e-mail: qa-h...@openoffice.apache.org




-
To unsubscribe, e-mail: qa-unsubscr...@openoffice.apache.org
For additional commands, e-mail: qa-h...@openoffice.apache.org



Re: [QA AUTOMATION] Insert Sheet Tests

2022-10-18 Thread Matthias Seidel
Hi Carl,

Thanks for the info and your continuing QA work!

I *think* the problem with "Update Links" came up when we introduced a
confirmation because of security reasons.

https://bz.apache.org/ooo/show_bug.cgi?id=127582

Regards,

   Matthias

Am 18.10.22 um 14:57 schrieb Carl Marcum:
> Hi All,
>
> There was an UNO FVT test uno/sc/sheetSheetBasicTest that was timing
> out and throwing an error due to an "Update Links" confirmation dialog
> that was waiting on a response that never comes.
> This test created a source Excel spreadsheet with a formula in a cell
> on each of three sheets and created a Calc document to copy these
> sheets into it with each of the three linking modes: Normal, Value,
> and None.
>
> I wasn't able to get past the dialog using UNO only so I have set that
> test to be ignored and created two additional mixed UNO/VCL test
> classes to cover it.
> mix/sc/sheet/InsertExcelSheetTest and InsertCalcSheetTest and instead
> of one large test method it's one for each of the three link modes and
> a class for Excel on one for Calc source documents.
>
> Using VCL I was able to acknowledge the dialog and move on and then
> use as much UNO after that.
>
> I also added a do while loop to retry a VCL call that randomly throws
> an VCLHookException so we don't fail a test because the dispatch
> glitched. (This same method loop might also fix some other flaky tests
> also.)
>
> More information in the PR [1].
>
> [1] https://github.com/apache/openoffice/pull/158
>
> Best regards,
> Carl
>
> -
> To unsubscribe, e-mail: qa-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: qa-h...@openoffice.apache.org
>



smime.p7s
Description: S/MIME Cryptographic Signature