Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Tanmay]

Hi,

I just sent a patch with fewer files to address using git-send-email.

Thanks,
Tanmay

On Tue, 7 May 2024 at 15:56, Peter Maydell  wrote:

> On Mon, 6 May 2024 at 07:20, Tanmay  wrote:
> >
> > Hi,
> >
> > I have added a patch inline that fixes indentation and formatting for
> some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373.
> >
> > Thanks,
> > Tanmay
>
> Hi; thanks for this patch. Unfortunately there seem to be some
> problems with the formatting, which mean it doesn't apply correctly.
>
> In particular you've sent it as a plain/text + HTML email, and
> something (probably your mail client) is wrapping long lines.
> I can usually fix something like this up on my end for a first
> time submitter, but in this case the patch is just way too big
> for that to be practical.
>
> I generally don't recommend trying to send patch emails directly
> through the gmail web UI -- it unfortunately mangles them too
> much. Personally I use git-send-email; it is a bit awkward to
> set up, but https://git-send-email.io/ has a nice step-by-step
> guide including specific details on how to configure it to send
> via Gmail.
>
> > From 46026574821c46804111eea6607a1b39314b7abe Mon Sep 17 00:00:00 2001
> > From: Tanmay Patil 
> > Date: Sat, 25 Nov 2023 00:53:54 +0530
> > Subject: [PATCH] Fixes: Indentation using TABs and improve formatting
> >  Resolves: https://gitlab.com/qemu-project/qemu/-/issues/373
> >
> >Files changed:
> > - hw/arm/boot.c
> > - hw/char/omap_uart.c
> > - hw/dma/pxa2xx_dma.c
> > - hw/gpio/omap_gpio.c
> > - hw/gpio/zaurus.c
> > - hw/input/tsc2005.c
> > - hw/input/tsc210x.c
> > - hw/intc/omap_intc.c
> > - hw/misc/cbus.c
> > - hw/misc/omap_clk.c
> > - hw/misc/omap_l4.c
> > - hw/misc/omap_sdrc.c
> > - hw/misc/omap_tap.c
> > - hw/sd/omap_mmc.c
> > - hw/sd/pxa2xx_mmci.c
> > - hw/timer/omap_gptimer.c
> > - hw/timer/omap_synctimer.c
> > - hw/timer/pxa2xx_timer.c
> > - include/hw/arm/pxa.h
> > - include/hw/arm/sharpsl.h
> > - include/hw/arm/soc_dma.h
> > - tcg/arm/tcg-target.h
> >
> > Signed-off-by: Tanmay Patil 
> > ---
> >  hw/arm/boot.c |   8 +-
> >  hw/char/omap_uart.c   |  49 +-
> >  hw/dma/pxa2xx_dma.c   | 198 
> >  hw/gpio/omap_gpio.c   | 243 +-
> >  hw/gpio/zaurus.c  |  61 +--
> >  hw/input/tsc2005.c| 130 ++---
> >  hw/input/tsc210x.c| 442 +
> >  hw/intc/omap_intc.c   | 261 +-
> >  hw/misc/cbus.c| 202 
> >  hw/misc/omap_clk.c| 999 +++---
> >  hw/misc/omap_l4.c |  21 +-
> >  hw/misc/omap_sdrc.c   | 135 +++---
> >  hw/misc/omap_tap.c|  28 +-
> >  hw/sd/omap_mmc.c  | 208 
> >  hw/sd/pxa2xx_mmci.c   | 149 +++---
> >  hw/timer/omap_gptimer.c   | 126 ++---
> >  hw/timer/omap_synctimer.c |   7 +-
> >  hw/timer/pxa2xx_timer.c   | 279 ++-
> >  include/hw/arm/pxa.h  | 100 ++--
> >  include/hw/arm/sharpsl.h  |   2 +-
> >  include/hw/arm/soc_dma.h  |   4 +-
> >  tcg/arm/tcg-target.h  |   4 +-
> >  22 files changed, 1903 insertions(+), 1753 deletions(-)
>
> This is a lot of changes to do all in one commit, even though they're
> all just whitespace fixes. Could you split them up, please, into
> multiple patches that tackle fewer files at a time?
>
> thanks
> -- PMM
>

Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Peter Maydell]

On Mon, 6 May 2024 at 07:20, Tanmay  wrote:
>
> Hi,
>
> I have added a patch inline that fixes indentation and formatting for some 
> files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373.
>
> Thanks,
> Tanmay

Hi; thanks for this patch. Unfortunately there seem to be some
problems with the formatting, which mean it doesn't apply correctly.

In particular you've sent it as a plain/text + HTML email, and
something (probably your mail client) is wrapping long lines.
I can usually fix something like this up on my end for a first
time submitter, but in this case the patch is just way too big
for that to be practical.

I generally don't recommend trying to send patch emails directly
through the gmail web UI -- it unfortunately mangles them too
much. Personally I use git-send-email; it is a bit awkward to
set up, but https://git-send-email.io/ has a nice step-by-step
guide including specific details on how to configure it to send
via Gmail.

> From 46026574821c46804111eea6607a1b39314b7abe Mon Sep 17 00:00:00 2001
> From: Tanmay Patil 
> Date: Sat, 25 Nov 2023 00:53:54 +0530
> Subject: [PATCH] Fixes: Indentation using TABs and improve formatting
>  Resolves: https://gitlab.com/qemu-project/qemu/-/issues/373
>
>Files changed:
> - hw/arm/boot.c
> - hw/char/omap_uart.c
> - hw/dma/pxa2xx_dma.c
> - hw/gpio/omap_gpio.c
> - hw/gpio/zaurus.c
> - hw/input/tsc2005.c
> - hw/input/tsc210x.c
> - hw/intc/omap_intc.c
> - hw/misc/cbus.c
> - hw/misc/omap_clk.c
> - hw/misc/omap_l4.c
> - hw/misc/omap_sdrc.c
> - hw/misc/omap_tap.c
> - hw/sd/omap_mmc.c
> - hw/sd/pxa2xx_mmci.c
> - hw/timer/omap_gptimer.c
> - hw/timer/omap_synctimer.c
> - hw/timer/pxa2xx_timer.c
> - include/hw/arm/pxa.h
> - include/hw/arm/sharpsl.h
> - include/hw/arm/soc_dma.h
> - tcg/arm/tcg-target.h
>
> Signed-off-by: Tanmay Patil 
> ---
>  hw/arm/boot.c |   8 +-
>  hw/char/omap_uart.c   |  49 +-
>  hw/dma/pxa2xx_dma.c   | 198 
>  hw/gpio/omap_gpio.c   | 243 +-
>  hw/gpio/zaurus.c  |  61 +--
>  hw/input/tsc2005.c| 130 ++---
>  hw/input/tsc210x.c| 442 +
>  hw/intc/omap_intc.c   | 261 +-
>  hw/misc/cbus.c| 202 
>  hw/misc/omap_clk.c| 999 +++---
>  hw/misc/omap_l4.c |  21 +-
>  hw/misc/omap_sdrc.c   | 135 +++---
>  hw/misc/omap_tap.c|  28 +-
>  hw/sd/omap_mmc.c  | 208 
>  hw/sd/pxa2xx_mmci.c   | 149 +++---
>  hw/timer/omap_gptimer.c   | 126 ++---
>  hw/timer/omap_synctimer.c |   7 +-
>  hw/timer/pxa2xx_timer.c   | 279 ++-
>  include/hw/arm/pxa.h  | 100 ++--
>  include/hw/arm/sharpsl.h  |   2 +-
>  include/hw/arm/soc_dma.h  |   4 +-
>  tcg/arm/tcg-target.h  |   4 +-
>  22 files changed, 1903 insertions(+), 1753 deletions(-)

This is a lot of changes to do all in one commit, even though they're
all just whitespace fixes. Could you split them up, please, into
multiple patches that tackle fewer files at a time?

thanks
-- PMM

Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Tanmay]

Sure, I'll do it!

Thanks,
Tanmay

On Mon, 6 May 2024 at 10:11, Thomas Huth  wrote:

> On 04/05/2024 22.34, Michael Tokarev wrote:
> > 04.05.2024 21:58, Tanmay wrote:
> >> Hi,
> >>
> >> I have attached a patch file that fixes indentation and formatting for
> >> some files as listed in
> https://gitlab.com/qemu-project/qemu/-/issues/373
> >> .
> >
> > it is sort of good you posted this patch to stable@.  It has absolutely
> > nothing to do
> > with stable, but it serves as a an example of things which should - in
> my
> > opinion -
> > not be done at all.
>
> I disagree. Yes, clean-up patches like this make it somewhat difficult to
> backport other patches to stable, but that should not be the reason to not
> do cleanups at all. If we keep badly formatted code in the repository,
> people will copy-n-paste it to other places, or if you have to do fixes in
> sources that have mixed TABs and spaces, you often get complaints from
> checkpatch.pl though it is not your fault. So we should get this straight
> at
> one point in time.
>
> So, Tanmay, could you please resend your patch, this time to
> qemu-devel@nongnu.org instead of qemu-stable, and CC: qemu-...@nongnu.org
> and the corresponding ARM maintainers (you can use
> scripts/get_maintainers.pl to find out the correct maintainers that
> should
> be CC:-ed). And if possible, please send your patch inline and not as an
> attachment (so it's possible to comment on the patch via hitting the reply
> button), preferably with "git send-email" instead of using your e-mail
> program.
>
>   Thanks!
>Thomas
>
>

Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Thomas Huth]

On 04/05/2024 22.34, Michael Tokarev wrote:

04.05.2024 21:58, Tanmay wrote:

Hi,

I have attached a patch file that fixes indentation and formatting for 
some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373 
.


it is sort of good you posted this patch to stable@.  It has absolutely 
nothing to do
with stable, but it serves as a an example of things which should - in my 
opinion -

not be done at all.


I disagree. Yes, clean-up patches like this make it somewhat difficult to 
backport other patches to stable, but that should not be the reason to not 
do cleanups at all. If we keep badly formatted code in the repository, 
people will copy-n-paste it to other places, or if you have to do fixes in 
sources that have mixed TABs and spaces, you often get complaints from 
checkpatch.pl though it is not your fault. So we should get this straight at 
one point in time.


So, Tanmay, could you please resend your patch, this time to 
qemu-devel@nongnu.org instead of qemu-stable, and CC: qemu-...@nongnu.org 
and the corresponding ARM maintainers (you can use 
scripts/get_maintainers.pl to find out the correct maintainers that should 
be CC:-ed). And if possible, please send your patch inline and not as an 
attachment (so it's possible to comment on the patch via hitting the reply 
button), preferably with "git send-email" instead of using your e-mail program.


 Thanks!
  Thomas

Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Tanmay]

Hi,

I completely agree!
This was more of a "NEWCOMERS" issue to help us understand how the patch
flow works.
I'll take up a trivial issue and work on it instead.

Thanks,
Tanmay

On Sun, 5 May 2024 at 02:05, Michael Tokarev  wrote:

> 04.05.2024 21:58, Tanmay wrote:
> > Hi,
> >
> > I have attached a patch file that fixes indentation and formatting for
> some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373
> > .
>
> it is sort of good you posted this patch to stable@.  It has absolutely
> nothing to do
> with stable, but it serves as a an example of things which should - in my
> opinion -
> not be done at all.  We had another similar change, 55339361276a "sh4:
> Coding style:
> Remove tabs", which makes all further changes (fixes) in this area
> basically
> non-back-portable to previous stable series.
>
> FWIW,
>
> /mjt
> --
> GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
> New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD
> 3D98 ECDF 2C8E
> Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C
> E0A0 8044 65C5
> Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
>
>

Re: [PATCH] Fixes: Indentation using TABs and improve formatting

[Michael Tokarev]

04.05.2024 21:58, Tanmay wrote:

Hi,

I have attached a patch file that fixes indentation and formatting for some files as listed in https://gitlab.com/qemu-project/qemu/-/issues/373 
.


it is sort of good you posted this patch to stable@.  It has absolutely nothing 
to do
with stable, but it serves as a an example of things which should - in my 
opinion -
not be done at all.  We had another similar change, 55339361276a "sh4: Coding 
style:
Remove tabs", which makes all further changes (fixes) in this area basically
non-back-portable to previous stable series.

FWIW,

/mjt
--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 
ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 
8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt