Re: [PATCH] hw/arm/npcm7xx: remove setting of mp-affinity
On Sat, 4 May 2024 at 15:17, Dorjoy Chowdhury wrote: > > The value of the mp-affinity property being set in npcm7xx_realize is > always the same as the default value it would have when arm_cpu_realizefn > is called if the property is not set here. So there is no need to set > the property value in npcm7xx_realize function. > > Signed-off-by: Dorjoy Chowdhury > --- Applied to target-arm.next, thanks. -- PMM
Re: [PATCH] hw/arm/npcm7xx: remove setting of mp-affinity
On 4/5/24 16:32, Richard Henderson wrote: On 5/4/24 07:17, Dorjoy Chowdhury wrote: The value of the mp-affinity property being set in npcm7xx_realize is always the same as the default value it would have when arm_cpu_realizefn is called if the property is not set here. So there is no need to set the property value in npcm7xx_realize function. Signed-off-by: Dorjoy Chowdhury --- hw/arm/npcm7xx.c | 3 --- 1 file changed, 3 deletions(-) Implicitly in https://lore.kernel.org/qemu-devel/20231212162935.42910-31-phi...@linaro.org/ Reviewed-by: Philippe Mathieu-Daudé
Re: [PATCH] hw/arm/npcm7xx: remove setting of mp-affinity
On 5/4/24 07:17, Dorjoy Chowdhury wrote: The value of the mp-affinity property being set in npcm7xx_realize is always the same as the default value it would have when arm_cpu_realizefn is called if the property is not set here. So there is no need to set the property value in npcm7xx_realize function. Signed-off-by: Dorjoy Chowdhury --- hw/arm/npcm7xx.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Richard Henderson r~
[PATCH] hw/arm/npcm7xx: remove setting of mp-affinity
The value of the mp-affinity property being set in npcm7xx_realize is
always the same as the default value it would have when arm_cpu_realizefn
is called if the property is not set here. So there is no need to set
the property value in npcm7xx_realize function.
Signed-off-by: Dorjoy Chowdhury
---
hw/arm/npcm7xx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c
index 9f2d96c733..cb7791301b 100644
--- a/hw/arm/npcm7xx.c
+++ b/hw/arm/npcm7xx.c
@@ -487,9 +487,6 @@ static void npcm7xx_realize(DeviceState *dev, Error **errp)
/* CPUs */
for (i = 0; i < nc->num_cpus; i++) {
-object_property_set_int(OBJECT(>cpu[i]), "mp-affinity",
-arm_build_mp_affinity(i, NPCM7XX_MAX_NUM_CPUS),
-_abort);
object_property_set_int(OBJECT(>cpu[i]), "reset-cbar",
NPCM7XX_GIC_CPU_IF_ADDR, _abort);
object_property_set_bool(OBJECT(>cpu[i]), "reset-hivecs", true,
--
2.39.2
