Re: [PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start
On Thu, Sep 07, 2023 at 10:30:49PM +0300, Daniil Tatianin wrote: > This series fixes an issue where the outcome of the migration qtest > relies on the initial memory contents all being the same across the > first 100MiB of RAM, which is a very fragile invariant. > > We fix this by making sure we zero the first byte of every testable page > in range beforehand. > > Daniil Tatianin (2): > i386/a-b-bootblock: factor test memory addresses out into constants > i386/a-b-bootblock: zero the first byte of each page on start Thanks, sorry for being slow on review. Reviewed-by: Peter Xu How about other archs (arm/s390)? It seems to me arm is all fine, but not sure about s390. -- Peter Xu
Re: [PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start
ping 07.09.2023, 22:31, "Daniil Tatianin" :This series fixes an issue where the outcome of the migration qtestrelies on the initial memory contents all being the same across thefirst 100MiB of RAM, which is a very fragile invariant.We fix this by making sure we zero the first byte of every testable pagein range beforehand.Daniil Tatianin (2): i386/a-b-bootblock: factor test memory addresses out into constants i386/a-b-bootblock: zero the first byte of each page on start tests/migration/i386/a-b-bootblock.S | 18 +++--- tests/migration/i386/a-b-bootblock.h | 16 2 files changed, 23 insertions(+), 11 deletions(-) --2.34.1
[PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start
This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invariant. We fix this by making sure we zero the first byte of every testable page in range beforehand. Daniil Tatianin (2): i386/a-b-bootblock: factor test memory addresses out into constants i386/a-b-bootblock: zero the first byte of each page on start tests/migration/i386/a-b-bootblock.S | 18 +++--- tests/migration/i386/a-b-bootblock.h | 16 2 files changed, 23 insertions(+), 11 deletions(-) -- 2.34.1
