Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 9/7/23 22:11, Michael Tokarev wrote: 11.07.2023 20:25, Andrey Drobyshev via wrote: v1 --> v2: * Fixed line indentation; * Fixed wording in a comment; * Added R-b. v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html Andrey Drobyshev (3): block: add subcluster_size field to BlockDriverInfo block/io: align requests to subcluster_size tests/qemu-iotests/197: add testcase for CoR with subclusters block.c | 7 + block/io.c | 50 ++-- block/mirror.c | 8 +++--- block/qcow2.c | 1 + include/block/block-common.h | 5 include/block/block-io.h | 8 +++--- tests/qemu-iotests/197 | 29 + tests/qemu-iotests/197.out | 24 + 8 files changed, 99 insertions(+), 33 deletions(-) So, given the size of patch series and amount of time the series were sitting there.. I'm hesitating to apply it to -stable. The whole issue, while real, smells like somewhat unusual case. Any comments on this? Thanks, /mjt The issue was observed by us in the reality on not yet released product, but the series requires correct, which has been sent as 4/3 patch today by Andrey. Unit tests are broken at the moment. Thanks, Den
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
11.07.2023 20:25, Andrey Drobyshev via wrote: v1 --> v2: * Fixed line indentation; * Fixed wording in a comment; * Added R-b. v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html Andrey Drobyshev (3): block: add subcluster_size field to BlockDriverInfo block/io: align requests to subcluster_size tests/qemu-iotests/197: add testcase for CoR with subclusters block.c | 7 + block/io.c | 50 ++-- block/mirror.c | 8 +++--- block/qcow2.c| 1 + include/block/block-common.h | 5 include/block/block-io.h | 8 +++--- tests/qemu-iotests/197 | 29 + tests/qemu-iotests/197.out | 24 + 8 files changed, 99 insertions(+), 33 deletions(-) So, given the size of patch series and amount of time the series were sitting there.. I'm hesitating to apply it to -stable. The whole issue, while real, smells like somewhat unusual case. Any comments on this? Thanks, /mjt
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On Thu, Aug 24, 2023 at 06:47:20PM +0300, Andrey Drobyshev wrote: > On 8/24/23 17:32, Stefan Hajnoczi wrote: > > On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote: > >> On 8/22/23 22:58, John Snow wrote: > >>> On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev > >>> wrote: > > On 8/16/23 12:22, Andrey Drobyshev wrote: > > On 7/31/23 17:51, Andrey Drobyshev wrote: > >> On 7/24/23 16:11, Andrey Drobyshev wrote: > >>> On 7/11/23 20:25, Andrey Drobyshev wrote: > v1 --> v2: > * Fixed line indentation; > * Fixed wording in a comment; > * Added R-b. > > v1: > https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html > > Andrey Drobyshev (3): > block: add subcluster_size field to BlockDriverInfo > block/io: align requests to subcluster_size > tests/qemu-iotests/197: add testcase for CoR with subclusters > > block.c | 7 + > block/io.c | 50 > ++-- > block/mirror.c | 8 +++--- > block/qcow2.c| 1 + > include/block/block-common.h | 5 > include/block/block-io.h | 8 +++--- > tests/qemu-iotests/197 | 29 + > tests/qemu-iotests/197.out | 24 + > 8 files changed, 99 insertions(+), 33 deletions(-) > > >>> > >>> Ping > >> > >> Another ping > > > > Yet another friendly ping > > One more friendly ping > >>> > >>> Looks like Stefan gave you an R-B for the series; do we just need an > >>> ACK by the block maintainers at this point or is there someone > >>> specific you're hoping will review this? > >>> > >>> --js > >>> > >> > >> Hi John, > >> > >> I figure a maintainer's R-b doesn't imply the patches being merged into > >> the tree. Hence I'm waiting for the notice that they actually are merged. > >> > >> Please let me know if the process should be different. > > > > Hi Andrey, > > Kevin is away right now but seemed happy enough when I mentioned this > > series to him, so I have merged this into my own tree: > > > > https://gitlab.com/stefanha/qemu block > > > > Sorry that your patch series have not been merged in a timely manner. > > > > Stefan > > Hi Stefan, > Good news! Thank you for the notice. > > When you have some time would you mind taking a look at these series as > well: > > https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00068.html > https://lists.nongnu.org/archive/html/qemu-block/2023-07/msg00106.html > > They've been hanging in the list for weeks (probably even longer than > this one) with little to no feedback. Would be nice to know if people > find those changes useful at all. Kevin will be back on Tuesday and Hanna Czenczek said she may have time to look before then. Hopefully they will get taken care of soon. Thanks, Stefan signature.asc Description: PGP signature
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 8/24/23 17:32, Stefan Hajnoczi wrote: > On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote: >> On 8/22/23 22:58, John Snow wrote: >>> On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev >>> wrote: On 8/16/23 12:22, Andrey Drobyshev wrote: > On 7/31/23 17:51, Andrey Drobyshev wrote: >> On 7/24/23 16:11, Andrey Drobyshev wrote: >>> On 7/11/23 20:25, Andrey Drobyshev wrote: v1 --> v2: * Fixed line indentation; * Fixed wording in a comment; * Added R-b. v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html Andrey Drobyshev (3): block: add subcluster_size field to BlockDriverInfo block/io: align requests to subcluster_size tests/qemu-iotests/197: add testcase for CoR with subclusters block.c | 7 + block/io.c | 50 ++-- block/mirror.c | 8 +++--- block/qcow2.c| 1 + include/block/block-common.h | 5 include/block/block-io.h | 8 +++--- tests/qemu-iotests/197 | 29 + tests/qemu-iotests/197.out | 24 + 8 files changed, 99 insertions(+), 33 deletions(-) >>> >>> Ping >> >> Another ping > > Yet another friendly ping One more friendly ping >>> >>> Looks like Stefan gave you an R-B for the series; do we just need an >>> ACK by the block maintainers at this point or is there someone >>> specific you're hoping will review this? >>> >>> --js >>> >> >> Hi John, >> >> I figure a maintainer's R-b doesn't imply the patches being merged into >> the tree. Hence I'm waiting for the notice that they actually are merged. >> >> Please let me know if the process should be different. > > Hi Andrey, > Kevin is away right now but seemed happy enough when I mentioned this > series to him, so I have merged this into my own tree: > > https://gitlab.com/stefanha/qemu block > > Sorry that your patch series have not been merged in a timely manner. > > Stefan Hi Stefan, Good news! Thank you for the notice. When you have some time would you mind taking a look at these series as well: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00068.html https://lists.nongnu.org/archive/html/qemu-block/2023-07/msg00106.html They've been hanging in the list for weeks (probably even longer than this one) with little to no feedback. Would be nice to know if people find those changes useful at all. Thanks in advance! Andrey
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote: > On 8/22/23 22:58, John Snow wrote: > > On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev > > wrote: > >> > >> On 8/16/23 12:22, Andrey Drobyshev wrote: > >>> On 7/31/23 17:51, Andrey Drobyshev wrote: > On 7/24/23 16:11, Andrey Drobyshev wrote: > > On 7/11/23 20:25, Andrey Drobyshev wrote: > >> v1 --> v2: > >> * Fixed line indentation; > >> * Fixed wording in a comment; > >> * Added R-b. > >> > >> v1: > >> https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html > >> > >> Andrey Drobyshev (3): > >> block: add subcluster_size field to BlockDriverInfo > >> block/io: align requests to subcluster_size > >> tests/qemu-iotests/197: add testcase for CoR with subclusters > >> > >> block.c | 7 + > >> block/io.c | 50 ++-- > >> block/mirror.c | 8 +++--- > >> block/qcow2.c| 1 + > >> include/block/block-common.h | 5 > >> include/block/block-io.h | 8 +++--- > >> tests/qemu-iotests/197 | 29 + > >> tests/qemu-iotests/197.out | 24 + > >> 8 files changed, 99 insertions(+), 33 deletions(-) > >> > > > > Ping > > Another ping > >>> > >>> Yet another friendly ping > >> > >> One more friendly ping > > > > Looks like Stefan gave you an R-B for the series; do we just need an > > ACK by the block maintainers at this point or is there someone > > specific you're hoping will review this? > > > > --js > > > > Hi John, > > I figure a maintainer's R-b doesn't imply the patches being merged into > the tree. Hence I'm waiting for the notice that they actually are merged. > > Please let me know if the process should be different. Hi Andrey, Kevin is away right now but seemed happy enough when I mentioned this series to him, so I have merged this into my own tree: https://gitlab.com/stefanha/qemu block Sorry that your patch series have not been merged in a timely manner. Stefan signature.asc Description: PGP signature
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 8/22/23 22:58, John Snow wrote: > On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev > wrote: >> >> On 8/16/23 12:22, Andrey Drobyshev wrote: >>> On 7/31/23 17:51, Andrey Drobyshev wrote: On 7/24/23 16:11, Andrey Drobyshev wrote: > On 7/11/23 20:25, Andrey Drobyshev wrote: >> v1 --> v2: >> * Fixed line indentation; >> * Fixed wording in a comment; >> * Added R-b. >> >> v1: >> https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html >> >> Andrey Drobyshev (3): >> block: add subcluster_size field to BlockDriverInfo >> block/io: align requests to subcluster_size >> tests/qemu-iotests/197: add testcase for CoR with subclusters >> >> block.c | 7 + >> block/io.c | 50 ++-- >> block/mirror.c | 8 +++--- >> block/qcow2.c| 1 + >> include/block/block-common.h | 5 >> include/block/block-io.h | 8 +++--- >> tests/qemu-iotests/197 | 29 + >> tests/qemu-iotests/197.out | 24 + >> 8 files changed, 99 insertions(+), 33 deletions(-) >> > > Ping Another ping >>> >>> Yet another friendly ping >> >> One more friendly ping > > Looks like Stefan gave you an R-B for the series; do we just need an > ACK by the block maintainers at this point or is there someone > specific you're hoping will review this? > > --js > Hi John, I figure a maintainer's R-b doesn't imply the patches being merged into the tree. Hence I'm waiting for the notice that they actually are merged. Please let me know if the process should be different. Andrey
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev wrote: > > On 8/16/23 12:22, Andrey Drobyshev wrote: > > On 7/31/23 17:51, Andrey Drobyshev wrote: > >> On 7/24/23 16:11, Andrey Drobyshev wrote: > >>> On 7/11/23 20:25, Andrey Drobyshev wrote: > v1 --> v2: > * Fixed line indentation; > * Fixed wording in a comment; > * Added R-b. > > v1: > https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html > > Andrey Drobyshev (3): > block: add subcluster_size field to BlockDriverInfo > block/io: align requests to subcluster_size > tests/qemu-iotests/197: add testcase for CoR with subclusters > > block.c | 7 + > block/io.c | 50 ++-- > block/mirror.c | 8 +++--- > block/qcow2.c| 1 + > include/block/block-common.h | 5 > include/block/block-io.h | 8 +++--- > tests/qemu-iotests/197 | 29 + > tests/qemu-iotests/197.out | 24 + > 8 files changed, 99 insertions(+), 33 deletions(-) > > >>> > >>> Ping > >> > >> Another ping > > > > Yet another friendly ping > > One more friendly ping Looks like Stefan gave you an R-B for the series; do we just need an ACK by the block maintainers at this point or is there someone specific you're hoping will review this? --js
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 8/16/23 12:22, Andrey Drobyshev wrote: > On 7/31/23 17:51, Andrey Drobyshev wrote: >> On 7/24/23 16:11, Andrey Drobyshev wrote: >>> On 7/11/23 20:25, Andrey Drobyshev wrote: v1 --> v2: * Fixed line indentation; * Fixed wording in a comment; * Added R-b. v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html Andrey Drobyshev (3): block: add subcluster_size field to BlockDriverInfo block/io: align requests to subcluster_size tests/qemu-iotests/197: add testcase for CoR with subclusters block.c | 7 + block/io.c | 50 ++-- block/mirror.c | 8 +++--- block/qcow2.c| 1 + include/block/block-common.h | 5 include/block/block-io.h | 8 +++--- tests/qemu-iotests/197 | 29 + tests/qemu-iotests/197.out | 24 + 8 files changed, 99 insertions(+), 33 deletions(-) >>> >>> Ping >> >> Another ping > > Yet another friendly ping One more friendly ping
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On Tue, Jul 11, 2023 at 08:25:50PM +0300, Andrey Drobyshev via wrote: > v1 --> v2: > * Fixed line indentation; > * Fixed wording in a comment; > * Added R-b. > > v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html > > Andrey Drobyshev (3): > block: add subcluster_size field to BlockDriverInfo > block/io: align requests to subcluster_size > tests/qemu-iotests/197: add testcase for CoR with subclusters > > block.c | 7 + > block/io.c | 50 ++-- > block/mirror.c | 8 +++--- > block/qcow2.c| 1 + > include/block/block-common.h | 5 > include/block/block-io.h | 8 +++--- > tests/qemu-iotests/197 | 29 + > tests/qemu-iotests/197.out | 24 + > 8 files changed, 99 insertions(+), 33 deletions(-) > > -- > 2.39.3 > > Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 7/31/23 17:51, Andrey Drobyshev wrote: > On 7/24/23 16:11, Andrey Drobyshev wrote: >> On 7/11/23 20:25, Andrey Drobyshev wrote: >>> v1 --> v2: >>> * Fixed line indentation; >>> * Fixed wording in a comment; >>> * Added R-b. >>> >>> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html >>> >>> Andrey Drobyshev (3): >>> block: add subcluster_size field to BlockDriverInfo >>> block/io: align requests to subcluster_size >>> tests/qemu-iotests/197: add testcase for CoR with subclusters >>> >>> block.c | 7 + >>> block/io.c | 50 ++-- >>> block/mirror.c | 8 +++--- >>> block/qcow2.c| 1 + >>> include/block/block-common.h | 5 >>> include/block/block-io.h | 8 +++--- >>> tests/qemu-iotests/197 | 29 + >>> tests/qemu-iotests/197.out | 24 + >>> 8 files changed, 99 insertions(+), 33 deletions(-) >>> >> >> Ping > > Another ping Yet another friendly ping
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 7/24/23 16:11, Andrey Drobyshev wrote: > On 7/11/23 20:25, Andrey Drobyshev wrote: >> v1 --> v2: >> * Fixed line indentation; >> * Fixed wording in a comment; >> * Added R-b. >> >> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html >> >> Andrey Drobyshev (3): >> block: add subcluster_size field to BlockDriverInfo >> block/io: align requests to subcluster_size >> tests/qemu-iotests/197: add testcase for CoR with subclusters >> >> block.c | 7 + >> block/io.c | 50 ++-- >> block/mirror.c | 8 +++--- >> block/qcow2.c| 1 + >> include/block/block-common.h | 5 >> include/block/block-io.h | 8 +++--- >> tests/qemu-iotests/197 | 29 + >> tests/qemu-iotests/197.out | 24 + >> 8 files changed, 99 insertions(+), 33 deletions(-) >> > > Ping Another ping
Re: [PATCH v2 0/3] block: align CoR requests to subclusters
On 7/11/23 20:25, Andrey Drobyshev wrote: > v1 --> v2: > * Fixed line indentation; > * Fixed wording in a comment; > * Added R-b. > > v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html > > Andrey Drobyshev (3): > block: add subcluster_size field to BlockDriverInfo > block/io: align requests to subcluster_size > tests/qemu-iotests/197: add testcase for CoR with subclusters > > block.c | 7 + > block/io.c | 50 ++-- > block/mirror.c | 8 +++--- > block/qcow2.c| 1 + > include/block/block-common.h | 5 > include/block/block-io.h | 8 +++--- > tests/qemu-iotests/197 | 29 + > tests/qemu-iotests/197.out | 24 + > 8 files changed, 99 insertions(+), 33 deletions(-) > Ping
[PATCH v2 0/3] block: align CoR requests to subclusters
v1 --> v2: * Fixed line indentation; * Fixed wording in a comment; * Added R-b. v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html Andrey Drobyshev (3): block: add subcluster_size field to BlockDriverInfo block/io: align requests to subcluster_size tests/qemu-iotests/197: add testcase for CoR with subclusters block.c | 7 + block/io.c | 50 ++-- block/mirror.c | 8 +++--- block/qcow2.c| 1 + include/block/block-common.h | 5 include/block/block-io.h | 8 +++--- tests/qemu-iotests/197 | 29 + tests/qemu-iotests/197.out | 24 + 8 files changed, 99 insertions(+), 33 deletions(-) -- 2.39.3
