Re: [Qemu-devel] [PATCH] Fix net_check_clients warnings: make it per vlan.

2011-04-01 Thread Aurelien Jarno 
On Tue, Mar 15, 2011 at 02:20:54PM +0100, Tristan Gingold wrote:
 Signed-off-by: Tristan Gingold ging...@adacore.com
 ---
  net.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

Thanks, applied.

 diff --git a/net.c b/net.c
 index ddcca97..b2dfaa8 100644
 --- a/net.c
 +++ b/net.c
 @@ -1305,9 +1305,10 @@ void net_check_clients(void)
  {
  VLANState *vlan;
  VLANClientState *vc;
 -int has_nic = 0, has_host_dev = 0;
  
  QTAILQ_FOREACH(vlan, vlans, next) {
 +int has_nic = 0, has_host_dev = 0;
 +
  QTAILQ_FOREACH(vc, vlan-clients, next) {
  switch (vc-info-type) {
  case NET_CLIENT_TYPE_NIC:
 -- 
 1.7.3.GIT
 
 
 

-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net

Re: [Qemu-devel] [PATCH] Fix net_check_clients warnings: make it per vlan.

2011-03-16 Thread Markus Armbruster 
Tristan Gingold ging...@adacore.com writes:

 Signed-off-by: Tristan Gingold ging...@adacore.com
 ---
  net.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

 diff --git a/net.c b/net.c
 index ddcca97..b2dfaa8 100644
 --- a/net.c
 +++ b/net.c
 @@ -1305,9 +1305,10 @@ void net_check_clients(void)
  {
  VLANState *vlan;
  VLANClientState *vc;
 -int has_nic = 0, has_host_dev = 0;
  
  QTAILQ_FOREACH(vlan, vlans, next) {
 +int has_nic = 0, has_host_dev = 0;
 +
  QTAILQ_FOREACH(vc, vlan-clients, next) {
  switch (vc-info-type) {
  case NET_CLIENT_TYPE_NIC:

Screwed up in commit 62112d18 by yours truly, and papered over in commit
64e69d50 by Blue.

Reviewed-by: Markus Armbruster arm...@redhat.com

[Qemu-devel] [PATCH] Fix net_check_clients warnings: make it per vlan.

2011-03-15 Thread Tristan Gingold 
Signed-off-by: Tristan Gingold ging...@adacore.com
---
 net.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net.c b/net.c
index ddcca97..b2dfaa8 100644
--- a/net.c
+++ b/net.c
@@ -1305,9 +1305,10 @@ void net_check_clients(void)
 {
 VLANState *vlan;
 VLANClientState *vc;
-int has_nic = 0, has_host_dev = 0;
 
 QTAILQ_FOREACH(vlan, vlans, next) {
+int has_nic = 0, has_host_dev = 0;
+
 QTAILQ_FOREACH(vc, vlan-clients, next) {
 switch (vc-info-type) {
 case NET_CLIENT_TYPE_NIC:
-- 
1.7.3.GIT