Re: [Qemu-devel] [PATCH for-3.2 19/41] slirp: remove unused HAVE_SYS_SELECT_H

2018-11-19 Thread Samuel Thibault 
Daniel P. Berrangé, le mer. 14 nov. 2018 13:51:01 +, a ecrit:
> On Wed, Nov 14, 2018 at 04:36:21PM +0400, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau 
> > ---
> >  slirp/main.h | 4 
> >  slirp/slirp.h| 4 
> >  slirp/slirp_config.h | 6 --
> >  3 files changed, 14 deletions(-)
> 
> Reviewed-by: Daniel P. Berrangé 

Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH for-3.2 19/41] slirp: remove unused HAVE_SYS_SELECT_H

2018-11-14 Thread Daniel P . Berrangé 
On Wed, Nov 14, 2018 at 04:36:21PM +0400, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau 
> ---
>  slirp/main.h | 4 
>  slirp/slirp.h| 4 
>  slirp/slirp_config.h | 6 --
>  3 files changed, 14 deletions(-)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH for-3.2 19/41] slirp: remove unused HAVE_SYS_SELECT_H

2018-11-14 Thread Marc-André Lureau 
Signed-off-by: Marc-André Lureau 
---
 slirp/main.h | 4 
 slirp/slirp.h| 4 
 slirp/slirp_config.h | 6 --
 3 files changed, 14 deletions(-)

diff --git a/slirp/main.h b/slirp/main.h
index e04677944f..4bc05fb904 100644
--- a/slirp/main.h
+++ b/slirp/main.h
@@ -8,10 +8,6 @@
 #ifndef SLIRP_MAIN_H
 #define SLIRP_MAIN_H
 
-#ifdef HAVE_SYS_SELECT_H
-#include 
-#endif
-
 extern u_int curtime;
 extern struct in_addr loopback_addr;
 extern unsigned long loopback_mask;
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 7aa14feeb6..abe87618af 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -36,10 +36,6 @@ typedef char *caddr_t;
 # include 
 #endif
 
-#ifdef HAVE_SYS_SELECT_H
-# include 
-#endif
-
 #ifdef HAVE_SYS_FILIO_H
 # include 
 #endif
diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h
index 9becb98e11..68e75f3873 100644
--- a/slirp/slirp_config.h
+++ b/slirp/slirp_config.h
@@ -32,12 +32,6 @@
 #define DECLARE_IOVEC
 #endif
 
-/* Define if you have sys/select.h */
-#undef HAVE_SYS_SELECT_H
-#ifndef _WIN32
-#define HAVE_SYS_SELECT_H
-#endif
-
 /* Define to sizeof(char *) */
 #define SIZEOF_CHAR_P (HOST_LONG_BITS / 8)
 
-- 
2.19.1.708.g4ede3d42df