Re: [Qemu-devel] PATCH: fix Makefile issue with make 3.79

2007-11-28 Thread Mike Frysinger
On Monday 26 November 2007, Tristan Gingold wrote:
 $^ is all dependencies (ie the .c and .h files in dyngen case).
 Because there is only one .c file to compile, this patch will work in
 all cases.

why not simply upgrade your make to something that is not known to be broken 
and something that isnt ~7 years old.  make-3.80 was released over 5 years 
ago.
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [Qemu-devel] PATCH: fix Makefile issue with make 3.79

2007-11-28 Thread Tristan Gingold


On Nov 28, 2007, at 11:24 AM, Mike Frysinger wrote:


On Monday 26 November 2007, Tristan Gingold wrote:

$^ is all dependencies (ie the .c and .h files in dyngen case).
Because there is only one .c file to compile, this patch will work in
all cases.


why not simply upgrade your make to something that is not known to  
be broken
and something that isnt ~7 years old.  make-3.80 was released over  
5 years

ago.


Sure, but the proposed patch is not that ugly !





[Qemu-devel] PATCH: fix Makefile issue with make 3.79

2007-11-26 Thread Tristan Gingold

$^ is all dependencies (ie the .c and .h files in dyngen case).
Because there is only one .c file to compile, this patch will work in  
all cases.


Tristan.


diff -c -r1.136 Makefile
*** Makefile24 Nov 2007 23:35:07 -  1.136
--- Makefile26 Nov 2007 13:17:41 -
***
*** 132,138 

  # dyngen host tool
  dyngen$(EXESUF): dyngen.c
!   $(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $^

  clean:
  # avoid old build problems by removing potentially incorrect old  
files

--- 132,138 

  # dyngen host tool
  dyngen$(EXESUF): dyngen.c
!   $(HOST_CC) $(CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -o $@ $

  clean:
  # avoid old build problems by removing potentially incorrect old  
files