Re: [PATCH] include/exec/cpu-common.h: Rename PAGE_BITS macro to PAGE_RWX

2024-05-06 Thread Philippe Mathieu-Daudé 

On 5/5/24 14:10, BALATON Zoltan wrote:

This macro can be used to abbreviate PAGE_READ | PAGE_WRITE | PAGE_EXEC
for which PAGE_RWX is a better name and renaming it also shows it is
not related to TARGET_PAGE_BITS.

Signed-off-by: BALATON Zoltan 
---
  accel/tcg/user-exec.c  | 2 +-
  bsd-user/mmap.c| 6 +++---
  include/exec/cpu-common.h  | 2 +-
  linux-user/elfload.c   | 2 +-
  linux-user/mmap.c  | 2 +-
  target/cris/mmu.c  | 4 ++--
  target/microblaze/helper.c | 2 +-
  7 files changed, 10 insertions(+), 10 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé 

and patch queued, thanks!

Re: [PATCH] include/exec/cpu-common.h: Rename PAGE_BITS macro to PAGE_RWX

2024-05-05 Thread Richard Henderson 

On 5/5/24 05:10, BALATON Zoltan wrote:

This macro can be used to abbreviate PAGE_READ | PAGE_WRITE | PAGE_EXEC
for which PAGE_RWX is a better name and renaming it also shows it is
not related to TARGET_PAGE_BITS.

Signed-off-by: BALATON Zoltan
---
  accel/tcg/user-exec.c  | 2 +-
  bsd-user/mmap.c| 6 +++---
  include/exec/cpu-common.h  | 2 +-
  linux-user/elfload.c   | 2 +-
  linux-user/mmap.c  | 2 +-
  target/cris/mmu.c  | 4 ++--
  target/microblaze/helper.c | 2 +-
  7 files changed, 10 insertions(+), 10 deletions(-)


Reasonable.
Reviewed-by: Richard Henderson 


r~