RE: [Rails-core] Inheritance rework
Nice extraction of the inheritance code, hope this work gets some legs. Looks good on the surface, however, your patch has some junk in it that should be removed. It has your username in the postgres database connection and also includes the class inheritance stuff that isn't complete. I think you'll find a better audience with a clean patch. Cheers, Bob Silva http://i.nfectio.us/ -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Rodrigo Kochenburger Sent: Friday, August 11, 2006 3:06 PM To: rails-core@lists.rubyonrails.org Subject: [Rails-core] Inheritance rework I've made minor (or major) rework in how inheritance works. Basicaly it only loads the inheritance on the class that actually will use it, also it moves the inheritance support to a different module, makes simple to create additional inheritances support. I'm planning to release a class table inheritance support soon. I've tried to submit to trac, but it seems down. Would you guys give a test and please let me now if it breaks something. Thanks ;) -- Rodrigo Kochenburger divoxx at gmail dot com Linkedin professional profile: http://www.linkedin.com/in/rodrigok ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
Re: [Rails-core] Inheritance rework
On 8/12/06, Bob Silva [EMAIL PROTECTED] wrote: Nice extraction of the inheritance code, hope this work gets some legs. Looks good on the surface, however, your patch has some junk in it that should be removed. It has your username in the postgres database connection and also includes the class inheritance stuff that isn't complete. I think you'll find a better audience with a clean patch. Do we really need the ActiveRecord::Inheritances module? It looks like there are some plugin concerns bleeding in. I don't think there are any plans to add any other Inheritance types in ActiveRecord. Is there some reason you need that for your plugin? -- Rick Olson http://weblog.techno-weenie.net http://mephistoblog.com ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
Re: [Rails-core] Inheritance rework
I agree that the patch has some junk on it, sorry. I'll clean it up and post in trac. I haven't found any satisfying inheritance plugin out there and imho it would be nice if AR would support other inheritances types right in the core, but even if there's no intention of incorporating other inheritances type i believe it would make easier to create well written plugins. Also, loading the inheritances only in the classes that will use it is less code being executed when the inheritance isn't needed. It's also a pretty hefty change to make when we're preparing a 1.2 release. Perhaps we should park this till just post 1.2? then we can be a little more 'violent' in our refactoring? -- Cheers Koz ___ Rails-core mailing list Rails-core@lists.rubyonrails.org http://lists.rubyonrails.org/mailman/listinfo/rails-core
