[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-07-19 Thread koertkuipers
Github user koertkuipers commented on the issue:

https://github.com/apache/spark/pull/18714
  
@cloud-fan i created 
[SPARK-24860](https://issues.apache.org/jira/browse/SPARK-24860) for this


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-07-16 Thread koertkuipers
Github user koertkuipers commented on the issue:

https://github.com/apache/spark/pull/18714
  
@cloud-fan OK, that works just as well 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-07-16 Thread cloud-fan
Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/18714
  
@koertkuipers makes sense to me, but I won't add a new API in 
`DataFrameWriter` for it, I think we can just add a write option for file 
source, e.g. `df.write.option("partitionOverwriteMode", "dynamic").parquet...`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-07-15 Thread koertkuipers
Github user koertkuipers commented on the issue:

https://github.com/apache/spark/pull/18714
  
should this be exposed per write instead of as a global variable?
e.g.
dataframe.write.csv.partitionMode(Dynamic).partitionBy(...).save(...)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/18714
  
Thanks! Merged to master/2.3


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18714
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85622/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18714
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18714
  
**[Test build #85622 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85622/testReport)**
 for PR 18714 at commit 
[`f7745a0`](https://github.com/apache/spark/commit/f7745a019fc5cc67c2555a3f907a266249a5abad).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18714
  
**[Test build #85622 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85622/testReport)**
 for PR 18714 at commit 
[`f7745a0`](https://github.com/apache/spark/commit/f7745a019fc5cc67c2555a3f907a266249a5abad).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/18714
  
retest this please


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18714
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18714
  
**[Test build #85621 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85621/testReport)**
 for PR 18714 at commit 
[`f7745a0`](https://github.com/apache/spark/commit/f7745a019fc5cc67c2555a3f907a266249a5abad).
 * This patch **fails due to an unknown error code, -9**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18714
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85621/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18714
  
**[Test build #85621 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85621/testReport)**
 for PR 18714 at commit 
[`f7745a0`](https://github.com/apache/spark/commit/f7745a019fc5cc67c2555a3f907a266249a5abad).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-02 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/18714
  
LGTM


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18714
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/18714
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85590/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18714
  
**[Test build #85590 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85590/testReport)**
 for PR 18714 at commit 
[`65a9741`](https://github.com/apache/spark/commit/65a97413453099e9b807b6af1ecd0c6695df8f3c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `class HadoopMapReduceCommitProtocol(`
  * `class SQLHadoopMapReduceCommitProtocol(`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #18714: [SPARK-20236][SQL] dynamic partition overwrite

2018-01-02 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/18714
  
**[Test build #85590 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85590/testReport)**
 for PR 18714 at commit 
[`65a9741`](https://github.com/apache/spark/commit/65a97413453099e9b807b6af1ecd0c6695df8f3c).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org