Re: [PR] [SPARK-44264][PYTHON][ML] FunctionPickler Class [spark]

2024-05-02 Thread via GitHub


HyukjinKwon commented on PR #41946:
URL: https://github.com/apache/spark/pull/41946#issuecomment-2089747330

   cc @WeichenXu123, @lu-wang-dl, @xinrong-meng, @rithwik-db, @maddiedawson, 
mina following up this please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-44264][PYTHON][ML] FunctionPickler Class [spark]

2024-05-01 Thread via GitHub


HyukjinKwon commented on code in PR #41946:
URL: https://github.com/apache/spark/pull/41946#discussion_r1585985451


##
python/pyspark/ml/tests/test_dl_util.py:
##
@@ -0,0 +1,186 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from contextlib import contextmanager
+import os
+import textwrap
+from typing import Any, BinaryIO, Callable, Iterator
+
+import unittest
+from parameterized import parameterized

Review Comment:
   We don't have this dependency in our test image. Can we avoid using this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-44264][PYTHON][ML] FunctionPickler Class [spark]

2024-05-01 Thread via GitHub


HyukjinKwon commented on code in PR #41946:
URL: https://github.com/apache/spark/pull/41946#discussion_r1585985064


##
python/pyspark/ml/dl_util.py:
##
@@ -0,0 +1,150 @@
+#

Review Comment:
   This test is actually not running. It has to be listed in 
`dev/sparktestsupport/modules.py`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org