Re: [rkward-devel] Potential Data editor bug
Hi, On Sun, Sep 26, 2010 at 1:46 PM, Thomas Friedrichsmeier thomas.friedrichsme...@ruhr-uni-bochum.de wrote: Thus, I am rather reluctant to do this. I would assume that duplicate column names are a rare exception, and so we can afford not to support them 100%. Do you think they are important enough as a use-case to make a better effort? Not really. In fact, I was under the impression, till I saw Stefan's example, that R does not allow same column names as it does not allow same row names... It was a surprise to me. Displaying column numbers in the GUI should be no problem. Where would you like to see them? Hmm, may be on top of the column headers or below, no particular preference. Regards, -- Prasenjit -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
Re: [rkward-devel] Potential Data editor bug
Hi, On Thursday 23 September 2010, Stefan Rödiger wrote: It should be mostly, but not entirely safe to edit such objects. If you edit a cell in one of the duplicate columns, all columns with the same name will be affected in the backend. However, in the editor, this will not become visible until you close and re-open the editor. the idea was to underline that there really is some danger associated with editing these objects, and thus to require a somewhat more conscious effort from the user. I suppose we could offer an option to run names (x) - make.unique (names (x)) and re-open the object after that. I think it will be very rare for users to run into this, though. If you care, please remind me shortly after the release, or add an item to the feature request tracker. Regards Thomas signature.asc Description: This is a digitally signed message part. -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
Re: [rkward-devel] Potential Data editor bug
Am Dienstag 21 September 2010, 16:52:04 schrieb Thomas Friedrichsmeier: Hi, On Sunday 19 September 2010, Prasenjit Kapat wrote: As a caution to the user: Should a warning be displayed when the data editor encounters multiple columns with same name? Noting that, the data itself is not lost, it is just not displayed and hence not safe to be edited! (Or is it safe anyways?) ok, current SVN version should no longer crash on this object. A warning should be displayed, and the table set to read-only mode. Please test. Confirmed. It's (opening and warning) working reliably. What is the rational to set it to read-only mode? I mean giving a warning and leaving the user in this mode might be a bit confusing. In a future version it might be nice to have an option in the dialogue to change the mode. Something like okay I know and don't want to edit it and okay I know and want to edit it right now. Regards Stefan It should be mostly, but not entirely safe to edit such objects. If you edit a cell in one of the duplicate columns, all columns with the same name will be affected in the backend. However, in the editor, this will not become visible until you close and re-open the editor. Regards Thomas -- Nokia and ATT present the 2010 Calling All Innovators-North America contest Create new apps games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev ___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
Re: [rkward-devel] Potential Data editor bug
Hi, On Thu, Sep 16, 2010 at 2:44 PM, Thomas Friedrichsmeier thomas.friedrichsme...@ruhr-uni-bochum.de wrote: Hi, On Thursday 16 September 2010, Stefan Rödiger wrote: BTW, as you might consent the lines attached in my example are not a good example how to work with R (size and arrangement of data ...). Thus it was really interesting for me to see what happens ... . I think the crucial thing in your example is that there are some duplicate names in the data.frame: Right. Sorry for the wrong flag earlier. There are three objects called D09. I don't think we can reasonably support this in the editor (probably the editor should just drop two of these variables), but of course it should not crash. Here is something that I found interesting. Consider the last two lines of Stefan's Procedure.txt: data - data.frame ( names (data) - c(... The crash is deterministic after you run these two lines individually (ie, Run current line). But the crash does NOT occur after you run them together (ie, Run selection) or after you run the whole file (ie Run all) or after _source (Procedure.txt)_. Stefan can you confirm this? Although, in many attempts I could not reproduce the crash using any of the following toy examples: Eg 1: data - as.data.frame (matrix (rnorm (3636), 101, 36)) names (data) - rep (A, 36) Here 101 and 36 were chosen based on Stefan's variable lengths. Eg 2: data - as.data.frame (matrix (1:70,10,7)) names (data) - c(A,B,C,A,D,E,A) Eg 3: data - data.frame (A=1:10, B=11:20, C=21:30, A=31:40, D=41:50, E=51:60, A=61:70) names (data) - c(A,B,C,A,D,E,A) Eg 4: A=1:10; B=11:20; C=21:30; D=41:50; E=51:60 data - data.frame (A,B,C,A,D,E,A) names (data) - c(A,B,C,A,D,E,A) When editing these, note that the order of the D and E columns as displayed in the data editor are swapped; which happens with Stefan's example as well (E07/F07 and C07/G07). I was just trying to create another reproducible (toy) example. As a caution to the user: Should a warning be displayed when the data editor encounters multiple columns with same name? Noting that, the data itself is not lost, it is just not displayed and hence not safe to be edited! (Or is it safe anyways?) Regards, -- Prasenjit -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
Re: [rkward-devel] Potential Data editor bug
On Thu, Sep 16, 2010 at 8:22 AM, Stefan Rödiger stefan_roedi...@gmx.de wrote: Hi, I have two files attached. First is called procedure.txt with the description how to preduce the potential bug. And there is also the gdb message. I was able to reproduce the crash of RKWard multiple times by doing this. Confirmed. But if you use mydata instead of data as the data.frame variable then the crash does not occur. I guess the data editor is trying to edit utils::data as opposed to .GlobalEnv::data? Regards, -- Prasenjit -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
Re: [rkward-devel] Potential Data editor bug
Am Donnerstag 16 September 2010, 17:14:49 schrieb Prasenjit Kapat: On Thu, Sep 16, 2010 at 8:22 AM, Stefan Rödiger stefan_roedi...@gmx.de wrote: Hi, I have two files attached. First is called procedure.txt with the description how to preduce the potential bug. And there is also the gdb message. I was able to reproduce the crash of RKWard multiple times by doing this. Confirmed. But if you use mydata instead of data as the data.frame variable then the crash does not occur. I guess the data editor is trying to edit utils::data as opposed to .GlobalEnv::data? Regards, Well yes good point. But do the same procedure with: a-rnorm(100) b-rnorm(100) data-data.frame(a,b) names(data)-c(a,b) then lets say fix(data) ... nothing will happen or open data from workspace browser (as in my previous example) and nothing will happen. Shouldn't the same thing happen? BTW, as you might consent the lines attached in my example are not a good example how to work with R (size and arrangement of data ...). Thus it was really interesting for me to see what happens ... . Regards Stefan -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
Re: [rkward-devel] Potential Data editor bug
Hi, On Thursday 16 September 2010, Stefan Rödiger wrote: BTW, as you might consent the lines attached in my example are not a good example how to work with R (size and arrangement of data ...). Thus it was really interesting for me to see what happens ... . I think the crucial thing in your example is that there are some duplicate names in the data.frame: length (unique (names (data))) [1] 34 length (names (data)) [1] 36 There are three objects called D09. I don't think we can reasonably support this in the editor (probably the editor should just drop two of these variables), but of course it should not crash. I'll look into it. Regards Thomas signature.asc Description: This is a digitally signed message part. -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev___ RKWard-devel mailing list RKWard-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rkward-devel
