Indeed, that would be better. How does this look? I can't say Makefiles are my strong point!On 9/29/06, Daniel Stenberg
[EMAIL PROTECTED] wrote:On Fri, 29 Sep 2006,
[EMAIL PROTECTED] wrote: +ifeq ($(UNAME), Darwin) +SHARED_FLAG=-dynamiclib -Wl,-single_module +else +SHARED_FLAG=-shared +endifBarry, since this is done in numerous Makefiles now, wouldn't it be nicer to
have the configure script create the SHARED_FLAG variable in the root Makefileand have all other Makefiles just use that?--Daniel Stenberg -- http://www.rockbox.org/
-- http://daniel.haxx.se/
Index: apps/codecs/Makefile
===
RCS file: /cvsroot/rockbox/apps/codecs/Makefile,v
retrieving revision 1.37
diff -u -r1.37 Makefile
--- apps/codecs/Makefile 29 Sep 2006 16:15:07 - 1.37
+++ apps/codecs/Makefile 29 Sep 2006 19:50:31 -
@@ -12,12 +12,6 @@
CFLAGS = $(INCLUDES) $(GCCOPTS) $(TARGET_INC) $(TARGET) $(EXTRA_DEFINES) \
-DTARGET_ID=$(TARGET_ID) -DMEM=${MEMORYSIZE} -DCODEC
-ifeq ($(UNAME), Darwin)
-SHARED_FLAG=-dynamiclib -Wl,-single_module
-else
-SHARED_FLAG=-shared
-endif
-
ifdef APPEXTRA
INCLUDES += $(patsubst %,-I$(APPSDIR)/%,$(subst :, ,$(APPEXTRA)))
endif
Index: apps/plugins/Makefile
===
RCS file: /cvsroot/rockbox/apps/plugins/Makefile,v
retrieving revision 1.77
diff -u -r1.77 Makefile
--- apps/plugins/Makefile 29 Sep 2006 16:15:08 - 1.77
+++ apps/plugins/Makefile 29 Sep 2006 19:50:32 -
@@ -13,12 +13,6 @@
CFLAGS = $(INCLUDES) $(GCCOPTS) $(TARGET) $(EXTRA_DEFINES) \
-DTARGET_ID=$(TARGET_ID) -DMEM=${MEMORYSIZE} -DPLUGIN
-ifeq ($(UNAME), Darwin)
-SHARED_FLAG=-dynamiclib -Wl,-single_module
-else
-SHARED_FLAG=-shared
-endif
-
ifdef APPEXTRA
INCLUDES += $(patsubst %,-I$(APPSDIR)/%,$(subst :, ,$(APPEXTRA)))
endif
Index: apps/plugins/chessbox/Makefile
===
RCS file: /cvsroot/rockbox/apps/plugins/chessbox/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- apps/plugins/chessbox/Makefile 29 Sep 2006 16:15:08 - 1.7
+++ apps/plugins/chessbox/Makefile 29 Sep 2006 19:50:33 -
@@ -12,12 +12,6 @@
CFLAGS = $(GCCOPTS) -O2 $(INCLUDES) $(TARGET) $(EXTRA_DEFINES) \
-DTARGET_ID=$(TARGET_ID) -DMEM=${MEMORYSIZE} -DPLUGIN
-ifeq ($(UNAME), Darwin)
-SHARED_FLAG=-dynamiclib -Wl,-single_module
-else
-SHARED_FLAG=-shared
-endif
-
ifdef APPEXTRA
INCLUDES += $(patsubst %,-I$(APPSDIR)/%,$(subst :, ,$(APPEXTRA)))
endif
Index: apps/plugins/databox/Makefile
===
RCS file: /cvsroot/rockbox/apps/plugins/databox/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- apps/plugins/databox/Makefile 29 Sep 2006 16:15:08 - 1.8
+++ apps/plugins/databox/Makefile 29 Sep 2006 19:50:33 -
@@ -12,12 +12,6 @@
CFLAGS = $(INCLUDES) $(GCCOPTS) -O3 $(TARGET) $(EXTRA_DEFINES) \
-DTARGET_ID=$(TARGET_ID) -DMEM=${MEMORYSIZE} -DPLUGIN
-ifeq ($(UNAME), Darwin)
-SHARED_FLAG=-dynamiclib -Wl,-single_module
-else
-SHARED_FLAG=-shared
-endif
-
ifdef APPEXTRA
INCLUDES += $(patsubst %,-I$(APPSDIR)/%,$(subst :, ,$(APPEXTRA)))
endif
Index: apps/plugins/doom/Makefile
===
RCS file: /cvsroot/rockbox/apps/plugins/doom/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- apps/plugins/doom/Makefile 29 Sep 2006 16:15:08 - 1.5
+++ apps/plugins/doom/Makefile 29 Sep 2006 19:50:33 -
@@ -26,12 +26,6 @@
-DTARGET_ID=$(TARGET_ID) -DMEM=${MEMORYSIZE} -DPLUGIN \
-Wno-strict-prototypes -O2 $(PROFILE_OPTS)
-ifeq ($(UNAME), Darwin)
-SHARED_FLAG=-dynamiclib -Wl,-single_module
-else
-SHARED_FLAG=-shared
-endif
-
ifdef APPEXTRA
INCLUDES += $(patsubst %,-I$(APPSDIR)/%,$(subst :, ,$(APPEXTRA)))
endif
Index: apps/plugins/mpegplayer/Makefile
===
RCS file: /cvsroot/rockbox/apps/plugins/mpegplayer/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- apps/plugins/mpegplayer/Makefile 29 Sep 2006 16:15:08 - 1.2
+++ apps/plugins/mpegplayer/Makefile 29 Sep 2006 19:50:34 -
@@ -12,12 +12,6 @@
CFLAGS = $(INCLUDES) $(GCCOPTS) -O2 $(TARGET) $(EXTRA_DEFINES) \
-DTARGET_ID=$(TARGET_ID) -DMEM=${MEMORYSIZE} -DPLUGIN
-ifeq ($(UNAME), Darwin)
-SHARED_FLAG=-dynamiclib -Wl,-single_module
-else
-SHARED_FLAG=-shared
-endif
-
ifdef APPEXTRA
INCLUDES += $(patsubst %,-I$(APPSDIR)/%,$(subst :, ,$(APPEXTRA)))
endif
Index: apps/plugins/pacbox/Makefile
===
RCS file: /cvsroot/rockbox/apps/plugins/pacbox/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- apps/plugins/pacbox/Makefile 29 Sep 2006 16:15:09 - 1.4
+++ apps/plugins/pacbox/Makefile 29 Sep 2006 19:50:34 -
@@ -12,12 +12,6 @@
CFLAGS = $(INCLUDES) $(GCCOPTS) -O2 $(TARGET) $(EXTRA_DEFINES) \
