Re: Apply python coloring from magic
On Sep 12, 2013, at 11:40 PM, Per Øyvind Karlsen wrote: 2013/8/27 Jeffrey Johnson n3...@me.com Not the right fix. Here's why: RPM includes/uses magic strings returned from libmagic. For reproducible results, where external system magic changes arbitrarily, there are any number of problems that ensue because the (what used to be) /etc/magic text has changed. The only proper reproducible solution is to distribute/maintain (what used to be) /etc magic content directly in RPM. RPM used to carry --with-file=internal, removed by popular outcry. But chasing arbitrary strings across per-distro content isn't a solvable problem generally. The string returned from libmagic comes from vanilla file/libmagic upstream, not any distro specific identifier/patch, so if supporting magic strings returned from libmagic, it would make sense to recognize these strings in order to make libmagic support actually usable, don't you agree? :) Whether I agree is irrelevant. There is no concept of upstream or vanilla that applies to the myriad versions of magic that are around on real world systems that end up in *.rpm packages. 73 de Jeff
Apply python coloring from magic
Add missing string reported by libmagic on some python files. -- Regards, Per Øyvind rpm-5.4.5-rpmfc-apply-python-coloring-from-magic.patch Description: Binary data
Re: Apply python coloring from magic
Not the right fix. Here's why: RPM includes/uses magic strings returned from libmagic. For reproducible results, where external system magic changes arbitrarily, there are any number of problems that ensue because the (what used to be) /etc/magic text has changed. The only proper reproducible solution is to distribute/maintain (what used to be) /etc magic content directly in RPM. RPM used to carry --with-file=internal, removed by popular outcry. But chasing arbitrary strings across per-distro content isn't a solvable problem generally. Maintain per-distro patches as you wish. 73 de Jeff On Aug 26, 2013, at 4:07 PM, Per Øyvind Karlsen wrote: Add missing string reported by libmagic on some python files. -- Regards, Per Øyvind rpm-5.4.5-rpmfc-apply-python-coloring-from-magic.patch __ RPM Package Managerhttp://rpm5.org Developer Communication Listrpm-devel@rpm5.org
