On Aug 26, 2013, at 2:36 PM, Per Øyvind Karlsen wrote:
This patch fixes an incorrect attempt to get the string length with sizeof on
a string allocated on the heap.
The line numbers and code both indicate that this patch
is not against rpm5.org code.
The proper fix here (imho) is _NOT_ to implement filtering policies
(in this case perl only) for automagically filtering %defaultdocdir paths out
of the
set of executable files from which rpm dependencies are extracted.
One approach (which I have pointed out to you and ROSA/Cooker developers
several times) would be to steal the existing configurable hierarchy for
enabling/disabling
dependency extraction (though there is really little difference in
compiling/reading various
patterns, the whole idea that MIME suffixes and paths can be used as filtering
policy
hints is fundamentally flawed and non-portable).
The value of checking %defaultdocdir is also fundamentalkly broken since
there are many, not just one, path prefixes which cause files to automagically
acquire a %doc attribute. The only reason for permitting the change where
this flaw resides was to squash endless repeated complaints about
RPM sux because it finds dependencies in %doc files!
when there already exist several mechanisms/answers to the issue including
chmod -x /usr/share/doc/*.pl
and
Don't put *.pl scripts in /usr/share/doc/*/ directories.
that are adequate.
Meanwhile I've fixed the de facto equivalent flaw in lib/rpmfc.c.
Odd that coverity did not detect the flaw, but perhaps I wasn't
paying attention at the time.
73 de Jeff
--
Regards,
Per Øyvind
rpm-5.4.12-rpmfc-use-strlen-not-sizeof.patch
__
RPM Package Managerhttp://rpm5.org
Developer Communication Listrpm-devel@rpm5.org
