Re: [PATCH] rpm 5.4.0: Fix pointer mishandling

2011-05-27 Thread devzero2000 
On Fri, May 27, 2011 at 12:14 PM, devzero2000 pinto.e...@gmail.com wrote:

 On Fri, May 27, 2011 at 9:40 AM, Qing He qing...@intel.com wrote:

 In fpLookupSubdir, data returned by hash should be of type
 struct rpmffi_s ** instead of struct rpmffi_s * to avoid
 segfault.

 Thanks,
 Qing

 Fixed already with commit  db407ba1f54292552bafc13a8989238e262e7470
 in rpm5.3, i presume.

 commit db407ba1f54292552bafc13a8989238e262e7470
 Author: jbj jbj
 Date:   Sat Jan 30 20:19:53 2010 +

 - haul out some rpm.org trash.

 What version are you using ? I will backport where necessary. I will take a
 look better.

Sorry, i have looked bad . I was without glass. I will merge shortly. Thanks


 Thanks

 Best Regards

 ---
 diff --git a/rpmdb/fprint.c b/rpmdb/fprint.c
 index 0e76148..82b8f45 100644
 --- a/rpmdb/fprint.c
 +++ b/rpmdb/fprint.c
 @@ -333,7 +333,7 @@ restart:
 *te = '\0';

 while (te  se) {
 -   struct rpmffi_s * recs;
 +   struct rpmffi_s ** recs;
int numRecs;
int i;

 @@ -346,8 +346,8 @@ restart:
const char * link;
int fx;

 -   fx = recs[i].fileno;
 -   fi =  recs[i].p-fi;
 +   fx = recs[i]-fileno;
 +   fi =  recs[i]-p-fi;
flink = fi-flinks[fx];
if (!(flink  *flink != '\0'))

continue;
 __
 RPM Package Managerhttp://rpm5.org
 Developer Communication Listrpm-devel@rpm5.org

RPM 5.4.0

2011-01-06 Thread Mark Hatle 
I've just started working with RPM 5.4.0.  Some of this strange things I've been
doing with RPM has me creating databases while never installing any files to the
disk.

Before I could use:

-D _dbi_tags_3 Packages:Name:Basenames:Providename:Nvra \

but now if I enable that RPM doesn't return any error messages but fails with a
non-zero return code.  Any suggestions?

--Mark
__
RPM Package Managerhttp://rpm5.org
Developer Communication Listrpm-devel@rpm5.org

Re: RPM 5.4.0

2011-01-06 Thread Jeff Johnson 

On Jan 6, 2011, at 6:42 PM, Mark Hatle wrote:

 I've just started working with RPM 5.4.0.  Some of this strange things I've 
 been
 doing with RPM has me creating databases while never installing any files to 
 the
 disk.
 
 Before I could use:
 
 -D _dbi_tags_3 Packages:Name:Basenames:Providename:Nvra \
 
 but now if I enable that RPM doesn't return any error messages but fails with 
 a
 non-zero return code.  Any suggestions?
 

No intended change in rpm-5.4.0. The indexes to create are same list.

You likely need Filepaths as well as Basenames.

(but I am getting ready to haul out a butt load of trash).

rpm-5.3.7 is likelier to be a bit more stable than 5.4.0 - 5.4.1 
as I try to get -fopenmp multi-threading in place (mostly there but
there's definitely a couple of modestly serious races).

Meanwhile -vv, and try --rpmdbdebug. Have you converted to RPM ACID?
The simplest way to convert (that I know of) is build from cvs
cd tests
make test
That will give you tests/newdb RPM ACID database for use with --dbpath.

There's some tests/Makefile.am targets like
make -C tests IDMS/solve
that limit the number of tags iirc (I'm traveling atm and so can't check
properly ... lemme look tomorrow).

73 de Jeff

 --Mark
 __
 RPM Package Managerhttp://rpm5.org
 Developer Communication Listrpm-devel@rpm5.org

__
RPM Package Managerhttp://rpm5.org
Developer Communication Listrpm-devel@rpm5.org